GitLab

Prevents the wrong height hover card for the current window title from
being displayed. Previously, there were cases where the size of the
hover card was not correctly updated.

Note: probably still needs browsertests :/

Bug: 984963, 995980
Change-Id: I61c1ee3a9b8cf4c8315860c619f151e772cca04c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763637Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689544}

- Updated url::Origin version of CanAccessDataForOrigin() to verify
  precursor information if present and preserves existing behavior
  for opaque origins w/o precursor info. (i.e. only allow if lock is
  not set).
- Created tests for url::Origin version of CanAccessDataForOrigin().
- Added a few new tests cases for GURL version of
  CanAccessDataForOrigin().

Bug: 991607
Change-Id: Ic102e5f9f90a0f2412b5f18d7c48d46c706b818c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756763
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689543}

Change-Id: I126d5ffffcf2e9d10940ebb672d42bb2a1529742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764767Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689542}

It seems like something in CodecImageGroup is happening on the
wrong thread.  This CL adds CHECKs to see what, as a temporary
measure.  Inspection and local repros haven't gotten far.

Bug: 986783
Change-Id: I8873f083b19070855d8f7babcf39cfaa6e3f6928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764332
Auto-Submit: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689541}

- Tab scrubbing: change to use 4-finger gestures.
- Desk switch: change to use 3-finger  gestures.
- Overview selection: change to use 4-finger gestures.

BUG=995911
TEST=Manually, modify existing tests.

Change-Id: I867f3c0033647cc15998e6ef3bce02ac43c2ae7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764832Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689540}

4 tests that I thought I fixed are still failing on the bot, so
disabling for now while I investigate further.

Autofill tests disabled: academy, dell, findmeagift, timberland

Bug: 984664
Change-Id: I6af57bf572d244251bff22c7210dd4e2b5510768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763240
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689539}

This CL adds the bridge to java, as well as basic showing and hiding
logic.

Bug: 986317
Change-Id: Iec8a65a7c025da71505b16487e2070234ea58fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763677
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689538}

Help app will present help topic about parent access code:
https://support.google.com/families/answer/7307262
This change requires submitting new offline resources to
chromeos-assets (WIP).

Bug: 941702
Test: ParentAccessViewTest + manually
Change-Id: Ib7d9846e1e8bc4da3ce3ebb803a5d621994699d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764750Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689537}

Prior to this CL, the entire parent surface was read back to form the
input for the backdrop-filter. In some cases (e.g. crbug.com/993971),
that parent surface was very large, resulting in very large readbacks,
and poor performance. With this CL, which is a perf optimization, the
readback rect is intersected with the device viewport (expanded for
pixel moving filters) prior to readback. Pixels outside of the
viewport will not contribute to the visible filtered content.

Bug: 993971, 974789
Change-Id: I429c8dcb335b264873b3a3671225d19162ecfe27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761346
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689536}

TBR=mmenke@chromium.org

Bug: 996367
Change-Id: I55e86f79fa4ffd9001b643d1beea1481b28c7285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765709Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689535}

https://crrev.com/679757 added a cache on LayerImpl
(all_touch_action_regions_) but did not invalidate this cache in
LayerImpl::PushPropertiesTo. This cache invalidation bug led to
incorrect hit testing in
LayerTreeImpl::FindLayerThatIsHitByPointInTouchHandlerRegion.

Bug: 987937
Change-Id: Ie8a26203ebfabd751a3a287108eced875112e790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764805
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689534}

This patch is a follow-up to CL 1676167, found in [1], and introduces
minor mechanical changes to the DecodeNode() method so that GUID
validity is only checked for bookmarks that are not of type
BookmarkPermanentNode.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1676167

Bug: 978430
Change-Id: I44ba7699482c229bb9c651d5b213e68036c9d233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728883Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Pauline Leitao <psivieroleitao@google.com>
Cr-Commit-Position: refs/heads/master@{#689533}

Makes state transitions feel a lot smoother, which aside from polish is
a definite requirement for removing the border when highlighting the
Butter avatar icon as the border goes away while still hovering the
container.

Bug: chromium:993105
Change-Id: I3af2c8f626834be66b30e99d5aca6d76dad07189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762758
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689532}

Bug: 970083
Change-Id: I17b34aa730a880e00a1b1d6a821ee0e1cf948f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764550
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689531}

TBR=johnchen@chromium.org

Change-Id: I31cd96ca47c2eb483e70e9377a3b7a3419557692
bug: 978500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764676Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689530}

https://chromium.googlesource.com/angle/angle.git/+log/24456989e21b..58940f67acd5

git log 24456989e21b..58940f67acd5 --date=short --no-merges --format='%ad %ae %s'
2019-08-22 jonahr@google.com Revert "Make Mac SystemInfo reflect the currently active GPU on dual GPU machines"
2019-08-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 0cbdc7a2c35b..aef8f92b2bb6 (2 commits)
2019-08-21 jdarpinian@chromium.org WebKit requires "Web" as prefix to Objective-C class names
2019-08-21 dakshidnani@google.com Make Mac SystemInfo reflect the currently active GPU on dual GPU machines
2019-08-21 lujc@google.com Fix frame capture build for Android

Created with:
  gclient setdep -r src/third_party/angle@58940f67acd5

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@chromium.org,jonahr@google.com

Bug: chromium:985486,chromium:984780,chromium:None,chromium:985486,chromium:984780
Change-Id: Icf733ee161ce14c4b57b7c0d092b4289a348ee38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765648Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689529}

Also add ownership to some Chrome OS settings tests.

Change-Id: Ib3b37c099bb21b0fa830765c9bc92aa6e896b744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764763
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689528}

Bug: 950248
Change-Id: I7ea4198c96fda976ce2d9ae6e6b19b5cdc473f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764896Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689527}

Since we are using finch to roll out play store app search feature,
we should disable it by default in the client code.

Bug: 996303
Change-Id: Iae9d95ba1666fa76c66a1fcd1a06cae7d6e43571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764518Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689526}

Frankly, the ozone-linux has never run the ozone_x11_unittests.
Enable them.

Bug: 700309
Change-Id: I379f2c411812a7cd15527e81e7b5b14fb3bf1147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765508Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#689525}

https://skia.googlesource.com/skia.git/+log/197c58647161..068af9e416cb

git log 197c58647161..068af9e416cb --date=short --no-merges --format='%ad %ae %s'
2019-08-22 brianosman@google.com Revert "Temporary Lua hook to measure impact of conservative convexity"
2019-08-22 brianosman@google.com Enable SkSL interpreter in CanvasKit to get particles working again

Created with:
  gclient setdep -r src/third_party/skia@068af9e416cb

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@google.com

Bug: None
Change-Id: I83a294f76c093ce21345f7101ea743e490856964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764866Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689524}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/49980fb4f214..cab59a32b90b

git log 49980fb4f214..cab59a32b90b --date=short --no-merges --format='%ad %ae %s'
2019-08-22 yyanagisawa@chromium.org Auto detect Goma client for ChromeOS chroot.

Created with:
  gclient setdep -r src/third_party/chromite@cab59a32b90b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: If6016a62dd05049343f7d927cfb7c964b29ebb46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764864Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689523}

This CL fixes adds path for passthrough gl decoder to
ScopedSurfaceToTexture. It also fixes gl state sync issue between
|gles2_implementation_| and |gles2_decoder_| for the readback.

Bug: 983581
Change-Id: I03a17724326968d57e2f26a558a2e6237aaadc32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763432
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689522}

Add a histogram to track when a user interacts
with the lock screen media controls.

BUG=995373

Change-Id: Ia462e38d1b7eceafb2cf8073a67b7421fcf573f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761259
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689521}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8e94fde0647093b02b7c8db703567b9d7628dd12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765649Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689520}

According to guide[1], it is acceptable to be also named
like macro instead of constants. but it is old way.
so change it to keep consistency with others.

[1] https://google.github.io/styleguide/cppguide.html#Enumerator_Names

Bug: 940736
Change-Id: I03312364177a9108c59673be8f074e28adb42317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763656
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689519}

Adds bialpio@chromium.org to the VR_JAVA_OWNERS file since he's
familiar with the AR files that are still in the VR directory.

Change-Id: I856ad90d913da4e21ad718afaf8e109d3562a1db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764766Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689518}

A user policy which controls the dictation accessibility feature.
The policy can have one of these three states: default off, force on
or force off by controlling a boolean pref.
Adds SelectToSpeakEnabled accessibility feature along with DictationEnabled to Accessibility group.

Bug: 552439
Change-Id: I617da14787e7adbf3abf87aea556df63369d932a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713514
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689517}

LayerTreeFrameSink::ForceAllocateNewId() is no longer needed after
surface-sync has been enabled on all platforms.

BUG: 985009
Change-Id: I9aa2042eca489182ab66d354d2538951c2066c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762787
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689516}

They were disabled by mistake by commit:
https://chromium-review.googlesource.com/c/chromium/src/+/1699374

Bug: 996725
Change-Id: Iab5bfa3dba506119bb1093d53e5db7dec2cd4c98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764199
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689515}

Visitor has to use thread-safe accessors.

Bug: 986235
Change-Id: I58b3ae813cfcddbabae473d05704d54ebb395642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760803
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689514}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bfcde3c5b880..4c55b355580f

git log bfcde3c5b880..4c55b355580f --date=short --no-merges --format='%ad %ae %s'
2019-08-22 tmrts@chromium.org [devtools] create devtools-frontend gclient config

Created with:
  gclient setdep -r src/third_party/depot_tools@4c55b355580f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Bug: chromium:995657
Change-Id: I1301a4b79517082d1222bf36c52b9395e5989cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764366Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689513}

The content_unittests have been running by the linux-ozone-rel
bot for a couple of weeks since 06 of August without any failures.

Thus, remove the experiment percentage.

R=sky@chromium.org

Bug: 700309
Change-Id: Ib9c7e4f29c8bebc808b23bfb8c10358816e7d793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764139Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#689512}

This CL updates tab strip when dragging the current tab out of group if
the tab strip is visible. Aka when static tab is shown.

Change-Id: I10f0f332a3915105e4281d78762aa265d9d6493b
Bug: 991251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747248Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689511}

This change adds a simple fuzzer for CipherEncrypt() used in the Leak
Detection feature.

Bug: 986298
Change-Id: I4878b1bf04a0edc4341c7c2997e443207120d6d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763756
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689510}

Changes the VR browser tests that click on suggestions to ensure
navigation works to click on the bottom suggestion instead of the
middle one. This is because either the top or middle suggestion can be
the "search on the web" suggestion depending on if the
OmniboxGroupSuggestionsBySearchVsUrl feature is enabled or not.

Bug: 995943
Change-Id: Ic1ee49f8ef95a6b13c65117065bc08c882bbb615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764756
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689509}

Values from manual testing.

Bug: 996227
Change-Id: I854f1690f039842c21d97e9324c581156cfa7939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761358Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689508}

With this CL, we now call BackForwardCache::RestoreDocument at the end
of the navigation just before committing, instead of at the start of
the navigation.

This shrinks the window of time where an eviction can occur after
the document has been removed from the cache, but before it
has been committed.

Before this patch, if an eviction arrived after the navigation started,
the behavior was undefined. With this patch, that case is now handled by
canceling the navigation. In a follow-up CL, it will be handled by
restarting the same session history navigation.

This CL also has the (pleasant) side effect of fixing an issue where
throttling wasn't handled correctly in the case of a BackForwardCache
restore, (test added in this CL).

Change-Id: I65a1600cef04f2e10f0d28a5df750b26c85e917a
Bug: 976697,995316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760220Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689507}

Update the strings in accordance with the latest UX specs.
Remove bold emphasis in omnibox usage bubbles (keep it for prompts).
Update screenshots and sha1 files.

Consolidate IDS_NATIVE_FILE_SYSTEM_WRITE_PERMISSION_*_TITLE
Remove now unused |NativeFileSystemPermissionView::is_directory_|.

See updated screenshots in the associated bugs.

Bug: 995897, 996336
Change-Id: I0063b80e2a0fa4fe1442b90029011016d2d808b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764267Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689506}

Bug: 969764
Change-Id: I78592474edd3ee7c69700940baa148349b4c9830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764967Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689505}