GitLab

BUG=143646
TEST= mini_installer (with branding=chrome) builds

Here is the error:

t0\src>ninja -C out\Debug mini_installer
[1/9] CXX obj\chrome_frame\npchrome_frame.chrome_tab.obj
FAILED: ninja -t msvc -r . -o obj\chrome_frame\npchrome_frame.chrome_tab.obj -e environment.x86 -- cl.exe ...
 .. microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(2845) : error C2338: 'CAtlDllModuleT<T>'
 must be used with either _WINDLL or _USRDLL defined
 ..\microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(3298) : 
see reference to class template instantiation 'ATL::CAtlValidateModuleConfiguration<isDllModule,T>' being compiled
        with
        [
            isDllModule=true,
            T=`anonymous-namespace'::ChromeTabModule
        ]
        t0\src\chrome_frame\chrome_tab.cc(98) : see reference to class template instantiation 'ATL::CAtlDllModuleT<T>' being compiled
        with
        [
            T=`anonymous-namespace'::ChromeTabModule
        ]
Review URL: https://codereview.chromium.org/11189018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162291 0039d316-1c4b-4281-b951-d872f2087c98

Attempt to reuse an existing Browser instance for application launches in Chrome on Windows 8 Metro mode.

BUG=155388
R=mihaip
Review URL: https://codereview.chromium.org/11191017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11192013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162289 0039d316-1c4b-4281-b951-d872f2087c98

Two scripts for now, one that lets you view the gstore directory structure
(cribbed from Chrome), and another that lets you view the current
naclsdk_manifest file (cribbed from OmahaProxy).

They are installed to
http://commondatastorage.googleapis.com/nativeclient-mirror/nacl/nacl_sdk/...

BUG=none
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11192021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=148615


TBR=jhawkins

Review URL: https://chromiumcodereview.appspot.com/11044020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162287 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155413
TEST=cc_unittests
R=enne@chromium.org,jamesr@chromium.org

Review URL: https://codereview.chromium.org/11145033

TBR=tfarina@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155413
TEST=cc_unittests
R=enne@chromium.org,jamesr@chromium.org

Review URL: https://codereview.chromium.org/11145033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11185016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162283 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122229
NOTRY=true

Review URL: https://codereview.chromium.org/11066105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162282 0039d316-1c4b-4281-b951-d872f2087c98

BUG=154451
TEST=cc_unittests
R=enne@chromium.org,jamesr@chromium.org

Review URL: https://codereview.chromium.org/11191018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162281 0039d316-1c4b-4281-b951-d872f2087c98

Just removing condition because 2008 is toast.

BUG=143646
R=cpu@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/11184012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162280 0039d316-1c4b-4281-b951-d872f2087c98

If chrome in desktop mode on Windows 8 defers to Windows 8 metro chrome, then we only want to create a new window/incognito
window is one does not exist. To achieve this we look at the startup url being opened and if it is the new tab page, then
we attempt to find an existing browser window and activate it.

For non Windows platforms and Windows desktop mode the behavior is unchanged.

BUG=155134,155281
R=sky
Review URL: https://codereview.chromium.org/11137031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162279 0039d316-1c4b-4281-b951-d872f2087c98

These stubs are no longer needed.

BUG=145783


Review URL: https://chromiumcodereview.appspot.com/11155027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162278 0039d316-1c4b-4281-b951-d872f2087c98

Error:

    /b/build/slave/Mac/build/src/remoting/base/resources_unittest.cc:8:10: fatalerror: 'remoting/base/string_resources.h' file not found
#include "remoting/base/string_resources.h"
         ^
1 error generated.

The new common_resources.grd will be used for non-loalizeable resources, 
such as images.


Review URL: https://chromiumcodereview.appspot.com/11087059

TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/11194022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162277 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162276 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danakj

Review URL: https://codereview.chromium.org/11189014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162275 0039d316-1c4b-4281-b951-d872f2087c98

This connects the nested message loop spawning code that I wrote for the
NativeWidgetAuraHelper into DesktopRootWindowHostLinux.

BUG=146077


Review URL: https://chromiumcodereview.appspot.com/11193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155619


Review URL: https://chromiumcodereview.appspot.com/11192008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162273 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162271 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r10002: (mseaborn) Attempt to fix flakiness in run_multidomain_test's exit status on Windows
r10003: (mseaborn) service_runtime: Move TLS values to live exclusively in NaClThreadContext
r10004: (bradnelson) Enhancing HttpDownload to support absent resources and logging.
r10005: (noelallen) Assume missing timestamp (file) is stale.
r10006: (phosek) Generic containers moved into a separate module, split each container into individual source file.
r10007: (petarj) [MIPS] New pattern in validator to detect jumps/branches in delay slots.
r10008: (shcherbina) Validator testing: split some huge tests into parts.
r10009: (petarj) [MIPS] Update SConstruct to use new MIPS toolchain.
r10010: (khim) Bump REVISIONS
r10011: (dschuff) Fix GYP generator export in pnacl buildbot script
r10012: (dschuff) PNaCL merge script: fix upstream remote setup and get up to date HEAD

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11189004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162270 0039d316-1c4b-4281-b951-d872f2087c98

Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode. The crash
occurs because we attempt to initiate a navigation when there are no frame windows registered with the metro driver.

Fix is to ignore the navigation request in this case.

I also updated the ChromeUrlLaunchHandler::GetUrlFromLaunchArgs function to return the chrome://newtab url if the verb
coming in is opennewwindow. This should address bug http://code.google.com/p/chromium/issues/detail?id=135122

BUG=155281,135122
R=cpu
Review URL: https://codereview.chromium.org/11193007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162269 0039d316-1c4b-4281-b951-d872f2087c98

also add wjia@ in webkit/media/OWNERS
Review URL: https://codereview.chromium.org/11144005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162268 0039d316-1c4b-4281-b951-d872f2087c98

Add a fake video decoder that outputs colorful frames without really trying to decode the compressed buffers. This is useful for testing purpose.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11147032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162267 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11144040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162266 0039d316-1c4b-4281-b951-d872f2087c98

OpenInputDesktop() can fail when the window station is shutting down. We cannot really do anything about it and it happends often enough polluting the logs.

BUG=156135

Review URL: https://codereview.chromium.org/11195006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162265 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/chromium/issues/detail?id=134093
https://chromiumcodereview.appspot.com/10993067/

This is a better fix than 10993067. This CL undoes that change and moves the fix to the AcceleratorController. This is a more general fix which employs a table of actions that are allowed when in a modal dialog. All other actions are suppressed.

BUG=153077
TEST=System Tray -> Ehternet -> Join Other; while the modal dialog is up, try various ash shortcuts. Observe that the ones are working (like volume up) make sense, but things like new window or moving around windows are inactive.

Review URL: https://chromiumcodereview.appspot.com/10977088

TBR=sschmitz@chromium.org
Review URL: https://codereview.chromium.org/11192016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162264 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11125002

TBR=rch@chromium.org
Review URL: https://codereview.chromium.org/11191015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162263 0039d316-1c4b-4281-b951-d872f2087c98

It appears that paint() checks for non-NULL delegate_, so it makes sense to
do the same for updateGeometry as well.

BUG=155950

Review URL: https://codereview.chromium.org/11148031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162262 0039d316-1c4b-4281-b951-d872f2087c98

<math.h> has all we need

BUG=154451


Review URL: https://chromiumcodereview.appspot.com/11151032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162261 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11125002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162259 0039d316-1c4b-4281-b951-d872f2087c98

The test was originally disabled because of Windows-specific failures, but runs fine on other platforms.

BUG=130327
TEST=browser_tests BrowserViewTest


Review URL: https://chromiumcodereview.appspot.com/11137002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162258 0039d316-1c4b-4281-b951-d872f2087c98

This flag was added by r153554 and only set for desktop Chrome default apps.
Since it affects install behavior (e.g. OAuth scope granting in
ExtensionService::InitializePermissions) it should be set everywhere.

BUG=156001
R=dpolukhin@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11146028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=148615


Review URL: https://chromiumcodereview.appspot.com/11044020

TBR=rouslan@chromium.org
Review URL: https://codereview.chromium.org/11192014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162256 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162255 0039d316-1c4b-4281-b951-d872f2087c98

Soon we'll build necessary libs into gen/sdk/toolchains/... directly, which
will obviate the need to move files around like this. This is just a stopgap to
make the tree green.

BUG=none
TBR=noelallen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/11183010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=148615


Review URL: https://chromiumcodereview.appspot.com/11044020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162252 0039d316-1c4b-4281-b951-d872f2087c98

Media Galleries: Initialize the internal state of MediaGalleriesPrivateEventRouter with the list of already attached storage devices.

BUG=156024

Review URL: https://chromiumcodereview.appspot.com/11164003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162251 0039d316-1c4b-4281-b951-d872f2087c98

R=grt@chromium.org
BUG=155640
TEST=Install old Chrome (user and system level), over-install new Chrome, make sure <root>\Software\Classes\Chrome<suffix>\.exe\shell\run is deleted.

Review URL: https://chromiumcodereview.appspot.com/11146003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162250 0039d316-1c4b-4281-b951-d872f2087c98

The previous overview image of the Calculator app has an OS X title bar,
this updated version is OS-neutral.

BUG=156159

Review URL: https://codereview.chromium.org/11191012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162249 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156119


Review URL: https://chromiumcodereview.appspot.com/11191011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162248 0039d316-1c4b-4281-b951-d872f2087c98