- 21 Nov, 2018 40 commits
-
-
Richard Knoll authored
If a notification title is between 22 and 26 characters long, it might get truncated in the view. This is because we calculate different line counts for a title in the layout and draw phases. This is related to crbug.com/682266. Instead of relying on the layout phase, we now just set a wider right-border on the first element in the view, to make space for the control buttons. Bug: 785589 Change-Id: I4c6e157d732065224612766dbe02a3f21f377b2f Reviewed-on: https://chromium-review.googlesource.com/c/1341924 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610225}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8da7b350cf93..5eae1d994e20 git log 8da7b350cf93..5eae1d994e20 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 Peter) Slatala Remove legacy SetTargetTransferRateObserver 2018-11-21 Peter) Slatala Add check for media transport and bundle policy 2018-11-21 Peter) Slatala Create 'MaybeCreateMediaTransport' function 2018-11-21 sakal@webrtc.org Add sakal@ to OWNERS in android tests / aarproject directories. 2018-11-21 kron@webrtc.org Move HdrMetadata to ColorSpace 2018-11-21 alessiob@webrtc.org AGC2 adaptive digital: remove unnecessary flag. Created with: gclient setdep -r src/third_party/webrtc@5eae1d994e20 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8cba4140f98d3698aa8f895567586561f54042a3 Reviewed-on: https://chromium-review.googlesource.com/c/1347030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610224}
-
John Chen authored
Updating capabilities returned from New Session command for W3C spec compliance. Change verified by Web Platform Tests (13 additional new_session tests passed). Bug: chromedriver:1997 Change-Id: I7683acb33cbf2739a867787ba2a3fedd28be32c5 Reviewed-on: https://chromium-review.googlesource.com/c/1347065 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#610223}
-
Ryan Hansberry authored
To support legacy Smart Lock hosts which did not mark themselves as supporting EASY_UNLOCK_HOST (because they couldn't have), simply ignore lack of a kSupported bit if kEnabled is present, and set the host device as an enabled Smart Lock host. Bug: 896082 Change-Id: Id8fb1ade25113fcb108a7658738e7bf9e0c996a0 Reviewed-on: https://chromium-review.googlesource.com/c/1345123Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#610222}
-
Robert Ogden authored
This CL corrects the metrics in PLM which are thrown off by the restarting of navigations for this preview type. In order to serve this preview, we cancel and then posttask a new navigation to our own server. This causes PLM to loose track of the original navigation start time. To correct this, I've added functionality to PLM that accepts a TimeDelta penalty that will be added to all metrics once the page load completes. Persisting the original navigation start time is done by copying a ServerLitePageInfo struct between navigations and which lives on PreviewsUserData during navigation and page load. Bug: 874150 Change-Id: Ib31d1694ecdbd310f975a431f76a76c7e47774d7 Reviewed-on: https://chromium-review.googlesource.com/c/1334944Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#610221}
-
Carlos Caballero authored
Bug: 901345 Change-Id: I3fb2bcdab9a61fc818da6a4cc6439635f9421b31 Reviewed-on: https://chromium-review.googlesource.com/c/1346834Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#610220}
-
Erik Luo authored
Adds the "Inspect Elements" (Ctrl-Shift-C, Mac: Cmd-Alt-C) to X11's main menu and Mac's developer menu. This matches locations for "Javascript Console" (Ctrl-Shift-J). Screenshot: https://imgur.com/a/jOFOmTn TBR=cpu@chromium.org Bug: 881534 Change-Id: Id17b9ca123ebc54c8e753ec25f31604ab3248f3d Reviewed-on: https://chromium-review.googlesource.com/c/1343513Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#610219}
-
dpapad authored
The original change at r608013 caused WebUI regressions, some of which are unclear on how to fix because of a separate issue with tabindex -1 and Custom Elements, https://github.com/w3c/webcomponents/issues/774. Need to address WebUI affected cases, before the flag is re-enabled by defalut. Bug: 907284 Change-Id: Ie8a41df1df663d25cf06a0ed6ae42ac80512df0c Reviewed-on: https://chromium-review.googlesource.com/c/1347429 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610218}
-
Christopher Grant authored
Credit to digit@ who supplied much of this change via a reference CL. Rather than including one of two static linker scripts, generate the desired script instead. This allows an arbitrary list of additional exported methods to be supplied if desired. BUG=874587 Change-Id: I88eb0469dfb764bf910b8c3fe76fd4ed2c91c1e4 Reviewed-on: https://chromium-review.googlesource.com/c/1338141 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610217}
-
Morten Stenshorne authored
(writing-mode has nothing to do with it, FWIW) Legacy layout is buggy here, so the expected rendering was wrong. Also wrote a new wpt test for this. When calculating quirky line height, the legacy engine makes room for whitespace that is to be collapsed. Bug: 845902 Change-Id: I004d024578bb147d4f70c58fc1e3213a14174fd7 Reviewed-on: https://chromium-review.googlesource.com/c/1346465Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610216}
-
Nico Weber authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/da9b2941cbf6..04161ec8d7c7 $ git log da9b2941c..04161ec8d --date=short --no-merges --format='%ad %ae %s' 2018-11-21 thakis Roll gn to version 1496 (0790d304). Created with: roll-dep src/buildtools Bug: none Change-Id: Iddc4c9ad79f28d024b32c41162e0df7b2a7cd1f7 Reviewed-on: https://chromium-review.googlesource.com/c/1347335Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610215}
-
Sam Maier authored
This reverts commit a404b85a. Reason for revert: Suspected cause of crbug.com/906242 Original change's description: > [omnibox metrics] Copy new keyword information into log > > We added new fields to the Omnibox event protobuf regarding keyword > mode. This CL copies the new relevant information from a set of > suggestions into that protobuf. Also adds new boolean field to a > suggestion. > > Bug: 837395 > Change-Id: I496d5235790a3c3cd1744155fe766b134a366fd5 > Reviewed-on: https://chromium-review.googlesource.com/c/1312930 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Kevin Bailey <krb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608528} TBR=mpearson@chromium.org,krb@chromium.org,tedchoc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837395 Change-Id: I9c4a39a1d3104a65796d43b31233cc36647f586c Reviewed-on: https://chromium-review.googlesource.com/c/1347031Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#610214}
-
Ryan Meier authored
Change-Id: I2fdd1e141a177ff9433b9cdc785bf8d4fd2afadc Reviewed-on: https://chromium-review.googlesource.com/c/1347169 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610213}
-
Christian Biesinger authored
Bug: 591099 Change-Id: I68874c4c0d099d8896ecc437730e48d12444d5a5 Reviewed-on: https://chromium-review.googlesource.com/c/1344950Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#610212}
-
John Rummell authored
Original change's description: > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > External Clear Key CDM to store the license in the file system, if it is > available. This reverts commit e9fc38c7. The original CL was flaky due to Mac's only saving file timestamps to second granularity. As a result it was possible for the newly created license to be saved with a timestamp prior to the current actual time, and deleting "old" licenses would include it in the deletion. Change is to wait for some time on Macs only to ensure that the "new" license has a later timestamp. BUG=808690,879812 TEST=new browser_tests pass Change-Id: Ibd7cf65b468f98af9aa583d3f320e54c8f3f223e Reviewed-on: https://chromium-review.googlesource.com/c/1345248Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610211}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a85a4b01ee72..d66dad7fc2c3 git log a85a4b01ee72..d66dad7fc2c3 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 iannucci@chromium.org [vpython] Re-roll to pick up user differentiation of cached envs Created with: gclient setdep -r src/third_party/depot_tools@d66dad7fc2c3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:869227 TBR=agable@chromium.org Change-Id: I536a4155d4cc66aa1ab8928eaa385eeab070effd Reviewed-on: https://chromium-review.googlesource.com/c/1347073Reviewed-by:
-
Christopher Cameron authored
Move ScopedAccessibilityFocus from ui/views/cocoa to ui/base/cocoa, because it is going to be used by content/ (which, for the moment, does not depends on ui/views, though I would like to add an explicit dependency at some point). Rename ScopedAccessibilityFocus to AccessibilityFocusOverrider, and - make it track - whether or not the view it represents if the first responder for its window - whether or not its window is key - override -[NSApplication accessibilityFocusedUIElement] only when both of those conditions are true Apply this scheme to the two main NSViews - BridgedContentView uses an AccessibilityFocusOverrider in BridgedNativeWidgetHostImpl - RenderWidgetHostViewCocoa uses an AccessibilityFocusOverrider in RenderWidgetHostViewMac Change slightly the way that NSWindow key status is tracked between RenderWidgetHostViewCocoa/Mac. - These changes were only send to the browser when the view was also first responder - Change this to always send changes in key status, and early-out when the view is not first responder on the browser side. Bug: 900846 Change-Id: I15bb144ae4570eeffa51c4609f58aa8b58b892d9 Reviewed-on: https://chromium-review.googlesource.com/c/1345121Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#610209}
-
Emircan Uysaler authored
getDisplayMedia() allows capturing user's display content. Before launching this feature, we want to add a kill switch that can be set from server side in case there exists some use case that causes security or privacy problems. Bug: 326740 Change-Id: I34cf0cb412c599712fa10b0beb40b18404cf0440 Reviewed-on: https://chromium-review.googlesource.com/c/1313192 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610208}
-
Tarun Bansal authored
At the time of page load, navigation predictor may take some action (such as prefetch). This CL records metrics around the accuracy of the action taken. Bug: 903945 Change-Id: Id4bea8b7e7aec1f017e070213438b20905f1d96c TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1338944Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610207}
-
edchin authored
Two private methods in BVC take in a WebState as an argument. They call the TabHelper to get the corresponding Tab, then never use the Tab reference. This CL removes these unnecessary references to Tab. Change-Id: Ie5be3d4600fafe9bd4777ece6717eb67525e8c30 Reviewed-on: https://chromium-review.googlesource.com/c/1344835Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610206}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a370396f131..ea02708e078c git log 9a370396f131..ea02708e078c --date=short --no-merges --format='%ad %ae %s' 2018-11-21 bsalomon@google.com Add SK_API to SkCanvas::ImageSetEntry to fix Chrome roll 2018-11-21 mtklein@google.com move NEON matrixProcs into matrixProcs.cpp 2018-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 836674c28b1e..6aab06e0e5d4 (1 commits) 2018-11-21 reed@google.com add flag to flutter 2018-11-21 bsalomon@google.com Make experimental_drawImageSet support per-quad alpha. 2018-11-21 reed@google.com Revert "Revert "add rect-parameter to makeImageSnapshot"" 2018-11-21 brianosman@google.com Revert "Prefer GrAAConvexPathRenderer over ccpr" Created with: gclient setdep -r src/third_party/skia@ea02708e078c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860021 TBR=csmartdalton@chromium.org Change-Id: I7af4b53a6c7a2fc462253becdd305574608f60a5 Reviewed-on: https://chromium-review.googlesource.com/c/1347072Reviewed-by:
-
John Z Wu authored
Actually made it into a method instead since I felt asking a CWVAutofillSuggestion for its property passwordSuggestion is kind of confusing. As a method I think it's more clear. Change-Id: I3eb32cfff01236f099dcda720a812bdaa0f78c20 Reviewed-on: https://chromium-review.googlesource.com/c/1347101 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#610204}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a285cdeb4d1a..eacc22d07da8 Created with: gclient setdep -r src-internal@eacc22d07da8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iedc32bf4232895898de5aa2f3754f6fa96d7727c Reviewed-on: https://chromium-review.googlesource.com/c/1347106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610203}
-
Nigel Tao authored
The App Registry is discussed in chrome/services/app_service/README.md. BUG=826982 Change-Id: If914f4237b6a42c2b212225be280218b69d676b3 Reviewed-on: https://chromium-review.googlesource.com/c/1338590Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#610202}
-
Nicolas Pena authored
This CL unifies the timestamp computations for FID as reported to UMA and FID as exposed in the Web Perf API. It moves the UMA reporting from the PageWidgetDelegate to the EventTiming class. After this CL, the same types of events are logged by both the UMA metric and the webexposed metric. In addition, this CL removes the check that there are default actions or event handlers from EventTiming, which means that now the webexposed API will expose events even if they have no associated event handlers. In particular, this means that a click will now trigger mousedown, click, and mouseup entries, in that order. This is reflected in changes to the layout tests. Bug: 897656 Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc Reviewed-on: https://chromium-review.googlesource.com/c/1334564 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#610201}
-
Esmael El-Moslimany authored
cr-input skip validation when old and new values are both falsy After validation, if the input value is invalid, the red underline will be drawn under the input. When initializing the cr-input, the value switches from undefined to '' and then it is updated to new values from there. This causes an issue because the underline opacity and width have transition. So if the value is valid after initialization, the underline will appear blue and then transition away (the color change is instant). This CL addresses this by skipping validation until a real value has been set. Bug: 907022 Change-Id: I2369cb41467c3d6ee9b3b30004188579df107906 Reviewed-on: https://chromium-review.googlesource.com/c/1345415Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610200}
-
Alexandr Ilin authored
The data collected for the following histograms have not been used recently: - ResourcePrefetchPredictor.PrefetchingDuration - ResourcePrefetchPredictor.ReportingEvent Bug: 900064 Change-Id: I4f1d6b479c1a5a1f1a5c30160322acd436fcbc8c Reviewed-on: https://chromium-review.googlesource.com/c/1343091Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Chris Morin authored
Create ARC server socket in chrome instead of in session_manager. BUG=b:119447298 TEST=Ensure container starts up Change-Id: I6207f16fd6cfaa5a9eface6cf1ae6806c053157b Reviewed-on: https://chromium-review.googlesource.com/c/1343046 Commit-Queue: Christopher Morin <cmtm@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#610198}
-
Becca Hughes authored
There is a memory leak in the contents observer. BUG=885394 Change-Id: Iea5044f3c739c4c42962e5aea5c5dfda6d5790f4 Reviewed-on: https://chromium-review.googlesource.com/c/1335784Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610197}
-
Mikel Astiz authored
This is a reland of 05048d0f Meanwhile, a patch has landed that is believed to fix the issue observed in recent flakes. Original change's description: > Reenable a test in TwoClientPreferencesSyncTest on CrOS > > Recent changes (linked to the bug) are believed to have deflaked the > test, so let's reenable it on all platforms. > > Bug: 873902 > Change-Id: I9804fa4d83c3b1afb9b71356d134736b63b11298 > Reviewed-on: https://chromium-review.googlesource.com/c/1343083 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609649} Bug: 873902 Change-Id: I0c82df1ed8ca63ec4c0490a3f76ac1c9efddd5c6 Reviewed-on: https://chromium-review.googlesource.com/c/1347351Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610196}
-
Mustaq Ahmed authored
Bug: 860713 Change-Id: I561cb3042aa1d83bd45ed7ec2678df1994da67f3 Reviewed-on: https://chromium-review.googlesource.com/c/1347058Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#610195}
-
liberato@chromium.org authored
In preparation for adding more tests to D3D11VideoDecoder, this CL converts use of the command decoder stub to CommandBufferHelper. Otherwise, we have to mock out the stub for the test. Change-Id: I4234841d26dbb0187e626cfd20d534916506b8d4 Reviewed-on: https://chromium-review.googlesource.com/c/1343340 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#610194}
-
Mei Liang authored
This CL fixes the arithmetic exception when recording tab launch type. TasksUma::recordTAbLaunchType should return early when total tab count is equal to zero. Bug: 906616 Change-Id: I03c9d069b1292d3adc73f14b1b99bc50c1709392 Reviewed-on: https://chromium-review.googlesource.com/c/1343534Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610193}
-
Joe Mason authored
This updates the logging/proto and scanner subdirs R=csharp@chromium.org Bug: 830892 Change-Id: I15b1cfe9fdb123553b4d00c0e42395adbc068db3 Reviewed-on: https://chromium-review.googlesource.com/c/1338406 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610192}
-
Xi Cheng authored
Change-Id: I39c796801d9cfc70465633a9c682d66ba7e41cd6 Reviewed-on: https://chromium-review.googlesource.com/c/1345535 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610191}
-
François Beaufort authored
Change-Id: I27a55289aaf2f5a2ba4f504dfb97602b9a4418c6 Reviewed-on: https://chromium-review.googlesource.com/c/1345970Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#610190}
-
Antonio Gomes authored
CL converts ArcAuthContext away from PO2TS, as part of the IdentityManager servicification effort (//services/identity). No functionality change is expected. Note that there is still one reference to PO2TS left, that is used to construct UbertokenFetcher. It will be removed on a follow up pass. CL also takes the opportunity to migrate ArcBackgroundAuthCodeFetcher away from OAuth2TokenService::Consumer, since it is tied to ArcAuthContext. BUG=905243 TEST=Run on test device. TEST=Run browser_tests --gtest_filter=Arc* TEST=Run unit_tests --gtest_filter=Arc* Change-Id: I1a74df3b79a7753e96dc7993d636692efa18d1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1345130 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610189}
-
Steven Holte authored
Update variations_seed proto and metrics protos, and send seed versions to UMA, so it's available for analysis. Change-Id: Id2954646c6c000af8accde3e43f1eedc9e5c1c1f Reviewed-on: https://chromium-review.googlesource.com/c/1339242Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#610188}
-
Majid Valipour authored
Previously scroll source was resolved anytime it was accessed. However this is problematic in two ways: - The Document.scrollingElement can change so we could resolve to a different node if that happens. However Attach/Detach process expect the resolved node to be the same and violating this invariant can cause unexpected behavior. - Resolution process can trigger layout which may not be allowed during detachment (see issue 890143) This patch changes this behavior so that the scroll source is only resolved at ScrollTimeline construction and the resolved node is used for the lifetime of scroll timeline. Bug: 890143 Change-Id: I8a745385e22e2c0718a5f9cade763f5eb2174c83 Reviewed-on: https://chromium-review.googlesource.com/c/1342677Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610187}
-
Erik Luo authored
Motivated by the desire to make Console links keyboard navigable, this CL removes the BrowserConsole module and moves logic back into ConsoleViewMessage. BrowserConsole did not explicitly depend on BrowserSDK. Bug: 865674 Change-Id: Ibb004c52699b1d504b32accdfa4ee19adc907633 Reviewed-on: https://chromium-review.googlesource.com/c/1338329Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#610186}
-
