- 16 Nov, 2018 40 commits
-
-
Wei Li authored
Recent commit 13fc02ff broke Windows build because the compiler on Windows uses different ABIs than those on Linux. The change caused the UI devtools server failed to be created so no connection could be made. This CL fixes the calling, and added a unit test to prevent future brokerage. BUG=903987 Change-Id: Ie8c0201ab817482b9e7d6eaf305ff0620dff3540 Reviewed-on: https://chromium-review.googlesource.com/c/1336446Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#608913}
-
Reilly Grant authored
In r604906 this method was updated to return the device list from cache if available. By running the passed callback synchronously however this violated the assumptions of other code, such as the USB device chooser on Android. Methods that execute a callback either synchronously or asynchronously tend to trigger errors in other code and so rather than work around this change in behavior this patch forces the callback to always be run asynchronously. Bug: 904321 Change-Id: Ib6a71bee3c578e42e2812bc762db40ebc2bd6994 Reviewed-on: https://chromium-review.googlesource.com/c/1338941 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#608912}
-
Peter Kasting authored
This allows enabling some disabled tests on Mac. Bug: none Change-Id: I3b5bce542d91f40842d9ab68bac60c1b11ef9014 Reviewed-on: https://chromium-review.googlesource.com/c/1338211Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608911}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4d46091. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Icdc3a568d2dfd89d63f768213bdc54a67e757982 Reviewed-on: https://chromium-review.googlesource.com/c/1340580 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608910}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/645a3afceae0..eee39206a2f6 git log 645a3afceae0..eee39206a2f6 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 sprang@webrtc.org Don't poll EncoderInfo from encoder twice per frame Created with: gclient setdep -r src/third_party/webrtc@eee39206a2f6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia7a23f4ddc9d9ce993b25ebf093d7b5d10187286 Reviewed-on: https://chromium-review.googlesource.com/c/1340388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608909}
-
Vlad Tsyrklevich authored
After a refactor I noticed that this unit test was broken. _aligned_malloc() does not go through the allocator shims on windows, but because we used EXPECT_TRUE() we didn't catch this failure. Delete the _aligned_malloc() test and refactor allocationCheck() to return failure count so that we can track failures across calls and return the proper exit code. Bug: 896019 Change-Id: Ibef719eb14980575cc52796167735f5a0ba177fc Reviewed-on: https://chromium-review.googlesource.com/c/1339319 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608908}
-
Adrienne Walker authored
This reverts this change: https://chromium-review.googlesource.com/c/chromium/src/+/1323715 And changes the WebGraphicsContext3dProvider implementation to not depend on Blink internals by using Skia types. Bug: 902022 Change-Id: I1fbe7a261095f4b30f1365e99005d332d66b7df8 Reviewed-on: https://chromium-review.googlesource.com/c/1323616Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608907}
-
Chris Lu authored
[ios] Implement TableViewPresentationControllerDelegate for Clear Browsing Data's Presentation Controller This will allow for a tap on the shield to communicate to the coordinator the view controller needs to be dismissed. The coordinator can then nil the view controller references. Video: https://drive.google.com/open?id=1imYHGJI0Dw6mm9LJD2N4atO1WMTaEl23 Bug: 904776 Change-Id: I8c1d9baf9c6c6de28fcd015f645e978f82623d3d Reviewed-on: https://chromium-review.googlesource.com/c/1336077 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608906}
-
Guido Urdaneta authored
This CL changes the policy so that the WakeLock is enabled only when an RTCPeerConnection becomes connected. Previously the WakeLock was enabled as soon as the RTCPeerConnection was created. This caused problems for some users, since some sites create peer connections that are never connected and are only closed when the peer connection is removed. Bug: 866200 Change-Id: I47e573f9555960c1a64a0f9834afb9d5dc048a94 Reviewed-on: https://chromium-review.googlesource.com/c/1315210Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#608905}
-
Aiden Benner authored
In preparation for enabling an errorprone check that would prohibit context#getApplicationContext in favour of ContextUtils#getApplicationContext see https://bugs.chromium.org/p/chromium/issues/detail?id=560466 for context. Bug: 846456 Change-Id: I13c432d238876cdf8c075e28f74d49e86f8f00a8 Reviewed-on: https://chromium-review.googlesource.com/c/1340376Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#608904}
-
Quan Nguyen authored
This prevents an invalid request while in the lock screen, since the OOBE dialog does not exist. Bug: 905752 Change-Id: Ie1f820877ea659c9cbfa1e260c2e6a49776e46c9 Reviewed-on: https://chromium-review.googlesource.com/c/1338111Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608903}
-
Jonathan Metzman authored
/OPT:REF works again with libFuzzer on Windows thanks to a clang patch and the recent roll. Reenable it on libFuzzer on Windows builds. Bug: 884545 Change-Id: Ia90acb6d1655d001c63d4fdc25700541f5ba4515 Reviewed-on: https://chromium-review.googlesource.com/c/1334556Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608902}
-
Xiaohan Wang authored
This CL removes "Reset Device Credentials" option from the "Protected Content" settings and related implementation. See bug for the context. Bug: 904883 Test: Verified that "Reset Device Credential" option is removed. Change-Id: Id88c045b8c6128396cef41c48f28e7ffddf5a367 Reviewed-on: https://chromium-review.googlesource.com/c/1333903 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#608901}
-
jdoerrie authored
This is a reland of 73564b6c Fixes Google Chrome Win Build Breakage by modifying module_blacklist_cache_util_win.cc. Original change's description: > [base] Remove base::span's comparison operators > > At the recent ISO C++ Committee meeting in San Diego it was decided [1] > to make std::span SemiRegular and drop its comparison operators [2]. For > further info see also this blog post [3]. > > This change updates the base::span implemention appropriately and > replaces prior usages of the comparison operators with their STL > algorithm equivalent. > > [1] http://redd.it/9vwvbz > [2] https://wg21.link/p1085 > [3] https://abseil.io/blog/20180531-regular-types#evaluating-span > > Bug: 828324 > Change-Id: I94e94450df5f233b6de81da81f309386e0dcf4a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1337628 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jun Choi <hongjunchoi@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608702} TBR=rockot@google.com,mek@chromium.org,dcheng@chromium.org,rsleevi@chromium.org,jrummell@chromium.org,haraken@chromium.org,hongjunchoi@chromium.org Bug: 828324 Change-Id: I9c28c2a000dc0994143a7565632f3e7489c702ba Reviewed-on: https://chromium-review.googlesource.com/c/1340219Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#608900}
-
Alexander Timin authored
Call ScopedTaskEnvironment::SetLifetimeObserver(nullptr) to ensure that the next test after ScopedTaskEnvironmentTest.LifetimeObserver doesn't crash. R=gab@chromium.org BUG=905812 Change-Id: Ifbdcfa55695fbd5641ffccb8d3e60a80d1afb3ca Reviewed-on: https://chromium-review.googlesource.com/c/1338090 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#608899}
-
Rohit Rao authored
Moves IO thread-specific initialization into WebSubThread. BUG=826465 Change-Id: I5527dafdf75c29fbc8478f7500c20a96410ad008 Reviewed-on: https://chromium-review.googlesource.com/c/1335961Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Matthew Wang authored
This is a reland of 20b9700c Original change's description: > Add Fast Transition as enterprise policy > > Add support for an enterprise policy that lets the admin > turn Fast Transition on or off. > > BUG=791202 > CQ-DEPEND=1291930 > TEST=(1) unit-tests (2) Added network policy to YAPS > server, enabled Fast Transition and checked that the > values propagate to client > > Change-Id: I4092ffb33169219515d235a25b1153e197a5af2d > Reviewed-on: https://chromium-review.googlesource.com/c/1297644 > Commit-Queue: Matthew Wang <matthewmwang@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607824} Bug: 791202 Change-Id: Id89eec841667ceb821e52eb53a37f2f9641bcbaa Reviewed-on: https://chromium-review.googlesource.com/c/1334839Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608897}
-
Jonathan Metzman authored
Bug: 906126 Change-Id: I4a6cce3f2b535fe24e44dd4569cb005c6edc2bc8 Reviewed-on: https://chromium-review.googlesource.com/c/1340481Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608896}
-
Shakti Sahu authored
This crash was introduced due to the changes for URL backstack introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1309428 Bug: 903716 Change-Id: Idfb7c09fde27ed546628b875f6fa2ac68b6f1cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1338484 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#608895}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5bf5a64fe7a9..07ee63d076e5 git log 5bf5a64fe7a9..07ee63d076e5 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 csmartdalton@google.com sksl: Add builtinFMASupport to StandaloneShaderCaps 2018-11-16 brianosman@google.com Add SkPMColor4fFitsInBytes 2018-11-16 mtklein@google.com remove _DXDY_ sample procs 2018-11-16 jvanverth@google.com Remove use of integers for atlas indexing 2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 000df8b42041..b16f9897a868 (4 commits) 2018-11-16 halcanary@google.com SkShaper: better error info. 2018-11-16 mtklein@google.com I think the _DXDY_ code may all be dead. 2018-11-16 michaelludwig@google.com Update threshold for degenerate gradients 2018-11-16 brianosman@google.com Use GrVertexWriter for GrRegionOp, add writeQuad() 2018-11-16 brianosman@google.com Do CCPR hairline coverage scaling in floats, rather than bytes 2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 44994a88c9cc..000df8b42041 (1 commits) 2018-11-16 herb@google.com Fun with flags 2018-11-16 csmartdalton@google.com sksl: Polyfill fma() when not present in GLSL 2018-11-16 scroggo@google.com Add safety net logging for issue 118143775 Created with: gclient setdep -r src/third_party/skia@07ee63d076e5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:905607,chromium:b/118143775 TBR=rmistry@chromium.org Change-Id: I8f2c6d04a79abcc003ca4c5c9c02fb4e71c05441 Reviewed-on: https://chromium-review.googlesource.com/c/1340386Reviewed-by:
-
Austin Eng authored
Bug: 894200, 891059 Change-Id: Ic3ad1be6bf9ce21cd672266d42ef4259fd47cd9d Reviewed-on: https://chromium-review.googlesource.com/c/1340568Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608893}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=timvolodine@chromium.org Bug: 903957 Change-Id: Icaf8fe70611a4e937b69bca1c2a670a9a45ae5ac Reviewed-on: https://chromium-review.googlesource.com/c/1338129Reviewed-by:Tim Volodine <timvolodine@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608892}
-
Lily Chen authored
Original CL description: This change makes it possible to reprioritize socket pool ConnectJobs to match their corresponding Requests. For TransportConnectJobs that are reprioritized while undergoing host resolution, the corresponding host resolver request is also reprioritized to match the connect job. Reland fixes a bug in the original CL causing a failing DCHECK due to trying to reprioritize jobs with RespectLimits::DISABLED, which should not be reprioritized as they should always be MAXIMUM_PRIORITY. Bug: 166689 Change-Id: If845c941b02a9a1c01c267ee463fda7205bd928c Reviewed-on: https://chromium-review.googlesource.com/c/1333135 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#608891}
-
Lei Zhang authored
Aside from adding the sanity check, this also hooks up loadTimeData in pdf_viewer.js, and demonstrates how to plumb a feature flag from the browser into pdf_viewer.js. BUG=61248 Change-Id: I48850afaac17854af785d04a8ca93078ebd8532f Reviewed-on: https://chromium-review.googlesource.com/c/1339244Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608890}
-
Justin Cohen authored
Change-Id: I9da271f43547686c9e141b2875e0b796d7adabae Reviewed-on: https://chromium-review.googlesource.com/c/1340643Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608889}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe9b104421c3..5a3d34a0f7ad Created with: gclient setdep -r src-internal@5a3d34a0f7ad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d49bb78f50faa15cb23309f8af17b08bb9c92f7 Reviewed-on: https://chromium-review.googlesource.com/c/1340387Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608888}
-
Changwan Ryu authored
Check window.origin value for HTTPS-schemed base Uri vs custom-schemed base Uri. Bug: 896059 Change-Id: Ic310c584e0826d14683734f8e6190875dddcc28f Reviewed-on: https://chromium-review.googlesource.com/c/1340821Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608887}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4d4ac41560ad..acedb7bc166f git log 4d4ac41560ad..acedb7bc166f --date=short --no-merges --format='%ad %ae %s' 2018-11-16 treehugger-gerrit@google.com Merge "ftrace: Add oom_score_adj_update" 2018-11-16 treehugger-gerrit@google.com Merge "profiling: Remove unused dump path." Created with: gclient setdep -r src/third_party/perfetto@acedb7bc166f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ida96dbcae9b91951260596b7f47b8a1043445c19 Reviewed-on: https://chromium-review.googlesource.com/c/1340383Reviewed-by:
-
Shimi Zhang authored
SELECTION_HANDLES_MOVED and INSERTION_HANDLE_MOVED are triggered for scrolling, but we don't want to perform haptic feedback in this case. Bug: 900778 Change-Id: I1ab97f3630ae0b0cca5ee1a1bf988699ac710bbb Reviewed-on: https://chromium-review.googlesource.com/c/1315990Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608885}
-
Colin Howes authored
Add a network disconnected connection type to the Update Engine connection type histogram. BUG=chromium:660283 Change-Id: Icc93ec2f49073566dcb49d6abcd70bc535aca176 Reviewed-on: https://chromium-review.googlesource.com/c/1235282Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Colin Howes <chowes@google.com> Cr-Commit-Position: refs/heads/master@{#608884}
-
Yaron Friedman authored
This is accessed by native and must not be renamed by proguard. BUG=905960 Change-Id: I99f74affe95c2e9356f66303eb921fa8a5eb1125 Reviewed-on: https://chromium-review.googlesource.com/c/1340366Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608883}
-
Jamie Madill authored
Currently when the script reads multiple results it outputs the last value read as well as a zero placehold for standard deviation. According to benjhayden@ we can return all results in an array. This change does just that and adds a test. It also updates the expected unit test output. Bug: 900677 Change-Id: Icc38808ea83caddbdf6b8582e2ddc34db4f8cdf0 Reviewed-on: https://chromium-review.googlesource.com/c/1338468Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#608882}
-
Theresa authored
The "ablation" variant of the Simplifid NTP was launched, so the shortcuts are no longer needed. We can also remove the feature flag and clean up some test code. Future CLs will do more clean-ups to remove support for bookmarks/downloads sections on the Chrome for Android NTP. BUG=865216 Change-Id: Ia0bd851c300f5a16d0a9d417eebb3cc37652e79e Reviewed-on: https://chromium-review.googlesource.com/c/1333107 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608881}
-
David Bokan authored
In https://crrev.com/f9cbcfa426bdf0cb830cd7d1ce7cc80845184d3e I landed a fix to https://crbug.com/898757. This fix was needed ASAP since it needed to be merged. I landed a fix without a test at the time. This CL adds a test. Bug: 901083,898757 Change-Id: I0b3dc44a7e94e33f5897f7d9f19159523807dc56 Reviewed-on: https://chromium-review.googlesource.com/c/1336786Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608880}
-
Mohamed Amir Yosef authored
This CL uses CachedMetric to record the histogram for number of queued messages instead of using RecordHistogram directly. RecordHistogram call native directly and hence falsifies the whole purpose of queuing FCM messages (to avoid calling the native code) In order to test the behavior, ShadowRecordHistogram had to implement the method recordCustomCountHistogram() of RecordHistogram. The reason is CachedMetric is internally using this method directly instead of the proxy methods such as recordCount100Histogram(). Bug: 882887 Change-Id: I15e9e77ab96cf65084242443a1a134c5df00f7fd Reviewed-on: https://chromium-review.googlesource.com/c/1340000Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#608879}
-
Steve Anton authored
Bug: 874296 Tbr: hbos@chromium.org Change-Id: Id2905574237fe9221d49a1e772c9ba0f3e7957e1 Reviewed-on: https://chromium-review.googlesource.com/c/1289436 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#608878}
-
Philip Rogers authored
Zoom animations [1] use LayerTreeImpl::ScrollableSize. ScrollableSize was incorrect if there was not an outer container layer, which is the case for Blink Gen Property Trees (BGPT) where we use property tree nodes for the outer container data. This patch makes LayerTreeImpl::ScrollableSize work using property tree nodes. To do this, ScrollTree::scroll_bounds has been introduced which is used by both ScrollTree::MaxScrollOffset and LayerTreeImpl::ScrollableSize. A common function for setting up browser controls and virtual viewport layers has been added: LayerTestCommon::SetupBrowserControlsAndScrollLayerWithVirtualViewport [1] Zoom animations are triggered on android via two codepaths: * Double tapping _anywhere_ on a non-mobile (i.e. desktop) page * Focusing (single tapping) on any editable These can also be triggered on desktop in some configurations, such as two-finger tapping a touchpad on MacOS. Bug: 899702 Change-Id: I022974df18c410f5a513aad1bce3dfcd30a902da Reviewed-on: https://chromium-review.googlesource.com/c/1338109 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608877}
-
Etienne Pierre-Doray authored
[TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /chrome/browser/ui/webui/chromeos/login base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=jdufault@chromium.org Bug: 903957 Change-Id: I884ec06bef124aef5b587bff4027e9014962c163 Reviewed-on: https://chromium-review.googlesource.com/c/1338487Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6a7b164f0c0e..d7cd1203a42b git log 6a7b164f0c0e..d7cd1203a42b --date=short --no-merges --format='%ad %ae %s' 2018-11-16 zoddicus@users.noreply.github.com Ensure for OpVariable that result type and storage class operand agree (#2052) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d7cd1203a42b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icb13cda81738459913597a2274ff0667099d5816 Reviewed-on: https://chromium-review.googlesource.com/c/1340385Reviewed-by:
-
Scott Violet authored
This reverts commit 6aac2af3. Reason for revert: Caused breakage of mash test. See https://crbug.com/902870. Original change's description: > MojoVideoDecoder: Add histogram to track initialization and error. > > The autotest video_ChromeHWDecodeUsed verifies Chrome used the HW > decoding when playing a video stream by checking the histogram value, > which is reported from GpuVideoDecoder. > In order to keep the test pass during switching from GpuVideoDecoder > to MojoVideoDecoder, we have to report the same histogram value > temporarily from MojoVideoDecoder. > > With this CL, we can enable MojoVideoDecoder at ChromeOS platform. > > BUG=chromium:902968 > TEST=Pass video_ChromeHWDecodeUsed autotest on Eve > TEST=Play video at Youtube on Eve and confirm the successfull option > of Media.GpuVideoDecoderInitializeStatus are increased. > > Change-Id: I26fc53704843e9b153bbee304e8f60ab3a7b0417 > Reviewed-on: https://chromium-review.googlesource.com/c/1328634 > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607890} TBR=posciak@chromium.org,sandersd@chromium.org,akahuang@chromium.org,hiroh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:902968 Change-Id: I3b74c752b6cc34dcbcba203eeb39707f4921d405 Reviewed-on: https://chromium-review.googlesource.com/c/1340378Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608874}
-
