- 29 Jun, 2018 40 commits
-
-
Fredrik Söderquist authored
Check Document::hidden() in LayoutObject::WillRenderImage, thus pausing animations on pages that are not visible. To resume animations, we may need to explicitly resume the timeline, so a hook is added in Page::SetVisibilityState to allow calling StartAnimation() on the relevant SVGImages. Bug: 856082 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4a0b008730ec3e6c2af26e15d52eebb26020ad32 Reviewed-on: https://chromium-review.googlesource.com/1115130Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#571543}
-
Peter K. Lee authored
FeedbackKit V2 launched in M67. In order to deprecate the V1 implementation, the first step needs to force the chrome://flags to true and then implementation code can be removed. Bug: 847329 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9451fa04453584d6e056e82f8c9f323d0a87c06c Reviewed-on: https://chromium-review.googlesource.com/1119355Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#571542}
-
Klaus Weidner authored
Managing the Surface/SurfaceTexture pair is somewhat expensive, and we don't need it for SharedBuffer transport. Now that the mailbox_to_surface_bridge supports surfaceless initialization (thanks to AR mode), use that to avoid this allocation. This required some minor reshuffling to ensure we have the right initialization order. BUG=857547 Change-Id: I7edca6e791f9b13bef4a3a50266715182517fdef Reviewed-on: https://chromium-review.googlesource.com/1120677Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#571541}
-
Bailey Berro authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/f05c58b1e0ca..ec6d4902f36c $ git log f05c58b1e..ec6d4902f --date=short --no-merges --format='%ad %ae %s' 2018-06-08 baileyberro smbprovider: Add auth params to the Remount proto 2018-06-22 derat system_api: Add GetKeyboardBrightnessPercent constant. 2018-06-12 smbarber vm_cicerone: add LXD container methods and signals Created with: roll-dep src/third_party/cros_system_api Change-Id: I670db644532a43a18fad629ea4c5b2c9d8c09b92 Reviewed-on: https://chromium-review.googlesource.com/1119345 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#571540}
-
John Rummell authored
Adds a new test file that is simply an audio stream fully encrypted with 'cbcs' encryption. BUG=850679 TEST=new content_browsertests and browser_tests pass Change-Id: I930af7aeb36cd4ccddab279849e3a84e6487bee3 Reviewed-on: https://chromium-review.googlesource.com/1093995 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571539}
-
Christian Fremerey authored
Fixes a race condition that can lead to a crash when taking a photo via the image capture web API on Android. Bug: 846576 Change-Id: I0008391acfd4fd1f84db1d403d33c0dc31410294 Reviewed-on: https://chromium-review.googlesource.com/1117845Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571538}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d0b89cd8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20356 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler TBR=kereliuk No-Export: true Change-Id: I03de0c3a0cc86d0e9c81a8593dc68802b16eef17 Reviewed-on: https://chromium-review.googlesource.com/1120156 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571537}
-
David Reveman authored
BUG= TEST= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I90a5f6b6904547bb64ef72f01664e6807377870f Reviewed-on: https://chromium-review.googlesource.com/1120351Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571536}
-
Ian Vollick authored
This change applies three heuristics to make trackpad scrolling feel smoother. We increase the frequency at which we submit scroll events to the platform, we also decrease the scroll scale factor (to make the scrolls less jumpy), and we do some simple filtering of our scroll values. I pair-programmed much of this change with asimjour@ and he wrote the initial code to interpolate events in the android ui gesture target. Bug: 859075 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad Reviewed-on: https://chromium-review.googlesource.com/1120425Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#571535}
-
Charlie Harrison authored
Some java code in the CheckCallback can synchronously delete the ongoing navigation. This should probably be fixed, but for now this CL just makes the InterceptNavigationThrottle robust to this failure case. The CL splits up the async and sync check logic in a way that improves readability as well. Bug: 856737 Change-Id: I540f3d18a7bcc923583991f1fecceae563be6641 Reviewed-on: https://chromium-review.googlesource.com/1115786Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#571534}
-
Mark Pilgrim authored
TBR=bartfab@chromium.org Bug: 844936 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I573698e0994b6dc6e70f0d17e6dcbbb83aa1a142 Reviewed-on: https://chromium-review.googlesource.com/1102725 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#571533}
-
Josh Horwich authored
Keep usage & diagnostics false during ARC setup if the user does not see the ARC ToS dialog due to all relevant settings being managed, even if usage & diagnostics is enabled for the device. Also removes the notification added by crrev.com/c/1086354. Bug: b/73338614, 859104, 855448 Test: Opt in to ARC with managed and unmanaged users Change-Id: If5bd6b10d4059df97af0b6c14c8f8a15ceaaddc0 Reviewed-on: https://chromium-review.googlesource.com/1115712 Commit-Queue: Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#571532}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/da32244d8116..e9d405363cbf git log da32244d8116..e9d405363cbf --date=short --no-merges --format='%ad %ae %s' 2018-06-29 lalitm@google.com trace_processor: add support for quantized slices Created with: gclient setdep -r src/third_party/perfetto@e9d405363cbf The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: Ia244315f9b7b6846d5777de9a9c06aae45466ccd Reviewed-on: https://chromium-review.googlesource.com/1120405 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571531}
-
Theresa authored
Fade out the toolbar buttons rather than scrolling them off when the NTP is scrolled. BUG=835412 Change-Id: I9c273aaa83f3546c9e04f9a7140c39796f09af9c Reviewed-on: https://chromium-review.googlesource.com/1120442Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571530}
-
David Reveman authored
BUG= TEST= Change-Id: I30e2f477136d3ed79577368874ade5f932906a5f Reviewed-on: https://chromium-review.googlesource.com/1120353Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571529}
-
Roman Kuksin authored
Bug: 856578 Change-Id: Ifb2a1b7e6c22e1af36e12eedba72427f51d925b9 Reviewed-on: https://chromium-review.googlesource.com/1114617Reviewed-by:
Hector Dearman <hjd@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#571528}
-
Mark Cogan authored
Adds a named guide to the content area so it can be positionally matched by transitions. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifcb0d873d88cf0af2b9f898a8d9e151b601504da Reviewed-on: https://chromium-review.googlesource.com/1118169 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#571527}
-
David Roger authored
When Dice is enabled, this will allow the reconcilor to perform a full web logout, in addition to turning off Sync. Bug: 852000 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I55bda4d7151fccd8c1f40b522fed0f5b63adbc1f Reviewed-on: https://chromium-review.googlesource.com/1117071 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571526}
-
Nicolas Ouellet-payeur authored
With this change, TranslateRanker only suppresses the infobar/bubble UI, but won't hide the omnibar icon for translating. This should be more convenient in cases where TranslateRanker draws an incorrect conclusion. Also, add a metric to track the new logical path: deciding to suppress the infobar/bubble UI, but still show the icon. Bug: 600874 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73ba3e28fea1479bbdafd8baf2c5c4da92c6bf9e Reviewed-on: https://chromium-review.googlesource.com/1115581Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#571525}
-
edchin authored
The content inset configuration was not correct for iPhone X on the tab grid. This CL implements a better configuration that works on all combinations of OS and device. Bug : 856718 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idfb72be09ce03ac5ee8bb68304c37b52cb4b9699 Reviewed-on: https://chromium-review.googlesource.com/1119631Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571524}
-
Mike Dougherty authored
The WebFrame class represents a rendered frame inside a WKWebView. This CL implements the class with its basic properties only. Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib1e803d586b3cfb8a52695272cb53ec0c05cfd33 Reviewed-on: https://chromium-review.googlesource.com/1117375 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#571523}
-
Sky Malice authored
Initialize it regardless of state so that either of the if blocks below can access it and be safe in doing so. Bug: 856384 Change-Id: I2205a3351e0ff0603ccaafd0594aaaf9ca8e29ec Reviewed-on: https://chromium-review.googlesource.com/1118911Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571522}
-
edchin authored
Since the close button and cell header is smaller than the recommended tap target, use an overlaid tap target to receive taps for the close button. Bug: 842647 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibc728aeba89cc9183a5de7d7fe1e8795dc3da99c Reviewed-on: https://chromium-review.googlesource.com/1118756Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571521}
-
James Cook authored
Bug: none Change-Id: I9270556bd90689ee2106f6c7591f39eefdf91ee0 Reviewed-on: https://chromium-review.googlesource.com/1119253Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571520}
-
Elad Alon authored
Some tests became identical when changing the way the feature was gated (switch vs. feature). Bug: 775415 Change-Id: I4b26cf9ca94f6a1bbc6f435f6378580d219fadc6 Reviewed-on: https://chromium-review.googlesource.com/1120336Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#571519}
-
Ben Pastene authored
Bug: 840967 Change-Id: Id556f0b2740b0ee9fcd799234c5936c71daf81fc Reviewed-on: https://chromium-review.googlesource.com/1118916Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#571518}
-
Jeremy Elson authored
Small cleanup: use the IsOptimizationHintsEnabled helper function consistently rather than accessing the kOptimizationHints feature directly. Change-Id: Ie61c5ba532e71c9524369f5d1bb056e8303ac02f Reviewed-on: https://chromium-review.googlesource.com/1119229Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Elson <jelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571517}
-
Ryan Hansberry authored
SecureChannel will simply listen forever, waiting for a connection to the specified remote device. MessageTransferOperation now uses a new timer that times out if a connection is not created in time. Bug: 824568, 752273, 854885 Change-Id: Ia37cf1ec55e60ae3e7e386cdf40fdd9486ab6cdf Reviewed-on: https://chromium-review.googlesource.com/1117899Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#571516}
-
Yi Su authored
Current web page text accessibility feature maps the system accessibility text category to a scaling number and adjusts font size based on that, so if Apple adds a new accessibility text category it won't work. The CL adds UMA to count that failure. Bug: 836962 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5bf2fb9c2f96dcc457afe423c302139cb1845fea Reviewed-on: https://chromium-review.googlesource.com/1112639Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571515}
-
Ken Rockot authored
Hurray! Replaces all usage of ScopedInternalPlatformHandle or InternalPlatformHandle with the public PlatformHandle type, a thing which is inherently scoped and also not weirdly overloaded a bunch of random non-handle junk. Hurray! Bug: 753541 Change-Id: Ie828e5545e24d4b57ea6fb9f21e635a02a52f9ff Reviewed-on: https://chromium-review.googlesource.com/1115804Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571514}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7869e579e31e..e33bdbe1d4a1 git log 7869e579e31e..e33bdbe1d4a1 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 vpalatin@chromium.org cros_portage_upgrade: disable the unittests Created with: gclient setdep -r src/third_party/chromite@e33bdbe1d4a1 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:858925 chromium:859031 TBR=chrome-os-gardeners@chromium.org Change-Id: I52432bf9a3d47ca14da962959bd06cecb9582493 Reviewed-on: https://chromium-review.googlesource.com/1120408Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571513}
-
Rune Lillesveen authored
::first-letter sadly has at least three code paths for computing its computed style. Two of them were lacking stacking context update. There is work in progress for Squad to mend this, but let's fix the current code paths for now. Bug: 856806 Change-Id: Ifeea799643bfa266e58c948f476bc23481fcdd5e Reviewed-on: https://chromium-review.googlesource.com/1120249 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571512}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c4642d4ffe8e..55f82fcc1297 git log c4642d4ffe8e..55f82fcc1297 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 thestig@chromium.org Clean up CJBig2_PDDProc. Created with: gclient setdep -r src/third_party/pdfium@55f82fcc1297 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3dbdc502996383f435c32330b28d88469d90e81e Reviewed-on: https://chromium-review.googlesource.com/1120385Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571511}
-
Ioana Pandele authored
This is the same text that used to be displayed in the password generation popup. It includes a link sending the user to the place in settings where they can manage their saved passwords. Bug: 835234 Change-Id: I7a072fe75323c813b43d20b1fdc545656dff789c Reviewed-on: https://chromium-review.googlesource.com/1113920Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#571510}
-
Jialiu Lin authored
Edit PasswordProtectionWarningTrigger description, since we've expanded protection to non-Google enterprise passwords. Bug: 845038 Change-Id: I3d98ee28f5ddf73b5f5e091b10d516fafaffc3ba Reviewed-on: https://chromium-review.googlesource.com/1118971Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571509}
-
Kim Paulhamus authored
Change-Id: I3f3c8470cdfd5ed7f57cba7243c8c678fcd6dec3 Reviewed-on: https://chromium-review.googlesource.com/1120432 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#571508}
-
Jeremy Roman authored
As requested during post-commit code review: https://chromium-review.googlesource.com/c/chromium/src/+/1118606/2/third_party/blink/renderer/modules/webaudio/base_audio_context.cc#756 Bug: 856641 Change-Id: I11fbe07a57dc4336fa10a552d424ded371ef72b2 Reviewed-on: https://chromium-review.googlesource.com/1120428Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571507}
-
Ted Choc authored
BUG= Change-Id: I7b7eeb6c445bbae504803659938bb34d81fc5602 Reviewed-on: https://chromium-review.googlesource.com/1120438Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571506}
-
Stephen Chenney authored
This patch corrects most of the known issues we have with sprite use in background images under zoom, cracks at the border of background images, failing to fill the positioning area with round, cover and space, etc. There may still be cases we fail at but they do not appear in bug reports or they are significantly harder to fix (meaning requiring changes in Skia or elsewhere). The primary change is to track snapped and unsnapped values throughout the background rendering pipleline, and use the appropriate values for every calculation. In general, this means using unsnapped values when trying to compute something related to source pixels, and snapped values when trying to describe the region for painting or calculations intended to interact with the destination region. There is scope for simplifying the code but they can wait until this has landed and stuck. In particular, we add and then subtract offsets when determinine source rects. And we do some odd adjustments for certain scrolling cases that seem like they could be removed. New tests cover various sprite sampling under zoom conditions. Several ref tests had to be converted to image tests because repeated images are now sub-pixel sized and cannot easily be matched with a reference result. R=fmalita@chromium.org,fs@opera.com Bug: 823339,825239,805495,785171,710342,659825,449600,594481,589449 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I32689f285d621afb7ec929eb193d7683dd15ff01 Reviewed-on: https://chromium-review.googlesource.com/1112563 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#571505}
-
Jeremy Roman authored
It's simpler and more direct. Change-Id: Ieaed47c3c2e4a28e7b6fdfe47b9fd8de355196de Reviewed-on: https://chromium-review.googlesource.com/1117704Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571504}
-