GitLab

The step in LocalFrameView has been merged into CompositingCommit
(PaintArtifactCompositor::Update) in http://crrev.com/815947.

Bug: 1132717
Change-Id: I69417ad86ae3b7507641ad693255aca9e58958ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462068Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816648}

Updates the expires_after attribute for 32 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-01-11.

TBR=chromium-metrics-reviews@google.com

Change-Id: I5b4b211108beb83581913b1937703415dd1a8600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467759Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#816647}

- Add customized notification view to phone hub notification controller.
- Add "From Phone" to the notification's header.
- Add IDs to NotificationViewMD to access the header in the view.

Screenshot: https://screenshot.googleplex.com/3kW99Ch5wGvVrGz

BUG=1106937,1126208

Change-Id: I0d0726d0d05c967384db702a557ba7a2895d77c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464163
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816646}

Privacy review:
https://docs.google.com/document/d/1L93H6TYrtq4qRWzvEa3H7uKZhwWCtTTJ_bT6QFdg_ys/edit#heading=h.k5jx6iluw4yt

Bug: 1133883
Change-Id: I07a89ebca144e8ee7d5600f2b5eba79b7069a64c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450610
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816645}

Despite what the current name implies, ComponentExtensionIMEManagerImpl
is NOT an implementation of ComponentExtensionIMEManager interface
(that's actually a concrete class, only ever subclassed by its mock).
This is extremely confusing in terms of readability.

In fact, ComponentExtensionIMEManagerImpl [sic] is an implementation
of ComponentExtensionIMEManagerDelegate interface. An instance of the
latter is dependency-injected for use by ComponentExtensionIMEManager
itself. The already confusing misnomer is thus exacerbated, as both
ComponentExtensionIMEManager and ComponentExtensionIMEManagerImpl [sic]
tend to appear together while bearing no inheritance relationship.

In this patch, ComponentExtensionIMEManagerImpl [sic] is renamed to
ComponentExtensionIMEManagerDelegateImpl to reflect what it really is.
Descriptiveness and conciseness improvements are out of scope.

Also:
- Extract ComponentExtensionIMEManagerDelegate to its own .h file.
- Fix pre-existing std::unique_ptr usage as flagged by presubmit errors.
- Replace pre-existing NULL with nullptr as flagged by presubmit errors.

Bug: 1134465
Change-Id: If36b7d4c17ee19cdfc773c22ad4f384779b2a4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440381
Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816644}

When the app is backgrounded and foregrounded again,
DisclosureNotification#onStartWithNative is called again, but
DisclosureController hasn't updated the model to reflect that the
notification has already been shown.

Change-Id: I96463c61e6e611528f47dd68f7c5a0cc4e34ec54
Bug: 1136477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467978Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816643}

This CL extracts code that tests X11-specific event logic into test
binaries that only run on X11 bots.

Bug: 1109112
Change-Id: I3ff177c911e170a4899455e98437da7aa3615238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466245
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816642}

Consider this code:
  <style>i { white-space: pre-line }</style>
  X<i> </i><i>&#10;</i>

The first time that NGInlineNode::CollectInlines runs, the text data
will be "X", then "X ", and then AppendForcedBreakCollapseWhitespace
will remove the trailing whitespace before inserting the forced break,
so we get "X\n".

But if some text is appended dynamically, CollectInlines will run again,
and this time it will try to reuse existing items in AppendTextReusing.
Before this patch, this would produce "X \n", which would trigger a
DCHECK failure in ComputeOffsetMapping because it's a different string.

Therefore, this patch prevents AppendTextReusing from reusing existing
items if the last item to collapse with ends with collapsible spaces and
the first item to reuse has 'white-space:pre' and begins with a newline.

Bug: 1136688

TEST=external/wpt/css/css-text/white-space/pre-line-with-space-and-newline.html

Change-Id: I0ff71b125b66256ec3b5c263605c3c116f9ac55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466279Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#816641}

https://dawn.googlesource.com/dawn.git/+log/d1bca09f4ab3..ccaef8525710

2020-10-13 rharrison@chromium.org Add running spirv-val on output of Tint

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: enga@google.com
Change-Id: Ia7ffaa02a5368ca3e365f350ad88e198187fb013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468140Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#816640}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8567edac4fdf..c0568abaca2d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC tnagel@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: tnagel@google.com
Change-Id: I39cf9325ed7a8af8e312cd0928b5313a41f0d45c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466922Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#816639}

These histograms are now logged inside blink and the appropriate
tests should move as well.

BUG=1097816

Change-Id: Ic84798cf223bf0dafe73bd813952d6678ba066aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461986
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816638}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ie167bdcfa494f7b6a7aaa0345c245167fcc9cded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466732Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#816637}

1/ RemoteCommandsInvalidator needs its Shutdown method called before
   destruction.
2/ RemoteCommandsInvalidator calls Start() itself after initialization
   is complete, no need to call it manually.

Bug: 1137832
Change-Id: I4a76369100c2bc1d599ddb8b43fc055d6fd301d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463715Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816636}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4fe1d403a22d..7c9f31beb6db

2020-10-13 inglorion@chromium.org cros_sdk: inform and raise vm.max_map_count if too low
2020-10-12 saklein@chromium.org Revert "deploy: Refactor SplitCPV to parse."
2020-10-12 saklein@chromium.org api/tutorials: Add part 4, faux decorators.
2020-10-12 jettrink@chromium.org build_api: add handlers for tot fw builder API
2020-10-12 jettrink@chromium.org generate: initial commit of firmware proto file
2020-10-12 manojgupta@chromium.org config_lib.py: Add hwtests for trogdor64

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: If4857d6142f47d4d1db7674cfd5c220aa8701837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466929Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#816635}

Obtained via `wget https://unpkg.com/d3@5.16.0/` on corp network

Bug: 1136195
Change-Id: I786c7a1e6a21f84392d455d15feeba5011cf231d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458847Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816634}

Fixes the issue when the user does not have the stored hour clock type
preference - it uses the previous user preference.

Bug: b/168759134
Change-Id: I415b85456dd578ac0565b42c819ef9d0b3590d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443009Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816633}

Removes all confirm Messages and any unused classes from the legacy
implementation.

Bug: 1024288, 961343
Change-Id: I60ac68d040e33b08b677665670186631054d37ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416940
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816632}

When the display compositor is offscreen, and the passed in surface
handle is null, return a stub class for overlay processor. This removes
enable_overlay and could_overlay bools from other overlay processor
classes.

R=Khushal

Bug: 898680
Change-Id: I75f72ba3dfabcc3ab0e2fe80509bb6cad7a74910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446463Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Maggie Chen <magchen@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816631}

A flag to check if a new RenderFrameHost is really new in
WebTestControlHost::HandleNewRenderFrameHost(),
we check if its RenderViewHost is already contained in
|main_window_render_view_hosts_|.

This detection is based on our past design that we don't
delete RenderViewHosts in a web test, and we don't erase
entries of |main_window_render_view_hosts_|.
But it can happen if we start to swap RenderFrameHosts and
RenderViewHosts with Browsing Instance Swap and/or
Back-Forward Cache.

After deleting an old RenderViewHost, a new RenderViewHost
can be created on the address where the old one was allocated.
This address conflict can lead a misjudge of the check of
new RenderFrameHosts.

This CL handles delete events of RenderViewHosts for main
windows on WebTestControlHost, and removes their addresses
from the list.


Bug: 1136383, 1132180
Change-Id: I442ad67d2207a822dec37fb676d623dd035f0b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462997
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816630}

In browsertests we don't wait for the bubble to be actually shown
before verifying the view. Fix it by having the tests wait for extra
events.

Bug: 1133332
Change-Id: I898ae939a7b604dff6d170d54d136566ad34799f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464025
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#816629}

crrev.com/c/2415244 introduced a new runtime flag for 'advance-override'
but didn't properly handle it in the parser. As a result, the descriptor
is leaked to web.

This patch fixes the parser to make sure it's properly hidden behind the
flag.

Bug: 1137624
Change-Id: I69f161932aede553b1cb31b181187e687eba1df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466979Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816628}

As part of bug 800764 I'm working on getting rid of BUILD.gn files
in core sub-directories, and merge (almost) everything into one large
core target. This was the only fuzzer whose target wasn't defined in
core/BUILD.gn, so I moved it there.

Bug: 800764

Change-Id: I468dc316795a2cc4e17fe424e35c7fea8da1de21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467856Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816627}

When we are using gpuBenchmarking.PointerActionSequence to simulate
three mouse click, it only set the click count to 2, not 3. It should
keep the mouse click count and decide if we should increase the count or
set to 1 when we have a mouse press based on the interval of two mouse
presses and difference between the current mouse positions and the last
one.

Bug: 1119679
Change-Id: If95c4da4aa62ae897204badfe1b1035f5240e0c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446637Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816626}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4159ffc366a3..320cf8513172

2020-10-13 bmeurer@chromium.org [third_party] Roll wasmparser 3.2.0
2020-10-13 sigurds@chromium.org Refactor static member to proper accessors
2020-10-13 tvanderlippe@chromium.org Use Node module resolution for tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1135143
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7cbe3e1f1e9164262e138fb983cd34d2534d9512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468138Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#816625}

BUG=b:153935975
TEST=Chromium builds for arm-generic.

Change-Id: I633a3b6df23fc097920dc1101fd08bc89ed71e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460753
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816624}

This is duplicated to the same config set in build/config/BUILDCONFIG.gn
causing 2 sets of coverage compiler flags in compile command.

Bug: 1137569
Change-Id: Ic4f712ff098e6e8b036576782d5f1a09f693da32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463853Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816623}

This reverts commit bbf55256.

Reason for revert: Better fix in:
https://chromium-review.googlesource.com/c/chromium/src/+/2468338

Original change's description:
> Handle ChromeVox Search + Space to "press" holding space items.
>
> Search + Space propagates to the view as mouse events. Unfortunately we
> can't tell from the mouse event if the event was created by ChromeVox
> but its good enough to just check if ChromeVox is enabled.
>
> Bug: 1137039
> Change-Id: I0ed18774632b0e46bf6100d86a27abbf5df29f85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466165
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Commit-Queue: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/master@{#816340}

TBR=dmblack@google.com,amehfooz@chromium.org

Change-Id: Ic438b2da85cceb76d66521e11c5520787e456dee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1137039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468339Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#816622}

This will control a feature which will send reports if the JavaScript on
a WebUI surface has a serious error, such as an unhandled exception.

Following instruction from go/finch-feature-api

Launch bug: https://crbug.com/1134416

Bug: chromium:1121816
Change-Id: Iaf2ac7935bf0546a9d1cc3709448ab5695b62196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462487Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816621}

This reverts commit 989724c3.

Reason for revert:
Fixing test failures. The msan failures were due to hash operator trying
to hash uninitialized padded bytes of the struct. Fix the struct to not
have any padding.

Original change's description:
> Revert "[tracing] Remove special handling of task execution and log events"
>
> This reverts commit f79b1513.
>
> Reason for revert: Breaks WebKit Linux MSAN
>
> The following tests started failing since this landed:
>
> * http/tests/devtools/tracing.js
> * http/tests/devtools/tracing/decode-resize.js
> * http/tests/devtools/tracing/timeline-paint/update-layer-tree.js
> * http/tests/devtools/tracing/timeline-style/parse-author-style-sheet.js
> * http/tests/devtools/tracing/tracing-record-input-events.js
> * http/tests/devtools/tracing/user-timing.js
> * http/tests/devtools/tracing/worker-events.js
> * http/tests/devtools/tracing/worker-js-frames.js
> * inspector-protocol/sessions/tracing-start.js
> * inspector-protocol/timeline/tracing-proto-format.js
>
> First run that failed, also the run where the CL landed:
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7830
>
> Original change's description:
> > [tracing] Remove special handling of task execution and log events
> >
> > The task execution and log events are handled specially for writing
> > proto arguments because we did not have the support for typed events in
> > base and interning support for the event macros. Now these events can
> > use the new client library API.
> > The events have to be migrated together because the source location
> > interning index is common for all events in the API and does not
> > account for the special handling in event sink.
> >
> > BUG=1136635
> > TBR=chirantan@chromium.org
> >
> > Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636
> > Reviewed-by: ssid <ssid@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: Erik Chen <erikchen@chromium.org>
> > Reviewed-by: Eric Seckler <eseckler@chromium.org>
> > Commit-Queue: ssid <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#815911}
>
> TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1136635
> Change-Id: I7a84356400bbdcae3144fd65afdcab7a4407dcd9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462895
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816069}

TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1136635
Change-Id: Ia659185ebeb265dc47ff6c2ef47bd9d8cc43dd65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466507Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816620}

- Add a CustomReportData struct to report data for kCustom
  typed FrameSequenceTracker to include jank_count as part
  of the report;
- Update the report code path, changing from ThroughputData
  by value to CustomReportData by const reference;
- Update autotest private api to use the new struct and
  report jank_count as part of animation metrics data;

Bug: 1132017
Change-Id: I30d932c2e64a0e2e0e2f3c99afa4918fc38d97b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465872Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816619}

This new clang-tidy check complains when param names /*in_comments=*/
don't match up with the actual parameter name they're being passed to.
Sometimes this is benign, other times, actual bugs are found.

Since callees and the definition used `quad_layer_rect` here, flip the
decl to use that, too.

Bug: 1136209
Change-Id: Ifb6a7e11d2816f1d05f5403b77af8382e605467b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458892Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816618}

AX-Relnotes: n/a
Change-Id: If9025b31fb1fceb89e4c691cc89f632eca632de8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466137Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816617}

ConstructAboutInformation() gathers debugging information about the sync
state. It's employed both to power the sync-internals page - a debugging
page only accessible locally - as well as to compose logs sent to Google
in case of crashes (provided the user has agreed to this). For the
latter use case, the caller used to manually filter a section containing
PII, for privacy. Delegating this responsibility to the caller was bad
since the return value is quite "weakly typed" (base::DictionaryValue).
This meant that one might easily add new sensitive information to the
return value while forgetting to update the filter in the caller.

In this CL we transfer this responsibility to the method, by exposing
an include_sensitive_data parameter. Additionally, we now force the
constructor of a "section" to specify whether it is sensitive or not.
This last part makes the code more privacy-aware, which should make it
less likely to accidentally leak any data (even if this solution isn't
bullet-proof).

Bug: 973820
Change-Id: I99138a741c26755e138ac0a60dd08815aa90a10c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467939
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816616}

See the linked bug for the renaming rationale.

Fixed: 1103583
Change-Id: Ifcb673542ec3514f30c811ce0edac7dc048cd846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468117
Commit-Queue: Victor Vianna <victorvianna@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816615}

mac_upload_clang had set static version of xcode to use. This
change removes these static properties such that it uses a version
of xcode calculated from the OS in the osx_sdk recipe module.

Bug: 1137520
Change-Id: Ia184c03abad326656989402655645938437d37e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468236
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816614}

ServerConnectionManager (and its implementations, plus some related
helper classes) returned an HttpResponse as an output parameter.
Output parameters are generally discouraged, and here in particular,
they made the logic hard to follow since the whole thing went through
many layers.

Before this CL, the methods in question returned a bool that roughly
meant "success", but it was inconsistent (in some layers, an HTTP error
would be counted as success, in others as failure). Now, they return
the HttpResponse instead. Clients now query the "success" they're
interested in from the HttpResponse.

Bug: 951350
Change-Id: Idd7867246506caf069287e4dc34c8b59a1da59fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465910
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816613}

This is a reland of crrev.com/c/2412693

This should not change deep scanning behaviour with Connectors. The
corresponding enums are kept until crbug.com/1109242 is fixed. Removing
these policies completely is safe since they were marked as future and
they have only been delivered as cloud policies.

Bug: 1103390
Change-Id: Ia0fd596313b15f20efd24958326a77da3342b485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463446Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816612}

Bug: 1018157
Change-Id: I3b72659190a78405f3201c85ad2cfe2672413ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456038
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816611}

The non-virtual version of
external/wpt/html/semantics/scripting-1/the-script-element/json-module/json-module-service-worker-test.https.tentative
fails by-design without --enable-features=JSONModules, but it's missing
the expectations file for this failure and is instead disabled in
TestExpectations.

This CR adds the expectations file so that the disable in
VirtualTestSuites can be removed, and crbug.com/967018, which is
actually the implementation bug for Synthetic Modules, can be resolved
(which should have happened a while back when we finished that feature).


Bug: 967018
Change-Id: I8046fc66861e077f5d5d9515118f19ac768aec0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466204Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#816610}

Test that signed in account is shown at the top of the list of accounts
in AccountManagementFragment page.

Bug: 1105800
Change-Id: I4990400862acf4b794f205062b47acc46365fbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465747Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816609}