- 15 Aug, 2018 40 commits
-
-
Chris Palmer authored
Bug: 817982 Change-Id: If8602db9f284873f037775f3a37bcac8e120b313 Reviewed-on: https://chromium-review.googlesource.com/1166456Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583155}
-
Wenzhao Zang authored
1) The full-screen white background in OOBE is rendered in web-ui, so there's a delay showing it. Users will see a glimpse of the default wallpaper (it's blue on an eve) between the boot splash screen and the OOBE screen (both white). To avoid this, we can show a white wallpaper during the entire OOBE screen, which can show right after the boot splash seamlessly. 2) The original idea was to delay the dismissal of the boot splash screen until OOBE dialog is ready. However, boot splash screen will not always show (e.g. when a guest user exits, or browser crash and restart). In such cases, we also want to avoid showing the blue default wallpaper before the white OOBE screen is loaded. Therefore, showing a white wallpaper is a better solution. Bug: 872936 Change-Id: Iaa600f9d455956743a6cfd3dd26f07ad2a4ed61d Reviewed-on: https://chromium-review.googlesource.com/1172066Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583154}
-
Andrey Lushnikov authored
This patch adds the `isIsolatedWorld` bit to the execution context's aux data. This is necessary to be able to differentiate between isolated worlds and other worlds, e.g. worklets. R=dgozman Change-Id: I3741b1631f653ffcfaddcba6bf40b229711494dc Reviewed-on: https://chromium-review.googlesource.com/1173015 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583153}
-
Asami Doi authored
This CL adds a new 'name' option to the WorkerOptions dictionary, but not fully implement it yet and instead shows the console message. Subsequent CLs will implement it. Spec: https://html.spec.whatwg.org/multipage/workers.html#workeroptions Bug: 721219 Change-Id: Ie03ab85a9c3d5636017cc72e3389394b120da508 Reviewed-on: https://chromium-review.googlesource.com/1174581 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#583152}
-
Hiroki Nakagawa authored
These tests are failing on non-dbg bots, too. Bug: 846747 Change-Id: I846d5a6f521f8f5d8d47f0d52f34c199d39ce666 Notry: true TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1175501Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#583151}
-
Alexei Filippov authored
Precalculate and cache running accumulated value for each category, then use a binary search to find values for right and left bounds and subtract them. BUG=874116 Change-Id: I3195ce4c38d52d048d453c5f999fb7005f0982ff Reviewed-on: https://chromium-review.googlesource.com/1175241 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#583150}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41e33062. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22735 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Iefbd3121e68ae03c7e379e45525770da0c780f0b Reviewed-on: https://chromium-review.googlesource.com/1175402 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#583149}
-
Jordy Greenblatt authored
The main thrust of this CL is to build the multidevice-tethering-item element which is a wrapper for the network-summary-item and provides relevant updates. It is intended to encapsulate the tether-relevant functionality of the network-summary element. This also involved some mild refactoring in the settings/internet_page folder to allow the network-summary-item to be reused in the multidevice subpage and a fix of a minor bug in the cr-network-icon element that was causing problems for the multidevice-tethering-item. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idb03c1f051cc03e825d0389508e1bd3e2e5d28e6 Reviewed-on: https://chromium-review.googlesource.com/1140733 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#583148}
-
Joel Hockey authored
Change 'background-color:white' to apply to outer webview/iframe element rather than inner body so that test page picks this up. Add missing string. Bug: 813477 Change-Id: I69d4827e4ec5dd4cc40b1ad229c6c8afd6e2254d Reviewed-on: https://chromium-review.googlesource.com/1174578Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#583147}
-
David Bokan authored
This bug was introduced by: https://crrev.com/dbd4eed1920a2aafbc87236db7efb98f108ba063 The previous behavior was to only ProcessUrlFragment if rendering was ready. If it wasn't, we would mark it as needing processing and try again when it becomes ready. My patch above separated ProcessUrlFragment from ScrollAndFocusFragmentAnchor but omitted the deferral of the latter in cases where rendering wasn't yet ready. This patch simply early-outs in ScrollAndFocusFragmentAnchor when rendering isn't yet ready to match the old behavior. It also adds back a hook in ImplicitClose since a layout may not be needed at the time the document was closed because it was done at a time when rendering was still blocked. Bug: 851338 Change-Id: I70d4ab233580f7c005fd56e805d5acd79cd4eee6 Reviewed-on: https://chromium-review.googlesource.com/1130958Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583146}
-
Yafei Duan authored
Avoid moving OnceCallback twice by wrapping it using base::AdaptCallbackForRepeating. Bug: 874024 Change-Id: Ieee18e1084a555f4757e7c18c54a79cb13902736 Reviewed-on: https://chromium-review.googlesource.com/1175311 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#583145}
-
Alexei Filippov authored
BUG=874116 Change-Id: Ie98f2d526921dc7d1b49a6a6a89e4778c48308ab Reviewed-on: https://chromium-review.googlesource.com/1175409Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583144}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Iffe72276a1214d28aac2fd5743889f020fdd936d Reviewed-on: https://chromium-review.googlesource.com/1175423Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583143}
-
Sujie Zhu authored
A card is migratable only when this card's card number and expiration date is valid and does not have a duplicated server card. The validation and duplication check is only supported in the c++ side, so we add a new attribute called IsMigratable when we create each CreditCardEntry in autofill_util in order to check the migration requirement later. The following CLs will be: 1. Use the added IsMigratable, syncStatus and experimental flag to check the migration requirement. 2. Display the migration button to the user when requirements meet. 3. Trigger migration when user click on the button with a new API call. Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i Bug: 852904 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib02706bea5e7485eb8ac7dfd227003e3380e24af Reviewed-on: https://chromium-review.googlesource.com/1173142 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583142}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f1630e3..022206d5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I247c6ef3906ea82a3caeb4c8f9c5308e2106ea34 Reviewed-on: https://chromium-review.googlesource.com/1174924Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583141}
-
Peter Mayo authored
Make them use the same variable name as the code they describe. Bug: None Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id8547edbcc39b591865165bab440165e4d05e7e1 Reviewed-on: https://chromium-review.googlesource.com/1169697 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#583140}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a2f48ac5546b..a66ea19e9d55 git log a2f48ac5546b..a66ea19e9d55 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 lepton@chromium.org Remove newbie related builder 2018-08-14 dgarrett@google.com cros_mark_as_stable: Switch --srcroot to --buildroot. Created with: gclient setdep -r src/third_party/chromite@a66ea19e9d55 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icefbce93050d1e08e207fc7d91477b949851f545 Reviewed-on: https://chromium-review.googlesource.com/1174975Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583139}
-
Tom Anderson authored
It was decided in [1] that the Ctrl+Shift+Q shortcut should be removed altogether and replaced with a bubble giving an alternative way to quit using the keyboard (similar to the "Press Alt+Left to go back" bubble). [1] https://docs.google.com/document/d/1mvTBrxD58GIsqFiqgiLCZiXy1iOtDpQx_Tp5OSuYWEU/edit?usp=sharing BUG=243164 R=sky Change-Id: I47578d6b750c45fbc5d0a6e6ffe7e5f528dbe80d Reviewed-on: https://chromium-review.googlesource.com/1173654 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583138}
-
Aga Wronska authored
Bug: 868105 Test: DemoSetupTest, DemoSetupArcUnsupportedTest Change-Id: I5b4616c620dabf11704a02fd9345e22515e5a373 Reviewed-on: https://chromium-review.googlesource.com/1164560 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#583137}
-
rajendrant authored
Update the placeholder image replacement mechanism to not forcibly bypass the cache. This was implemented for server LoFi feature, and no longer needed. The design doc has more explanation as well. https://docs.google.com/document/d/1jF1eSOhqTEt0L1WBCccGwH9chxLd9d1Ez0zo11obj14/edit#heading=h.v3bc3q4jzwm4 Bug: 846170 Change-Id: I6cbbdc81528984bbd9c15da3e498e277a8c2cfca Reviewed-on: https://chromium-review.googlesource.com/1166600Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#583136}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f46d49b52d39..b924003d3504 git log f46d49b52d39..b924003d3504 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 thestig@chromium.org Remove unreachable vertical text code in CPDF_Document. 2018-08-14 tsepez@chromium.org Remove default level from FPDF_GetFieldAttr(). 2018-08-14 vmiklos@collabora.co.uk Add FPDFFormObj_GetMatrix() API 2018-08-14 tsepez@chromium.org Remove unused form/args of AddWindowsFont() 2018-08-14 thestig@chromium.org Add CPDF_Type1Font::IsBase14Font() to replace GetBase14Font(). 2018-08-14 thestig@chromium.org Remove CFX_BufferSeekableReadStream. 2018-08-14 tsepez@chromium.org Remove more default arg = nullptr cases. Created with: gclient setdep -r src/third_party/pdfium@b924003d3504 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2d9bc49618d805737348097adcee81d84f5cbef2 Reviewed-on: https://chromium-review.googlesource.com/1174797Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583135}
-
Jialiu Lin authored
Add AdvancedProtectionStatusManager class to observe signin and gaia account events, and update advanced protection state accordingly. Bug: 866620 Change-Id: I28453160d030aea9080f8f8c30ad2162aa18372f Reviewed-on: https://chromium-review.googlesource.com/1157560 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#583134}
-
Aga Wronska authored
Bug: 857515 Test: DemoSetupTest Change-Id: Iaa3106dacad12855c8c62bcff05bd91c2b6e0a1e Reviewed-on: https://chromium-review.googlesource.com/1164253 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583133}
-
Zach Helfinstein authored
Modify AccessibilityPanel sizing to be more flexible, and work for both the ChromeVox panel and the SwitchAccess context menu. Also fixes a bug where ChromeVox Panel fullscreen goes offscreen when Docked Magnifier is enabled. Bug: 864796 Change-Id: Ib99150f68dcb332aa86a0cc72d7863d6e6b301f7 Reviewed-on: https://chromium-review.googlesource.com/1167886 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583132}
-
Makoto Shimazu authored
This reverts commit c1df3739. Original description: > Each FetchContexts needs to be notified it's update. This introduces a new Mojo > interface (mojom::RendererPreferenceWatcher) to observe changes in the > preferences. TBR=lazyboy@chromium.org avi@chromium.org Bug: 853085 Change-Id: I850dbba70812013e2495670229a00e8e94f1a597 Reviewed-on: https://chromium-review.googlesource.com/1174203Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583131}
-
Eric Roman authored
Change-Id: Iebb06cdefd1ced27cad5aef8a2679dfee291efcf Reviewed-on: https://chromium-review.googlesource.com/1175107Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583130}
-
Muyuan Li authored
When taking screenshot with RecreateLayers, the animations on layer being recreated will be interrupted. We ignore assistant's layer here to exclude it from screenshot and prevent the animation from being canceled. Bug: b/112604283 Test: Manual Change-Id: Idca40f51954c8aa48d81a8fa54e395cb4028d512 Reviewed-on: https://chromium-review.googlesource.com/1174983 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#583129}
-
Xiaocheng Hu authored
The editing command requires SelectionForParagraphIteration() to figure out the correct paragraph range, which however may fail due to invalid input. This patch makes the command abort so that it doesn't crash the renderer. Bug: 873084 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I86c77903e218ff4b564bce9122315b99896b01ed Reviewed-on: https://chromium-review.googlesource.com/1175244Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#583128}
-
Zach Helfinstein authored
Bug: 873016 Change-Id: Ia69e01e4839d4ae215d8cc97d588cc33abbd17b4 Reviewed-on: https://chromium-review.googlesource.com/1170907 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583127}
-
Adam Langley authored
In CTAP2, a self-attestation is where the credential private key signs over the creation request to show that it's fresh. It's a standard proof-of-ownership to demonstrate that the private agrees to be used in a given context. Without it, it's possible to submit, say, someone else's public key as your own. With this change, self attestations, if generated by the authenticator, won't be erased when no attestation is requested. We might want to revisit this in the future because a self-attestation does indicate that the user used an authenticator that generates them. Currently, only our Touch ID integration does so. In that case, if an RP requests a platform authenticator on a Mac, Touch ID is already a foregone conclusion so that's not actually disclosing anything. We keep the prompt for when the RP requests attestation so that RPs don't get in the habit of requesting it without thinking. In the future, we might have attestation for Touch ID and don't want a sudden flood of prompts because to previously suppressed them. Change-Id: I030d8281ec166c653eed2573eedbb854f5736f91 Reviewed-on: https://chromium-review.googlesource.com/1168392 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583126}
-
Weidong Guo authored
Background: A crash occur when a page break item exists in folder. (Not sure why a page break item gets into folder.) Changes: Remove the page break item from folder if it exists. Bug: 873485 Change-Id: I0cc435ae8d47c056eeec4b04a8afe7f5cc989588 Reviewed-on: https://chromium-review.googlesource.com/1172071 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583125}
-
Xida Chen authored
On a touchscreen desktop, when we open a pdf and scroll it, the GSB and GSE is send to the pdf (guest) view, while the GSU is send to its embedder. In this case, the embedder may not have touch action set which could lead to a crash. This CL fixes the issue by setting the touch action of the embedder to auto in this case. A browser test is added. Bug: 870536 Change-Id: Id3846334510a9bf4a66a365a447f3b4d8de1ddc7 Reviewed-on: https://chromium-review.googlesource.com/1166426 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#583124}
-
Wez authored
Bug: 859095 Change-Id: I6847b8333df122484190513f9b3aa63111c7fdce Reviewed-on: https://chromium-review.googlesource.com/1172084Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#583123}
-
Xi Cheng authored
Bug: 851163 Change-Id: I93d7ea84b7a3b99058a4a619782501aba2e0f21f Reviewed-on: https://chromium-review.googlesource.com/1174976Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#583122}
-
Noel Gordon authored
Speed-up these copy tests by loading the one file needed for the test, and adjust test comments. Test: browser_tests --gtest_filter="*/FilesApp*keyboardCopy*" Bug: 873915 Change-Id: Icbac3f7dd25dfae5b1119f021e5b336a4406ff7a Reviewed-on: https://chromium-review.googlesource.com/1174337Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583121}
-
agrieve authored
Plus re-ordered content a bit. Change-Id: I363ffcb5c2a4cb36afcb980503a12564d9e7199b Reviewed-on: https://chromium-review.googlesource.com/1162112 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#583120}
-
Noel Gordon authored
Bug 873915 notes flakey time-outs on the Mash bots for keyboard delete on Drive tests. Speed-up the delete file tests by loading the one file needed for the test (photos). Make the test delete one file (not two). Minor: fix comments, group the keyboard delete test cases together. Test: browser_tests --gtest_filter="*/FilesApp*keyboardDelete*" Bug: 873915 Change-Id: I2af501ef6b10cbad323991fcdec2f500260ad0d3 Reviewed-on: https://chromium-review.googlesource.com/1174336Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583119}
-
Bailey Forrest authored
Bug: internal b/112359125 Test: cast_bluetooth_unittests. BLE sanity check. Change-Id: Ia0815f0251a276a8b0b01315eb4a1d588b3c7e69 Reviewed-on: https://chromium-review.googlesource.com/1171921 Commit-Queue: Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583118}
-
Clark DuVall authored
These tests were accessing ResourceMessageFilter directly, instead of using the network service path when it is enabled. Bug: 862176, 874227 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3add3b588ad40c3bca265ad68adccca293ddae0d Reviewed-on: https://chromium-review.googlesource.com/1175105Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#583117}
-
Yue Li authored
Link to new mock: https://docs.google.com/presentation/d/1wEy1dkObL9GSVGKNigqNHiqn1m7ciHHLgcdW2oWwXcY/edit#slide=id.g36522ea91d_0_2 Bug: b/78190629 Test: Manual Test Change-Id: Ie8715c8b2c08eeb5a62514457c2fb1487f37c710 Reviewed-on: https://chromium-review.googlesource.com/1171860Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#583116}
-