- 13 Apr, 2018 40 commits
-
-
Jordy Greenblatt authored
Bug: 831798 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id27d20963ae03a92aff7ae6d5e0fb6ab04da0773 Reviewed-on: https://chromium-review.googlesource.com/1008602 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#550753}
-
Kenneth Russell authored
It turns out "mac" and "sierra" in the same expectation means all macOS, not just Sierra. Tbr: kainino@chromium.org Bug: 526748 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I26b9849ba342fd058b5568739034c754ab75c842 Reviewed-on: https://chromium-review.googlesource.com/1012518Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550752}
-
Maggie Chen authored
The previous checkin for "996594:Adding SupportsDX12 and SupportsVulkan to UMA histogram for the Windows platform" did not quit the GPU process after the job is complete. base::RunLoop().QuitCurrentWhenIdleDeprecated() is added to the end of the function of the second GPU process to fix this issue. BUG=832596 TEST=manual,Chrome task manager R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ifadb24d39b24a9a5a6cdc0c33e66bcfc42d5a5a7 Reviewed-on: https://chromium-review.googlesource.com/1012595Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550751}
-
Francois Doray authored
Reordering native views causes multiple changes to the window tree. This CL instantiates a ScopedPauseOcclusionTracking in DesktopNativeWidgetAura to ensure that occlusion is recomputed after the reordering is done rather than after each individual change. Note: It has been discussed that occlusion should be recompute once per frame if the window tree has changed since the last frame, rather than in direct response to window tree changes. That would fix this issue. However, it is a more involved change, so having this simple fix in the meantime is still relevant. https://crbug.com/832645 Bug: 829918, 832645 Change-Id: I043be75b53ee10683f8bd5bdbe298bdbcf54a987 Reviewed-on: https://chromium-review.googlesource.com/1010602Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#550750}
-
John Abd-El-Malek authored
TBR=juncai@chromium.org Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8c3f9956b131c171fc35e5fdb78f5f9ec53e2cd1 Reviewed-on: https://chromium-review.googlesource.com/1012445Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#550749}
-
Garfield Tan authored
BUG=823634 BUG=b/74621390 TEST=Manual tests with WM test app. Exo unit tests pass. Change-Id: I0e0595fc62a50498790fd99144b547a88d1d9ba6 Reviewed-on: https://chromium-review.googlesource.com/996401 Commit-Queue: Garfield Tan <xutan@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550748}
-
Eugene But authored
This view controller will be used as a base view controller for Download Manager presentation. Download Manager must be presented under toolbar view, so using BVC as a base view controller does not work. This CL replaces BrowserContainerView with BrowserContainerViewController which should not cause any functional changes. Bug: 818264 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I93d66906c671a8647589db8d9717ab2dcd26cd51 Reviewed-on: https://chromium-review.googlesource.com/981684Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550747}
-
Min Qin authored
ChildProcessSecurityPolicy can be used on any thread. This CL moves the security policy check to UI thread, so that all the content/ dependencies in BeginResourceDownload() are removed() BUG=803135 Change-Id: I97ecb0788f099d010627599275553ad268404345 Reviewed-on: https://chromium-review.googlesource.com/1008869Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550746}
-
Gabriel Charette authored
It extracts the statically accessible interface of MessageLoop (through MessageLoop::current()) from its core interface. See message_loop_current.h for more details. Note: At first it seemed like the easiest approach would have been to introduce MessageLoopInterface as the public interface which MessageLoop implements (and only return an interface pointer from current()). But that doesn't work once we get in MessageLoopForUI (and ForIO) territory as it would need to both be a MessageLoop (MessageLoop is-a MessageLoopInterface) and a MessageLoopInterfaceForUI (MessageLoopInterfaceForUI is-a MessageLoopInterface) and we have diamond inheritance... This thus enforces the current approach of MessageLoopCurrent being a separate class that merely represents a MessageLoop*. I think this is cleaner overall as well because it will allow must callers to include solely message_loop_current.h and ultimately have very few files including the message_loop.h impl (I'll also move MessageLoop::current() to MessageLoopCurrent::Get() in a follow-up). This CL adds many temporary implicit back-and-forth casts. After landing this, I plan to script migrations of the actual usage to the proper types with the goal of eventually disconnecting the two APIs (so that few callers actually need message_loop.h anymore and it's obvious what a replacement of MessageLoop needs to provide statically and/or what we need to deprecate before making such a move). This CL is a contract with the reviewer that I will follow-up with many TBRed CLs for trivial mass renames. Even though the implicit casts might not seem like this CL does much overall, it still required 25 precursor CLs (ref. crbug.com/825327) and landing this CL locks in those gains. Removed the two TestWatchingFromBadThread tests which are irrelevant now that going through MessageLoopForIOCurrent enforces usage on same thread via a ThreadChecker. NOPRESUBMIT=True (calls to deprecated MessageLoop methods) Bug: 825327 Change-Id: Ie66a394d02a162289aabe155436a583bfb024e8d Reviewed-on: https://chromium-review.googlesource.com/957760 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550745}
-
Bo Liu authored
Add a kill method to ChildProcessConnection to force kill the service. Also add a new field that keeps track of whether the process is killed intentionally. Add a junit test to verify this. Bug: 693484 Change-Id: Iaae9e82e611be97b9694fc8d67b23ba090220840 Reviewed-on: https://chromium-review.googlesource.com/1003635Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550744}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5d17629393d..c23684514c93 $ git log b5d176293..c23684514 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ihf Revert "chromeos_config: add bettyvirgl builder." Created with: roll-dep src/third_party/chromite BUG=chromium:807873 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic52798de6b856ce362f5d1ed42b0eef29e79395a Reviewed-on: https://chromium-review.googlesource.com/1012598 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550743}
-
Dominic Mazzoni authored
In r535735 we made WebView responsible for showing an overlay (like a sad tab) when the WebContents has crashed. When the overlay was showing we hid the NativeViewHost to be safe (using SetVisible(false)). This had the unintended consequence of closing modal dialogs such as a cookie dialog or dangerous download warning dialog. In testing, it seems safe to not actually hide |holder_|, the NativeViewHost. The overlay is absolute-positioned on top of it, and it's not possible to focus the WebContents. This was more or less true in the previous Sad Tab implementation where it was displayed in a Widget on top of the WebView instead of as a child View. Bug: 826248, 821312 Change-Id: I748afeff1ac8d7e1fa18ccafe709706f803ae6cc Reviewed-on: https://chromium-review.googlesource.com/1008621Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#550742}
-
Varun Khaneja authored
Change-Id: I459baac99f1b4d94e8f1b96ddfd3c66a561a80db Bug: 817377 Change-Id: I459baac99f1b4d94e8f1b96ddfd3c66a561a80db Reviewed-on: https://chromium-review.googlesource.com/998190Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550741}
-
xlai authored
DrawingBuffer::TransferToStaticBitmapImage() is the common function shared by commit() and transferToImageBitmap() in OffscreenCanvas WebGL, as well as the VR display frame submission. The two OffscreenCanvas APIs miss a release callback; as a result, release_callback populated by image extraction function PrepareTransferableResourceInternal is invoked very early with a "lost resource" signal. On the other hand, VR display frame submission has correctly implemented a release callback that is releasing previous frame whenever there is a new frame coming in. This is a very likely reason to contribute to the flakiness of these two OffscreenCanvas APIs, while the VR display is working well. This CL adds a release callback to OffscreenCanvas commit(). I will follow-up with another CL that adds release callback to OffscreenCanvas transferToImageBitmap() and another CL that enables the relevant gpu pixel tests. Bug: 809227, 735228 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia6e2c613de416f1e6e2a0f1c833d9e82e47fed4f Reviewed-on: https://chromium-review.googlesource.com/1010466Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/c6c5eade823a..21dfd846724a $ git log c6c5eade8..21dfd8467 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit) 2018-04-12 liyuqian Limit our IsBadForDAA for stroke width > 0 and <= 2 2018-04-12 csmartdalton ccpr: Actually blacklist ANGLE 2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits) 2018-04-12 reed can't abort looper loop, as saveCount won't be balanced 2018-04-12 egdaniel Don't create lazy proxys if their width/height is greater than max tex size 2018-04-12 robertphillips Actually generate the gm images on the DDL1 bot 2018-04-12 caryclark son of path is rect bug 2018-04-12 ethannicholas workaround for buggy macOS GLSL shader compiler 2018-04-12 egdaniel Delete getRenderTargetHandle call on SkSurface. 2018-04-12 reed check for non-finite values output by clipper 2018-04-12 brianosman Fail fast when trying to make a texture that's too large 2018-04-12 djsollen Include shadow ops in the debugger. 2018-04-11 liyuqian Reland "Add private fIsBadForDAA bit to SkPath" 2018-04-12 reed add conservative bounds to raster tiling 2018-04-12 reed always clear the looper when we're unrolling it, to not confused devices 2018-04-11 robertphillips Disable CCPR and the small path renderer on DDL1 bot 2018-04-12 caryclark another rect is path fix 2018-04-11 robertphillips Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS 2018-04-11 csmartdalton Implement Sk2f Load2 2018-04-11 csmartdalton ccpr: Blacklist ANGLE again 2018-04-11 robertphillips Allow SkImage_Gpu to fail some requests in DDL mode 2018-04-11 cwallez update_meta_config: Use new LUCI optional GPU trybot on Windows 2018-04-11 csmartdalton Implement Sk4f min/max 2018-04-11 liyuqian Remove obsolete comment 2018-04-11 benjaminwagner Upgrade PixelC and NexusPlayer OS. 2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits) 2018-04-11 caryclark fix bm gm 2018-04-12 mtklein skcms→1654786 concat gamut transform matrices together Created with: roll-dep src/third_party/skia BUG=chromium:824145,chromium:821353,chromium:818693,chromium:820245,chromium:820470,chromium:824145,chromium:815092 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ic83a9e3addd0c3593736a5bd03a4b4b2d37b7c51 Reviewed-on: https://chromium-review.googlesource.com/1011738Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#550739}
-
Eugene But authored
At this point almost all callbacks were removed from CRWWebDelegate and the only remaining callbacks are related to Native Content size (moved in this CL) and external app launching (will be moved to PolicyDecider). CRWNativeContentProvider is still heavily used for features like NTP, Old Download Manager, Error Pages, Reading List. It will take more time to get rid of Native Content Provider, so size callbacks can temporary live there. Bug: 674991 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia5c6d565a116c858f3fe5fefa4964364144a8279 Reviewed-on: https://chromium-review.googlesource.com/1010822Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550738}
-
Nico Weber authored
deqp used to not build with clang, but nowadays it does. We wanted to wait with the switch until we can pin clang on the deqp bots to an older clang if necessary, but we already don't do that on mac and linux, so this doesn't make things any worse, and it removes one blocker for the msvc bot turndown and makes the deqp bots run tests with the compiler that we use for building shipping chromium. Bug: 727437, 786460 Change-Id: I3bd76f7e2939e33b28262ca509259b37e8bbe582 Reviewed-on: https://chromium-review.googlesource.com/1012740Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550737}
-
Eugene But authored
NSURLSessionTask crashes if download is started for data:// URLs. Creating download task only for HTTP/HTTPS urls is a reasonable limitation, and there is no need to show UI for unsupported downloads. Bug: 832248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifec5e3ef1d4e4d76f78c5e310c2ca018e288e8bc Reviewed-on: https://chromium-review.googlesource.com/1011232Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550736}
-
Avi Drissman authored
BUG=832842 TBR=hbos@chromium.org NOTRY=true Change-Id: I5329fc3c5b0c1e1d330471ceab8edf66ce24dbad Reviewed-on: https://chromium-review.googlesource.com/1012454 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550735}
-
Greg Thompson authored
The test harness drives an UpgradeDetectorImpl by calling its UpgradeDetected method. In a normal instance, this method is called by tasks scheduled on detect_upgrade_timer_, which is only started after the instance has determined whether or not updates are enabled. Since the test harness was not waiting for this determination to complete, it was racing with this task. The fix is to disable the update enablement check in the test so that there's no race. BUG=832057 Change-Id: Ie8b69a59e7de29aa7da37fe1edba5d324dbed450 Reviewed-on: https://chromium-review.googlesource.com/1012041 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
Normally when a button is clicked we assume the mouse is still hovering over it, so we go back to the hovered state and wait for the mouse exit event. However, when the minimize button minimizes the window Windows gives us the mouse exit event before the mouse up event, so the button will get stuck in the hovered state. This patch fixes this by resetting the button state when it receives a window control action, the same way the opaque frame currently solves this problem. Bug: 828591 Change-Id: I6e3f27b8f92bcbf3fb8171555702b8cf5326ba21 Reviewed-on: https://chromium-review.googlesource.com/1006373Reviewed-by:
-
Saman Sami authored
I would like to be able to send a shared memory handle + SkImageInfo and construct an SkBitmap on the receiver's side. TBR=reed@google.com Bug: 831744 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: If8be0cd2d876100f2430aed6195263cfcc415213 Reviewed-on: https://chromium-review.googlesource.com/1007767 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#550732}
-
Eugene But authored
DownloadManagerTabHelper does not work without delegate, so make sure that DownloadManagerCoordinator is created before DownloadManagerTabHelper. Previously DownloadManagerCoordinator was created in viewDidLoad which is called after all Tab Helpers are attached to the restored tabs. Bug: 832210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5bcbec42b0723007aef4d8a25a065cb30238484 Reviewed-on: https://chromium-review.googlesource.com/1011182Reviewed-by:
-
Ahmed Fakhry authored
When browser actions are dragged and dropped inside the menu, they used to use the menu's widget theme provider which is of type ui::DefaultThemeProvider. Instead, it should use the browser's frame theme provider, so it can get the correct color. BUG=831510 Change-Id: If7f46e38e44bbfee04b6f67e8377b7d8dd3d9d7f Reviewed-on: https://chromium-review.googlesource.com/1011374Reviewed-by:
-
Jialiu Lin authored
We've launched softer warning to 100%, now it's time to remove the set of scary strings we're not using. Bug: 831244 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6c37435055154091dc91dcfc096d1295a5091572 Reviewed-on: https://chromium-review.googlesource.com/1010420Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#550729}
-
Avi Drissman authored
This reverts commit c9d9f5f1. Reason for revert: Test failures: EnableDisableSingleClientTest.DisableOneAtATime EnableDisableSingleClientTest.EnableOneAtATime SingleClientAppsSyncTest.InstallSomeApps SingleClientAppsSyncTest.InstallSomeLegacyApps SingleClientAppsSyncTest.InstallSomePlatformApps SingleClientAppsSyncTest.StartWithNoApps SingleClientAppsSyncTest.StartWithSomeLegacyApps SingleClientAppsSyncTest.StartWithSomePlatformApps SingleClientBookmarksSyncTest.BookmarkAllNodesRemovedEvent SingleClientBookmarksSyncTest.DeleteFaviconFromSync SingleClientBookmarksSyncTest.DownloadBookmarkFolder SingleClientBookmarksSyncTest.DownloadDeletedBookmark SingleClientBookmarksSyncTest.DownloadModifiedBookmark SingleClientBookmarksSyncTest.InjectedBookmark SingleClientBookmarksSyncTest.Sanity SingleClientBookmarksSyncTest.SetFaviconHiDPIDifferentCodec SingleClientDictionarySyncTest.Sanity SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted SingleClientDirectorySyncTest.StopThenDisableDeletesDirectory SingleClientExtensionsSyncTest.InstallSomeExtensions SingleClientExtensionsSyncTest.StartWithNoExtensions SingleClientExtensionsSyncTest.StartWithSomeExtensions SingleClientExtensionsSyncTest.UninstallWinsConflicts SingleClientPasswordsSyncTest.Sanity SingleClientPreferencesSyncTest.Sanity SingleClientSearchEnginesSyncTest.Sanity SingleClientSessionsSyncTest.NoSessions SingleClientSessionsSyncTest.Sanity on https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20(1)/79083 https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20(1)/37046 https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/22395 Original change's description: > Keep poll intervals in prefs. > > Without persisting them, server-side provided intervals are less efficient on > platforms with relatively short app lifetime. > > This also allows lower poll intervals for latency-sensitive use cases in cases > when our notifications are not reliable enough (yet). > > Bug: 832019 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I69abdc89273dd16301fb32f3a0df6ba51712adf3 > Reviewed-on: https://chromium-review.googlesource.com/1010662 > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550668} TBR=treib@chromium.org,tschumann@chromium.org Change-Id: I015df172b8f0503553c5bbd9df5efaa97840fd64 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832019 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1012818Reviewed-by:
-
Aleks Totic authored
Inline outlines are painted by containing block. Containing block's SelfVisualRect did not include outline rects. The fix: - Refactors inline outline computation into NGOutlineUtils, so it can be shared between paint and layout. - Computes inline outline rects in NGPhysicalBoxFragment constructor. - Propagates outline to Legacy in LayoutNGMixin::AddOverflowFromChildren - Because overflow is flipped blocks, corrects some calls to AddOverflow Lots of work to correct a single failing test. Bug: 728378 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I252515113c8fb4e81dd59f377f4be00471596000 Reviewed-on: https://chromium-review.googlesource.com/1011828 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#550727}
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I13af30a066f8ada04b06cc34143cce6c6292f5a9 Reviewed-on: https://chromium-review.googlesource.com/1012590Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550726}
-
Tien-Ren Chen authored
PaintLayerClipper returns a counter-scrolled rect when kIgnoreOverflowClipAndScroll is specified. Before this CL the counter-scroll was not applied if the scroller is not manually scrollable, e.g. overflow:hidden with a scroll offset. BUG=825033 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I05ad28a584911143e45204c751f679592ab03e19 Reviewed-on: https://chromium-review.googlesource.com/1011214Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550725}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/54a81e45ddfc..58330b0db43d $ git log 54a81e45d..58330b0db --date=short --no-merges --format='%ad %ae %s' 2018-04-06 ehmaldonado roll-dep: Use gclient_eval.GetRevision to get current revision. Created with: roll-dep src/third_party/depot_tools BUG=chromium:760633 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Icab9883fd549a3383689c198168a5d196ab1c855 Reviewed-on: https://chromium-review.googlesource.com/1012342Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550724}
-
Avi Drissman authored
This was broken for a very long time and the initializers regressed. There was a tool to update the perf_expectations.json file, but it is either broken or has zero documentation. The perf team disavows it. This is unmaintained, so I'm manually hacking this file to get it to a state in which it works. BUG=831951, 832854 NOTRY=true NOPRESUBMIT=true TBR=thakis@chromium.org Change-Id: Idf1bd61d40540d0b85497e6669297fb54c2c2a28 Reviewed-on: https://chromium-review.googlesource.com/1012743 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
- Add CastDialogSinkButton, which will be used for sink list items in the Harmony Cast dialog. It's a subclass of HoverButton that shows a device icon and an optional status indicator (checkmark or throbber). - Add UIMediaSink, a struct containing data used to populate the button - Add Skia icons used by the button: Cast for EDU, input, speaker, speaker group, and TV Screenshot of the button (two of them) in a WIP dialog: https://drive.google.com/file/d/1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf/view?usp=sharing Dimensions and colors are subject to change in later CLs. Bug: 826089, 826393 Change-Id: I0eef58e1c0b9bf2cff3b3d146e911d3a18c7d23c Reviewed-on: https://chromium-review.googlesource.com/996458 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#550722}
-
Avi Drissman authored
This reverts commit 0ade0386. Reason for revert: Unexpected Failures: * bindings/sequence-type.html * custom-elements/spec/define-element.html * external/wpt/custom-elements/CustomElementRegistry.html on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/ https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/ Speculatively reverting this to see if it's the cause. Original change's description: > Web Animations: Fix bugs in procedure to process a keyframes argument > > There were three minor bugs left in the implementation: > > - We threw on lists-in-custom-iterators instead of just ignoring them. > - We returned all properties on the keyframe rather than just those > defined on the keyframe itself (e.g. we would include prototype > properties, against spec). > - We didn't access the properties in ascending unicode order. > > Bug: 827573 > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > Reviewed-on: https://chromium-review.googlesource.com/989261 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550641} TBR=flackr@chromium.org,yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,smcgruer@chromium.org Change-Id: I5e8dc0c67599492bd6e90fca4a034e29e334ef88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827573 Reviewed-on: https://chromium-review.googlesource.com/1012857Reviewed-by:
-
Matt Menke authored
The method has some safe-for-display safety checks that assume the input is UTF-8 / output is UTF-8. This change makes it at least a little harder to avoid those checks, and makes output no longer vary based on whether passing in a std::string or a string16 (By removing the latter option entirely). Bug: 831321 Change-Id: Ib39a2cccd71861213341e92932525e8ecafc60cd Reviewed-on: https://chromium-review.googlesource.com/1004855Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#550720}
-
Ryan Hansberry authored
Breaks up the UNKNOWN_ERROR enum into 3 enums: 1) UNKNOWN_ERROR, which precisely captures when the host returns an UNKNOWN_ERROR response code. 2) NO_RESPONSE, which captures when the client never received a response at all. This likely indicates a Bluetooth error. 3) INVALID_HOTSPOT_CREDENTIALS, which captures when the host returns a SUCCESS response, but with invalid SSID or password info. Bug: 785514 Change-Id: I0d40283d8b458dd45a1d490fb53eb075e2eb05e4 Reviewed-on: https://chromium-review.googlesource.com/1011595 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#550719}
-
Devlin Cronin authored
There was a bug where if the ID were passed as null or undefined (rather than completely omitted), the message would fail to parse. Fix this, and add a unittest. Bug: 828664 Change-Id: I92b0f071a1627322e12e8eaf0f5787ccd0793138 Reviewed-on: https://chromium-review.googlesource.com/1012601Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550718}
-
Dale Curtis authored
Use WillRepeatedly() instead of WillOnce(). BUG=831566 TBR=chcunningham Change-Id: I2cebaebcfa5ff026c43d3c4a267f5d3653e91dae Reviewed-on: https://chromium-review.googlesource.com/1012699Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550717}
-
Dave Tapuska authored
Adjust ToggleFullscreen IPC to be two IPCs (Enter/Exit). Pass the options on the Enter IPC. This change is only plumbing necessary to get the options up to the content layer. A follow-on CL will be created that will modify the implementation of fullscreen on Android and plumbing at the WebContents layer. BUG=829937 Change-Id: I76ff73b6435bc6ae2ead57f06a98557a4961258d Reviewed-on: https://chromium-review.googlesource.com/999831 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#550716}
-
Paul Irish authored
Change-Id: If64e6f5fc245da7d9bbb8d3925d004b545338b0a Reviewed-on: https://chromium-review.googlesource.com/993477 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550715}
-
Eric Stevenson authored
This CL adds the --step flag to make debugging large rolls more efficient. Also adds the --apply-patch flag to give users the ability to apply local patches before performing each build (not compatible with --cloud). Note that this doesn't work for patches to supersize; we copy supersize to a temp dir before modifying local state. Side note: using diagnose_bloat.py with CLs before and after the blink rename require "git config merge.renamelimit 20000". Bug: 831601 Change-Id: Ida5d0a879355e48c942dab07afd5489c36bca1ca Reviewed-on: https://chromium-review.googlesource.com/1011681Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550714}
-
