- 02 Oct, 2019 40 commits
-
-
Moe Ahmadi authored
Bug: 996516 Change-Id: Ie7a6048d5095a2b62db8b599626f2dc88c9a986d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825488 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#701877}
-
Eric Stevenson authored
New invalid references have been added (5 in about 2 months). Bug: 956839 Change-Id: I2c82dcbb461f048b2743fb266a2deaf26505cbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834265 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#701876}
-
Ryan Daum authored
* Adds new navigation decision calls in RPC. * When the setting has_navigation_delegate is true, uses a NavigationThrottle to defer navigation until a decision has been made over RPC. Bug: b/141853741 Test: manual Change-Id: Idefea26dbabe39d4afe8ae2a5c61349b483ed646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833790Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#701875}
-
Gabriel Charette authored
In an effort to help diagnose run timeouts. e.g.: https://bugs.chromium.org/p/chromium/issues/detail?id=1010061#c14 R=wez@chromium.org Bug: 1010061 Change-Id: I3c2a3d1898be58eaea9167d3202e5aa9dbf4deca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834743 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#701874}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/40b3bbb9073b..9cdcaeee872d git log 40b3bbb9073b..9cdcaeee872d --date=short --no-merges --format='%ad %ae %s' 2019-10-02 seanabraham@chromium.org OWNERS: update owners Created with: gclient setdep -r src/third_party/chromite@9cdcaeee872d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icb580ddb2df3490ffdb2603602a4269b4a8c7159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701873}
-
David Staessens authored
This CL adds functionality to the new video_decode_accelerator_tests to write frames that fail frame validation to disk. The "--output_frames" parameter now takes "all" and "corrupt" as possible values. If "corrupt" is specified the number of frames written to disk is limited to 3 by default, to avoid generating to may artifacts in Tast tests. TEST=ran new VDA tests on eve BUG=962354 Change-Id: Iad086c099d486e05b343d6fe6550807007ef1c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609025 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701872}
-
Maggie Cai authored
This CL moves the components/arc/ glob match function to components/services/app_service/, and uses it in App Service intent matching. The usage in the components/arc/ should be deprecated when we connect all intent handling logic to the App Service. Will add unit tests for glob match in a follow up CL. BUG=853604 Change-Id: I7ac743726dbcf69aa68efa729cd8c9107535446d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828780 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#701871}
-
John Lee authored
(Screen capture in bug.) Bug: 1010349 Change-Id: I3fdc0df29dcc03b3b95b003c6d991416e538d650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834861 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#701870}
-
John Lee authored
Bug: 1004981 Change-Id: I33a60faf2b647cb72bc25c453c76687471882a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834645Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#701869}
-
Takuto Ikuta authored
TBR=ioanap@chromium.org, fhorschig@chromium.org Bug: 1010344 Change-Id: I30adb961bea4f85c87899bd4ac09b63a0fb1d053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834802Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#701868}
-
Alex Gough authored
Modifies sandbox api and service manager to use heap-safe types and adds process id as example. Only virtual base classes can be returned by chrome.exe for destruction in chrome.dll. Accordingly, such classes are now returned when snapshoting policies. Policy snapshots are exported as Json strings, making transition to alternative sandbox apis easier in the future, and making careful memory management necessary in only one location. In particular:- sandbox::PolicyInfo is now a virtual base class. sandbox::PolicyDiagnostic concretely snapshots policies. sandbox::PolicyList is a new virtual base class (was a using alias) which delegates to std::vector. sandbox::PolicyDiagnosticList concretely collects snapshots. This will be consumed by the chrome://sandbox webui. This is tested in the following CL (and existing unittests). Bug: 997273 Change-Id: If186785880766821514312e292e1c1aced48272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815903 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#701867}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b3ced8d6..11c0f9d0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3d9704b2e79f7f66632d16ef2c2a20f615ddc807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833569Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701866}
-
John Williams authored
This change is needed to support desktop mirroring. Bug: 972751 Change-Id: I41db2ed4a053d4f9c620dcb02fb56cdc9a3c365a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771055 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701865}
-
Tetsui Ohkubo authored
This is a reland of 10fa9630 Change from the original CL: Do not move up a window on Chrome side unless it's a notification Original change's description: > Implement ArcImeService::EnsureCaretNotInRect. > > It's left as unimplemented because Android WM handles insets by VK for > most cases. > However, Android WM can't move the SystemTray up for inline-reply in an > Android notification because from Android WM's point of view, > notificaiton is placed at (0, 0). > This CL implements ArcImeService::EnsureCaretNotInRect to cover that > case. > This CL changes the behavior of windowed Android app with a11y keyboard. > Before this CL, a position of a window is not changed by a11y keyboard > visibility, but after this CL a position can be changed not to be > covered by a11y keyboard. > > SystemTray moves up if there is a space for it. > > Bug: b/114115612 > Test: manual - Focus on inline reply of an Android notificatioln and > Change-Id: Ib666b6c269a8fc36195d30affa4c7a8a805560d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631859 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664583} Bug: b/114115612 Test: manual - Open an Android notification with inline reply Test: manual - Confirm http://b/138674508 does not reproduce with ARC Change-Id: I589533a0d0ea6a89de7394279a461b8417eabe9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828676Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#701864}
-
Maxim Novikov authored
* "OnPushBufferComplete()" can be called after the playback has been already stopped ("Stop()" method was called). In that case "push_in_progress_" will be "false" and it is an expected scenario, so there is no reason to fail in "OnPushBufferComplete()" in that case. Bug: internal b/141580218 Test: Tested with Android 10 that was crashing without this change Change-Id: I25b018f5fae37d2b9d3fe38e208d34ab66d87d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834824Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Maxim Novikov <csbubbles@chromium.org> Cr-Commit-Position: refs/heads/master@{#701863}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0ba4163ae14..1784cda8d57a Created with: gclient setdep -r src-internal@1784cda8d57a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8ed8d203db8d8919f569ba6c7a6f1cfdc92fdb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701862}
-
Dominic Farolino authored
This CL re-enables a recently-disabled DownloadReferrerPolicy test. The test was disabled due to flakiness, but as we resolved on the bug thread, this caused by a separate known issue with leveldb crbug.com/978680. R=yhirano@chromium.org Bug: 1009022 Change-Id: Iea6216003058168cac8715b0d42d73afb973bf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832695Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701861}
-
Andrew Xu authored
In ShelfContainerView::Layout, |shelf_view_|'s bounds are set to be its preferred size, a.k.a ShelfView::GetPreferredSize. However, during the calculation of the preferred size, the app icon's bounds are used and they may be updated by animation. As a result, when change the alignment, the app icon's bounds are not updated yet. It is the reason why the shelf view's size after alignment change is always 56x56. This CL fixes the issue by calculating the preferred size manually. Bug: 1009334 Change-Id: Ifd09fa8b595cfff581133dd38cb34d0abaaf43ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833080Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701860}
-
Miyoung Shin authored
This change converts SpeechRecognizer mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ia8d04a54cf75c92223824f1423e5a24947313c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828764 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#701859}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b9aca9494e40..5eac9d301390 git log b9aca9494e40..5eac9d301390 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 ehmaldonado@chromium.org depot_tools: Fix bug when running download_from_google on Python 3. 2019-10-01 ehmaldonado@google.com depot_tools: Fix gclient_test on Windows. Created with: gclient setdep -r src/third_party/depot_tools@5eac9d301390 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009698,chromium:1007580 Change-Id: I36eca6b7012dec1992f918f7d4bae5bda382cd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701858}
-
Changwan Ryu authored
1) Add all child layouts to the root layout such that we can remove a child layout without affecting any grand child layout. 2) Allow a child webview to create yet another child with extended WebChromeClient. 3) Add and remove child layout programmatically by adding a bidirectional map between layout and webview such that onCreateWindow() can add a child layout to the parent layout, and closing a layout can destroy the webview. 4) Also, add a test to verify depth = 3 case. Bug: 994939 Change-Id: Icddf54e10c643b41f8f5f2b676744232e7fb29ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828097 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701857}
-
Matt Mueller authored
net: Extract the EncodeTimeAsGeneralizedTime from TryBuildPath into CertVerifyProcBuiltin::VerifyInternal No need to repeat this for each path, the value doesn't change. Bug: 1008994 Change-Id: Ifcc769bdc8a05ae95dd37fc96d72df6de672aade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829242Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#701856}
-
dpapad authored
Specifically removing animationFrame(), contentElement() and testAsync(). These must have been leftovers from a previous refactor, since a copy of these methods exists in annotations_feature_enabled_test.js. Bug: 1005029 Change-Id: I32881c15e3cc3a269fcec53f5f0d6b8e4a31449b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833070 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701855}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/616a4dc0f2fb..f22f16d3c0a8 git log 616a4dc0f2fb..f22f16d3c0a8 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 tobine@google.com Reland "Vulkan: Use VK repos' internal BUILD.gn files" 2019-10-01 timvp@google.com Vulkan: Enable dEQP-GLES31.functional.shaders.* Created with: gclient setdep -r src/third_party/angle@f22f16d3c0a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I90ce92d375fcc6bed3eac0672e51ac7dd7ba2db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834761Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701854}
-
Jeremie Boulic authored
Before this change, removable partitions were always seen as directories. As a result: - the type used to sort each partition is 'folder', instead of their actual file system type (i.e. ntfs, ext4 etc...) - when rendering the types of removable partitions in the file list, the renderType function calls FileType.getType, gets returned 'folder', checks separately whether the entry to render is a removable partition, retrieves and overrides 'folder' with the actual file system type. FileType.getType now returns a special type for removable partitions. In file_list_model.js, compareType_ is not modified, but it now compares, for removable partitions, their file system type. Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayUsbPartitionSort Bug: 973743 Change-Id: I2a5090c7b0f039c4be0b3ea6d223f05be5a75ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828669 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#701853}
-
Tom Anderson authored
See the section titled "Convert YUV to RGB in parallel" of the 8K document [1] for performance measurements. [1] https://docs.google.com/document/d/1kE5zs4oId4C2k9CQHUJ1UtetGgTqctoX0wLr10e7Th8/edit?usp=sharing BUG=1001207 R=dalecurtis Change-Id: Id2225f4507a5772e4d2f3f2bd27ee0b047e0a8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824132 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#701852}
-
Jinsuk Kim authored
The API can be better in RenderFrameHost which actually can handle the request. This CL moves the API and updates its single call site. Bug: 925242, 995903 Change-Id: I7bf5df33371c0588261d80e17ea488b4cb471a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831658Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701851}
-
rbpotter authored
Mac 10.9 is no longer supported, so try re-enabling this test, since it was disabled for flakes that only happened on this platform. Bug: 771099 Change-Id: I84b1d03da50099d7d22e8020f3943e26aaa3f268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833794Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701850}
-
Roger Tawa authored
Bug: 1008511 Change-Id: Ifb0660347805854bc7c3fb71f81b8c4d267193d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829782 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#701849}
-
Brandon Wylie authored
Bug: 1006139 Change-Id: I50741f80d4c40290caef9e1814e26f5a409d4b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829983 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#701848}
-
Ilia Samsonov authored
This can cause following tests in the same batch to crash. Bug: 1006412 Change-Id: I6ac3dce5dadc50aee74f5dcfcbef30730dbb422c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817155Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#701847}
-
Steve Kobes authored
Bug: 581518 Change-Id: Ibd6a02dadcc9d90d26d20fb827d2c5bdfb52b3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831948Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#701846}
-
Jinsuk Kim authored
This CL fixes a lint warning IconXmlAndPng. The lint, when building monochrome_apk, stops complaining if the XML resource is located in a version-specific directory which is not visible to it. Verified on K/M/Q that the change has the same effect as before. Bug: 993506 Change-Id: I86d7bb44c96d8f5a98136f11a4d72eff18fbfbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833003Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701845}
-
Jay Harris authored
Previously, it only supported file extensions. This CL updates it to be generic across mimetypes and extensions, and renames it to web_app_file_handler_registration in the process. This is to reduce code duplication when implementing file handler registration on Linux. Bug: 829689 Change-Id: Ie4740915fe799ee8c48d3823d43ff556407a72f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833015Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#701844}
-
Eric Lawrence authored
The chrome://conflicts page was not correctly showing the product version in the Version column. The root cause was that the accessor was incorrectly reading the |basename| instead of the |version|. Bug: 996766 Change-Id: I158ca52ff201ebb0c67856ae806c9cff2712c840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832530Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#701843}
-
Xiaohui Chen authored
This is a reland of c7eaa31e Original change's description: > assistant: deprecate |enable_cros_assistant| gn arg > > It's been default equivalent to |is_chromeos| for a few > milestones already. And there is no plan to split it out > from ChromeOS. Remove the flag to clean things up. > > Bug: b/136564463 > Test: locally build and run > Change-Id: I57b20ae88b47e062dc457c0f857452d4e04bfd59 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829750 > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701672} TBR=xiyuan@chromium.org,blundell@chromium.org,xiaohuic@chromium.org,wutao@chromium.org Bug: b/136564463 Change-Id: Ie8c38c4a3fd615afea3ec3d27422bb06b0e6c8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832719Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#701842}
-
Jinsuk Kim authored
This is a speculative fix for the report bugs on navigation sheet UI working wrong, which is hard to repro locally. NavigationSheet view is based on ListView that might not be guaranteed to work when reused. This CL creates a new ListView for displaying the navigation history entry list for each request. Bug: 1007049, 1009059 Change-Id: Ibc0a65095e1c3f6b2cf06eede0db915755842053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831620Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701841}
-
Ken Rockot authored
These were recently broken due to https://crrev.com/f58dc6a1 creating a new SequenceTaskRunner for every new instance of SessionStorageContextMojo. Some of the tests rely on sequencing between the destruction of one context and the creation of another. This plumbs a SequencedTaskRunner argument into SessionStorageContextMojo construction so that tests can provide a stable one across contexts. Also re-enable the tests that were broken by this. Bug: 1006416 Change-Id: I81d6eb67a9d0b978c922f912c895bae8a6e4a75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832737Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#701840}
-
Dale Curtis authored
We're piling up too many frames on the remote side, so throttle based on if we're waiting for an ack or not like we do for OnBeginFrame(). As an added sanity check we also won't submit the same frame twice. We weren't doing this for SubmitSingleFrame() and it appears that sometimes the WebRTC path can get into a state where both OnBeginFrame and DidReceiveFrame() are being called for every single frame... which seems like a bug in and of itself, so more to follow there. Bug: 1010322, b/141542246 Test: Updated unittests, original white flash issue still gone. Change-Id: Ia319303701ecec79b68613de853cd9c918b73b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832668 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701839}
-
Jinsuk Kim authored
Navigation popup bottom sheet doesn't stay after the longpress on back button to trigger is released. This is reported to happen on N. Extended the check to include N (in addition to K/M/L) to fix the bug. Back button longpress action in general does not depend on its keyup event to do something, so this will be safe. Bug: 1009387 Change-Id: I5afc95755288305a9630ad5310dbc84d78a0a948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833001Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701838}
-