GitLab

This should move the implementation of StdStringCanonOutput from the
header to the source file, that should please the chromium-style clang
plugin.

BUG=287029
TEST=url_unittests
R=thakis@chromium.org,abarth@chromium.org
TBR=abarth

Review URL: https://codereview.chromium.org/84673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238392 0039d316-1c4b-4281-b951-d872f2087c98

Clean up the huge switch of accelerators as well:
* Move a bunch of code into Handle helpers.
* Alphabetize the anon namespace helpers.
* Clean up the OS_CHROMEOS groupings a bit.

BUG=321695
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/78763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238391 0039d316-1c4b-4281-b951-d872f2087c98

It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.

To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.

base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:

sed -E -i '' \
    -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
    -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
    -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
    $(git grep -El 'HANDLE_EINTR.*close')

sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
    $(grep -EL '(HANDLE|IGNORE)_EINTR' \
        $(git grep -El '#include.*eintr_wrapper\.h"'))

BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS

Review URL: https://codereview.chromium.org/100253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98

Core code in the Autofill component now gets the AutofillWebDataService from
the embedder. This CL eliminates the declaration of the static
AutofillWebDataService::FromBrowserContext() from the Autofill component's core
code, instead having the concept of getting an AutofillWebDataService from a
BrowserContext/Profile be entirely an embedder-level concept.

BUG=303048

Review URL: https://codereview.chromium.org/72613006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238389 0039d316-1c4b-4281-b951-d872f2087c98

UpdateResource can do the same thing.

BUG=None
TEST=build

Review URL: https://codereview.chromium.org/100903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316397

Review URL: https://codereview.chromium.org/99393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238386 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238385 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/100473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298036

Review URL: https://codereview.chromium.org/99853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238383 0039d316-1c4b-4281-b951-d872f2087c98

Wire up fallback from Compositor::CreateOutputSurface to
ContextFactory::CreateOutputSurface, so that we force using
the software compositor after failing to create a GL context
enough times.

BUG=319267

Review URL: https://codereview.chromium.org/93593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238382 0039d316-1c4b-4281-b951-d872f2087c98

The ComponentCloudPolicyService is created whenever a user signs in, but isn't
cleared when the user signs out; signing out and back in leads to this crash:

[2774:2774:1126/144024:FATAL:cloud_policy_manager.cc(111)] Check failed: !component_policy_service_.
[0x7f9aa98bba3c] policy::CloudPolicyManager::CreateComponentCloudPolicyService()
[0x7f9aa9518eaf] policy::UserCloudPolicyManager::Connect()
[0x7f9aa951a321] policy::UserPolicySigninService::InitializeUserCloudPolicyManager()
[0x7f9aa951a2af] policy::UserPolicySigninService::OnRefreshTokenAvailable()
[0x7f9aaab639d9] OAuth2TokenService::FireRefreshTokenAvailable()
[0x7f9aa91dbfc9] ProfileOAuth2TokenService::UpdateCredentials()
[0x7f9aa8c9647b] SigninManager::CompletePendingSignin()
[0x7f9aaa2d4b5f] OneClickSigninSyncStarter::ConfirmAndSignin()

BUG=None

Review URL: https://codereview.chromium.org/98433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238381 0039d316-1c4b-4281-b951-d872f2087c98

So we should skip them when disable_nacl=1.

BUG=325019

Review URL: https://codereview.chromium.org/101213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238380 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238379 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/101333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238378 0039d316-1c4b-4281-b951-d872f2087c98

Popup menu item with attributes (<optgroup> for instance) will
break typeahead matching support on Mac. Use the same trick Apple
uses in WebKit2 [1] to fix this.

BUG=90064

[1] http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm#L90

Review URL: https://codereview.chromium.org/99043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238377 0039d316-1c4b-4281-b951-d872f2087c98

Since the very long long ago when we have moved file manager out of tabs
to a separate app window, it didn't have any tab_id associated,
and the existing code always assigned an invalid value (-1).

This CL removes the useless code. Since the field is defined to
be optional, it doesn't change the interface of the API.

BUG=312519

Review URL: https://codereview.chromium.org/101323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62154
TBR=pkasting@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/101293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271176

Review URL: https://codereview.chromium.org/57863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238374 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165
TEST=unit_tests --gtest_filter=ConflictResolverTest.*

Review URL: https://codereview.chromium.org/101283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238373 0039d316-1c4b-4281-b951-d872f2087c98

All new symbols need to be in an .order file on Mac but because libaddressinput
is built statically it doesn't need to export symbols at all, so remove this
from its gyp file.

R=rouslan@chromium.org
BUG=317837
TEST=mac compiles when we actually start using libaddressinput in chrome

Review URL: https://codereview.chromium.org/101113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238372 0039d316-1c4b-4281-b951-d872f2087c98

@tapted: assigning you as a reviewer for the sake of mixing it up (see @miket's email re assigning new reviewers to CLs) and because it's a trivial change.

Review URL: https://codereview.chromium.org/100983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238371 0039d316-1c4b-4281-b951-d872f2087c98

Some pages you just want to let run while the profiler runs. This
no_op measurement does just that.

R=tonyg
CC=eseidel

Review URL: https://codereview.chromium.org/100933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323728
TEST=see bug
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/100903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238369 0039d316-1c4b-4281-b951-d872f2087c98

This CL appeared to be the cause of a link failure on Win dbg: http://goo.gl/PTFpFF

> Clean up TestProfileSyncService and related tests
> 
> This CL refactors many of the tests in profile_sync_service_unittest.cc.
> It continues the refactoring work begun in r233533, r235661, and
> r235854.
> 
> The JsController tests have been deleted.  There is not much point in
> testing the JsController here; it can be more easily tested on its own
> in sync_js_controller_uniittest.cc.  The SyncJsController unit tests
> have been updated so they now cover the few cases that were formerly
> only exercised in the ProfileSyncService unit tests.
> 
> It converts all remaining uncoverted tests from relying on the
> TestProfileSyncService to using a real ProfileSyncService with an
> injected backend.  The injected backend makes it easier to create the
> scenarios we want to test.  We can inject a specially crafted SBH rather
> than fiddling with "synchronous init" and "fail initial download" flags.
> 
> Since the TestProfileSyncService no longer needs to support the wide
> variety of test scenarios required by the tests in
> profile_sync_service_unittest.cc, we can greatly simplify its
> implementation.  Many of its parameters and associated code have been
> removed.
> 
> BUG=140354,312994
> 
> Review URL: https://codereview.chromium.org/67683005

TBR=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/98323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238368 0039d316-1c4b-4281-b951-d872f2087c98

Reads on the Windows impl of SerialConnection were erroneously set to
wait for up to 10ms before completing with less than the requested
amount of data.

They will now complete immediately with any available data, without
waiting.

BUG=324886

Review URL: https://codereview.chromium.org/100813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238367 0039d316-1c4b-4281-b951-d872f2087c98

Both setting metadata_edit_state to DIRTY and calling OnEntryUpdateByOperation are necessary to trigger syncing.

BUG=260538
TEST=unit_tests --gtest_filter="MoveOperationTest.*"

Review URL: https://codereview.chromium.org/100373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237427

Review URL: https://codereview.chromium.org/98583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238365 0039d316-1c4b-4281-b951-d872f2087c98

This implements UpdateForErrors, which allows the
AutofillDialogController to initiate form validation. Necessary so
fields can be validated on e.g. instrument change.

BUG=277319
TEST=Use Wallet, use incomplete instrument, see error markers.

Review URL: https://codereview.chromium.org/100203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238364 0039d316-1c4b-4281-b951-d872f2087c98

This includes the "enable-linkable-ephemeral-apps" switch as well as
the EphemeralAppThrottle.

BUG=324815, 312460
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/100553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238363 0039d316-1c4b-4281-b951-d872f2087c98

Current code just uses the key_event.nativeKeyCode which is copied
from the Windows' lParam. The proper scancode needs to be shifted
and masked out of the lParam (as is done for UsbKeyCodeForKeyboardEvent.

BUG=325015

Review URL: https://codereview.chromium.org/100533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238362 0039d316-1c4b-4281-b951-d872f2087c98

Always show a prompt before an ephemeral app is about to be installed
and launched, whether it has permission warnings or not.

BUG=324817, 312460

Review URL: https://codereview.chromium.org/100393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238361 0039d316-1c4b-4281-b951-d872f2087c98

Zero suggest request re-uses the same URL as regular suggest and
therefore will be requesting xssi=t by default. We should make sure the
output is then correctly parsed.

BUG=

Review URL: https://codereview.chromium.org/96753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238360 0039d316-1c4b-4281-b951-d872f2087c98

The webkitGetUserMedia maxWidth/maxHeight parameters only define the maximum
frame sizes. The actual capture resolution should not exceed that or the
actual desktop resolution. In other words it should only downscale the desktop
but not upscale it.

BUG=324923
TEST=trybot, Chrome OS feedback screen captures in native resolution

Review URL: https://codereview.chromium.org/100313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238359 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg
CC=eseidel

Review URL: https://codereview.chromium.org/100283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260538
TEST=unit_tests

Review URL: https://codereview.chromium.org/99893007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238357 0039d316-1c4b-4281-b951-d872f2087c98

It now matches the timing and timing function of the advanced options section in settings.

BUG=none

Review URL: https://codereview.chromium.org/99873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318551, 251070
TEST=manually tested

Review URL: https://codereview.chromium.org/99703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238355 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to handle create-create conflict of folders in LocalToRemoteSyncer.

BUG=240165
NOTRY=true

Review URL: https://codereview.chromium.org/99813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=antrim@chromium.org

Review URL: https://codereview.chromium.org/99783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316397

Review URL: https://codereview.chromium.org/99483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238352 0039d316-1c4b-4281-b951-d872f2087c98