- 23 Jan, 2020 26 commits
-
-
Will Cassella authored
This follows the same pattern as "core/css/BUILD.gn". Since the "html" folder already has its own "BUILD.gn" file for regular sources, the tests should go there as well. I initially wasn't sure if "html" had any tests (I was a bit shocked), until I found them in the parent file. Change-Id: I3f1bf3517ed7bfcf3c7c155fe878ae8df7f5a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015776Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#734280}
-
Henrique Nakashima authored
This is a common dependency that should be available to all modules. TBR=twellington@chromium.org Bug: 1041468 Change-Id: Idbd04924ced7ee17ebac68b127b2a9d064cf0db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015612Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#734279}
-
Adenilson Cavalcanti authored
Fix use of uninitialized memory reported by oss-fuzz (and confirmed by valgrind@aarch64) by properly setting deflate_state internal member (i.e. s->prev) to a valid value before use. For details, see: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11360 Bug: 1032721 Change-Id: I6c7b2e87e81b8ccc6c39298fd3c704befd797b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015667 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734278}
-
Tommy Nyquist authored
The inline update experiment data has shown that we want to use the best effort version of the feature config to be able to reach as many users as possible. This changes the default configuration to be the version without notifications, and using best_effort. Bug: 884914 Change-Id: Iccecb804bf21501640170343584666a9c1a07c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013814 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734277}
-
matterchen authored
We want the GuestOS to have access to the same fonts as ChromeOS. To achieve this, on TerminaVM startup we will ask Seneschal to share the fonts directory with the VM. Tremplin will then share this with the container. ChromeOS VM Container /usr/share/fonts --> /mnt/shared/fonts --> /mnt/chromeos/fonts Relies-on: CL:1975215 Bug: chromium:903631 Test: Verifies it shares the font directory, test will come later Change-Id: Idcc321e7b14ee1b4535d9a6e6cdaeb051d8cb98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973490 Commit-Queue: Matthew Chen <matterchen@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#734276}
-
Alan Cutter authored
This CL is a data dependency refactor that makes ThemeService::UsingDefaultTheme() based on the current CustomThemeSupplier rather than prefs. This is in preparation to make ThemeService::GetColor() based on any CustomThemeSupplier instead of just the currently installed one. See follow up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1994026/15 Bug: 1020050 Change-Id: If3bd87e16f6ccf034f4c4909c7f7ca940ee2f838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007800Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#734275}
-
Arthur Wang authored
R=harringtond@chromium.org Bug: 1044242 Change-Id: I5e7cd4285891420db66af423257ce7ee974e63a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013261 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#734274}
-
Kyle Horimoto authored
In [1], treib@ suggested moving this to settings pref instead of including it within sync prefs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1977956 Change-Id: Ide9c1c4e8b1ede12e3324db96db44293bc8ec703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008302 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#734273}
-
liberato@chromium.org authored
This CL also plumbs ukm::SourceId through BeginObservation, instead of CompleteObservation so that default target values work. Change-Id: I46d65c7ca539e2b97aabd36e9667f886bda57f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006114 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#734272}
-
John Lee authored
Bug: 1027373 Change-Id: I53cfa85c279e39c38b262234a14cbad4ac284cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012525 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#734271}
-
sangwoo authored
Casting it into boolean makes it impossible to tell Showing from Hiding Bug: NONE Change-Id: Iaca2ee9aea0c033186ad0107b6734921d7fb87e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010235Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#734270}
-
Alex Danilo authored
Bug: 1027012 Change-Id: I2f7dc9648295808ff9ca2d74af28ab7eb0f1bcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014218Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734269}
-
Stefan Zager authored
This implements a behavioral change as described in: https://github.com/w3c/IntersectionObserver/issues/372 If the 'root' argument to the IntersectionObserver constructor is a Document, then the observer will clip to the Document's root scroller. For the top Document, this is the same behavior as the implicit root. For an iframe Document, this is new behavior which is unobtainable by other means. BUG=1015183 Change-Id: I234bfce28ab954bb15b8d157bc22ee2d2469d5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003750Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#734268}
-
Vasiliy Telezhnikov authored
This CL splits kVizForWebView feature flag into kVizForWebView and kVizFrameSubmissionForWebView. As we made decision to try reuse old path for frame submission the code that implements it needs to be under different flag. Bug: 805739 Change-Id: I0040cc0af8305d75612315967afa3bbf3915456a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015496Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#734267}
-
Ben Pastene authored
So it can be referenced from other build files. Namely, CrOS's toolchain can use it to set proper defaults: crrev.com/c/2015822. Bug: 937821 Change-Id: I5136ebf3b8c91295b7732a1f0225067d79bead59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014801Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#734266}
-
Jesse McKenna authored
This change replaces any '.' characters in a PWA launcher's filename with '_' on Windows 7 to prevent launchers from having misleading or potentially unsafe file extensions, such as those in net::IsShellIntegratedExtension(). This is largely a just-in-case measure added because a PWA launcher on Windows 7 has no extension. This change also simplifies the logic for legitimizing a reserved filename on Windows by prepending '_' rather than appending it. On Windows, each Progressive Web App (PWA) must have its own launcher in order for the PWA to be able to register as a handler for file types. On Windows 7, the filename of this launcher is used as the PWA's display name in the Open With menu, because Windows 7 lacks an alternate way to set multiple custom display names for one executable (and PWA launchers are identical copies of chrome_pwa_launcher.exe). The launcher filename is based on the PWA's name, with modifications to ensure the resulting filename is legitimate. These modifications are as follows: * Replace illegal characters with '_' * If filename is reserved on Windows: - OLD: + Append '_' + Replace all '.' with '_'; this was necessary because Windows' logic for checking reserved filenames views characters after '.' as file extensions, and only the pre-file-extension portion is checked for legitimacy (e.g. "nul" is reserved; "nul_" is allowed, but "nul.a_" is not). - NEW: + Prepend '_' * NEW: On Windows 7, replace all '.' with '_' Change-Id: Ibb2a183a8f023e5cbd98adb143e95551c49a1218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002982 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#734265}
-
Philip Rogers authored
We do not need to query PaintLayerCompositor to find out the setting for accelerated compositing. Bug: 1044674 Change-Id: I1d31fd9ab8767ffb3d0528520fb52f4ce57c7fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015300 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734264}
-
Khushal authored
This reverts commit d196259f. The error here was trying to delete a shared image created using a context before a GPU process crash. The service side considers an erroneous shared image deletion command as a fatal error which in turn destroys the new GpuChannel. This change now depends on a patchset which ensures that shared images are automatically deleted once a context is deleted avoiding the need for explicit deletion from the user. TBR=klausw@chromium.org R=kbr@chromium.org Bug: 1042446,1042481,1036142 Change-Id: I886460b8b1a62617ae987a1c96e0626fc3eb6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008076 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734263}
-
wutao authored
This cl fixes a bug to stop logo view animation when the view is not drawn. Bug: 1044320 Test: manual Change-Id: Ifa8b3f8ae1cf2c66b58ff2ff778599263ade7166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015608Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734262}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1bcbb571..a2e07326 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf3e44c60c5fa98f1b338c95789ec3ccb262c365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014782Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734261}
-
Takumi Fujimoto authored
Relanding crrev.com/c/1955086 with a fix for crbug.com/1043484. The only difference from the original patch is in media_notification_service.cc where we now call WebContentsPresentationManager::RemoveObserver() from MediaNotificationService::Session::~Session() before an early exit, so that it always gets called. Original message: When a Cast session is initiated from a web page and the page doesn't get rid of its media session, we generally get duplicate media notification items: one for the sender page and the other from the receiver. This CL hides the former in such cases. Bug: 1038447 Change-Id: I09a074ec4d08a1c19dc21de925c1974b5f9f47dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013631Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#734260}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56d4671ce783..6589db968634 git log 56d4671ce783..6589db968634 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 eseckler@google.com Merge "build: Don't propagate public_configs of proto_library targets" Created with: gclient setdep -r src/third_party/perfetto@6589db968634 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I421c25c4fb1bd12aaf6792123cfdcc6764e6288d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734259}
-
gogerald authored
Bug: 1025296 Change-Id: Ic72b26024d7125587b3803d1d3bb7655cc0f7efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013638 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734258}
-
Adam Ettenberger authored
It looks like Role::kEmbeddedObject was used for both "plugin" elements <object> and <embed>. Adding Role::kPluginObject which will have the same mappings that are currently set for Role::kEmbeddedObject, and Role::kEmbeddedObject has been updated to follow the spec for <embed>. https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings Bug: 1043338 Change-Id: Ia9869e6e616eebd9ac0954975b152c99a8653837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008276Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734257}
-
Ahmed Mehfooz authored
Bug: 960117 Change-Id: Ic71983cb3882f3579fddbd23299fd7b0691bd07b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015827Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734256}
-
Lukasz Anforowicz authored
In the past, CORB allowlist could be controlled via a field trial parameter, but that is no longer possible since r692251. This CL introduces a new, separate field trial parameter that can provide similar functionality for the AllowlistAlsoAppliesToOorCors feature. A *separate* field trial parameter is desirable because we want to separately control 1) the old CORB allowlist that is distributed via a field trial to old Chrome versions and 2) the new CORB+CORS allowlist that will be distributed to new/future Chrome versions. Bug: 920638 Change-Id: I65af7ddbc2387765b944bf1dfb05a22b1b8555c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995925 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734255}
-
- 22 Jan, 2020 14 commits
-
-
Kenneth Russell authored
Tbr: jdarpinian@chromium.org Bug: 859249 Change-Id: I973d272c1d99ba2c94e739eaba6759511afbfd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015980Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734254}
-
Toni Barzic authored
Starts shelf layout manager shutdown earlier at the beginning of shell shutdown sequence (during OnShellDestroying call issued to shell observers when the shell tear down starts). The main goal is to prevent shelf state updates that might happen during shutdown. For example, tablet mode controller destruction, and overview controller destruction might cause window stacking changes, that in turn can cause shelf state updates - both of which happen before Shell::CloseAllRootWindowChildWindows(), which is from where ShelfLayoutManager::PrepareForShutdown is currently called (with some indirection). NOTE: Calls to start shelf shutdown issued from RootWindowController::CloseChildWindows() are kept around to handle root window controller shutdowns that happen outside shell shutdown. BUG=1033343 Change-Id: I86211392b45bdafd5f095bd60c774fe88e8accce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015358Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#734253}
-
Xianzhu Wang authored
- Don't output repaint rects if PaintArtifactCompositor is not tracking raster invalidations. - Rebaseline tests. Bug: 648274, 757977, 765003, 842356, 931486, 937573, 1029620 Change-Id: Icdf154ca6cb39ead80e1b2aa7eaf71e1c3d941ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014177Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734252}
-
Maksim Ivanov authored
Implement the animation of the "Start" ("->") button on the Login Screen for the users that use challenge-response authentication (a.k.a. smart card login). The animation is, in accordance with the UI mocks, a continuously increasing arc around the button. This change also removes the code that was hiding the "Start" button - this is replaced by the animation. Bug: 1016839 Test: log in as a smart card user, log out, click "->" to log in again, verify that the "->" button is animated with a continuously increasing arc Change-Id: I77e830522c5a0770d583d661122cb3831fbb5390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005988Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#734251}
-
Xiaoqian Dai authored
Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804 doesn't fix the issue entirely. Looking deeper in this issue, it's actually caused by ClientControlledShellSurface::UpdateBackdrop() can be called on a dragged window (whose backdrop has been disabled (kDisabled) when drag starts) to re-enable the backdrop. This CL makes sure an ARC window with disabled backdrop mode won't be modified. Bug: 1027269 Change-Id: I4d138ddf17bbcee2ab07e1a5fb9785fc05b3fc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#734250}
-
Gil Dekel authored
Currently, DisplaySnapshot provides an API that says whether or not privacy-screen is supported by the display. This CL modifies this API so that querying the prop will return the state; whether it exists or not, and enabled/disabled if does. Bug: b/147451539 Test: display_unittests Change-Id: Idf4b111f0325550907eebe676f51e705eb8dad2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007871 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#734249}
-
Andres Calderon Jaramillo authored
This CL reduces the sizes of the expected-colors rectangles for the Pixel_ReflectedDiv test so that it passes on Nexus 5. The result in that device looks visually fine [1], but pixels along some edges are slightly different than the expected color: actual = rgba(255, 130, 4, 255) expected = rgba(255, 128, 0, 255) Therefore, reducing the size of the test rectangles to avoid the edges is reasonable. [1] https://chrome-gpu-gold.skia.org/img/images/f357a4dd6c87c632ae787203fcc307fa.png Bug: 1033279 Test: Same reliability test as in CL:1979059. Change-Id: I1d7ed61f5d1c7c2cacacb45d2d72b363580cba9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015560Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#734248}
-
Peter Boström authored
Removes references to InkDropMasks not working on Windows, this hasn't been correct for a long time. Also adds a TODO to replace existing overrides with HighlightPathGenerator usage. Bug: None Change-Id: I3e3724a711b560677b44293f5856c1fce05bb115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015772Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734247}
-
Ben Joyce authored
-Updates intellij to 13.0. -Adds commons-cli for standalone script. -Adds Kotlin and jetifier to android_deps. Bug: 896775 Change-Id: Ibccfda9574261f7f0cc49270bf8ff84a1ff0f5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992352 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#734246}
-
Lukasz Anforowicz authored
It is desirable (see https://crbug.com/1031119) to focus tab contents when a navigation is triggered by dropping a link or a file onto the browser window. Before this CL, tab contents would be focused any time the OpenURL code path is used, but not in BeginNavigation code path. This meant that dropping a local file (e.g. navigating to a file: URL) would result in focusing the tab contents (possibly moving the focus away from the omnibox), but other navigations (e.g. navigating to a https: URL) would not affect focus. After this CL any "drop" focuses the WebContents. Bug: 1042271 Change-Id: Ib1db79faec6e32846747d1cde9a78450dc354b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003079Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#734245}
-
Allen Bauer authored
This is a reland of fe842ad4 Original change's description: > Update and clarify view ownership for app-list views. > > Bug: 648382 > Change-Id: I0d000accee686dd67b2db1e14cea20ff893835c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001399 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732019} Bug: 648382 Change-Id: I07aa57e7b497367fd5699bf997dc76c6f36f355c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012835Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#734244}
-
Patti authored
A bunch of countries were being enrolled into the root organisation during the online demo mode setup flow when they should be enrolled into their own suborganizations. Fix this for Belgium, Canada, Ireland, Italy, Luxembourg, Spain, and the United Kingdom. The corresponding organisational units and admins have been added already. Bug: 1039934 Change-Id: I4945eb89db95b95d1c10795390b04a14c74f36af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006900Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#734243}
-
Takashi Sakamoto authored
chrome/browser/devtools/protocol/page_handler.cc depends on //components/subresource_filter/browser:browser. c.f. https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/9894 [51956/72454] CXX obj/chrome/browser/devtools/devtools/page_handler.obj In file included from ../../chrome/browser/devtools/protocol/page_handler.cc:8: In file included from ../..\chrome/browser/subresource_filter/chrome_subresource_filter_client.h:13: ../..\components/subresource_filter/content/browser/subresource_filter_client.h(10,10): fatal error: 'components/subresource_filter/core/mojom/subresource_filter.mojom.h' file not found FAILED: obj/chrome/browser/devtools/devtools/page_handler.obj C: \b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) Change-Id: I49d4fad36a3340fb0df6a758c64f49d9ac1efc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007807 Auto-Submit: Takashi Sakamoto <tasak@google.com> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734242}
-
Daniel Libby authored
DirectlyCompositedImages in blink has a dependency on having compositing information prior to the painting phase. This can't work the same way in CompositeAfterPaint. We'll be moving support directly to cc, in which we'll detect the situations under which we would have directly composited images (i.e. some specific sets of paint ops within a paint chunk) and adjust the raster scale appropriately. Blink's usage always matches layer size and image size, due to the usage of ReplacedContentTransform and directly setting the content layer bounds. This means we can reuse the code to detect and compute raster scale changes, where the current code is handling the case where (i.e. attempt to use raster scale of 1). A future change will add support for the paint op detection and set image sizes to non-matching values. This change generalizes the directly composited image code to use the image size rather than a boolean. Then use the ratio of layer bounds to image bounds to determine the raster scale. Bug: 875110 Change-Id: I4eb60f3f9b603b4e553104440695e13fc2fec43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009368 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734241}
-