GitLab

Add load task tracking to the TileGrid to allow it to record UMA when
the TileGroup has completed all its load tasks.

In addition to logging the Tile state when the group is initialised,
we also do so when the bottom sheet opens. To support the new load
task triggers, Tile load task tracking moved inside of the TileGroup
and only the completion event is exposed through the delegate.

Appropriately updated the non-Chrome Home code to separate non-Tile
completion logging for Tile specific one.

Bug: 735945
Change-Id: I8582ae510fe1edda31197460bcf9db2527e22682
Reviewed-on: https://chromium-review.googlesource.com/558358
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485602}

Modified SuggestionsSection#fetchSuggestions to take a recieving
callback as input rather than relying on notifying back the right
observer for the result.

This makes SuggestionsSection.Observer simpler, with only
notification-style methods, opening the possibility to register
multiple observers later.

Bug: 721407
Change-Id: I0e735be3eaca7bdc428abd2d009d6bbfb230cbc5
Reviewed-on: https://chromium-review.googlesource.com/563410
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485601}

This change adds additional fields for affiliation information to
password forms. In order to do so it modifies the existing Inject*
methods. This additional information will be needed to be able to show
Play Store names and icons for Android credentials in the password
settings page.

Bug: 628988
Change-Id: I37138f89c1fed826d151419ab296db322457aac7
Reviewed-on: https://chromium-review.googlesource.com/561380
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485600}

The playbacks were not be recoreded correctly because muted state
was not propagating through to the WebContentsObserver correctly.
There was also a bug where the timer didn't have the time-delta
set correctly so it was never being called.

BUG=731750

Change-Id: I2944679adbb88b9f37c1a88efa97652ff032d9b1
Reviewed-on: https://chromium-review.googlesource.com/563668
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485599}

According to the Apple documentation [1], the main binary of an iOS
application bundle should have the same name as the bundle without
the .app suffix and if the bundle name is defined it should have the
same value (only required for non-application bundles if resources
are loaded from the bundle).

Change build/config/ios/codesign.py to enforce those requirements and
fix the ios_remoting_app_tmpl used by chrome remoting iOS application.

This fix an incremental build always being considered dirty because
the ios_app_bundle template requires the correct naming of the binary
of the application bundle but did not enforce it previously.

Bug: 740476
Change-Id: I045dd3a393c96a0240f78bab303a241de967cfcd
Reviewed-on: https://chromium-review.googlesource.com/565401
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485598}

On wide screens (width > 720dp), if the two sets of bulletpoints can't
be positioned horizontally next to each other, they must be positioned
vertically.

However, the specification suggests that in this case they should
not be centered under the subtitle, but left-aligned with the subtitle.
This can be most easily achieved by extending the container to match
the subtitle width.

As a side effect, this also addresses the first layout pass misalignment
bug, for which we had to add extra 10dp. This hack has now been removed.

See crbug.com/693525 for screenshots.

Bug: 693525
Bug: 740619
Change-Id: I176fdd26914d212da0acb54fbab7721562faca19
Reviewed-on: https://chromium-review.googlesource.com/566825Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485597}

This provides a more consistent way for listeners to get the PID
of a service. The existing APIs for doing this (for example the
pid argument of OnServiceStarted) will be removed in a follow up.

Bug: 739710
Change-Id: Ia41cdb12e412bd478aefb1481431db1cd2824265
Reviewed-on: https://chromium-review.googlesource.com/563366Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485596}

We need to create the safe browsing directory for storing
safe browsing related cookies. This should happen in any case
as the safe browsing functionality can be enabled on a
per webview basis at runtime.

BUG=700351, 688629

Review-Url: https://codereview.chromium.org/2969693002
Cr-Commit-Position: refs/heads/master@{#485595}

TBR=benwells@chromium.org
BUG=359837
TEST=Build with target_os="chromeos" and enable_nacl=false.

Change-Id: I17e9bd2a62e4f4e79957e5ae7cc16a9c4248fb21
Reviewed-on: https://chromium-review.googlesource.com/566771
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485594}

This patch changes SelectionModifier::ModifyMovingForward() to utilize
early-return style for improving readability.

Change-Id: I39e9659b787a7366b46b77c0bd9a9cf45b11765c
Reviewed-on: https://chromium-review.googlesource.com/566161
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485593}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1604146f..e19aed3c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ia06a73828672b47f19fbd29b30db40da9c55c5e1
Reviewed-on: https://chromium-review.googlesource.com/566880Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485592}

NotificationViewMDTest were reverted due to LSan failure in
NotificationViewMD.
This CL fixes the leak and restores NotificationViewMDTest.
The leak was caused because we assumed a->RemoveChildView(b)
would delete the b object, but it was not true.
We should use DCHECK(a->Contains(b)); delete b; instead.

Original CL: https://codereview.chromium.org/2966343002/

BUG=733948,739356
TEST=
gn gen out/asan --args='is_asan=true is_lsan=true enable_nacl=false
is_debug=false' &&
ASAN_OPTIONS="detect_leaks=1 symbolize=1
external_symbolizer_path=`pwd`/third_party/llvm-build/
Release+Asserts/bin/llvm-symbolizer" out/asan/message_center_unittests

Change-Id: I81f1aefdab6fafa35fd00e69875b1aa426822c9e
Reviewed-on: https://chromium-review.googlesource.com/564859Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485591}

This reverts commit ee22b7dd.

Reason for revert: Possibly causing Linux Trusty flake. See crbug.com/740802

Original change's description:
> WPTServe: Run .any.js and .worker.js variations
> 
> This change is based on jsbell's crrev.com/2767673002.
> 
> When .any.js and .worker.js files are seen during MANIFEST generation
> they are mapped to .any.html, .any.worker.html, and .worker.html files
> as appropriate which WPTServe will generate on-the-fly. This allows
> for easy testing of [Exposed=(Window,Worker)] APIs and tests that are
> simply script with no boilerplate HTML. These are now supported in
> run-webkit-tests.
> 
> When specifying tests to run, the source name should be specified, 
> for example:
> 
>   $ run-webkit-test external/wpt/storage/interfaces.worker.js
> 
> But expectations will use the generated name, e.g.:
> 
>   external/wpt/storage/interfaces.worker-expected.txt
> 
> And failures will be reported under the generated name:
> 
>   external/wpt/storage/interfaces.worker.html
> 
> Bug: 653514
> Change-Id: I2f531e142c4ca41b1f3223a69a1e6f61343464c2
> Reviewed-on: https://chromium-review.googlesource.com/461722
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485419}

TBR=jsbell@chromium.org,qyearsley@chromium.org,tkent@chromium.org,jeffcarp@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 653514
Change-Id: I685218eb840aa3d860a3709bc413d946240633d5
Reviewed-on: https://chromium-review.googlesource.com/566980
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485590}

The section titles are not visible enough in ContentSuggestions.
Changing the color to match the one used for other titles should help.

BUG=740863

Change-Id: I9dd640ec6ec6cb0df734200987c06fd13ce39f50
Reviewed-on: https://chromium-review.googlesource.com/566823Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485589}

TEST=manually confirmed double-click opens item, both mouse and touchscreen

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I06febecffff64e4d393f855c25ef549e424e09e4
Reviewed-on: https://chromium-review.googlesource.com/557621
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485588}

Bug: 740894
Change-Id: I2ecd9902237fa558caae6f49a77bb2ce7022e5ea
Reviewed-on: https://chromium-review.googlesource.com/566801
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485587}

Change-Id: I269c4156bdf0237e3bdcf48cc17859ba09e95135
Reviewed-on: https://chromium-review.googlesource.com/563379
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485586}

In jumbo several compilation units are merged so you have to
have more unique names in each one, and don't #undef macros
needed by other compilation units.

BUG=713137

Review-Url: https://codereview.chromium.org/2971683003
Cr-Commit-Position: refs/heads/master@{#485585}

This CL flips `use_once_callback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//mojo/common starts using base::OnceCallback instead of base::Callback
on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

Bug: 714018
Change-Id: I6696d57e6aa0dff7820f740903a1a9f34fa97794
Reviewed-on: https://chromium-review.googlesource.com/558895Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485584}

This patch gets rid of useless member variable |granularity_| from
|VisibleSelectionTemplate| for improving code health.

Bug: 692923
Change-Id: I0ed67a6076e4c34496cf8c6eaf39f497572f614d
Reviewed-on: https://chromium-review.googlesource.com/566200
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485583}

In this case UIApplication doesn't retain block, and at the end
of constructor ref_count of |this| will be decremented to zero ->
|this| will be deleted. Later deleted object will be accessed in
|core_(new ScopedCriticalAction::Core())|

The solution is to separate object construction and
beginBackgroundTaskWithExpirationHandler method call.

Change-Id: I0aa21cba2396231ea9ccd3ee34617f5d0417dbdd
Reviewed-on: https://chromium-review.googlesource.com/558245Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485582}

BUG=

Review-Url: https://codereview.chromium.org/2965403002
Cr-Commit-Position: refs/heads/master@{#485581}

This CL moves the functionality of
chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.*
into the TestUkmRecorder to provide the utility to other code that needs to
test URL keyed metrics.

NOTRY=true

Bug: 738921
Change-Id: I8c4e9101fc817e265415f4c45c174c5a1ef8ccc0
Reviewed-on: https://chromium-review.googlesource.com/565293
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485580}

Revert of Remove all of the CrOS Ozone configs from MB. (patchset #8 id:130001 of https://codereview.chromium.org/2949093004/ )

Reason for revert:
ash_unittests are failing on ChromeOS AsanLsan bot
crbug.com/740859
Regression range is 485493 - 485513 so suspecting this.

Original issue's description:
> Remove all of the CrOS Ozone configs from MB.
>
> Ozone is now on by default on all CrOS builds, and we don't
> need to test the old x11 config any more. This CL flips
> all of the CrOS builders to (implicitly) be building for Ozone,
> so that we can then remove the explicit Ozone builders in a
> follow-up CL.
>
> This builder also removes the
> linux_chromium_chromeos_ozone_rel_ng builder from the CQ
> since would otherwise be redundant with the
> linux_chromium_chromeos_rel_ng builder.
>
> This CL also removes a couple of commented-out CQ entries for
> builders that were removed as part of the work in bug 669297
> (linux_chromium_chromeos_compile_dbg_ng and linux_chromium_clobber_rel_ng);
> at the time I had planned to re-add them once the capacity
> issues were resolved, but at this point it's unclear how
> important those configs are and we may want to use the
> capacity for other things, and so these comments were misleading.
>
> R=kylechar@chromium.org, kbr@chromium.org
> TBR=achuith@chromium.org, xdai@chromium.org
> BUG=671355
>
> Review-Url: https://codereview.chromium.org/2949093004
> Cr-Commit-Position: refs/heads/master@{#485495}
> Committed: https://chromium.googlesource.com/chromium/src/+/7385c63ec2b3606a67bb192bf96311ada07aa1c6

TBR=kylechar@chromium.org,kbr@chromium.org,fjhenigman@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671355

Review-Url: https://codereview.chromium.org/2974923002
Cr-Commit-Position: refs/heads/master@{#485579}

This CL fixes a bug where the action menu would use the entire body's
length as the viewport when flipping coordinates in RTL.

It also moves the scroll position saving into showAtPosition so that
both show methods account for scroll correctly.

BUG=734984
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2966163004
Cr-Original-Commit-Position: refs/heads/master@{#485181}
Committed: https://chromium.googlesource.com/chromium/src/+/87be8f4c1eaef26b7c6d7ddb2c56d84ef504a232
Review-Url: https://codereview.chromium.org/2966163004
Cr-Commit-Position: refs/heads/master@{#485578}

To be consistent with the dialog title and make it easier to distinguish it from
other share-related actions, we rename the label which is used in following
locations.
- Menu item label in context menu.
- Spoken feedback label for the toolbar button.
- Tooltip label for the toolbar button.
All of them uses the same dictionary entry.

Bug: 740817
Change-Id: If6f893bbd2a4595b75e8694fa88b5283d3327af1
Reviewed-on: https://chromium-review.googlesource.com/566784Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485577}

Specific mode for users who go to chrome://dino just want to play the game.
+ Hides the offline messaging for game focused mode.
+ Game area scales up to the window width, removing the current 600px max width restriction.

BUG=

Review-Url: https://codereview.chromium.org/2955153002
Cr-Commit-Position: refs/heads/master@{#485576}

Caller takes ownership of the created object. We should use
std::unique_ptr<> for it according to coding style guide.

Bug: 731537
Test: Build passes.
Change-Id: Ia8f5887219ec8696ed66728de3e65c04d7aaadbe
Reviewed-on: https://chromium-review.googlesource.com/563278
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485575}

The "ImpressionsTilDismiss" should be sent only when the setting view
is closed (it was sent when going into a submenu of the settings).
The display count should only be increased when opening the settings.
Before it was increased for each data reload of the collection view.

Bug: 709286
Change-Id: I301f96241f7704aa01695fc41e841364fca1f80a
Reviewed-on: https://chromium-review.googlesource.com/563389
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485574}

If no sound was made then do not record significant playback

BUG=729998

Change-Id: I348649bfa2fefc2556717e011609ffa7813672a8
Reviewed-on: https://chromium-review.googlesource.com/537253Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485573}

The field was used uninitialized what may lead to arbitrary number of unwanted
network request retries when server replies 5xx.

Change-Id: I4700d8186f81dc133b64440a392d3a916247a739
Reviewed-on: https://chromium-review.googlesource.com/564610
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485572}

After https://codereview.chromium.org/2946223002/ landed renaming
FullScreenActivity to SingleTabActivity, we can rename
FullscreenWebContentsActivity to FullscreenActivity to keep things
simpler.

Bug: 740534
Change-Id: Idb72b4734aaf211799f3c5956c3f626be05f0105
Reviewed-on: https://chromium-review.googlesource.com/565409Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485571}

This arises from the frame disconnecting the context's per context
data when the frame is disconnected; which is <crbug.com/583429>.

Bug: 740455
Change-Id: I71967c43b69f8dd4df7c9c97acf9db7868b13af6
Reviewed-on: https://chromium-review.googlesource.com/566265
Commit-Queue: Dominic Cooney (OOF until 7/28) <dominicc@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485570}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0cd46302..1604146f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I99ef67675285d4e3f106901c5315b480024c8ba3
Reviewed-on: https://chromium-review.googlesource.com/566618Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485569}

This is mostly a reland of https://chromium-review.googlesource.com/548719
which was reverted because of perf impact. In the meantime,
https://chromium-review.googlesource.com/558924 has landed which hopefully
improves performance.

It also adds the CaptureThumbnailDependingOnTransitionType feature, since
the two will likely launch together (and that might also alleviate the
perf impact).

Bug: 718413, 737396
Change-Id: I0ef909f0015d07a3f908d0ba3dc52f6a897a53b1
Reviewed-on: https://chromium-review.googlesource.com/563202Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485568}

Implement ConsumeShorthandGreedilyViaLonghandsAPI and API for shorthand property -webkit-text-emphasis.

ConsumeShorthandGreedilyViaLonghandsAPI is a modified version of
ConsumeShorthandGreedily of CSSPropertyParser. The difference between
the two is that the new version expects component longhands to have API
impl already  as it will forward parsing logic to component longhands API
via ParseLonghandViaAPI.

ConsumeShorthandGreedily will be deprecated soon, when shorthand properties 
are ribbonised (i.e. have their own APIs). Until then, there is a slight 
code duplication between the two versions for the following reasons:

1. An alternative to code duplicate is to have the old ConsumeShorthandGreedily
call the new ConsumeShorthandGreedilyViaLonghandsAPI. However, the new 
ConsumeShorthandGreedilyViaLonghandsAPI expects ALL component longhands 
to have APIs and will parse all longhands via their APIs. In order to parse 
shorthands, where some component longhands do not have APIs, the new 
ConsumeShorthandGreedilyViaLonghandsAPI will need to return to the old 
ConsumeShorthandGreedily which longhands have no APIs and thus are not parsed.
The old ConsumeShorthandGreedily will then have to parse these longhands separately.
Hence there's added code complexity with little code reduction.

2. All shorthand properties will have APIs soon, hence such code duplication is 
temporary only.

This cl also implements API for shorthand property -webkit-text-emphasis
as a use case of ConsumeShorthandGreedilyViaLonghandsAPI.

Design doc for shorthand parsing: https://docs.google.com/document/d/1gF_3wAvO82iVNcyJ7z2YzT8sFa8JepkWmIgJ9NcT1Pc/edit

Diff: https://gist.github.com/f9cff56b20f46225b6b90f033798eccf/revisions
Bug: 668012
Change-Id: I1cf9295893bb113527b44c2935d296e2997164ac
Reviewed-on: https://chromium-review.googlesource.com/564875Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485567}

webcomponents-bugzilla@chromium.org is a legacy mailing list and
nobody cares today.

Change-Id: I53c99ec3b7b4ed7b9a1e4cf4b93e3bc0c0a80760
Reviewed-on: https://chromium-review.googlesource.com/566779Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485566}

This CL removes the IDC_SHOW_TOOLS_MENU command, and updates call sites.

This involves:

- Adding a command dispatcher to the stack view. This is done by defining
a dispatcher property on the TabSwitcher protocol; StackViewController
creates a dispatcher on init and returns it for this property. The tab
switcher view controller returns nil (for now).

- The special case in the tools menu on phones for the menu button to
no-op but still record metrics is removed by simply not having the 
tools menu button in that case call -showToolsMenu.

(Note that tapping the tools menu button while the menu is showing is
still a no-op, presumably because that's easier than special-casing
the button to do nothing. Since all of the menu and toolbar code is 
moribund, this doesn't seem worth cleaning up.)

Bug: 
Change-Id: I6d90ff72cdc6969679ec1c5e07dd6ee32cf0deed
Reviewed-on: https://chromium-review.googlesource.com/563660
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485565}

This reverts commit 45f7994f.

Reason for revert: Broke BrowserWindowControllerTest.UsesAutoLayout

Original change's description:
> Enable ShouldUseFullSizeContentView().
> 
> Also fixes the known issues with enabling it:
> 
> - crbug/665787: The tab background view was added in front of the content and
>   blocked interaction with the top of the scroll bar when the toolbar was
>   hidden. It's now inserted behind the content, like before.
> 
> - crbug/655112: FramedBrowserWindowTest.DoesHideTitle took screenshots of the
>   frame view, which gets drawn using a different (layer-backed?) path when
>   NSFullSizeContentViewWindowMask is on. The test now calls -[CATransaction
>   flush] before taking each screenshot, and uses a different API to screenshot
>   the whole window instead of trying to grab just the frame view by accessing
>   the content view's superview.
> 
> Bug: 605219, 655112, 665787, 730679, 734713, 737206
> Change-Id: Id78c21aff6748e02fd4b3e461c77ef9f7454d744
> Reviewed-on: https://chromium-review.googlesource.com/566030
> Commit-Queue: Sidney San Martin <sdy@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485544}

TBR=tapted@chromium.org,shrike@chromium.org,sdy@chromium.org

Change-Id: I00b73bc5d2d5607736ddc81b9ae81ec65527ebad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 605219, 655112, 665787, 730679, 734713, 737206
Reviewed-on: https://chromium-review.googlesource.com/566898Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485564}

This CL disables the sort button in the toolbar action menu for empty
folders.

BUG=737034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2973783002
Cr-Commit-Position: refs/heads/master@{#485563}