- 06 Oct, 2020 13 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium cac85ac0. With Chromium commits locally applied on WPT: 430b7621 "[LayoutNG] Don't truncate margins after spanners." ce85ff61 "[LayoutNG] Correct column balancing for horizontal-rl." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I2c41f0d2a4032881a8f2ff5f9c6221802df0a42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450771Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814012}
-
Jinsuk Kim authored
Replaces |assert| which can be removed in release build with one of Assert.assert* variations in test. Bug: 1131424 Change-Id: Iadba51d09fb857a2db0f41357690361885e3c6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437669Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#814011}
-
Xing Liu authored
Currently we didn't build DownloadCollectionBridge for webview. Bug: 1135162 Change-Id: Id7a2cb3fa263281216304b1c519271c95b44ae37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450721 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814010}
-
Leonid Baraz authored
Bug: None Change-Id: Ie4a0bf883e97cfd2b412583151030312048628a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450922 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#814009}
-
Ionel Popescu authored
This is a reland of c64eed06 The difference from the original change is that this CL updates the color-picker-show-eye-dropper.html test to provide user activation. Original change's description: > Add security mitigations for eye dropper IPC. > > As discussed on the security review this CL adds the following mitigations: > - require a transient user activation on the browser side, and consume > it when showing the eye dropper for the renderer (this will prevent a > compromised renderer to repeatedly ask for a color) > - require the eye dropper UI to be visible for a minimum amount of time > before color selection is allowed in order to ensure the user has a > chance to see the UI. > > There is also a fix for the popup not correctly updating the user > activation state. This happens because it is using a > EmptyLocalFrameClient and its frame is not related to the > owner element's frame. > > Bug: 992297 > Change-Id: Ia5d2aead0be153ce4b49048552062de3a6c72e63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442132 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812847} TBR=avi@chromium.org,tkent@chromium.org,masonfreed@chromium.org Bug: 992297 Change-Id: Icecebf941b277790e12a12d06bca5b20da404ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450731Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814008}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/df909306835a..326e14f34bb5 2020-10-05 kainino@chromium.org Revert "Add a per-thread proc table using thread local storage" 2020-10-05 enga@chromium.org Add a per-thread proc table using thread local storage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ia2310d80ddd10c2300ab6587ca397872cc72a6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814007}
-
Yuke Liao authored
This CL moves ui/ozone/ozone.gni to build/config/ui.gni because a few args in ui/ozone/ozone.gni will be used by toolchain files under build/, and the reason is that in a LaCrOS build, ozone_platform is set to use Wayland, and meanwhile, we build an ash-chrome in an alternate toolchain, which requires re-setting the ozone_platform back to empty. For more details, please see: https://chromium-review.googlesource.com/c/chromium/src/+/2416999 Bug: 1129223 Change-Id: I8c1e94c568165de2a5c26ca103fa84a60eb68b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427423 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#814006}
-
Hirokazu Honda authored
When the VASliceData buffer is re-used, decoded frames randomly have artifacts. This is a workaround of the issue. VASliceData is always created on submitting each frame. Bug: b:166646505, b:169725321 Test: Play swirl_128x128_vp9.webm on eve-kernelnext Change-Id: I85d9b7902496b84fd905da0e80dd604298db0bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448272 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#814005}
-
Garrett Beaty authored
chromium-m87/ci/mac-arm64-rel tried to trigger the non-existent builder chromium-m87/ci/mac-arm64-rel-tests. Change-Id: I2de27cfd399c75614d1d2d9b78a2edecc80acd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450723 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#814004}
-
Yulun Wu authored
This addresses the changes in this CL https://chromium-review.googlesource.com/c/chromium/src/+/2382222 Bug: 1134854 Change-Id: I193d0d73a44d858a8674f16703696da8bbcf5c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447431Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814003}
-
Jeroen Dhollander authored
This name better describes the reality, as the QuickAnswer feature will be enabled automatically, even if the user doesn't acknowledges it. The "consent" is more of a "FYI this new feature exists". There should be no functional change. I did change the return value from |QuickAnswersUiController::CloseUserNoticeView| to |void| because the return value was never used anyway. I did not change the values with which the pref values are stored (in chromeos/components/quick_answers/public/cpp/quick_answers_prefs.cc), as that would have functional impact for users. Bug: b/169430885 Tests: ash_unittests/chromeos_component_unittests/ Change-Id: I83e53840746e5b116cd89a1996406986a751ffb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436323 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#814002}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a7bec371a3c..765c9d3a9ca4 2020-10-05 johnstiles@google.com Update message on SkBitSet static assertion. 2020-10-05 michaelludwig@google.com Use preservesAxisAlignment instead of scaleTranslate for clip simplification 2020-10-05 ethannicholas@google.com moved SkSL FunctionCall data into IRNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ifb5a316e720c2930c71e9bacf02eac686a77b5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451357Reviewed-by:
-
Krishna Govind authored
This reverts commit 7ba7ed5e. Reason for revert: Breaks translation, crbug.com/1135333 Original change's description: > [Autofill Offer] Update offer text to "cashback" > > Bug: 1112095 > Change-Id: I614ec70d4ba183850cd19412c963bd344b7c318c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444800 > Commit-Queue: Siyu An <siyua@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#813422} TBR=jsaul@google.com,siyua@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1112095 Change-Id: I998f30b7c76cca3e933a64168bbc796248946a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451378Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#814000}
-
- 05 Oct, 2020 27 commits
-
-
Josh Simmons authored
Assistant will use this information to determine whether or not to show a translate prompt when Assistant is opened over Chrome. This is controlled by the "TranslateAssistContent" Feature and is off by default. Design doc here: https://docs.google.com/document/d/1xZR09XTTGgY0F00_lFOEX7nUc0oqgSrCs5lZFU9INA0/edit Bug: 1110943 Change-Id: I213f55af0efdaa2762f4524b74f942b99123f64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442360Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#813999}
-
Xinghui Lu authored
PasswordProtectionService::CanGetReputationOfURL and RealTimeUrlLookupServiceBase::CanCheckUrl both check whether Safe Browsing backend can get a reliable reputation of a URL. Move this check to a central place. Bug: 1126130 Change-Id: Ia6f1f197024a8436cf3c116291829007f1ce4a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441376 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#813998}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/34445b29ae40..0ff24ae00769 2020-10-05 jmadill@chromium.org Suppress failing Mac GL dEQP tests. 2020-10-05 cnorthrop@google.com Tests: Update two traces, remove one 2020-10-05 jmadill@chromium.org Capture/Replay: Split very large replay function. 2020-10-05 jmadill@chromium.org Capture/Replay: Generalize function splitting. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_perftests --gtest_filter="*Trace*" Change-Id: I55131c60350bf0a8b17ef950d65720bf55119af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451409Reviewed-by:
-
Kristi Park authored
This reverts commit 1d11f9fd. Reason for revert: Suspect for failing test, InputHandlerProxyEventQueueTest.VSyncAlignedGestureScrollPinchScroll https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20826 Original change's description: > De-couple PredictionMetricsHandler from specific histograms > > PredictionMetricsHandler appears to be designed to work for anything > that is predicting points. However, it currently only reports metrics > in the Event.InputEventPrediction.Scroll* histograms. De-couple the > class from these histograms so it can be used for things only than > scroll metrics. > > Bug: 1133785 > Change-Id: Ib34129fc46b20b45810cbd5ca195483e88c513e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441197 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Mario Bianucci <mabian@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#813813} TBR=sadrul@chromium.org,dtapuska@chromium.org,mabian@microsoft.com Change-Id: I9cefcdb1b51f13026726eb2449e1213f43dfc91f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451569Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#813996}
-
Nathan Zabriskie authored
On Windows we're currently not allowing OOP Rasterization to be enabled when using a validating command decoder. This is currently blocking running web tests on trybots with the new OOPR Canvas2D feature enabled. Since this configuration (OOPR with Validating decoder) will never ship to production this CL removes the check to unblock testing until SwANGLE/passthrough decoder is used by default in web tests. Bug: 1081534 Change-Id: Idc76619ed49872b023728088c79a5426daab9029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436771 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#813995}
-
Roger Zanoni authored
If primary-selection-unstable-v1 is available, it is used. Otherwise, falls back to gtk-primary-selection. Bug: 1088132 Change-Id: I9a17e4a4765ab7b5869948c67707f6af2173d001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440659Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#813994}
-
Dale Curtis authored
Should result in nullptr crashes which may be easier to debug to find culprits which are violating this. R=tguilbert Bug: 1035556 Change-Id: I14fe4ad3680e536b1193b47d0127ba46cda6b93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451383 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#813993}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //weblayer. Bug: 1113033 Change-Id: I60344a039c708f581e6e98c65f41c866cb0d2958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450701Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#813992}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/97356acb50e2..7e8ea22e4056 $ git log 97356acb5..7e8ea22e4 --date=short --no-merges --format='%ad %ae %s' 2020-10-02 jianj Add codec control to disable loopfilter for vp9 2020-09-30 jianj Add file for rate control interface test. 2020-09-29 jzern ratectrl_rtc_test.cc: fix signed/unsigned comparison 2020-09-29 jzern configure.sh: fix arm64-darwin-gcc match 2020-09-25 jzern configure: add darwin20 support 2020-09-16 jzern vp9_ratectrl,vp9_resize_one_pass_cbr: rm redundant casts 2020-09-16 jzern test/encode_test_driver: rm redundant get() w/unique_ptr Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: Id1b2c90b313d4a8ecfc385f26f912bcdb4c73d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451373Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#813991}
-
Xinghui Lu authored
The goal is to replace the SBER checkbox with the enhanced protection message. Enhanced protection message is shown when: 1 Not in incognito mode 2 kEnhancedProtectionMessageInInterstitials flag is enabled. 3 Safe Browsing pref is not managed by policies. 4 Enhanced protection is not already turned on. Bug: 1130721 Change-Id: Ic7175c6210023ebe23e5cd7aedacadf39091528a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430826 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
- NTP Realbox has been fully launched in M84 and enabled by default in M86 (crrev.com/c/2354993). - This CL cleans up C++ code affected by the feature only. It leaves JS code in place. This is because (1) the local NTP code will be removed entirely with the launch of the WebUI NTP at a later milestone; and (2) there is still a lot of development in the WebUI NTP. References to <fakebox> in the WebUI NTP will be removed NTP at a later milestone Fixed: 1134781 Change-Id: Ic0a7009ab6464b15c19e8a172f061c0e487ca075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446533 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813989}
-
Christopher Cameron authored
This was reverted last time because there was no GL context current (because the SharedImage path elides most GL calls). Add a MakeCurrent call before creating the SharedImage. This will need to be removed eventually. Bug: 1108909 Change-Id: I862b8ae7c502e5c4181b313db2be9e6acd4aae9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451372Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#813988}
-
Alex Gough authored
Adds a mojo ReadOnlyFile that won't serialize if it can be written. The expectation is that this handle will then be sent to another process which lacks the rights to add any write permissions to the handle. This may not be true on all platforms but is useful where this holds. Code to check for readonly-ness is implemented within mojo rather than base::File as it is (a) difficult to say in general what it means to be readonly, and (b) not possible on every platform. Bug: 1130762 Change-Id: I6f00934005da7e433af4fee94454dfcd28dfd3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417549 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#813987}
-
Ghazale Hosseinabadi authored
This CL adds test coverage for WINDOWS_GET and WINDOWS_GETCURRENT APIs. Bug: 1093066 Change-Id: I8c8535818ffd0b748418c28bb3b4945439ca8593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442130 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813986}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/422c039e8e1b..d0b4e1976ca1 2020-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4a1e48e2de33e3acea5977a089d180118214fd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451330Reviewed-by:
-
evliu authored
This CL updates the download progress UI for the Live Caption feature to reflect the total download progress of both the SODA component and the selected language pack component(s). The feature currently only supports the en-US language pack which should be downloaded along side the SODA component. Bug: i1134807 Change-Id: Ie9d7a0b5442d5fdbc63c255f0aea713464ef3225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446468Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
David Bienvenu authored
Change-Id: Ib31c2f3cc144b530fa6248e3481f7c6f3f61738a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451328Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813983}
-
Kristi Park authored
This reverts commit 6a69beb2. Reason for revert: Failing content_browsertests on linux-trusty-rel https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/16561 Original change's description: > Avoid illegal serializations with aria-owns and unincluded nodes > > When adding children, make sure we only add aria-owned children to the > owning nodes. This avoids a common crash in chrome://bookmarks that > has a confusing crash stack. In order to do this, when > ComputeAccessibilityIsIgnored() is called, the relation cache > must already be updated with the knowledge that the object is owned. > > Do not ever allow owned objects to ever have a "not included in tree" > parent. Therefore, they can never be added as second line children > via the recursion in InsertChild(). > > Also re-remove WalkAllDescendants(), which was it was recently > re-added as a band-aid for the chrome://bookmarks crashes. > Without this change, removing WalkAllDescendants() causes assertions > in AXTreeSerializer, when aria-owns points to an unincluded node, > that the same object is being added twice. > > Finally, add better logging and DCHECKs that will help diagnose issues > more quickly. > > Bug: 1100968, 1131848 > Change-Id: I3bb5d069814e144d426b5c3de0991bc41123206f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446200 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813955} TBR=dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: Icdc657185e51265e1939d32bd4508bf6cc0b307c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1100968 Bug: 1131848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451509Reviewed-by:
-
Joon Ahn authored
https://screenshot.googleplex.com/7fXF2GjLWEPcAbs Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I77af9ea199c2363636471d3b2b8b1ef739fdc1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441531 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813981}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: Ib40e1fdc8b72731c2b0d55a390fba0367da80f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444797 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813980}
-
Jamie Madill authored
When switching to isolated scripts the Lacros testers failed. Disable these tests for now to work around the bug. Bug: angleproject:5124 Change-Id: I5c68ed47be2ac59f039d9139c8e98d7adf3ab701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447102Reviewed-by:
-
Christopher Cameron authored
These functions will be used in capture. Leave the tests in media/gpu/mac, because the tests internally use media::CreateFormatExtensions. Bug: 959962 Change-Id: I14a6c49b1297d505b3780412bab54c4b2abf9d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437477 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813978}
-
Hui Yingst authored
This CL adds supports for navigating to view destinations with fit type 'FitR' (See table 151 in ISO 32000-1 standard for more details about syntax of "FitR"), which focus the view on a rectangular window specified by the FitR's coordinates parameters. Bug: 55776,535978 Change-Id: I91353e7569830ba306b9d4cc31f32bfb9622c1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391735Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813977}
-
Nicholas Hollingum authored
This CL refactors IsAllowed for borealis into the standard GuestOs approach (i.e. having a pref-keyed singleton). This necessitates minor refactorings of the installer and its tests. Relatedly, this calls for the creation of Borealis prefs, which were also added in the same fashion as the other GuestOs implementations. Bug: b/168763038, b/162562622 Change-Id: Ie153c2a860a174feaa3156801a8415ca99eefcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415755Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#813976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96edaff6ceb3..09e5f06f05dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kristipark@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085115,chromium:1105693,chromium:1119472,chromium:1134655 Tbr: kristipark@google.com,csharp@google.com Change-Id: I255e69a3c27bb6bfeb230cf48ab5f7e2be4e6719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450587Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813975}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/dee4a03873a1..952113a3bdf5 2020-10-05 jophba@chromium.org Improve OFFER message validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ieeff93ef07069288184b34b140d81946bbb5ec78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451350Reviewed-by:
-
Nico Weber authored
gyp is long long gone. Hopefully nobody still set this. (If you do: Set the concurrent_links gn arg instead.) Bug: none Change-Id: Ifef44f50825c15d89dff95af7597944bfdf87da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449935 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
