GitLab

When rotating, we receive events from the renderer in an unexpected
order (we get a SelectionBoundsChanged call with points in the new
window position before the CompositorFrameMessage and so we misinterpret
the SelectionBoundsChanged).

For now, we should simply unselect the text before rotating.

BUG=174665


Review URL: https://chromiumcodereview.appspot.com/12221150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=try bots, local build of pepper app

Review URL: https://chromiumcodereview.appspot.com/12217119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182073 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12209064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182072 0039d316-1c4b-4281-b951-d872f2087c98

linux-release/intl1: http://build.chromium.org/f/chromium/perf/linux-release/intl1/report.html?history=250&rev=182066

TBR=cmp@chromium.org
BUG=175888
Review URL: https://codereview.chromium.org/12225158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182071 0039d316-1c4b-4281-b951-d872f2087c98

Clobber the requestAutocomplete dialog when autofill data changes.

this patch was accidentally reverted

BUG=none
TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/12207140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182069 0039d316-1c4b-4281-b951-d872f2087c98

Don't append XPS extension. Use empty file created by CreateTemporaryFileInDir.
Use AppData subdir same as ProgramFiles subdir.
Delete leaked files.

BUG=172554

Review URL: https://chromiumcodereview.appspot.com/12218117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182068 0039d316-1c4b-4281-b951-d872f2087c98

> Create unit-test for exiting context menus via mouse button
> 
> Added a unit-test to BookmarkBarViewTest. It opens a context menu. The menu
> is dismissed by clicking the mouse outside of it. The underlying view gets
> the mouse event after the context menu has exited.
> 
> See also: https://chromiumcodereview.appspot.com/11761027
> 
> BUG=171891
> TEST=manual
> Run: 
> out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'
> 
> Review URL: https://chromiumcodereview.appspot.com/12087075

TBR=sschmitz@chromium.org
Review URL: https://codereview.chromium.org/12207141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182067 0039d316-1c4b-4281-b951-d872f2087c98

TBR=willchan
BUG=175563
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12212149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182066 0039d316-1c4b-4281-b951-d872f2087c98

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Use_of_const tells me not to use const where it's confusing. The instances of const removed by this CL are definitely confusing since they aren't even part of the interfaces they're written in. Worse yet, our Windows compiler gives errors if you override without matching them.

This issue is upstream of https://codereview.chromium.org/12192005/ (Add simple cache backend), and must land before it so as to not break the windows build.

R=rvargas@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/12207120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182065 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Mark async texture uploads as completed from the upload thread.
> 
> This reduces the latency between when an upload completes and when the
> client is notified.
> 
> BUG=173802
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12213073

TBR=reveman@chromium.org
Review URL: https://codereview.chromium.org/12211144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182063 0039d316-1c4b-4281-b951-d872f2087c98

Opus extension to mimetype map so files with .opus play instead of download, if enabled with --enable-opus-playback.
BUG=174280
TESTED=try bots
Review URL: https://codereview.chromium.org/12221108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182061 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-dual-core/moz/ws_peak_r: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=350&rev=182006&graph=ws_peak_r

TBR=cmp@chromium.org
BUG=175856
Review URL: https://codereview.chromium.org/12223112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182059 0039d316-1c4b-4281-b951-d872f2087c98

Also added public template for app_intents.html doc back in so that previous bookmarks do not result in a 404.

Note that I've repeated the deprecation warning under each <h2> in case a developer winds up in a section via search. Eventually we will want to add an 'Instead, use...' sentence/paragraph once this is defined and at the same time
remove the bulk of content in place.

BUG=174262

Review URL: https://codereview.chromium.org/12211131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182058 0039d316-1c4b-4281-b951-d872f2087c98

TBR=koz@chromium.org
BUG=175823
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12218129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182057 0039d316-1c4b-4281-b951-d872f2087c98

Zero behavioral change to the on-the-wire format nor protocol semantics.

This lands server change 40997047.

Also create spdy_protocol.cc and move some functions to it to
avoid clang warnings.


Review URL: https://chromiumcodereview.appspot.com/12220116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175854
TBR=benm@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12211141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182052 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that the AppListController class which lives in app_list_controller_win.cc plays nice with AURA and ASH.

For ASH on Windows 8 we defer calls to open and hide the apps list to the ash Shell via the ToggleAppList member
function in the Shell class.

For AURA the fixes were mostly around retrieving the native window for the view appropriately, i.e via RootWindow::GetAcceleratedWidget

This also fixes the AppInstallConfirmation and AppInstallConfirmation_Incognito browser tests for AURA.

I added a class AppListControllerAsh which inherits from the AppListController class and
overrides the ShowAppList/DismissAppList functions to display the ASH specific app lists.

This also fixes the startup crash in desktop chrome observed when displaying the app list
as we were deferencing a NULL ash shell pointer.

The app_list_controller_ash.cc functionality is disabled for Windows and is provided by the newly
added AppListControllerAsh class which lives in the app_list_controller_win.cc file.

BUG=174940, 174399, 174504, 175389

TEST=covered by existing Browser tests for desktop chrome AURA.
Review URL: https://codereview.chromium.org/12210102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182051 0039d316-1c4b-4281-b951-d872f2087c98

Events arising from clicks on instance elements in SVG <use> trees may have their
target changed when the instance tree is rebuilt during event processing. In this
case the toNode() call will return NULL for the target.

BUG=171363

Review URL: https://chromiumcodereview.appspot.com/12248003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182049 0039d316-1c4b-4281-b951-d872f2087c98

This allows user-level activation of Google Update from a cached system-level GoogleUpdateSetup.exe, even if the latter is a tagged meta installer.

R=grt@chromium.org
BUG=175028


Review URL: https://chromiumcodereview.appspot.com/12250005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182048 0039d316-1c4b-4281-b951-d872f2087c98

document.all is not available to Apps v2, so menus were previously not
dismissable. I could use document.body.parentNode, but I can't think of
any good reason to attach the event handler to <html> instead of <body>.

Review URL: https://codereview.chromium.org/12208141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182046 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12207089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182042 0039d316-1c4b-4281-b951-d872f2087c98

> Partially revert "Don't include web apps with empty names into autocomplete search."
> 
> This reverts commit http://src.chromium.org/viewvc/chrome?view=rev&revision=154070.
> Changing manifest was unnecessary to fix Omnibox issue.
> But change introduced unexpected issue with cloud print dialog hosted under www.google.com/cloudprint/
> 
> If dialog needs to "Sign in" and app's urls list includes dialog url, then "Sign in" is opened in new windows instead of current one. It completely breaks cloud print flow.
> 
> 
> BUG=170301
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12030002

BUG=170301,175696
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/12223111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182041 0039d316-1c4b-4281-b951-d872f2087c98

> Make base compile with no "using base::FilePath".
> 
> For base .cc files not using the base namespace, I added a using since theses
> files should be moved to the base namespace, and then explicit qualification
> will no longer be necessary.
> 
> Review URL: https://codereview.chromium.org/12226121

TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/12207132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182040 0039d316-1c4b-4281-b951-d872f2087c98

* Remove related methods in Extension: Set/GetCachedImage
* Remove related unit tests
* Update all comments mentioning ImageLoadingTracker to mention ImageLoader instead

BUG=163929
TBR=sky@chromium.org (for mechanical changes in chrome/.)

Review URL: https://chromiumcodereview.appspot.com/12213093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182039 0039d316-1c4b-4281-b951-d872f2087c98

Added a unit-test to BookmarkBarViewTest. It opens a context menu. The menu
is dismissed by clicking the mouse outside of it. The underlying view gets
the mouse event after the context menu has exited.

See also: https://chromiumcodereview.appspot.com/11761027

BUG=171891
TEST=manual
Run: 
out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'

Review URL: https://chromiumcodereview.appspot.com/12087075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182037 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we were asynchronously reading the manifest at start-up and using
chrome.runtime.getDetails when logging the version string. The latter is more
complicated than it needs to be, and the former doesn't work in Apps v2.

Review URL: https://codereview.chromium.org/12250011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182036 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12224106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182035 0039d316-1c4b-4281-b951-d872f2087c98

It passes locally but fails on the bots. Disabling for now.

BUG=175753

Review URL: https://chromiumcodereview.appspot.com/12217139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175838
TBR=cpu

Review URL: https://codereview.chromium.org/12224122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182033 0039d316-1c4b-4281-b951-d872f2087c98

For base .cc files not using the base namespace, I added a using since theses
files should be moved to the base namespace, and then explicit qualification
will no longer be necessary.

Review URL: https://codereview.chromium.org/12226121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182032 0039d316-1c4b-4281-b951-d872f2087c98

> [cc] Add gl-matrix to cc-frame-viewer 3rd party
> 
> R=vmpstr
> 
> Review URL: https://codereview.chromium.org/12250012

TBR=nduca@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182031 0039d316-1c4b-4281-b951-d872f2087c98

So we confirmed the random crashes have nothing to do with the tests: the cause must be in the content browsertests harness.

BUG=165269
TES=win gpu bots
TBR=kbr
Review URL: https://codereview.chromium.org/12221151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167114
TBR=dimich,dpolukhin

Review URL: https://chromiumcodereview.appspot.com/12220125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182029 0039d316-1c4b-4281-b951-d872f2087c98

Use "GetProtectedFileContents" for obtaining memory usage and fetch perf test data from instrumentation tests.

BUG=175127


Review URL: https://chromiumcodereview.appspot.com/12212137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182028 0039d316-1c4b-4281-b951-d872f2087c98

In WebAudio this can lead to oob reads.  In HTML5 this will cause
garbled audio or oob reads depending on the sample format.  The
guards in place just ensure channel count nor sample format change
between demux and decode.

Video already has similar guards in place via the checks done in
VideoFrame::IsValidConfig during buffer allocation.

BUG=166565
TEST=unit tests pass under ASAN.


Review URL: https://chromiumcodereview.appspot.com/12224114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182027 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=155525


Review URL: https://chromiumcodereview.appspot.com/12223091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182026 0039d316-1c4b-4281-b951-d872f2087c98

Main uninstall should be done in parent process. Child process should only delete program directory. Otherwise Windows sees that uninstall reg path still exists and shows error.


Review URL: https://chromiumcodereview.appspot.com/12211125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182025 0039d316-1c4b-4281-b951-d872f2087c98

bauerb is such a perfectionist.

BUG=175629
TBR=bauerb

Review URL: https://codereview.chromium.org/12218124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174873, 170629


Review URL: https://chromiumcodereview.appspot.com/12220089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182023 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182022 0039d316-1c4b-4281-b951-d872f2087c98