- 16 Jun, 2014 40 commits
-
-
dcheng@chromium.org authored
The main frame might be null, so we need to check that before trying to dereference it to see if it's a local frame. BUG=385162 Review URL: https://codereview.chromium.org/334323002 git-svn-id: svn://svn.chromium.org/blink/trunk@176245 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
Force the use of fully aliased text for certain common east asian fonts at smaller font sizes to ensure that text is legible. This is only required for fonts without an embedded bitmap at a the specific size and the minimum size for enabling anti aliasing is set on a per font basis. BUG=383090,383040 R=dglazkov@chromium.org, cpu@chromium.org Review URL: https://codereview.chromium.org/339693002 git-svn-id: svn://svn.chromium.org/blink/trunk@176244 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hartmanng@chromium.org authored
Universal accelerated overflow scroll doesn't paint highlight gaps between scroll children because the scrolling contents layer isn't always set up to draw content. BUG=381185,381187 Review URL: https://codereview.chromium.org/303253004 git-svn-id: svn://svn.chromium.org/blink/trunk@176243 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eseidel@chromium.org authored
BUG=371746 Review URL: https://codereview.chromium.org/339703002 git-svn-id: svn://svn.chromium.org/blink/trunk@176241 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@chromium.org authored
TEST=none BUG=383749 R=dglazkov@chromium.org Review URL: https://codereview.chromium.org/334263005 git-svn-id: svn://svn.chromium.org/blink/trunk@176240 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ch.dumez@samsung.com authored
Have NodeList::item() overrides return an Element* when appropriate instead of a generic Node*. This makes it clear to callers that these are actually returning Elements and avoids unnecessary isElementNode() checks or casts that look unsafe. R=adamk@chromium.org, esprehn@chromium.org Review URL: https://codereview.chromium.org/331863003 git-svn-id: svn://svn.chromium.org/blink/trunk@176239 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eroman@chromium.org authored
[webcrypto] Require importKey() for JWK to provide data as a Javascript object rather than a JSON arraybuffer. BUG=373917,245025 Review URL: https://codereview.chromium.org/336173002 git-svn-id: svn://svn.chromium.org/blink/trunk@176238 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
This CL takes care the page, plugins, rendering, and svg subdirs under core. BUG=381876 Review URL: https://codereview.chromium.org/334223005 git-svn-id: svn://svn.chromium.org/blink/trunk@176237 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
arv@chromium.org authored
Original patch from http://trac.webkit.org/changeset/169849 We were getting the length of the string before calling lower() on it but we were looping over the new string which might have a different length than the original. BUG=383704 Review URL: https://codereview.chromium.org/333643008 git-svn-id: svn://svn.chromium.org/blink/trunk@176235 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
This CL takes care the inspector and loader subdirs under core. BUG=381876 Review URL: https://codereview.chromium.org/337873003 git-svn-id: svn://svn.chromium.org/blink/trunk@176234 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
robhogan@gmail.com authored
We currently use 26-bits in RenderBlock to cache the result of RenderStyle::computedLineHeight(). However when you look at the computations behind that function the main components are already cached so at most we are saving a handful of computations per call. In https://codereview.chromium.org/256593009/ we added a test that calls RenderBlock::lineHeight() ~425,000 times on each run. This CL results in no measurable degradation in performance against that test. So since we cannot get a measurable improvement in performance as a result of the caching when testing locally, remove it and free up space for more useful bits in RenderBlock. We will let it cycle through the perf bots for a while before allowing people to start using the spare bits though. The cached result originally sat in RenderText and was inherited from the fork from KHTML. http://trac.webkit.org/changeset/6010 moved it to RenderBlock on the basis that "calls to fontMetrics().lineSpacing() are expensive." This is no longer the case as far as I can tell, since both lineSpacing() and fontMetrics() are now cached themselves. Review URL: https://codereview.chromium.org/260073005 git-svn-id: svn://svn.chromium.org/blink/trunk@176233 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
WebLocalFrameImpl::createChildFrame needs to keep a reference to the WebCore::LocalFrame in case LocalFrame::init() detaches the frame. BUG=384890 TEST=fast/loader/create-frame-in-DOMContentLoaded.html R=abarth@chromium.org Review URL: https://codereview.chromium.org/339513002 git-svn-id: svn://svn.chromium.org/blink/trunk@176232 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
schenney@chromium.org authored
Revert of Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/339683002/) Reason for revert: Revert the revert because the bot went green even without this revert, and other bots had no trouble. Original issue's description: > Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) > > Reason for revert: > This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 > > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() > #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f2c232cd4a0 \u003Cunknown> > #3 0x7f2c2337f313 __poll > #4 0x7f2c240b6036 \u003Cunknown> > #5 0x7f2c240b6164 g_main_context_iteration > #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() > #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() > #8 0x7f2c2a2f69d8 base::RunLoop::Run() > #9 0x00000466bd59 content::RunThisRunLoop() > #10 0x00000466c1b8 content::MessageLoopRunner::Run() > #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() > #12 0x0000011fdf00 MediaBrowserTest::RunTest() > #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() > #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() > #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() > #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() > ... > > Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. > > Original issue's description: > > IDL: Support optional argument default value syntax > > > > Adds support for parsing default values of different types, but > > only handles null default values when generating code. > > > > Replaces existing > > > > [Default=Null] optional SomeInterface arg > > [Default=NullString] optional DOMString arg > > > > with the now equivalent > > > > optional SomeInterface arg = null > > optional DOMString arg = null > > > > in IDL files, and drops support for those [Default] attributes. > > > > No changes to generated code. > > > > BUG=258153 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 > > TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com > NOTREECHECKS=true > NOTRY=true > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339723002 git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dgozman@chromium.org authored
This change moves most of the emulation under |emulateDevice| setting. BUG=327641 Review URL: https://codereview.chromium.org/330223004 git-svn-id: svn://svn.chromium.org/blink/trunk@176230 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
malch@chromium.org authored
Review URL: https://codereview.chromium.org/331143005 Review URL: https://codereview.chromium.org/331143005 git-svn-id: svn://svn.chromium.org/blink/trunk@176229 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
BUG=361045 Review URL: https://codereview.chromium.org/337123002 git-svn-id: svn://svn.chromium.org/blink/trunk@176228 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Url for this event is retrieved from imageURL field later in the same switch. BUG=361045 Review URL: https://codereview.chromium.org/339603002 git-svn-id: svn://svn.chromium.org/blink/trunk@176227 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kozyatinskiy@google.com authored
1. Open page with javascript 2. Add breakpoint 3. Stop on breakpoint 4. Use live edit and save script The test worked for Chromium revision until May 30. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176101 Review URL: https://codereview.chromium.org/329533002 git-svn-id: svn://svn.chromium.org/blink/trunk@176226 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
philipj@opera.com authored
This is based on Aaron Colwell's patch: https://codereview.chromium.org/170233009/#ps270001 BUG=249427 TEST=LayoutTests/media/avtracklists.html Review URL: https://codereview.chromium.org/284513003 git-svn-id: svn://svn.chromium.org/blink/trunk@176224 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
There use to be isBackground field on Timeline events but it has been removed. BUG=None Review URL: https://codereview.chromium.org/334743008 git-svn-id: svn://svn.chromium.org/blink/trunk@176223 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timvolodine@chromium.org authored
Implement Battery Status API using promises in blink as according to the (modified) spec: https://dvcs.w3.org/hg/dap/raw-file/tip/battery/Overview.html. Using this patch the Battery Status API is accessible using: navigator.getBattery().then(...) syntax. Also added layout tests for the various use-cases. BUG=122593, 360068 Review URL: https://codereview.chromium.org/329723005 git-svn-id: svn://svn.chromium.org/blink/trunk@176222 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aandrey@chromium.org authored
BUG=272416 R=yurys@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/332493002 git-svn-id: svn://svn.chromium.org/blink/trunk@176221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
schenney@chromium.org authored
Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) Reason for revert: This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f2c232cd4a0 \u003Cunknown> #3 0x7f2c2337f313 __poll #4 0x7f2c240b6036 \u003Cunknown> #5 0x7f2c240b6164 g_main_context_iteration #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() #8 0x7f2c2a2f69d8 base::RunLoop::Run() #9 0x00000466bd59 content::RunThisRunLoop() #10 0x00000466c1b8 content::MessageLoopRunner::Run() #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() #12 0x0000011fdf00 MediaBrowserTest::RunTest() #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() ... Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. Original issue's description: > IDL: Support optional argument default value syntax > > Adds support for parsing default values of different types, but > only handles null default values when generating code. > > Replaces existing > > [Default=Null] optional SomeInterface arg > [Default=NullString] optional DOMString arg > > with the now equivalent > > optional SomeInterface arg = null > optional DOMString arg = null > > in IDL files, and drops support for those [Default] attributes. > > No changes to generated code. > > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339683002 git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
clamy@chromium.org authored
This CL removes the setting of the first party for cookies url from FrameFetchContext::addAdditionalRequestHeaders. For request going through the ResourceFetcher, it will be added in content::RenderFrameImpl::willSendRequest (see https://chromiumcodereview.appspot.com/317853002/). Other users of the function (BeaconLoader, PingLoader) can use a new specific function of FetchContext. BUG=376025 Review URL: https://codereview.chromium.org/314093002 git-svn-id: svn://svn.chromium.org/blink/trunk@176219 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sungmann.cho@navercorp.com authored
BUG=none TEST=compile Review URL: https://codereview.chromium.org/331083003 git-svn-id: svn://svn.chromium.org/blink/trunk@176218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Avoids its unnecessary persistents by doing so. R=tkent@chromium.org BUG=357163 Review URL: https://codereview.chromium.org/333313002 git-svn-id: svn://svn.chromium.org/blink/trunk@176217 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
This CL takes care the rest part of html subdirs under core. BUG=381876 Review URL: https://codereview.chromium.org/338123002 git-svn-id: svn://svn.chromium.org/blink/trunk@176216 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
amikhaylova@google.com authored
BUG=376194 Review URL: https://codereview.chromium.org/337753004 git-svn-id: svn://svn.chromium.org/blink/trunk@176215 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
Now that we may fetch a lot of trace (or buffered timeline) events after timeline is stopped, we need a better indication of that. The button remaining red after it's pressed is very annoying. Let's turn it off and disable till we get all the events, and if the progress pane is on, display the appropriate message there. BUG=361045 Review URL: https://codereview.chromium.org/322403004 git-svn-id: svn://svn.chromium.org/blink/trunk@176214 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
BUG=354447 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174557 Review URL: https://codereview.chromium.org/267393003 git-svn-id: svn://svn.chromium.org/blink/trunk@176213 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eustas@chromium.org authored
BUG=245436 Review URL: https://codereview.chromium.org/337973004 git-svn-id: svn://svn.chromium.org/blink/trunk@176211 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kangil.han@samsung.com authored
This CL deletes unneeded mutable keyword by removing const keyword on setter functions. Review URL: https://codereview.chromium.org/337113002 git-svn-id: svn://svn.chromium.org/blink/trunk@176210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
schenney@chromium.org authored
TBR=dpranke BUG=385015 Review URL: https://codereview.chromium.org/338093003 git-svn-id: svn://svn.chromium.org/blink/trunk@176209 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/332203002 git-svn-id: svn://svn.chromium.org/blink/trunk@176208 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dominik.rottsches@intel.com authored
Second blink side change, part 3 of the series in total. BUG=382411 R=eae,behdad,tkent Review URL: https://codereview.chromium.org/323963002 git-svn-id: svn://svn.chromium.org/blink/trunk@176207 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Avoids keeping a bare pointer to the current anchor from the client implementation object. R=ager@chromium.org,zerny@chromium.org,haraken@chromium.org,tkent@chromium.org BUG=340522 Review URL: https://codereview.chromium.org/334153003 git-svn-id: svn://svn.chromium.org/blink/trunk@176206 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
TimelinePresentationModel.Record now has three implementations: one for root record, one for coealesced record and one for representing actual TimelineModel.Record. This allows it to work fine with Timeline based on trace events. BUG=361045 R=caseq@chromium.org Review URL: https://codereview.chromium.org/337023004 git-svn-id: svn://svn.chromium.org/blink/trunk@176205 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/332173002 git-svn-id: svn://svn.chromium.org/blink/trunk@176204 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mlamouri@chromium.org authored
The mock is currently assuming that the screen orientation is handled by a RendererWebKitPlatformSupportImpl which is no longer the case. It will move to be part of WebFrameTestProxy but that will require a two sided patch so we should first disable the false-negative. BUG=162827 Review URL: https://codereview.chromium.org/339553003 git-svn-id: svn://svn.chromium.org/blink/trunk@176203 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
With GeolocationController (now back) on the heap, maintain a persistent set of them from GeolocationInspectorAgent. R=haraken@chromium.org,ager@chromium.org,zerny@chromium.org BUG=304341 Review URL: https://codereview.chromium.org/332153002 git-svn-id: svn://svn.chromium.org/blink/trunk@176202 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-