- 25 Nov, 2019 40 commits
-
-
Daniel Rubery authored
The ternary operator here was backwards, with light mode colors being used when the system is in dark mode, and vice versa. Change-Id: Id6788f601a4cd741fb6ddce6ebe1aeb8fb44f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933386 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#718800}
-
Kristi Park authored
The actual screenshot image editor implementation lives downstream in Clank and should be used over the upstream implementation. See go/chrome-screenshotz-dd Bug: 1024586 Change-Id: Ia79a8ea9b9d95e40a5965168be435d325dc68b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931270 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#718799}
-
Theresa Wellington authored
Some clean-up from nits in http://crrev.com/c/1929262. BUG=1018170 Change-Id: Ib062e2ed3f512d3d3789099424534412519f5025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934449Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718798}
-
Lily Chen authored
Bug: 1007122 Change-Id: I1fd2715b5d18b512d3b498779c5e9495c2a6ed44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929986Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#718797}
-
Shawn Gallea authored
This is needed to prevent a crash where WebContentController::AttachTo is called after the controller is destroyed. Bug: Internal b/144546163 Bug: Internal b/144861135 Test: Compile cast_shell Change-Id: I71b05e3f6d404a4044c623a1712650e4f459e85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934652Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#718796}
-
Joe Downing authored
The Chrome app has been deprecated and replaced by a website. I am now cleaning up references to it throughout Chromium with the eventual goal of removing the code. Change-Id: I1e43659c82c79bb3a25b907496ee406b250e8e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926538Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#718795}
-
Khushal authored
Most code uses the StaticBitmapImage factory method for creating accelerated or unaccelerated versions of this class using an SkImage, which directs to the corresponding sub-class. As a first step towards removing support for creating an AcceleratedStaticBitmapImage with an SkImage, remove this method and have the call-sites explicitly create the sub-class based on whether the SkImage is texture backed. Subsequent patches will transition these cases to use shared images instead for allocating the texture's memory backing. The accelerated image can then be created using the shared image mailbox. R=fserb@chromium.org TBR=tsepez@chromium.org Bug: 962630 Change-Id: Ic3c7f05918c8fa9d2dd8bf365e56bffbab908a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925245 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718794}
-
Marc Treib authored
ProfileSyncService::GetTransportState() used to DCHECK that the engine doesn't exist if IsEngineAllowedToStart() is false. However, we *can* temporarily be in that state during ShutdownImpl(). Since it's not easily possible to check the relaxed condition, this CL removes the DCHECK. Bug: none Change-Id: Ie9361246208a69761830715f2c04c0370314d183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917771Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718793}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/800129711d28..0ab6a9f6e41a git log 800129711d28..0ab6a9f6e41a --date=short --first-parent --format='%ad %ae %s' 2019-11-25 ehmaldonado@chromium.org depot_tools: Use system's python for vpython. Created with: gclient setdep -r src/third_party/depot_tools@0ab6a9f6e41a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I88db8b8a169d4ab5f68b0fedb27750219ddefaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718792}
-
Bo Liu authored
If webview is in software mode, then 2d canvas are created in software mode. Make sure this works by getting the bitmap of a solid color canvas. Bug: 1027161 Change-Id: I99c547eb301f81940ea22ff8388243e3b711312d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932418Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718791}
-
Jasper Chapman-Black authored
Change-Id: Ic53887c62d7907f096520b5074fd55195c1ec530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933382 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718790}
-
Peter Kotwicz authored
This CL makes WebappActivity use CustomTabStatusBarColorProvider BUG=997793 R=peconn, dominickn TBR=yfriedman (for location of ThemeTestUtils.java) Change-Id: Ie964caea7e7708d88934fcb16d226d7f155203df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858605Reviewed-by:Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718789}
-
Adenilson Cavalcanti authored
It seems that some years ago clang@Windows didn't have the proper intrinsic required, which prompted the use of inline ASM. It has a side effect in that it will allow compilation of the optimized function within the same compilation unit while using regular compiler flags (i.e. 'crc32' instruction on x86 requires some special compiler flags). Main issue is that inline ASM is blocked on dependencies (e.g. 'base') that will be linked to NaCl. The main idea here is to allow the whole Chromium code base to use the highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported through an interface (i.e. base::Crc32()). This patch fixes this issue by removing the use of inline ASM. The workaround is to use clang/gcc 'target attributes' to instruct the backend to use different code generation options for the optimized function, see: https://clang.llvm.org/docs/AttributeReference.html#target Bug: 902789 Change-Id: I0d139268aefb8335310c0e3f6533006be9af6470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931272Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#718788}
-
Nathan Zabriskie authored
This CL replaces references to GLInterface with RasterInterface in CanvasResourceSwapChain to help the transition to OOP rasterization in Canvas2D. Bug: 1023254 Change-Id: I3706ec9d7defa2dc49a6c01bdd4e50e5d18c4344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928637Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718787}
-
James Hawkins authored
This is no longer accessed from JS/HTML. R=hansberry@chromium.org, reillyg@chromium.org Bug: 894585 Test: none Change-Id: Ibfde36a2c8f5c0e2c1853d85ca30d2f8f59121da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932169Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#718786}
-
Annie Sullivan authored
Change-Id: Idf3a61002fbeae07f76b57d8f0a62c650ee33562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933373Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718785}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f58d391f. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." 79b9ec84 "Port webkit-mask-position-interpolation to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I140ecf2f23cdd1520c066e28c4aa4757e501f986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934488Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718784}
-
Brian Sheedy authored
Re-enables the BrowserMinidumpTests on ChromeOS since the CL that was supposedly causing extra crash dumps to appear unexpectedly on Betty devices has been reverted. TBR=crouleau@chromium.org Bug: 1014754 Change-Id: I93645b8fb8994ad9e7506d7e2a07e4ce520c03f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933596Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#718783}
-
Owen Min authored
This reverts commit 9256783c. Reason for revert: This CL may be responsible for multiple All/Overview* flaky use-of-uninitialized-value. First failed build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16416?blamelist=1#blamelist-tab Because the original CL has been landed for few days, the change in tools/metrics/histograms/histograms.xml are not reverted due to merge warning. Original change's description: > Cros: Add metrics for transitions in the hotseat > > Report animation smoothness for the transition into the hotseat in the > HomeLauncher. > > Bug: 1022178, 1022177 > Change-Id: I5dc5e76688aa5a88bcabb5d688b419d819932867 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917941 > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Nik Bhagat <nikunjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718266} TBR=nikunjb@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1022178, 1022177, 1028255 Change-Id: If460f00f10fb8f8df2a9f7d3d41abfdd91f0ad0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933739 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#718782}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61169e9c4794..4a327bcb1019 git log 61169e9c4794..4a327bcb1019 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 herb@google.com Fix chrome build bots 2019-11-25 herb@google.com Structured binding for SkZip and SkEnumerate 2019-11-25 herb@google.com Simplify SubRun structure in GrTextBlob Created with: gclient setdep -r src/third_party/skia@4a327bcb1019 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I121c7bf090c7586fac33f8e24e476b9db7332164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933380Reviewed-by:
-
Yusuke Sato authored
This will make it easier to detect unibuild-related VM configuration errors. BUG=b:123309049 TEST=try, git cl lint Change-Id: Ie0dae50fe7df6a517ec3f41872e7e00a1e4aa8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931747 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#718780}
-
Michael Spang authored
GetKeyboardLayoutEngine() has the side effect of creating a stub keyboard layout engine if there's no previous layout engine. Avoid this as it shouldn't be necessary and it creates ordering dependencies between tests. In particular, running EventConverterEvdevImplTest after XkbLayoutEngineVkTest causes a crash when we enable use_xkbcommon in GN. This shows up as a flaky failure on infra: flaky failures [ignored]: EventConverterEvdevImplTest.KeyPress Removing the implicit initialization required fixes to a few components: - KeyEvent tests must create a layout engine if they call GetDomKey or GetCharacter - ozone/x11 needs to provide a layout engine to chromium. There was no layout engine support in that component at all. This needs followup work as Linux builds that need proper keyboard layout support need to use XkbKeyboardLayoutEngine rather than StubKeyboardLayoutEngine. - Chromedriver needs to create a layout engine if run headlessly in X11 (USE_X11) builds without an X display. This is a particularly unusual case as we've building ozone code in a non-ozone build. This patch makes those components create a StubKeyboardLayoutEngine explicitly, which is equivalent to the previous implicit behavior. KeyEvent tests that rely on the global layout (because they call GetDomKey or GetCharacter) now use ScopedKeyboardLayout, which has been updated to create a StubKeyboardLayoutEngine under the hood. If more control is required, a custom layout engine can be provided via ScopedKeyboardLayoutEngine (ozone specific). Bug: 1026406 Change-Id: I925ed2d0de880e19eaee41a2b36595fea467b6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928250Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718779}
-
Owen Min authored
This reverts commit d96236b5. Reason for revert: This may cause "WebKit Linux Leak" failure First failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/7276 Original change's description: > Sanitize style elements in clipboard markup > > This patch sanitizes clipboard markup before pasting it into document > by removing all pasted style elements and serializing them onto > elements as inline style. In this way, we stop stylesheets in clipboard > markup from being applied to the original elements in the document. > > This patch follows the same approach as in WebKit [1]: > - First create a dummy document to insert the markup > - Then computes style and layout in the dummy document > - Re-serialize the dummy document as the markup to be inserted. This > reuses the code path that we serialize a selection range into > clipboard, where we need to serialize element computed style into > inline styles so that the element styles are preserved. > - Make sure all style elements are removed before inserting markup > into document > > This patch also adds a complete test to ensure that content pasted from > Excel is still properly styled, which is the main reason we used to > preserve style elements in clipboard markup [2]. > > [1] https://trac.webkit.org/changeset/223440 > [2] http://crbug.com/121163 > > Bug: 1017871 > Change-Id: I3bb5a4ae7530a3fdef5ba251975e004857c06f1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922919 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718281} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017871, 1027386 Change-Id: I1d500647d6227c9be3ae14d9604ba702e9c29834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933452Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718778}
-
Tim Song authored
BUG=1027262 Change-Id: Id6745691e05f337a41de1aff2c5cbda558f85c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929617Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718777}
-
Vladimir Levin authored
This patch puts an early out for cases where the layout (for position) or paint (for pagination) is blocked by the display lock. This takes the growing update time on the referenced bug (example in comment 17) from ~8ms per frame to ~1ms per frame on my linux desktop. R=chrishtr@chromium.org Bug: 999486 Change-Id: I1c7a2a1948371c61565c079d30341c0ee4c7e8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934509Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#718776}
-
Joshua Bell authored
Converting script values to Indexed DB keys is a recursive algorithm in the spec. The implementation is naively recursive as well, but this can hit stack limits on some configurations (compiler, OS, build type, etc). Convert the implementation to do recursion on the heap instead of the stack. No functional changes. Bug: 1022460 Change-Id: I7292d38113d540c5bdf725c8354e19e1e13b0f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921636 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#718775}
-
Lily Chen authored
Bug: 807144 Change-Id: Ia7d6f83381509113b6601839b5c1d8eacdbc4860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929985Reviewed-by:
-
Yusuke Sato authored
* Add setters for testing to arc::FileSystemStatus * Add CreateArcVmClientAdapterForTesting() that allows the unit tests to rewrite the FileSystemStatus object BUG=b:123309049 TEST=try, git cl lint Change-Id: Id1054af7343c02d0f345b24ebd9546faeb98d774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931541 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Follow-up CL will change the JNI API to restrict reading and writing to these keys only. Bug: 1022108 Change-Id: Ibf61af08dbffbe44f92977cc3127c0e568661af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930692Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#718772}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8e9c3f663ccd..e9356045a4e0 git log 8e9c3f663ccd..e9356045a4e0 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 rharrison@chromium.org Rolling 3 dependencies Created with: gclient setdep -r src/third_party/dawn@e9356045a4e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8c5397947208aa856122b44bb4b7588c6c999d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933759Reviewed-by:
-
Owen Min authored
The test was mistakely disabled on all platforms but Mac. However, it should be disabled in the exactly opposite way. Tbr: dpapad@chromium.org Bug: 1028129 Change-Id: Ie54a98fe84db3be5a8989bd9cf1553591c69f067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933597Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718770}
-
John Lee authored
This CL moves away from listening on the generic window onfocus event and moves towards sending a custom WebUI event when the AccessiblePane receives focus. This resolves 2 main issues: (1) Visual focus indicators being visible on focus caused by touch. (2) The tab strip scrolls to the very first tab on tap because the first tab immediately becomes focused on window focus. Bug: 1017472 Change-Id: I8565b2e244a205791ba81eca23ba5a475c2f441c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929447 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#718769}
-
Ahmed Mehfooz authored
This CL includes a fix for a heap use after free error that existed in the previous submission. Bug: 1025050 Change-Id: I4928100f7a2599beb17741ec5f0ab22774385c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931411 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718768}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4a36ad5..96a59c93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9bf276084e93ccdd226a594af2d3d441e6d4450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934487Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718767}
-
David Black authored
The default focus ring is an undesired blue box that appears around the view when focused. Since we use custom highlighting for suggestion chips, similar to Assistant buttons, this should be removed. Bug: b:144404660 Change-Id: I4599c4d925bdbffcd59a901bf2979c850465315f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934513Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#718766}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e87972e30da4..f20323a4a264 git log e87972e30da4..f20323a4a264 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 tsepez@chromium.org Use PartitonAlloc to buffer some vectors in gif. Created with: gclient setdep -r src/third_party/pdfium@f20323a4a264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: If94bcfb9063917c6538bd15cb8f15e3ce9aa2d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933757Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/712a26f3842b..f534a6404772 git log 712a26f3842b..f534a6404772 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 gustaf@webrtc.org AEC3: Sub-band nearend detector 2019-11-25 ssilkin@webrtc.org Allow min start bitrate to be lower than min bitrate. 2019-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0ec8ef3c..e0dd604c (718517:718623) 2019-11-25 philipel@webrtc.org Fix VideoStreamEncoder to not reference encoded data from the RunPostEncode task. Created with: gclient setdep -r src/third_party/webrtc@f534a6404772 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:b/130016532,chromium:none,chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie49d39846129313cef04a70187b5e06fcba80c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933755Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<HTMLAreaElement>(element) in place of IsHTMLAreaElement(element) Bug: 891908 Change-Id: Ie3f3eeae304c0ae607531816c2d9782c0fdf365b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930537Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#718763}
-
Sky Malice authored
https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/9bf9b18f0a70..136d75fa6580 $ git log 9bf9b18f0..136d75fa6 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 dbaileychess Changed null checks in test. Removed verifier pointer usage (#5634) 2019-11-19 31897320+vglavnyy Add testing of C++ with sanitizers (CI-Docker) (#5631) 2019-11-19 i add namespace prefix in FLATBUFFERS_MAX_BUFFER_SIZE (#5629) 2019-11-15 malarkannan.invention Support for python grpc - continuing the work from the pull request #4270 #4705 (#5613) 2019-11-14 dbaileychess Removed idl_gen_general.cpp and move contents to code_generators.cpp (#5625) 2019-11-14 dbaileychess Lua cleanup (#5624) 2019-11-14 dbaileychess [C++] Adds basic schema evolution tests (#5611) 2019-11-11 dbaileychess [C++, C#, Java] Separated C# and Java generators into their own classes (#5618) 2019-11-11 Captfrozenberg add check for root_type specified for json schema generation (#5622) 2019-11-12 messense [Rust] Bump smallvec version to 1.0 (#5621) 2019-11-11 dbaileychess Ran src/clang-format-all.sh (#5617) 2019-11-07 aardappel Improved pull request & clang-format instructions. 2019-11-07 derekbailey Change monster_extra generation to use flatbuffers::unique_ptr (#5612) 2019-11-07 derekbailey [C++] Refactor to conform to Google C++ style guide (#5608) 2019-11-04 aardappel Fixed deprecated method in GRPC Java test. 2019-11-04 aardappel Fixed Apache license not using canonical version. 2019-11-04 even.rouault include/flatbuffers/base.h: fix no_sanitize issue with old clang (#5610) 2019-11-04 dbaileychess [C++, Java, C#, TypeScript, JavaScript] Skip generation of mutable union types (#5599) 2019-11-04 even.rouault flatbuffers.h: fix documentation warning (#5607) 2019-11-04 dbaileychess Add Lua FlatbufferBuilder Clean() method to enable reuseable builders (#5606) 2019-11-04 paulovictor.pinheiro [Kotlin] Fix union vector accessor after change in Java API (#5605) 2019-11-04 paulovictor.pinheiro [flatc] Remove an always true condition for flexbuffers (#5604) 2019-11-04 llchan [Go] Add UnPackTo functions (#5598) 2019-10-31 me [Go] Object API support (#5339) 2019-10-28 freaken Rust: Add idiomatic iterator for Vector type (#5579) 2019-10-28 even.rouault Fix typos in comments (#5590) 2019-10-28 dbaileychess C++ verifier for evolved union fields should return true (#5586) 2019-10-28 dbaileychess Add ByteBuffer copy for vector of bytes in Java (#5587) 2019-10-28 freaken Rust: Fix Copy and Clone impls for a few generic types (#5577) 2019-10-22 31897320+vglavnyy Add `--clean-first` to the cmake-build command (travis) (#5574) 2019-10-19 ojaslandge Fix Follow implementation for bool (#5554) 2019-10-19 31897320+vglavnyy Fix issue #5557 (#5573) 2019-10-18 bjornharrtell Avoid intentional unsigned integer overflow getting caught by sanitizers (#5572) 2019-10-18 bharat.tak Python: Add forceDefaults opt to python Builder (#5564) 2019-10-17 jaceks Java: Don't annotate vector-of-tables item getters with @nullable. (#5562) 2019-10-17 aardappel Fixed warnings generated by recent JSON sorting feature. 2019-10-18 ishinberg0 [Java] byte buffer factory returned buffer capcity is used instead of the requested size (#5558) 2019-10-17 gunter.burchardt #5544 Fix of Array of table is not sorted if Create<type>Direct() is used (#5546) 2019-10-15 BrianHarris Fix build with gcc version 7.4.0 (#5570) 2019-10-10 aardappel Fixed JSON parser not sorting vectors of tables/structs with key. 2019-10-04 paulovictor.pinheiro [FlexBuffers][Java] Cache size of Sized objects in FlexBuffers (#5551) 2019-09-30 paulovictor.pinheiro Fix issue #5542 (#5543) 2019-09-30 aardappel Fixed Android STLPort related error. 2019-09-30 hkmix Fix namespaced struct/field name collision detection (#5540) (#5545) 2019-09-27 paulovictor.pinheiro [flac] Add FlexBuffers option for generating data (#5519) 2019-09-26 rw Update Rust versions under test from 1.30.1 to 1.37.0 (#5538) 2019-09-26 29380294+mjvk Adds XOPEN_SOURCE for PATH_MAX and POSIX 1993 for stat (#5529) 2019-09-25 paulovictor.pinheiro [FlexBuffers][Java] Add override Key::toString (#5533) 2019-09-25 paulovictor.pinheiro [FlexBuffers][Java] Fix wrong access to a string using Reference::asString(). (#5532) 2019-09-23 31897320+vglavnyy Fix Mutate() methods of Array<scalar/struct> (override 5508) (#5526) (...) 2019-04-16 31897320+vglavnyy Add logging of warnings from the flatc compiler (#5289) 2019-04-11 aardappel Fixed VS2010 build. 2019-04-11 aardappel Allow Set() methods to handle reference types 2019-04-12 31897320+vglavnyy Fix the proto-enum leaking issue (#5286) 2019-04-12 31897320+vglavnyy Detect leak with sanitizer (#5283) 2019-04-09 31897320+vglavnyy Add basic test for enum defaults (#5280) 2019-04-09 31897320+vglavnyy Part of #5265, neutral changes (#5281) 2019-04-09 31897320+vglavnyy Enable MSVC assert report box [Abort|Retry|Ignore] if a debugger is present (#5279) 2019-04-06 lee0906 Add files generated by CMake to git ignore (#5278) 2019-04-06 lee0906 [C++]Sync the sample monster.fbs file with the tutorial (#5277) 2019-04-05 matthew Ensure we don't subtract with underflow getting enum names (#5246) 2019-04-05 wolfviking0 Add method GenerateTextFromTable issue #5249 (#5266) 2019-04-05 krojew Fix for build break in c# vector of unions (#5271) 2019-04-04 unexge Fix typo in Go tutorial (#5274) 2019-04-02 31897320+vglavnyy Add compile-time checking of numerical limits in C++ code. (#5270) 2019-03-28 16469394+tymcauley Update grammar to reflect required type signature for enum declarations. (#5269) 2019-03-25 AustinSchuh Add missing test data file to BUILD file (#5264) 2019-03-25 laszlocsomor Bazel CI: fix bad value in yml (#5262) 2019-03-25 nickkuznetsov Fix a warning on compiling with clang (#5258) 2019-03-25 lp.cordier Add inequality operator (inspired from #263) (#5257) 2019-03-22 lee0906 [C++] Changes in the flathash program (#5255) 2019-03-22 ashayshirwadkar12 Fixed tutorial markdown file (#5248) 2019-03-21 aardappel Further fixes to make minireflect compatible with old behavior. 2019-03-19 31897320+vglavnyy Unify line ending rules in '.editorconfig' and '.gitattributes' (#5231) 2019-03-18 aardappel Fixed vector_delimited excluding delimiter 2019-03-18 aardappel Fixed shadowing warning in older gcc for vector_delimited 2019-03-14 aardappel Made ToStringVisitor backwards compatible with older behavior. 2019-03-11 aardappel Made JS enum declarations compatible with google closure 2019-03-11 aardappel Disabled constexpr for hashing functions. 2019-03-12 31897320+vglavnyy Narrows template ascii routines to prevent a possible signed overflow in generic code. (#5232) 2019-03-11 25543498+RandyStevens Fix typo in dart documentation (#5230) 2019-03-11 aardappel [C++] Object API: document custom string type requirements, 2019-03-09 bspeice [Rust] Don't use inner attributes for `allow` (#5212) 2019-03-08 freaken Small usability tweaks to the rust codegen. (#5213) 2019-03-08 16469394+tymcauley Fix rust crate for big-endian targets (#5229) 2019-03-07 aardappel Removed -Wc++98-compat-extra-semi for compatibility with older clang. 2019-03-07 AustinSchuh Bazel ci (#5228) 2019-03-04 aardappel Fixed vector of union JSON parsing. 2019-03-06 25088801+jean-airoldie [Rust] Fixed codegen documentation for Tables (#5227) 2019-03-05 davidn [Go] Add mutation functions for vector elements (#5221) 2019-03-04 42381407+ll-antn Clean-up nested_parser on all paths (#5179) (#5184) 2019-03-04 laurent.stacul [Fix #5112] flatc generates constructors with memset for non-trivial types (#5222) 2019-03-01 5284924+csukuangfj [doc] fix typos in doc. (#5217) 2019-02-27 naure Rust: Fix lifetime in union _as_ accessors (#5140) 2019-02-26 kulikov.alexey90 Java: Calculation of vtable and vtable size moved to the __init method. (#5210) 2019-02-26 kulikov.alexey90 Java: Removed unused duplicate of bytebuffer from "Table#__string" method. (#5211) 2019-02-26 iskandarov_egor Lua library: fix vtable reuse. (#5214) 2019-02-25 aardappel Attempting to make travis not kill the Android build. 2019-02-25 marcus IterateValue: Use ReadScalar instead of unportable reinterpret_casts (#5209) 2019-02-25 bwelling Fix incorrect code generation on Solaris Sparc. (#5208) Created with: roll-dep src/third_party/flatbuffers/src Change-Id: I46bd259878ab27cade6323fb31a56b86edd56cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928296Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a1a942e18ee..a8c56ef52145 git log 9a1a942e18ee..a8c56ef52145 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 lalitm@google.com Merge "trace_processor: take into account asc/desc for eliminating constraints" 2019-11-25 lalitm@google.com trace_processor: update metrics to stop using ref/ref_type Created with: gclient setdep -r src/third_party/perfetto@a8c56ef52145 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:135177627 Tbr: perfetto-bugs@google.com Change-Id: Icc3625f6ebc30854da6ab5664e09ad7d3cebd4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933756Reviewed-by:
-
