- 05 Feb, 2020 40 commits
-
-
Mikel Astiz authored
This reverts commit 97e6c2b3. Reason for revert: suspect of causing unit test failures on msan builds: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Original change's description: > Enables the upgrade of Crostini container from Settings. > > We restart vm when upgrading, if it wasn't running already. > > Bug: 1024693 > Change-Id: I00e093f7bbf83eb04a6adb4029a4612e99950ae4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026559 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738422} TBR=khorimoto@chromium.org,nverne@chromium.org,hollingum@google.com,davidmunro@google.com Change-Id: I41e8d20c971ac1392e998cc2d791a3053b7fa8e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036189Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738507}
-
Yutaka Hirano authored
It was introduced to discard the response body for prefetch, but the response body (including the cached metadata) is filtered in the browser process (see content::PrefetchURLLoader) so we don't need to do that in content/renderer. Bug: 860403 Change-Id: I97d1feb2bc47727004484d53afcaa27f22ebf41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037291 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#738506}
-
Eric Willigers authored
HostedAppBrowserController static methods SetAppPrefsForWebContents and ClearAppPrefsForWebContents move out to become standalone methods in web_app_launch_utils.h/cc They are now also called by WebAppBrowserController and WebAppLaunchManager. The test PWAMixedContentBrowserTest, MixedContentInPWA now passes with the DesktopPWAsUnifiedUiController flag enabled. The test previously failed as SetAppPrefsForWebContents was not called when the DesktopPWAsUnifiedUiController flag and the DesktopPWAsUnifiedUiController flag were used. TBR=benwells@chromium.org Bug: 1034361 Change-Id: Id388122efa147ae8ae4ee26ba87a3c7c5101e5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035819 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#738505}
-
Maksim Moskvitin authored
Updated histograms are still useful for investigation of not completed Nigori migration to keystore. mamir@ no longer working on related things and removed from the owners. Bug: 1036875 Change-Id: I89ac124cd883f2e4c70458409f2e03b2d7a47e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036179Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#738504}
-
Marc Grimme authored
This reverts commit de47b200. Validates if the previously failing test are stable now to be reverted back once more. R=marcgrimme Bug: 1000694 Change-Id: I34806a0dd921ee90f4e8be7a83ee6c4cf27270a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035975Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Cr-Commit-Position: refs/heads/master@{#738503}
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I5ed06d330074e72c79bf31f49a9216e380322549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024890Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#738502}
-
David Jean authored
Popover now needs a sourceView or sourceRect. Bug: 1023619 Change-Id: Ifcc65cf83c9afb26080c9baeb22dd9030b06ec9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036065 Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738501}
-
Simon Zünd authored
This should prevent flakiness even further once asynchronous source mapping lands. R=petermarshall@chromium.org Bug: chromium:1032016 Change-Id: I65797584b8ab539d61421e06928cb4b6780823ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037991 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738500}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22c450dfeb2..0335e6749943 git log e22c450dfeb2..0335e6749943 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 szuend@chromium.org Prepare DebuggerPlugin for source map asyncification Created with: gclient setdep -r src/third_party/devtools-frontend/src@0335e6749943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9bd06fdd8a63f6d92616fdc6842bc67eebe7b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038124Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738499}
-
Anand K. Mistry authored
Functions which take an SmbUrl should also return an SmbUrl instead of std::string. This allows strong typing to be maintained, and helps avoid conversions between SmbUrl and std::string. Bug: 939235 Change-Id: If52ccc58d3bff62902179c1c9999fbf8bff64964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035827Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738498}
-
Mikel Astiz authored
This reverts commit a98ef426. Reason for revert: causes failures in ChromeVoxBackgroundTest, see crbug.com/1049012. Bug: 1049012 Original change's description: > Change the anonymous block in LayoutMenuList to a shadow element > > Enable rendering of the shadow element of <select>, and remove anonymous > block in LayoutMenuList. > > * HTMLOptionElement::ParseAttribute(): > Update the shadow element content on option[label] change. > > * HTMLSelectElement::UpdateFromElement(): > Fold LayoutMenuList::UpdateFromElement() into here. If option_style_ > and InnerElemnet's style are inconsistent, update InnerElement's > style. > > * HTMLSelectElement::UpdateMenuListLabel() > Move the code in LayoutMenuList::UpdateInnerStyle() here. > Also, kick TextChanged ax notification which LayoutText::ForceSetText > did. > > * MenuListInnerElement::CustomStyleForLayoutObject(): > Set "display: block" > Add custom style which the anonymous block used. > > * layout_menu_list.{h,cc}: > Remove a lot of code. > > * ax_layout_object_test.cc: > Add tests to check if AXLayoutObject::StringValue() respects to > text-transform and -webkit-text-security. > > * web_tests/accessibility/notification-listeners.html: > Remove TextChanged notification expectation. After this CL, <select> > won't notify TextChanged in this test scenario. The text is changed > before creating LayoutObject and AXLayoutObject. > > > > Bug: 1040828 > Change-Id: Ia0c19f0897ab2d1461e457c83adceda2c0739f9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024250 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738416} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Change-Id: I804ec3898b907ff79531dbc6390c99e24b66965f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036187 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738497}
-
Mikel Astiz authored
This reverts commit 882f5709. Reason for revert: dependency in order to revert crrev.com/c/2024250. Bug: 1049012 Original change's description: > Remove GetText(), ClientPaddingLeft(), and ClientPaddingRight() of LayoutMenuList > > Fold them into their callsites. > This CL has no behavior changes. > > Bug: 1040828 > Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738490} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Change-Id: I76d98f6f0ce474ca2cd64b94f8d3b36cb0878b71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037992Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738496}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c9b1fd6663e..bc3307c395e2 git log 6c9b1fd6663e..bc3307c395e2 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 csmartdalton@google.com Don't do clear or round rect optimizations when a rect has stencil Created with: gclient setdep -r src/third_party/skia@bc3307c395e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ic0d40bfb754ed34ca6717680d9b172fbbc205504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038177Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738495}
-
Friedrich Horschig authored
With this CL, the manual filling UI listens to the bottom sheet controller and suppresses any keyboard accessory or accessory sheet as soon as a BottomSheet of any kind is opened. This solution has the following constraints: * _Any_ bottomsheet will suppress the filling UI, always. * If the bottomsheet is closed, the filling UI will require another interaction (an opened keyboard, focusing a field, rotation) to reopen the filling UI. * The autofill dropdown is not affected in any way. Only if the keyboard accessory V2 is active (i.e. flag \#autofill-keyboard-accessory-view), the popup will be replaced by chips in the suppressed accessory. Launch of V2 has an uncertain target as of this writing. Bug: 1033849 Change-Id: I55fffa1bb7dd62a08af95705085c4884d38d9877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036103 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738494}
-
Morten Stenshorne authored
Hit-testing should never enter a child that establishes a self-painting layer. Also added a couple of local variables to make it slightly easier to read. Change-Id: I2854cb1b677f8eb164befe1577e7de2740735538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036104Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#738493}
-
Fergal Daly authored
Change-Id: I4c97da02e2106e2214e4a978f4c5a037365ebee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035551Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738492}
-
Rachel Sugrono authored
Add a test that tab-index key focus works correctly (only the elements inside the delete-confirm-dialog are tab-indexable). Elements outside of the delete-confirm-dialog should not be tab-indexable. Bug: 803259 Change-Id: I70f22dbd25220589157ade74016a7939aef03509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035476 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738491}
-
Kent Tamura authored
Fold them into their callsites. This CL has no behavior changes. Bug: 1040828 Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738490}
-
Eric Willigers authored
Two mixed content (http+https) desktop PWA tests have been ported to no longer have any dependency on Extensions code, so they are ready to run with BMO, when WebAppLaunchManager is complete. See https://chromium-review.googlesource.com/c/chromium/src/+/2035819/ for remaining work. Bug: 1026080 Change-Id: Ibcd690e44cc1949d352e16a11af5084a0abd2127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038195Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#738489}
-
Yoshifumi Inoue authored
This patch gets rid of unused functions in ElementInnerText for improving code health. Change-Id: I61692011375770b2c263c9a82499d7d02c340ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037304 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be70f94fa57b..166b478fa620 Created with: gclient setdep -r src-internal@166b478fa620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ieef89875ec85eac093f47cbbd5852694a84e4dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038119Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738487}
-
Chris Hall authored
R=aboxhall,dmazzoni Change-Id: I82c4687fd9923bf2669248419c7ed8616f1a7406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010227 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738486}
-
Kent Tamura authored
Bug: 924929 Change-Id: I29afe6b8e36c1101d81a3f2c02171662907f4057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035482Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738485}
-
Xiaocheng Hu authored
There's a CSSParserContext ctor that allows implicit conversion from a |const CSSParserContext*| to |const CSSParserContext&|, where the latter is actually a new object constructed on stack with different member values. So this patch stops the conversion. Change-Id: Ibf98e8b0012122d2fc42e3fc4b4b38e8fe9b797a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037854Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738484}
-
Clemens Backes authored
This should have been included in https://crrev.com/c/2030951 already. I missed that both "android_webview" and "ios" were missing. The set of "android", "android_webview" and "ios" hopefully covers all mobile platforms. R=bcwhite@chromium.org Bug: 1040061, 1040030 Change-Id: I8aa87b15c849be9d62c88df0a9f7eb7615eb6ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036056Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738483}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25cf469a112f..6c9b1fd6663e git log 25cf469a112f..6c9b1fd6663e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 jvanverth@google.com Update Viewer docs for Android and iOS. 2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 41a7302e9c62..8e8e1d0dd729 (4 commits) 2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 aa6dd50de0c5..58fc8b11cf3a (7 commits) 2020-02-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 egdaniel@google.com Make sure we invalidate mapped memory from vk transfer buffers before reading. 2020-02-04 tdenniston@google.com Revert "Initial checkin of GM verifier framework" 2020-02-04 tdenniston@google.com Initial checkin of GM verifier framework 2020-02-04 jvanverth@google.com Update iOS build instructions. Created with: gclient setdep -r src/third_party/skia@6c9b1fd6663e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ieeaf17a5514f142e6a145bc025f9fba4512d2265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738482}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d8c4b5fb80d4..f764fc02e94c git log d8c4b5fb80d4..f764fc02e94c --date=short --first-parent --format='%ad %ae %s' 2020-02-05 syoussefi@chromium.org Fix varying linking by location 2020-02-04 lexa.knyazev@gmail.com Implement RGTC (BC4, BC5) compressed texture formats 2020-02-04 cnorthrop@google.com Capture/Replay: Track compressed texture data 2020-02-04 jmadill@chromium.org Vulkan: Count active renderpasses in overlay. Created with: gclient setdep -r src/third_party/angle@f764fc02e94c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I9bfe5267a5088f96823a8528585e690647277a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738481}
-
rbpotter authored
Add Polymer 3 closure compiler targets for the files in settings_page/. Bug: 1026426 Change-Id: Ia672c0edbf05ef8779dcde296bcd704ff4c7b427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036524 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738480}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a299ca2..30fcb3eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d4065de8a55f0931d8758928f0ed974f00ab0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038372Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738479}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e06acb7de1b8..d28c5fe2b8b8 git log e06acb7de1b8..d28c5fe2b8b8 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 thestig@chromium.org Roll third_party/freetype/src/ e5038be70..4a19a53d5 (1 commit) 2020-02-04 tsepez@chromium.org Remove stray CFXJSE_Value forward declaration from ijs_runtime.h 2020-02-04 tsepez@chromium.org Add dumpTree() testing helper JS function. Created with: gclient setdep -r src/third_party/pdfium@d28c5fe2b8b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3fdc6a748845ab58cedb8bb39058e6d9684ed1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738478}
-
Naoki Fukino authored
Results from RecentModel are cached for 10 seconds. However, if the requested file type is different from previous one, the cache should be invalidated and not reused. Bug: 1040049 Test: Run browser_tests Change-Id: I0e9a90d6faeb612531ebdd64ff5b152bd9989755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035509 Auto-Submit: Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738477}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: Ib0f10d3267899069c53794e4ae42db23b4f8b98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037026 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738476}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0165beed0829..f72ef2db9462 git log 0165beed0829..f72ef2db9462 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 dberris@chromium.org E-Divisive: Reduce permutation testing iterations 2020-02-05 dberris@chromium.org Raise ceiling for upload-processing Created with: gclient setdep -r src/third_party/catapult@f72ef2db9462 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I9c1a4398f2fd0d2e81b83bde5d661e3d23684344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738475}
-
Eriko Kurimoto authored
This CL adds shared-worker-import-referrer.html for web-platform-test. Bug: 824646 Change-Id: I3031e34f1181303f7a0455974b3c614340d939f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037275 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#738474}
-
Nick Diego Yamane authored
After crrev.com/c/2028408, keyboard input handling has been broken in Ozone/X11 desktop builds (CrOS on Linux is not affected), when IBus IME is setup, among other cases which depend on KeyEvents::Properties being properly set. This fixes it as well as adds a unit test to prevent future similar regressions. Bug: 1047999 Change-Id: If67b78eb795b8d5efabf987a25ebf68de733948e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034810 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#738473}
-
Roman Sorokin authored
Still used in EasyUnlockAuthAttempt Fixed: 927498 Change-Id: Ice2c8c791d808349b508b6af79e684ca203644d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035972Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738472}
-
Alexey Baskakov authored
This getter will be needed for WebAppMigrationManager to convert downloaded icon sizes info. Bug: 1020037 Change-Id: I6d3fcb2e878671f9af455c3555aa4cf99053ea85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037302Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#738471}
-
Yutaka Hirano authored
We're planning to introduce a non-copyable request body to blink::ResourceRequest and blink::WebURLRequest in order to support streaming upload. WebURLLoader::LoadAsynchronously and WebURLLoader::LoadSynchronously take a const reference to WebURLRequest, but we'll need to modify the request when a non-copyable request body is introduced. Here we stop using WebURLRequest and pass std::unique_ptr<network::ResourceRequest> instead. This is better than using a mutable reference to WebURLRequest because it is hard to distinguish whether an argument is const reference or mutable reference. Moreover, WebURLRequest is planned to be deprecated and we are planning to use network::ResourceRequest or network::mojom::URLRequest for the "request" struct for IPC. This change is also a step of that larger refactoring effort. third_party/blink/PRESUBMIT.py is updated to reflect the discussion at https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/ntSzerId4gw . Bug: 860403, 688906 Change-Id: Ieb42432e30495d03f8cfb924a41a1327070c7aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032688Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#738470}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I8db12eacd2838ebf00b3094d744a0fde4dc28bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038371Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cecc4d627631..be70f94fa57b Created with: gclient setdep -r src-internal@be70f94fa57b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1048438 Tbr: jbudorick@google.com Change-Id: I19d45e54ef9d7a1846cac21a4b41afcc6eb316ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038117Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738468}
-