GitLab

BUG=87632
TEST=Manual

Review URL: http://codereview.chromium.org/7740065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98882 0039d316-1c4b-4281-b951-d872f2087c98

Make the "get window rect" message handlers report the work area, rather than the true window size, for maximized windows, since that's how the calling code expects them to function.

BUG=88523
TEST=Open DevTools maximized (full single screen) on Windows Vista/7, click the Gearbox button in the Elements panel's Styles pane. The SELECT popup should not stick beyond the right screen edge and should be right-aligned with the right edge of the button. Move the Windows taskbar to the right edge of the screen and repeat. The popup should still get the correct alignment and should not get clipped in any way.
Review URL: http://codereview.chromium.org/7799004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=86536
TEST=ChunkDemuxerTest.TestReadsAfterEndOfStream, ChunkDemuxerTest.TestEndOfStreamWithPendingReads

Review URL: http://codereview.chromium.org/7806002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98880 0039d316-1c4b-4281-b951-d872f2087c98

Fix link error with components build and media.dll. I have no idea why the bots aren't seeing this, it might be an interaction with supalink.
Review URL: http://codereview.chromium.org/7785013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7800012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98878 0039d316-1c4b-4281-b951-d872f2087c98

If a plugin dies with an open modal window the browser window will not be enabled. So, we re-enable the browser if it's ever disabled without any child dialogs.

BUG=90002
TEST=Kill the Flash process while a modal dialog (e.g. file, print) is open. Browser should remain responsive.
Review URL: http://codereview.chromium.org/7812005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98875 0039d316-1c4b-4281-b951-d872f2087c98

Corresponds to stability issues and also a security update:
http://service.real.com/realplayer/security/08162011_player/en/
Review URL: http://codereview.chromium.org/7776019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98873 0039d316-1c4b-4281-b951-d872f2087c98

* Constraint favicon size for bookmarks & most-visited to 16x16.
* Make color strip on bookmarks and most-visited full opacity.
* Set padding space between icon and title for bookmarks & most-visited to 8px.
Review URL: http://codereview.chromium.org/7794005

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/7776020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98872 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7778019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98868 0039d316-1c4b-4281-b951-d872f2087c98

Also adds an Aura test suite.

http://crbug.com/93933
http://crbug.com/93943
TEST=see unittest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98850
Review URL: http://codereview.chromium.org/7791030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98866 0039d316-1c4b-4281-b951-d872f2087c98

We should never use raw pointers of v8 objects in client code.

We should always use v8::Handle and it subclasses, v8::Local and v8::Persistent,
whenever referencing them.

Any allocation from v8 heap can make raw pointers invalid.

BUG=None
TEST=None

R=mnaganov@chromium.org
TBR=tonyg@chromium.org

Review URL: http://codereview.chromium.org/7779012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98865 0039d316-1c4b-4281-b951-d872f2087c98

1. make drag-over state match hover state for page switchers and nav dots
2. make recently closed text and arrow a hardcoded color (looks fine on a variety of themes; matches nav dot text)
3. don't show pulse for right click on apps

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7799015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98864 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7785003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98863 0039d316-1c4b-4281-b951-d872f2087c98

Add means for running some tests only o-o-p, add messaging o-o-p test.

BUG=None
TEST=included
TBR=dmichael@chromium.org

Review URL: http://codereview.chromium.org/7799031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94661
TEST=New unit test; also manually add a syncable app to profile, sync, then install extension with same ID: with change, no crash, without, crash on sync.


Review URL: http://codereview.chromium.org/7795011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98860 0039d316-1c4b-4281-b951-d872f2087c98

* Constraint favicon size for bookmarks & most-visited to 16x16.
* Make color strip on bookmarks and most-visited full opacity.
* Set padding space between icon and title for bookmarks & most-visited to 8px.
Review URL: http://codereview.chromium.org/7794005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98859 0039d316-1c4b-4281-b951-d872f2087c98

Logs a subset of the stack backtrace from the point of -dealloc into a
breakpad key to help debug messages to CrZombie objects.  This
productionizes the basic approach taken to debug a few recent zombie
object crashes.

BUG=none
TEST=monitor crash server.

Review URL: http://codereview.chromium.org/7766013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7790020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98857 0039d316-1c4b-4281-b951-d872f2087c98

Changed all @code to <code> and @endcode to </code> as per dmichael. Adding Polina to the review to look at url_loader.h and give approval of text that points to example.
Review URL: http://codereview.chromium.org/7715005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98856 0039d316-1c4b-4281-b951-d872f2087c98

I removed a bunch of static initializers, so update the expectations
so we don't regress.

Review URL: http://codereview.chromium.org/7806019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98855 0039d316-1c4b-4281-b951-d872f2087c98

The issue seems to be fixed as the ctor of JSONReader is public and there is
a public static Read() function.

BUG=None
TEST=None

R=aa@chromium.org,tony@chromium.org

Review URL: http://codereview.chromium.org/7794003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=89564
TEST=Go back or forward to a slow URL.  No omnibox change until it commits.


Review URL: http://codereview.chromium.org/7790018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98853 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98850 - Proper MouseEvent targeting. Adds a Window method that locates a Window for a given point.

Also adds an Aura test suite.

http://crbug.com/93933
http://crbug.com/93943
TEST=see unittest
Review URL: http://codereview.chromium.org/7791030

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7739002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98852 0039d316-1c4b-4281-b951-d872f2087c98

TBR=garykac@chromium.org
BUG=94764
TEST=none

Review URL: http://codereview.chromium.org/7785002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98851 0039d316-1c4b-4281-b951-d872f2087c98

Also adds an Aura test suite.

http://crbug.com/93933
http://crbug.com/93943
TEST=see unittest
Review URL: http://codereview.chromium.org/7791030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98850 0039d316-1c4b-4281-b951-d872f2087c98

Protect sensistive chrome: and chrome-extension: schemes as not being able to be manipulated by bookmarklets and javascript: URLs typed into the omnibox.

BUG=93498
Review URL: http://codereview.chromium.org/7748022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98849 0039d316-1c4b-4281-b951-d872f2087c98

mimic what we're doing on the server.

BUG=
TEST=BrowserFeatureExtractorTest


Review URL: http://codereview.chromium.org/7793012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98848 0039d316-1c4b-4281-b951-d872f2087c98

TBR=krisr@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7806021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98847 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98846 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7792041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98845 0039d316-1c4b-4281-b951-d872f2087c98

 This is temp fix and should be reverted once we found the real solution.

TBR=timurrrr@chromium.org
BUG=28439
TEST=none

Review URL: http://codereview.chromium.org/7792047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Enable scaling; make sure there are no vertical scroll-bars visible.

Review URL: http://codereview.chromium.org/7792017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98842 0039d316-1c4b-4281-b951-d872f2087c98

Implements per feature histograms.  At the moment three features: accelerated-compositing, accelerated-2d-canvas, and webgl.  Also, implemented each feature's allowed case percentage, per each OS (under Windows, they are divided into XP, Vista, and Win7).

BUG=91875
TEST=none 
Review URL: http://codereview.chromium.org/7618050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98840 0039d316-1c4b-4281-b951-d872f2087c98

the window, at which point window_ is NULL. This can happen because
SHAppBarMessage runs a nested message loop pumping events. I suspect
the right fix is to not invoke SHAppBarMessage, but that'll have to be
done separately.

BUG=94614
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7792014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98839 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure the NTP only listens for extension related notifications from the current profile. It also updates some of the sources for extension notifications in the Browser and ExtensionManagementEventRouters.

BUG=94438,87457,94034
TEST=see bug report

Review URL: http://codereview.chromium.org/7799008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98836 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7792043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92909
TEST=included

Review URL: http://codereview.chromium.org/7648033

TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/7806016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94135
TEST=Manual


Review URL: http://codereview.chromium.org/7792011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98831 0039d316-1c4b-4281-b951-d872f2087c98

For NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED the source is a RenderWidgetHost, and there are no details. Fix all the places that do the wrong thing.

BUG=94653
TEST=no DCHECK when closing a tab while a file picker is up

Review URL: http://codereview.chromium.org/7799009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98830 0039d316-1c4b-4281-b951-d872f2087c98