- 03 Dec, 2020 40 commits
-
-
Eric Lawrence authored
Remove the code for the divider line that is no longer used in the new layout. Bug: 1143472 Change-Id: I80c06e671de8bd061c983a47c9755064a1509c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567503Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833177}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1274ec33195..bdb300593cfb 2020-12-03 kimanh@chromium.org [LMI] Add functionality to change endianness from UI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75f88c85ff56716ea0d2e8df644da1e30b5ea962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833176}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c7112edbe0f4..27c78da79fce 2020-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6f5151f6572b to 3668d352bc5f (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I212da5f0abca482695023297494ee232dad8d629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570022Reviewed-by:
-
Nicholas Hollingum authored
We have been advised to avoid proliferating KeyedServiceFactories and instead use one omni-service. In line with this, we move the context manager. Bug: b/172006764, b/170596931 Change-Id: Iebc52681839b1476c0b01f93948c48334c80162f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562799Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#833174}
-
Yoshifumi Inoue authored
This patch gets rid of |VisiblePosition| version of |EndOfLine()| to reduce usage of |VisiblePosition| for improving code health. Note: This patch doesn't change behavior. Bug: 657237 Change-Id: I49e6732a7918ac4c55fced56f6e1d2362e4585b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568342 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#833173}
-
Jimmy Gong authored
Continue task tooltip now features the relative index of the card, title of the webpage, and the url. Screenshot: https: //storage.cloud.google.com/chromium-translation-screenshots/22fe620f4c048b2352ad6cfe316f63daf6372489 Fixed: 1152780 Change-Id: I099b5dd1d86ad73b9931cdfec15d68203d7ffffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570542 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833172}
-
Shik Chen authored
This CL reduces the barcode detection latency by shorten the delay between consecutive barcode detections. According to camera.CCAQRPerf, the slowest device needs ~50ms to detect a barcode from a 720x720 image. With 200ms delay, it should occupy <20% cpu on the slowest devices (50ms includes some I/O overhead). The measured cpu usage difference for a 1920x1080 stream on Kukui is about 3%. Bug: b/172879638 Test: Manually in expert mode Change-Id: Ie7a86d19c0734979b7456b79181af2e16ba69f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569436 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#833171}
-
Nicholas Hollingum authored
When anonymous apps are detected by borealis' window manager, we inform the BorealisApps publisher that it should publish an "app" for the given anonymous ID. Subsequently, anonymous apps can be handled like normal apps. Bug: b/172979315 Change-Id: I00a610a551088353cffff305e06b9b52a0c1ee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557769 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This adds the getter function of the bit depth of a stream to AcceleratedVideoDecoder interface. Bug: b:172223934 Test: media_unittests Test: video.DecodeAccelVD.* on trogdor Change-Id: Id3a5a3f84736a64d229366c0f352272483fae4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562798 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#833169}
-
Yicheng Li authored
Enable since it is approved. ChromeOS WebAuthn dialog shows up when doing MakeCredential Bug: 1150679 Test: in chrome://flags, set the flag to "Default", verify that the Change-Id: Iccb00a5831575ad09d5db45f7454c12cd366d458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551935 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#833168}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/429a12542f16..3668d352bc5f 2020-12-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 782f6a5e3e3c to 685cb02ea8d9 (15 revisions) 2020-12-02 rharrison@chromium.org Do not assert in work thread during tests 2020-12-02 enga@chromium.org OpenGL: Bind a dummy sampler for OpImageFetch if not present 2020-12-02 cwallez@chromium.org Reenable BufferMappedAtCreationOOM on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I78473a8988a0f4e59ba424e5ed4afc20fa459a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570041Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df5c49db593b..0516cae2a769 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC asamidoi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1149681 Tbr: asamidoi@google.com Change-Id: I3b9042247eadffc4392df56179ecb3964cc155a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833166}
-
Sophie Chang authored
Bug: 1146151 Change-Id: Ib10da995af2d6d7b91ac08e06460544a525f4e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567184 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#833165}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606920808-0540fdc6e596cc19c39443c176b663ce2ec75493.profdata to chrome-win64-master-1606942778-d5d5cc9b57e062a2c1a80c892b64ebbae55abc2c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9bb02731d6f69eef31697e617d545d84c298d826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570173Reviewed-by:
-
Alan Cutter authored
This CL extends the expiry of: - enable-desktop-pwas-tab-strip - enable-desktop-pwas-tab-strip-link-capturing Bug: 897314, 1078301 Change-Id: I1160964909d44d580b3cf394ce129adbbc7f3423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569141 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#833163}
-
Yuheng Huang authored
This CL fixes tabs inside a webapp is searchable from the browser in Chrome OS. Bug: 1099917, 1154393 Change-Id: I93b59f2ffe97487e0becb3eee6e1a8b77bea217b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568531 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833162}
-
Xing Liu authored
testAddReadingListItemFromBottomSheet is failing because https://chromium-review.googlesource.com/c/chromium/src/+/2562970 is landed before the test is landed. That CL requires the test to finish() the activity in the test code. We call it now. TBR=dtrainor@chromium.org Bug: 1150161 Change-Id: I51dc8ed4d595614cb4722733461c275d716f77c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570501Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833161}
-
Arthur Eubanks authored
SafeBrowsingPrivateEventRouterFactory::GetForProfile() can return nullptr, calling methods on nullptr is undefined behavior and causes some tests in unit_tests to crash under UBSan VPtr. Fixes $ ./out/Default/unit_tests --gtest_filter='*ChromeDownloadManagerDelegateTestWithSafeBrowsing*' under UBSan VPtr Bug: 1137496 Change-Id: I461f5d1235da4bc98bce22a1d7a4183ed11c4f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568667Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#833160}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae504d46b4c4..a45552c0f29d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4ec6f5bffbed0e155be0dec53ddc68cbab69e016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570342Reviewed-by:
-
Sophie Chang authored
This notifies observers of new models and persists it to disk I'll add browser tests in next CL Bug: 1146151 Change-Id: I05f0556b3735a1f98f035e1d66044e8d9755bcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566696 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#833158}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8bb911c3aa2c..b1274ec33195 2020-12-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I767cfb6ce766b026d07201ffabbea2191f07032a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570518Reviewed-by:
-
Minoru Chikamune authored
[purpose] The HeapMojoWrapperMode::kWithoutContextObserver was a HeapMojoWrapper's "safe mofe" to keep the existing behavior during the COVID-19 code freeze. The mojo objects on DevToolsFrontendImpl must outlive the ExecutionContext of LocalFrame, so it should not be associated with the ExecutionContext of LocalFrame. Bug: 1049056 Change-Id: I9c0b469ca206005a00a921838d24569c80f598a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291911Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#833156}
-
Joel Riley authored
Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. Bug: 1143814 Change-Id: I1c4fce614404c6cabd0336eed2ab6fa7ac1d4c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568547 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833155}
-
Yury Khmel authored
This sends request to ARC Android to set dalvik memory params based on device's memory config. BUG=b:160760318 TEST=unit test added Locally on device, early tests show improvements in app loading and ARC boot time up to 5%. This feature is currently optional and is behind Chrome feature. Next data will be collected on real user using finch experiment and in-lab tests by adding separate testing variation for few reference boards that activates this feature. Change-Id: Iacb1a8c6ce874fe74152204a2e41a35bb2fa9da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570552Reviewed-by:Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#833154}
-
Chan Li authored
To stop using result_adapter since iOS runner should be able to report results directly. Bug: 1136998 Change-Id: I0686ff23a16d5a59ddae1b80cf5b21df4240bf61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561462 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#833153}
-
Oriol Brufau authored
MostBackwardOrForwardCaretPosition was added in r832706, and this caused a -1.8% perf regression for line-layout-repeat-append-select.html The reason is that the function adjusts the obtained candidate position to avoid crossing shadow boundaries. This patch adds fast paths for the common cases when both the candidate and the original position are neither in a shadow tree nor are shadow hosts themselves. Bug: 1154646 Change-Id: I036e9044e2b8c921b466595be9661efbc852aa1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569740 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833152}
-
Nnamdi Theodore Johnson-Kanu authored
- Adds a dialog which allows the user to rename an esim profile screenshot: https://screenshot.googleplex.com/A6TtGk554XoETAr.png Reference: https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.gac80715f79_2_7 Bug: 1093185 Change-Id: I60b6780c28c603db1a35fb65733919b03bf92dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555470 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#833151}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/b3becb2f257a..685cb02ea8d9 2020-12-02 dsinclair@chromium.org Remove internal usage of Context. 2020-12-02 dsinclair@chromium.org [ast] Remove more set methods. 2020-12-02 bclayton@google.com Unrevert "[ast] Remove unused constructors and setters". 2020-12-02 bclayton@google.com Add ClassID::Unique template and TINT_INSTANTIATE_CLASS_ID 2020-12-02 enga@chromium.org spirv-reader: Fix bug with passing stack-allocated variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I85b4681a00284c75a1e5ede40ae0644abd09054c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570021Reviewed-by:
-
Ian Prest authored
Previously, to detect if VoiceOver was running on the Mac, we used an undocumented attribute (AXEnhancedUserInterface) that was set on the application. Unfortunately, this doesn't work with the new VoiceControl system. After discussions with Apple, they recommended that we turn on a11y whenever an AT accesses the 'accessibilityRole' property. This would work for VoiceControl, and should work with any new ATs in the future. Since this attribute is called frequently, we use 'dispatch_once' to ensure the expensive work is only done once. One disadvantage is that we can no longer turn *off* a11y when the 'AXEnhancedUserInterface' attribute is set to zero, because doing so breaks compatibility with VoiceControl. (A11y would be enabled, then quickly disabled again.) Bug: 1143047 Change-Id: I41ed07b31476cef4a04fd0f2d9c994acc9311654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538257Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/6216d098d8ab..1520e40f5e2b 2020-12-03 dneto@google.com copyright check: Exclude .venv in source tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ief57990d01d5fa03b9a494d76b36da7f2d4ef1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570014Reviewed-by:
-
Kenichi Ishibashi authored
This CL is similar to crrev.com/c/25509621 but for StoreUserData(). Introduces a specialized InflightCall for StoreUserData() to clone a move-only parameter for each call. Bug: 1133143 Change-Id: Ibfd98f2dab312e0f828ecb5941a4aaedae1883f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560706 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833147}
-
Joey Arhar authored
Fixed: 645845 Change-Id: I3dfcf092b1b323da8b08ec4620e8051e8e7c09d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497422Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#833146}
-
Joel Hockey authored
Test is failing and blocking LKGM Bug: 1154794 Change-Id: I9739e4d1439f0db7088e34b4a35eb72c6f489a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569328 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833145}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b8d12f1..9f448651 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib91524c8768481cdf9b9ef41c190f7a2924ca4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570336Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833144}
-
Eric Willigers authored
apps_util::CreateShareIntentFromFiles now omits title or text strings from the intent, if the supplied string are empty. Bug: 1127670 Change-Id: Ic62b1e80299ad2cfe067132e7e852fb34b8c6e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569324Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae504d46b4c4..a45552c0f29d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6d059e64e738b9648ff3355fbe2045b0e80aae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570013Reviewed-by:
-
Alan Cutter authored
This CL updates the Webapp.Update.ManifestUpdateResult histogram to record the situation where a navigation occurs in scope of a web app but the manifest served by the site would result in a different app ID than what's already installed. Bug: 1058265 Change-Id: I8d3d2ffceea77c3033d173e787dae1e538efff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569310 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This CL is similar to crrev.com/c/2550108 but for user data methods, except for StoreUserData(). StoreUserData() has a move-only parameter and needs to be specialized. This CL also updates some browser_tests to wait for all inflight tasks are executed before finishing tests. These changes are needed to satisfy the DCHECK() in generated mojo bindings. Bug: 1133143 Change-Id: Ia234eb4b84098f7a42450dfda1e70d9f34f9fe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561963 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
BUG=b:171408795 TEST=Launch Play Store Change-Id: I350bb9e05ecbd168a6452e76b59b601a27db8dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560534Reviewed-by:
-
Jeffrey Young authored
Move photo downloading and decoding to new class |AmbientPhotoCache|. Follow-up CL will also move disk access to make |AmbientPhotoController| tests more reliable. BUG=b:165481552 TEST=ash_unittests --gtest_filter="AmbientPhotoControllerTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I9f06b34aa661c86d2a960d8f3e279857da462bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550606 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833138}
-
