GitLab

This dialog does not have a single call-to-action button. Additionally,
the existing highlight implementation is a side-effect of using
DialogClientView, which is not well suited to this container. This CL
changes NativeDialogContainer to use a regular ClientView, removing the
default highlighting from the dialog, and refactors the two containers
to use a common base class.

BUG=445695

Review URL: https://codereview.chromium.org/933163002

Cr-Commit-Position: refs/heads/master@{#318206}

Revert of Telemetry: Refactor inspector_websocket to create cleaner interface. (patchset #2 id:80001 of https://codereview.chromium.org/942113004/)

Reason for revert:
This possibly is causing chrome tracing data leakage: BUG=461874

Original issue's description:
> Telemetry: Refactor inspector_websocket to create cleaner interface.
>
> This CL contains several improvements which are tightly coupled.
>  - The method DispatchNotificationsUntilDone is only used by tracing_backend. I
>  moved all the logic into tracing_backend. This has several side effects:
>    - The exception DispatchNotificationsUntilDone is no longer needed.
>    - The method _Receive no longer handles exceptions. It used to handle some,
>    but not all exceptions. This change is very important for sane exception
>    handling of the Chrome/Telemetry bindings.
>    - The method _HandleNotification never has a return value. It used to
>    sometimes return a boolean, and sometimes return nothing.
>  - I removed the member _error_handler. This member was only used in two
>  places: inspector_backend and tracing_backend. Of these two places,
>  tracing_backend only used it to emit a not-so-useful log statement.
>    - The biggest problem with _error_handler is that it decouples the exception
>    handling from the context of the try/catch loop that triggered the
>    exception.
>    - The _error_handler only was called during _Receive(). This is very
>    confusing, since that is not the only method that raises Exceptions. So some
>    exceptions get handled by _error_handler, and some do not. :(
>  - I removed all exception handling from inspector_page.py and
>  inspector_websocket.py. It used to be that some exceptions would be handled in
>  inspector_websocket, some would trickle up to inspector_page, and some would
>  trickle out past inspector_backend.py. The eventual goal is for
>  inspector_backend to catch all exceptions and translate them into
>  {Recoverable/Unrecoverable}Exceptions.
>
> BUG=460625
>
> Committed: https://crrev.com/64cf2ab4a6a348954d46d9d758c5be53aa1c1220
> Cr-Commit-Position: refs/heads/master@{#317972}

TBR=sullivan@chromium.org,slamm@chromium.org,erikchen@chromium.org
BUG=460625

Review URL: https://codereview.chromium.org/962443002

Cr-Commit-Position: refs/heads/master@{#318205}

BUG=452613

Review URL: https://codereview.chromium.org/944283002

Cr-Commit-Position: refs/heads/master@{#318204}

R=jam@chromium.org
BUG=426897

Review URL: https://codereview.chromium.org/960773002

Cr-Commit-Position: refs/heads/master@{#318203}

This was semantically incorrect; a Point represents a point in 2D space
whereas a Vector2d represents an offset. Therefore, 'offset' should be a
Vector2d.

BUG=None
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/884653003

Cr-Commit-Position: refs/heads/master@{#318202}

This reverts commit 603236c7.
The issue of 2x assets has been solved.

BUG=460430
TEST=checked on link

Review URL: https://codereview.chromium.org/962483002

Cr-Commit-Position: refs/heads/master@{#318201}

This makes more sense when it's an inline element in the page,
accessible by keyboard or mouse focus.

On chrome://apps it's not possible to focus this element
as far as I know; it's only shown while dragging.

R=estade@chromium.org
BUG=456706
TEST=visual, see bug

Review URL: https://codereview.chromium.org/952053003

Cr-Commit-Position: refs/heads/master@{#318200}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ee908a2b..238ad54d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/959833003

Cr-Commit-Position: refs/heads/master@{#318199}

This CL enables the context menu on the doodle web contents and logs
the received doodle data. This will be reverted in a future patch
once an issue with the doodle not displaying is diagnosed.

BUG=462082

Review URL: https://codereview.chromium.org/961553002

Cr-Commit-Position: refs/heads/master@{#318198}

Eliminates a bug where files will spaces in name were not being marked as synced.

Also:
1) Remove an unused method (with a TODO body) in ImportTask.

BUG=461174
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/954943006

Cr-Commit-Position: refs/heads/master@{#318197}

The public methods no longer take an Account as a parameter.
Instead, when the account changes, updateAccount() is called
by ChromeSigninController. This removes the need for all of
the "didUpdate" logic.

Instead, updateCachedSettings() is called only when the
Android settings are changed or the account is changed.

CachedAccountSettings has been removed entirely. A separate
class is not necessary to cache three boolean values (which
it was already only handling two of!)

Review URL: https://codereview.chromium.org/879533004

Cr-Commit-Position: refs/heads/master@{#318196}

Make animation code conform to the style guide by using auto where
appropriate, renaming functions named incorrectly, etc. Avoid
accessing layer_animation_controller directly where possible.

Review URL: https://codereview.chromium.org/948243003

Cr-Commit-Position: refs/heads/master@{#318195}

Some versions of libtool will complain about having multiple files with
the same name.

BUG=461989

Review URL: https://codereview.chromium.org/955263002

Cr-Commit-Position: refs/heads/master@{#318194}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/37a6107..f47e707

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/954353002

Cr-Commit-Position: refs/heads/master@{#318193}

BUG=461979
TEST=NONE

Review URL: https://codereview.chromium.org/961483003

Cr-Commit-Position: refs/heads/master@{#318192}

The fix basically includes reading default zoom percent of a tab  from a helper function in zoom_controller.

BUG=427440

TESTs = Go to chrome://settings
              Expand to Webcontents under Advanced Settings
              Change the default Zoom percentage
              Expected result: All the open tabs would be changed to that particular zoom   value and the "Actual Size" under View menu would be disabled.

Review URL: https://codereview.chromium.org/678343002

Cr-Commit-Position: refs/heads/master@{#318191}

This causes any gyp targets which use the mojom bindings generator
to regenerate all outputs when any of the input mojom files have
changed. In such cases, the Java output directory is first wiped
out.

This avoids problems with stale mojom-generated Java files hanging
around and being compiled by build/android/javac.py, which tries
to build everything in its generated sources location.

BUG=461622

Review URL: https://codereview.chromium.org/958773002

Cr-Commit-Position: refs/heads/master@{#318190}

The new 'gn clean' command didn't actually work right; when we
read in the existing build.ninja file, we would trim the leading
whitespace from the lines, producing an invalide ninja file as a result.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/952053004

Cr-Commit-Position: refs/heads/master@{#318189}

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/936143003

Cr-Commit-Position: refs/heads/master@{#318188}

Previously Files.app does not preapre container object of AsyncData if the
selection includes directory. Thus it raises exceptions when it tries to
store data to the container object. The CL let Files.app prepares the container
object always.

BUG=461726
TEST=None

Review URL: https://codereview.chromium.org/956853002

Cr-Commit-Position: refs/heads/master@{#318187}

This patch adds DBus method wrappers to PermissionBrokerClient for the
new Request(Tcp|Udp)PortAccess and Release(Tcp|Udp)Port methods
supported by permission_broker.

BUG=435404

Review URL: https://codereview.chromium.org/960033002

Cr-Commit-Position: refs/heads/master@{#318186}

TBR=kalman@chromium.org
BUG=427672

Review URL: https://codereview.chromium.org/960763002

Cr-Commit-Position: refs/heads/master@{#318185}

base::MessageLoop::RunUntilIdle() API is deprecated and the preferred way is
using RunLoop now.

BUG= 333557

Review URL: https://codereview.chromium.org/915373002

Cr-Commit-Position: refs/heads/master@{#318184}

These parts are not used ATM, this CL removes them until further notice.

> Add still image capture interface for VideoCaptureDevice.
>
> BUG=413086
> TEST=Run the media_unittests on peach_pit.
>
> Committed: https://crrev.com/fd5bdd2688768683e30b27941f181597a849656d
> Cr-Commit-Position: refs/heads/master@{#298009}

TBR=posciak@chromium.org, perkj@chromium.org, tommi@chromium.org

BUG=413086, 440843

Review URL: https://codereview.chromium.org/921683004

Cr-Commit-Position: refs/heads/master@{#318183}

The CL dumps event logs for devices that run with the CrOS
gesture library. It is designed to be backward-compatible
with the X11 behaviour.

Contributed by sheckylin@chromium.org

BUG=450159
TEST=samus ChromeOS build

Review URL: https://codereview.chromium.org/893753002

Cr-Commit-Position: refs/heads/master@{#318182}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1175397..ef73ddc

TBR=arv@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/960013003

Cr-Commit-Position: refs/heads/master@{#318181}

This should get most of NaCl and the PPAPI stuff needed
for NaCl building and linking. There is more work to be
done to get some of the test binaries working (and
probably fill out parts of the NaCl SDK) and possibly
some pnacl support work remaining as well.

NaCl is still disabled by default (set enable_nacl=true
to change). Enabling nacl is still mostly untested and
likely doesn't work at all :).

R=ncbray@chromium.org, brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/877553008

Cr-Commit-Position: refs/heads/master@{#318180}

BUG=459693
TEST=manually tested

Review URL: https://codereview.chromium.org/954113004

Cr-Commit-Position: refs/heads/master@{#318179}

This removes NOTIFICATION_PROFILE_CACHED_INFO_CHANGED and
NOTIFICATION_PROFILE_CACHE_PICTURE_SAVED notifications from all the
things.

This is part of the long process of killing the NotificationService with fire. In
particular, this ProfileInfoCache notification is terrible because it's incredibly
generic, gets shouted out any time *anything* happens to *any* profile, and
a bunch of things in Chrome listen to it, when in fact they care about very
specific profile notifications (i.e. has a name been changed, has a user been
added)

BUG=454845
TEST=All tests should pass. Chrome shouldn't behave weirdly. Everyone should
get a pony.

Review URL: https://codereview.chromium.org/895803003

Cr-Commit-Position: refs/heads/master@{#318178}

This test was disabled on Windows due to flakiness. I ran it locally & on the try jobs, and neither gave any flakes, therefore, this CL re-enables the test.

BUG=375538

Review URL: https://codereview.chromium.org/948733002

Cr-Commit-Position: refs/heads/master@{#318177}

Revert of Unload the ScopedGaiaAuthExtension asynchronously. (patchset #2 id:20001 of https://codereview.chromium.org/961443003/)

Reason for revert:
Broke BookmarkSyncPromoControllerTest.SignInLink on Mac ASan 64: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/7363

Original issue's description:
> Unload the ScopedGaiaAuthExtension asynchronously.
>
> If we don't do this, then we have a race condition between unloading
> this extension, and trying to use it because we have manually
> navigated to it.
>
> BUG=460431
>
> Committed: https://crrev.com/1805c4c5c4b5292cca51a54f379cde498db7238b
> Cr-Commit-Position: refs/heads/master@{#318140}

TBR=xiyuan@chromium.org,noms@google.com,noms@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460431

Review URL: https://codereview.chromium.org/944923007

Cr-Commit-Position: refs/heads/master@{#318176}

Revert of [Telemetry] Pass test_runner environment in local args instead of a global variable (patchset #9 id:160001 of https://codereview.chromium.org/942663002/)

Reason for revert:
crbug.com/462063

Original issue's description:
> [Telemetry] Pass test_runner environment in local args instead of a global variable
>
> Also adds more fields to environment to narrow the scope of
> benchmark and user story set discovery. This should avoid problems
> with adding Python files to unrelated directories, and hides PageTests
> from external Telemetry benchmark runners like run_gpu_tests.py and
> chrome_proxy's run_benchmark.
>
> R=dtu,nednguyen,sullivan,kbr@chromium.org,bolian
> BUG=460181
> TEST=tools/perf/run_benchmark; content/test/gpu/run_gpu_tests.py; tools/chrome_proxy/run_benchmark  # All return a full and correct test list.
>
> Committed: https://crrev.com/1da5f7f70ea6dc7dd0667ea78637802c76305f5a
> Cr-Commit-Position: refs/heads/master@{#318149}

TBR=bolian@chromium.org,dtu@chromium.org,kbr@chromium.org,nednguyen@google.com,sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460181

Review URL: https://codereview.chromium.org/955183003

Cr-Commit-Position: refs/heads/master@{#318175}

GPUTiming is our abstraction layer for various GL timing extensions. It
makes more sense for this abstraction layer to be owned by GLContext
instead. Clients that want to do GPU Timing calls (GPUTracer, eventual
support of WebGL tracer calls).

One of the main reasons for this differentiation is to support disjoint
queries across multiple virtual contexts. The actual support of this
will be completed in another CL.

BUG=451211
TEST=trybots

Review URL: https://codereview.chromium.org/937263006

Cr-Commit-Position: refs/heads/master@{#318174}

BUG=462044

Review URL: https://codereview.chromium.org/956623010

Cr-Commit-Position: refs/heads/master@{#318173}

On Mac, interpreting a tab keypress into an action message calls
[NSResponder insertTab]. [RenderWidgetHostViewCocoa
doCommandBySelector:] has for a long time had a check that skips
converting any action message whose selector starts with "insert" into
an editing command, and just treats it as a regular keypress instead.

This approach also works well for UI in MacViews, so do the same.

Theoretically a user could remap a different key or key combination to
the 'insertTab' action message, but that's unlikely.

Updates TextfieldTest.FocusTraversalTest with cross-platform checks to
test for this case. Also tested manually with views_examples.

For the test to work with the approach in this CL, the event simulator
needs to provide an answer for -[NSApplication currentEvent], so that's
done too.

BUG=454353

Review URL: https://codereview.chromium.org/951433002

Cr-Commit-Position: refs/heads/master@{#318172}

BUG=461504

Review URL: https://codereview.chromium.org/952213006

Cr-Commit-Position: refs/heads/master@{#318171}

Modifies pepper_hash_for_uma to sort the output by hash, so it's
easier to compare against the histogram.xml file when searching
for missing hashes.

I used the following script to get an API list from src/ppapi:

grep -r "PPB_" ppapi/c | grep -o "\".*;[0-9]\.[0-9]*\"" | tr '\n' ' '

BUG=
R=asvitkine@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/938283004

Cr-Commit-Position: refs/heads/master@{#318170}

BUG=457659,454416

Review URL: https://codereview.chromium.org/926193005

Cr-Commit-Position: refs/heads/master@{#318169}

The OnSessionRestore callback has been changed to accept the number
of tabs as an argument.

BUG=chromium:455482
TEST=Add logging to make sure the correct number of tabs is being
passed to perf provider during session restore
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/902613003

Cr-Commit-Position: refs/heads/master@{#318168}

R=maruel@chromium.org
TBR=jam@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/958733002

Cr-Commit-Position: refs/heads/master@{#318167}