GitLab

This reverts commit f2e0beaedaeaf15c509a2abd2c4fe598c4094bbd.

TBR=arv@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/546973004

git-svn-id: svn://svn.chromium.org/blink/trunk@181542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Those two files were split apart and redundantly copied
for non-Mac and Mac platforms. This is an attempt an unifying
them, as a preparation for removing the CoreText shaper.
We can merge the implementations in FontPlatformDataHarfBuzz.cpp
and FontPlatformData.cpp as a next step.

This is a reland after the original change 72f392cc147764ec75e4f
got reverted in bcfdb1312a26b0e611. Fix is to
change to the previous operator== implementation and add
m_isHashTableDeletedValue to the hash computation. 

I believe this addresses the observed crash issue as well.

BUG=334269, 411287
R=eae,arv

Review URL: https://codereview.chromium.org/542653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=arv@chromium.org
BUG=411779

Review URL: https://codereview.chromium.org/546633008

git-svn-id: svn://svn.chromium.org/blink/trunk@181540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I would like to add new time complexity test.
Unfortunately, current framework doesn't support async tests.

In this patch I wrap for and while operators, so they could
run asynchronously.

CL I'm going to write test to (fix n^2 HTML parsing):
https://codereview.chromium.org/494993002/

Here is the first async test:
https://codereview.chromium.org/500363002/

BUG=410790

Review URL: https://codereview.chromium.org/544453004

git-svn-id: svn://svn.chromium.org/blink/trunk@181539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While most color properties have an initial value of currentColor,
explicitly specifying currentColor behaves different internally to an
initial value. This patch makes currentColor no longer resolved in style
resolution for properties which are a single color and removes a flag
from RenderStyle indicating that currentColor was explicitly set.

Review URL: https://codereview.chromium.org/547273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Do what the comment says, not what the code does :)

BUG=399775

Review URL: https://codereview.chromium.org/543273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead, it should use synchronous ResourceRequest to obtain imported xsl-stylesheet.

TEST=fast/xsl/transform-xhr-doc.xhtml
BUG=367689

Review URL: https://codereview.chromium.org/507583002

git-svn-id: svn://svn.chromium.org/blink/trunk@181536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently this test is expected to be timed out and should be skipped to reduce
the time to run tests.

BUG=398355
TBR=horo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/546333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These attributes are gone:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container

Chromium: https://codereview.chromium.org/544023002/


BUG=404982
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/541943003

git-svn-id: svn://svn.chromium.org/blink/trunk@181534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Gardening: Fix tests failing on Win7(dbg) caused by hitting an assert in FontCache::addSideloadedFontForTesting
> 
> NOTRY=true
> TBR=arv@chromium.org,tkent@chromium.org
> BUG=None
> 
> Review URL: https://codereview.chromium.org/549013002

TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/554543002

git-svn-id: svn://svn.chromium.org/blink/trunk@181533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: Fix tests failing on Win7(dbg) caused by hitting an assert in FontCache::addSideloadedFontForTesting

NOTRY=true
TBR=arv@chromium.org,tkent@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/549013002

git-svn-id: svn://svn.chromium.org/blink/trunk@181532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I added m_skipServiceWorker to ResourceRequest in https://codereview.chromium.org/527703002/.
But I forgot to add it to CrossThreadResourceRequestData.

BUG=402093
TEST=none

Review URL: https://codereview.chromium.org/547563002

git-svn-id: svn://svn.chromium.org/blink/trunk@181531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In Web applications, the Filesystem API is used to create sandboxed
filesystems. Files in these filesystems should never be shown in a
filepicker. ChromeOS supports a few special filesystems (Downloads,
Gallery) where the files should be shown in filepickers.

This change fixes the userVisibility property for File instances created
from such filesystems.

BUG=398366

Review URL: https://codereview.chromium.org/516763002

git-svn-id: svn://svn.chromium.org/blink/trunk@181530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On non-intel (aka non x86/x64) we can compile the assembly stubs as a
source_set and not use yasm.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/541933003

git-svn-id: svn://svn.chromium.org/blink/trunk@181529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the unused MarginSign enum. I noticed this while
searching how we name enums in Blink as part of another patch.

Since I was in the area, I fixed the comment about margins as well.

R=esprehn

Review URL: https://codereview.chromium.org/548113002

git-svn-id: svn://svn.chromium.org/blink/trunk@181528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added all the plumbing to make Blink aware of the top controls position
and how its viewport has been resized as a result. This CL adds all the
machinery and plumbing but does not yet connect main-thread scrolls to
the top controls. This is needed to support scrolling the top controls
during slow-scrolls as well as correct viewport behavior in the virtual
viewport pinch-to-zoom.

The machinery for top controls now includes two values:

top_controls_layout_height: The amount that the viewport was shrunk to
accommodate the top controls. This is updated only during a layout that
causes a viewport resize (i.e. RenderWidget::OnResize). The compositor
needs this to know how much the viewport layer has already been resized
by Blink.

top_controls_content_offset: The amount that the top controls are showing.
This will be the same as top_controls_layout_height right after a viewport
resize, but will diverge since the top controls will move without
immediately causing a RenderWidget resize.

Blink now keeps track of the top controls "content offset", which is the
distance the content is offset from the top of the screen due to top
controls. It receives updates to this value from the Impl thread during
a commit and echos them back to the compositor.

On the compositor side, the top controls layout height is moved into the
LayerTreeImpl. This is necessary since a commit will change the viewport
layer's size on the pending tree. Keeping it in LayerTreeHostImpl meant
that, until the pending tree was activated, the top controls layout height
corresponded to the viewport bounds in the pending tree. This was causing
flickering as the viewport container was the incorrect size for a short
time. The compositor also keeps track of the top controls content offset
value. The top controls offset uses the same model as page scale, keeping
an offset (the value as known by the main thread), a delta from the main
thread's value, and a sent_delta to keep track of what has been sent to
the main thread.

See: https://codereview.chromium.org/511253003 for Chromium-side patch.

BUG=333143

Review URL: https://codereview.chromium.org/513053003

git-svn-id: svn://svn.chromium.org/blink/trunk@181527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes some deadcode from CompositedLayerMapping:
1) hasContentsLayer - this function name was confusing.
2) isMainFrameRenderViewLayer - state is now all within CLM.

No new tests, no change in behavior.

Review URL: https://codereview.chromium.org/542863007

git-svn-id: svn://svn.chromium.org/blink/trunk@181526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline-o-matic failing to rebaseline these results: some issue with
changing to it's third_party/WebKit directory. Remove baseline requests
for multicol tests on Snowleopard Debug:

fast/multicol/pagination-h-horizontal-bt.html
fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html
fast/multicol/client-rects.html

TBR=wangxianzhu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/553673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline server is not submitting them at thit time, event though it
has been asked to do so. Ran webkit-patch rebaseline-expectations, and
pulled results from the 10.6 Mac bots for submit (old skool).

TBR=wangxianzhu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/554503002

git-svn-id: svn://svn.chromium.org/blink/trunk@181524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fast/multicol/client-rects.html
fast/multicol/pagination-h-horizontal-bt.html
fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html

TBR=ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/548173002

git-svn-id: svn://svn.chromium.org/blink/trunk@181522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181520

TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/551633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline fast/layers/scroll-descendant-with-cached-cliprects.html on mac
after blink r181475 and r181499

TBR=ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/547233002

git-svn-id: svn://svn.chromium.org/blink/trunk@181520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/551613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/546273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/549963002

git-svn-id: svn://svn.chromium.org/blink/trunk@181517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/546663004

git-svn-id: svn://svn.chromium.org/blink/trunk@181516 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/554483002

git-svn-id: svn://svn.chromium.org/blink/trunk@181515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add null checking in EventTarget::removeEventListener,
because we shouldn't be passing in a null listener reference to the ==()operator.

BUG=377425
R=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/539453002

git-svn-id: svn://svn.chromium.org/blink/trunk@181514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also clarify some comments (I'm not sure why this needs this stuff
callable from any thread anyway) and organize the members by user.

BUG=

Review URL: https://codereview.chromium.org/553553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181493

BUG=408260
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/547113003

git-svn-id: svn://svn.chromium.org/blink/trunk@181512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181499

BUG=409708
TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/548933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simplify the implementation by having it mirror the addEventListener() version.

Which means creating a correct protector and passing it inwards.

Review URL: https://codereview.chromium.org/547103002

git-svn-id: svn://svn.chromium.org/blink/trunk@181510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is another speculative crash fix (previous one was r181045).

BUG=400483

Review URL: https://codereview.chromium.org/546633006

git-svn-id: svn://svn.chromium.org/blink/trunk@181509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. save page scale factor if it is greater than minimal legible/readable scale
2. normalize sizeRect on current page scale factor to be measurable with caret and textboxRect

R=aelias@chromium.org

Review URL: https://codereview.chromium.org/527003002

git-svn-id: svn://svn.chromium.org/blink/trunk@181508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Retires ScriptWrappable::init and renames m_wrapperOrTypeInfo to m_wrapper
because we no longer need WrapperTypeInfo in m_wrapperOrTypeInfo.
Removes related code, too.

BUG=235436

Review URL: https://codereview.chromium.org/540283003

git-svn-id: svn://svn.chromium.org/blink/trunk@181507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181499

BUG=409708
TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/551593002

git-svn-id: svn://svn.chromium.org/blink/trunk@181506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore.

Review URL: https://codereview.chromium.org/541383003

git-svn-id: svn://svn.chromium.org/blink/trunk@181505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Import these polygon shapes reftests and fix them.
Note that these tests should be imported at some point.

This is based on http://trac.webkit.org/changeset/172973 by Zoltan Horvath <zoltan@webkit.org>.

From the WebKit patch commit log:
We didn't respect the shape-margin before a positioned polygon, since we checked
the shape-margin for only 1 vertex for a polygon edge. This patch fixes the behavior,
removes the tests from the skipped list and updates 1 test, which was incorrect.

Review URL: https://codereview.chromium.org/510513002

git-svn-id: svn://svn.chromium.org/blink/trunk@181504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This depends on HTMLDocumentParser fix: https://codereview.chromium.org/532343002/

XMLHttpRequest and HTMLImport need callback when document has finished
parsing. This CL introduces an interface DocumentParserClient for receiving the
"parser stopped" notification, and migrates HTMLImportLoader to use the
interface.

BUG=409461

Review URL: https://codereview.chromium.org/535403002

git-svn-id: svn://svn.chromium.org/blink/trunk@181503 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add clipping.
Add transform.
Change recording to be driven by GraphicsContext.
Update dependent code.
Move a method used only by SVGFEImage from AffineTransform to SVGFEImage

R=pdr,senorblanco
BUG=410019

Review URL: https://codereview.chromium.org/536573002

git-svn-id: svn://svn.chromium.org/blink/trunk@181502 bbb929c8-8fbe-4397-9dbb-9b2b20218538