GitLab

AppListFolderView should ensure it respects apps container margins when
shown with ScalableAppList feature enabled, in particular it should
ensure its bounds do not overlap with the search box widget.
It was using search_box_fullscreen_top_padding() to determine search box
location, but this does not work correctly for ScalableAppList - when the
feature is enabled, use
AppsContainerView::CalculateMarginsForAvailableBounds to get the
container margins.

BUG=999273

Change-Id: Ie842da042cf6215fe9b1345229a1575d10ca55a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815581
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698649}

It's currently returning a double. As part of the process of rewriting the
animation engine we're replacing doubles by base::Time* alternatives.

Bug: 737867
Change-Id: Ibfaf523e3879ed2b8a34bf0ca710d46b3ac1f8c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814820Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#698648}

No behavior change.

Bug: 961769
Change-Id: I6cd1658bf18f6c0f66348d0270b0d1e08082cf74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817097Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698647}

This reverts commit 611c2959.

Reason for revert: Relanding without breaking downstream by keeping
nativeIsGoogleSearchUrl around until downstream use is removed.

Original change's description:
> Revert "JNI refactor: @NativeMethods conversion for more //chrome classes."
>
> This reverts commit 266b083e.
>
> Reason for revert: Compile break on android-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/113718
>
> Original change's description:
> > JNI refactor: @NativeMethods conversion for more //chrome classes.
> >
> > This CL was partially generated by
> > //base/android/jni_generator/jni_refactorer.py.
> >
> > Two classes converted in this CL:
> >   * UrlUtilities.java
> >   * DevUiModuleProvider.java
> >
> > The tests were manually refactored to not use robolectric shadows
> > for UrlUtilities native methods.
> >
> > Bug: 929661
> > Change-Id: Id3fbe2f7e53f3c0aa454aa51e1e94a2a6f0f1cb6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815344
> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> > Auto-Submit: Eric Stevenson <estevenson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#698556}
>
> TBR=agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org
>
> Change-Id: I2c9251ec65af0ab7ff5012d218c3860f14214e9d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 929661
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816970
> Reviewed-by: Nate Chapin <japhet@chromium.org>
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#698594}

TBR=japhet@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org

Bug: 929661
Change-Id: I0fe8d84b9fd1992d598fa7630b1f42042dca3279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816728
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698646}

The dedicated folders do not add much value, and in-fact get in the way by
resulting in too many BUILD.gn files and js_type_check targets.

For example viewer-pen-options:closure_compile target was not referenced
anywhere (fixed).

Merging all elements to a single folder makes things a bit easier for the
Polymer2 to 3 migration.

Bug: 1005029
Change-Id: Ic01de6e17486417dee79de791baddf3d9b338f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815078
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698645}

Speculative fix for UAF when Tabs are being destroyed while their
context menu is still active. This destruction seems to happen due to
nested event loops running during context menus where tab-removal
animations can finish and delete a Tab while its context menu is still
running.

This ends up cleaner than prior as Tab would always delegate to
TabStrip, now TabStrip gets called directly, removing one step in the
call chain. It also removes a method from the TabController interface.

Before this change Tab was its own ContextMenuController and
ContextMenuController::ShowContextMenuForView() accesses |is_opening_|
after ShowContextMenuForViewImpl returns, hence the use-after-free.

After this change TabStrip is the context-menu-controller. TabStrip is
expected to outlive any Tab context menus here, which would take care of
this specific use-after-free.

This implementation is still brittle as
BrowserTabStripController::TabContextMenuContents holds on to a dangling
pointer, though this seems OK for now as tabstrip_->GetModelIndexOfTab()
is checked, so the pointer isn't dereferenced as it won't belong to any
TabStrip. A follow-up change here might track the Tab pointer using a
ViewTracker.

Bug: chromium:976318, chromium:1003313
Change-Id: I4c9a6b16ca12e695fdf055a995d526f6da1a0712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816971
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698644}

Only affects ExtensionsToolbarContainer which is under a flag.

Bug: chromium:1006192
Change-Id: I0e414881815635b7a4810930cc0ebd142ef493ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815594
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698643}

Bug: 1002923, 539572
Change-Id: Iecd42a6ac0748041a07acbb79d49a52611608fb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816639
Auto-Submit: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698642}

This change introduces DecoratedSuggestionView that is hosting the final suggestion
content view. This class features suggestion icon that is rendered on the left side
of the suggestion itself.
Since the ViewGroup serves as an isolated focus area, it must be a separate entity
from BaseSuggestionView. I chose to implement it in a separate file for clarity and
to ensure future changes do not increase entanglement between the classes.

Change-Id: I413c901b1e119355b27b1f8f970d0acc80cd1d9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726900
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698641}

Tests were setting a global without unsetting it [after the object the global
was pointing to was destroyed]. This would cause subsequent tests to flakily
fail.

Change-Id: I31761deb1f7fe2c592c8e4ead302665f39688a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815830
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698640}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/e0aac4191fbd..6f647b543901

git log e0aac4191fbd..6f647b543901 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 engeg@google.com paygen: Extend Mem Semaphore across processes
2019-09-20 ahassani@chromium.org nebraska_wrapper: Fix the logic of raise error
2019-09-20 andrewlamb@chromium.org chromeos_config: Remove provision suite.
2019-09-20 tcwang@google.com afdo: Update mechanisms of comparing newer artifacts.

Created with:
  gclient setdep -r src/third_party/chromite@6f647b543901

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I87602f107852573932d85a7e2b407d7917d77499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815825Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698639}

Change-Id: Ide1b92ea746db1bee5c6cc9f12bbbc875fa58341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790380
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698638}

Convert the remaining references to the old Mojo types from the
mojom::ModuleEventSink interface.

Bug: 955171
Change-Id: I130747ca282ac78fe4046ff50c3d942f51661d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813324
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698637}

headless_browser_tests fail with native window occlusion turned on.
Specifically, headless browser tests have |root_window_hwnd| of 0, which
causes a DCHECK when the tracking is disabled for the window.

This is in preparation for enabling native window occlusion by default.

Bug: 813093
Change-Id: I525f8f1c1572654bc5e5ea25dca385d3d7c48fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815609Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698636}

The relayout after toggling a checkbox resets the scroll poition, causing a
jarring scroll to start of the list. The fix is to retain the original scroll
position during the layout.

BUG=1000599

Change-Id: I9102c924ac9526ed604124d99677506bca76469f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815537Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698635}

This CL adjusts the logic of merging prepopulated data into search
engines. The goal is to preserve Play API search engine record.The
behavior should be:
- When new prepopulated engine matches Play API engine, merge them.
- When prepopulated Play API engine gets updated, apply updates.
- When prepopulated Play API engine gets removed, keep the record.

BUG=1002271
R=pkasting@chromium.org,wylieb@chromium.org

Change-Id: I75822512bde4024f32af24565d66d87158732cbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814642Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698634}

Now it is possible to define exact set of sys events to trace. This CL
utilizes this functionality in order to reduce footprint on memory usage
and speedup tracing analysis.

TEST=Locally, tracing tool works as expected
BUG=b:140939504

Change-Id: Ibceca4d372a368bc07a38812f9c87381199c51d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816798
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698633}

These tests were crashing due to a Dawn bug in resource deallocation
which has been fixed.

Bug: dawn:227
TBR: kainino@chromium.org
Change-Id: Ia16c3c53eabbea2837a47402d8326b0b940ef69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816983Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698632}

In preparation for RootWindowController to own a SplitViewController,
the present CL arranges for the objects to be created at about the same
time, and destroyed at about the same time.

Bug: 970013
Change-Id: I0bcb60c76055124521dd3a33c4a06a299e9ccf0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811639
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698631}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e63bdb69ecd3..a75fd3592a81


Created with:
  gclient setdep -r src-internal@a75fd3592a81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Idcea8d6c96ebddf0ffe57c7fa4dcd18827e2f663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816994Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698630}

https://chromium.googlesource.com/angle/angle.git/+log/dd4a00a06d01..11dc16350cd4

git log dd4a00a06d01..11dc16350cd4 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 aukinros@microsoft.com Add support for generating UWP (Windows Store) projects again

Created with:
  gclient setdep -r src/third_party/angle@11dc16350cd4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Bug: None
Change-Id: I338729368905d22f1b93c7599a4ff3562c4eb975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816556Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698629}

All observers of the AccessibilityController shall be removed before the
AccessibilityController is destroyed.

Change-Id: I8b4cab4ce71a3bfb53c2f04b940dde218a494124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816301
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698628}

This CL adds initial IME support to ozone/x11 by reusing libgtkui's
LinuxInputMethodContext{Factory} implementation, which uses gtk-immodule as
backend.

Some logic has been added to be able to support the following scenarios,
possible, from now on, in ozone linux platforms:

(1) LinuxInputMethodContextFactory is implemented inside ozone backend
implementation, it is instantiated set in OzonePlatform::InitializeUI. E.g:
ozone/wayland.

(2) If the ozone platform initialization have not created/set a
LinuxInputMethodContextFactory instance and GtkUi is in place, then it is set
as the global instance. E.g: ozone/x11.

Even though the logic to support the aforementioned use cases is quite tricky,
spread over different layers (e.g: views::LinuxUI, libgtkui::GtkUi,
ui::OzonePlatform), using ifdefs, etc; it should be cleaned up and unified once
X11 migration to Ozone is completed.

It is worth noting that proper IME support for now requires GLib message pump
(at least IBus, for example) being used in UI thread (i.e: use_glib=true).

Bug: 987939, 789065
Change-Id: I700d39eec02c6bbeaafca29c9405e8e0e1ff6ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798263
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698627}

This is an old TODO left from around 2015,
and it looks like it's not helpful anymore.

This CL also includes minor style clean-up
(function rename, comment editing, whitespace).
No expected behavior change.

Change-Id: Icc6f4e02caa7d7200746f5a3bf76b0df3c6bcb29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801750Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698626}

TBR=yusufo@chromium.org
BUG=

Change-Id: Iec6dc0621a0d0f5c3b8b038c2158fe2ec1bfcacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817181Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698625}

The present CL addresses the problem that AccessibilityControllerImpl
never actually removes itself as an observer of TabletModeController. In
the following part of the destructor, the "if" condition is always false
because the tablet mode controller is destroyed first:

  if (Shell::Get()->tablet_mode_controller())
    Shell::Get()->tablet_mode_controller()->RemoveObserver(this);

Change-Id: Ib35b19751862921691c767520e6803007c763a8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816906Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698624}

This CL reverts r420600 and r459047 - now that MD history and MD
settings have shipped long time ago, there is no need to reset PageState
to avoid mixups when restoring MD-disabled PageState into an MD-enabled
chrome://settings and vice-versa.  This aspect of the CL affects only
the following 3 URLs:
- chrome://history
- chrome://settings
- chrome://help

Bug: 614758, 700350, 976055
Change-Id: I782664d9940c25406f3cd4a226692b75de6bfc48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808089
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698623}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7edc2d63..aa1b7640

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6a090a09078c8c9590b894f5316c663c4b5db848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817078Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698622}

Disabled captured_update_pass nexon under bug 1006335

Disabled worldmarket under bug 1006322

Disabled north_face, kohls, davidsbridal, verizonwireless under bug 1006308

Updated cargurus, dicks_sporting_goods recipes after cachereplayer fix, which
needs the DEPS update for the cipd version

Bug: 1006308,1006322,1006335
Change-Id: If112a8c364d5f934c03298d687435800f2813b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816959
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698621}

This reverts commit b0c92575.

PerfCollector uses a private dbus client bound to the collector sequence,
so it's safe to make dbus calls from the collector sequence.

BUG=b:141021087
TEST=Verified on a local device that perf collection works and it doesn't
     crash the browser.

Change-Id: If67f297a6cefd537f7fce3a3fe2d7f04dc20681f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811865Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698620}

https://skia.googlesource.com/skia.git/+log/2ab109212f0f..6b921b7e4add

git log 2ab109212f0f..6b921b7e4add --date=short --no-merges --format='%ad %ae %s'
2019-09-20 kjlubick@google.com [canvaskit] add support for SkAnimatedImage
2019-09-20 brianosman@google.com Use makeRenderTargetContextWithFallback when creating devices for layers

Created with:
  gclient setdep -r src/third_party/skia@6b921b7e4add

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@google.com

Bug: None
Change-Id: Ibc24acf33e661a644bb61ecd7572cf7323d39d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816991Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698619}

We are minimizing the impact of class verification failures for UrlBar by
putting all the failures into their own subclass. Thus, only the subclass
will fail.

No-Presubmit: true
Bug: 999165
Change-Id: I12ea5e29cdfac7973dbec26b44a1f0b7adf21e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803730
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698618}

This change is to make sure the URL in the Omnibox matches the page
content for navigations made through the tabs API, to make sure that
pending navigations made through the tabs API are not displayed in the
omnibox.
This also involves adding a pending URL entry to the tabs object, which
exposes the current pending URL that has not yet committed, if there
is one.

Bug: 981628, 1000489
Change-Id: I649438987ab11c4389dfbc1ff303c661762ef565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737819
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698617}

https://pdfium.googlesource.com/pdfium.git/+log/b93f7decd493..bf5be75f420c

git log b93f7decd493..bf5be75f420c --date=short --no-merges --format='%ad %ae %s'
2019-09-20 thestig@chromium.org Revert "Disable git EOL policy for .in files again."
2019-09-20 thestig@chromium.org Remove unneeded fx_stream.h includes from headers.
2019-09-20 thestig@chromium.org Remove IsArray() checks in CPDF_Array.

Created with:
  gclient setdep -r src/third_party/pdfium@bf5be75f420c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: I520c65233c5b26a2fab20fcd0e5d35399d0aa83e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815824Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698616}

Add the Assistant lottie animation resource for OOBE UI.

Bug: b/141352784
Test: Manual Test
Change-Id: I3afb598e8025439c79ef6c57ee9560b0fb2f1372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816967
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698615}

Bug: 1006022
Change-Id: I54a875d1a4d59a0e4208f5ae76e7dca7addaf048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815701
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698614}

Notifying of an audibility change in a WebContents is done by calling
NotifyNavigationStateChanged(INVALIDATE_TYPE_TAB). This CL adds
INVALIDATE_TYPE_AUDIO and notifies with this more specific flag instead.

This is to enable the browser UI side to filter this notification and
instead use RecentlyAudibleHelper for this purpose.

This is part of a refactor detailed in the attached bug.

Bug: 846374
Change-Id: I91b9d27453b2910ba262a4af581ac7662cce803e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815725Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698613}

Tokens are passed as string fields in a proto, and therefore should
probably be valid UTF-8, but RandBytes won't generate valid UTF-8.
There's no immediate concerns here, but we don't want to run into
trouble if some system tries to validate the token field.

Bug: 980777
Change-Id: Iefe3391eff6325cfea732bc9004bb495754935d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814694
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698612}

Before: https://i.imgur.com/XfCXuIb.png
After: https://i.imgur.com/Nlc9fqi.png

Bug: 989131
Change-Id: I2f8a69701fbf48fa5329f98c37e5a5bba08f82fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809802
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698611}

It made sense to just remove the dwrite namespaces since these headers are
only included in the other dwrite files (and will only ever be), and standard
Chromium namespace usage is "just one namespace per top-level module" anyway.

Bug: 82078
Change-Id: I9f5808da274d649cbfc8fabdf94980caf1de6edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815667Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698610}