- 23 Apr, 2018 40 commits
-
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=altimin@chromium.org Bug: 825327 Change-Id: I87b81780f737a0be5087f319474f663a3aa89892 Reviewed-on: https://chromium-review.googlesource.com/1024481 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552786}
-
Xi Cheng authored
This reverts commit 850001f3. Reason for revert: <file://notification_helper/OWNERS is referenced in chrome/browser/notifications/OWNERS. After moving this folder, the file is gone which creates a deadlock for "git cl upload".> Original change's description: > Move notification_helper/ to chrome/notification_helper/ > > ... plus all the necessary code migration. A follow-up CL will be used > to update relevant comments. > > Bug: 734095 > Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b > Reviewed-on: https://chromium-review.googlesource.com/1022957 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Xi Cheng <chengx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552762} TBR=jam@chromium.org,chengx@chromium.org Change-Id: Idc75aa458afeaf6c7fe5d36c85c76c60947c0687 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734095 Reviewed-on: https://chromium-review.googlesource.com/1024590Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#552785}
-
danakj authored
These numbers are no longer used as SharedBitmapId registration happens in the same mojo ipc stream as CompositorFrameSubmission. So they don't need to exist anymore. R=kenrb@chromium.org, pdr@chromium.org, piman@chromium.org Bug: 730660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I12fcb70963cfaeebc5ae439ab3eb74dab1486bcd Reviewed-on: https://chromium-review.googlesource.com/1022294 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552784}
-
Xida Chen authored
In my previous CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1023980, I didn't do it right, this CL does it right. TBR=thestig@chromium.org NOTRY=true Bug: 835826 Change-Id: I96919dbe0dc3be285e44315753ffdb4bc87b862d Reviewed-on: https://chromium-review.googlesource.com/1024537 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552783}
-
Derek Cheng authored
This patch removes PresentationDispatcher and related WebPresentation* interfaces. PresentationReceiver now eagerly connects to PresentationService, instead of waiting on document load signal, which isn't available in Blink and is not necessary. PresentationReceiver itself remains eagerly created, which causes some existing assumptions to be broken on the browser side, but should be fixable with further browser-side refactoring (added TODO). Also reverts the BindingSet in PresentationServiceImpl back to a single Binding since PresentationDispatcher no longer exists. Bug: 749327 Change-Id: Ic8296471491088da283450a05a620005b2668ba4 Reviewed-on: https://chromium-review.googlesource.com/961525Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#552782}
-
Fabrice de Gans-Riberi authored
This is a preliminary change to remove the posix source exclusion filter in a future commit. Bug: 835405 Change-Id: Ica1adbaab55c9cc64edd4a1d4dc6b57ddae8f967 Reviewed-on: https://chromium-review.googlesource.com/1022189Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#552781}
-
Tarun Bansal authored
Remove code related to experimenting with different statistical algorithms and ECT computing functions. Those experiments have completed, and there is no need to keep this code around. Change-Id: I0016ba2fda758dae7f3952cc2b120645ef996638 Bug: 834119 Reviewed-on: https://chromium-review.googlesource.com/1023275Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#552780}
-
Evan Stade authored
Also rename it: ARC implies Chrome OS so remove trailing "ChromeOS". Bug: 833533 Change-Id: Iea3644a3b2bbbd2f63273a332f2ee71a4d856f5f Reviewed-on: https://chromium-review.googlesource.com/1022125Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#552779}
-
Xida Chen authored
In my previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1024202, I disabled a test without proper comments. This CL adds a line of comment referencing the associated bug. TBR=thestig@chromium.org NOTRY=true Bug: 835865 Change-Id: I191efd833b6327d26fa2077b431a78fcc9eb8ce4 Reviewed-on: https://chromium-review.googlesource.com/1024377Reviewed-by:
-
Wenzhao Zang authored
Currently preview mode is always enabled on the new wallpaper picker. Change it to only enable in full screen mode. Bug: 834828 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9a0f7934e1466f80fce5682ef116efd5fd2e4b20 Reviewed-on: https://chromium-review.googlesource.com/1023172Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552777}
-
Christopher Grant authored
The full spec for omnibox appearing is a fade-in and slide-in from below, followed by the keyboard fading and rotating up into place. Because the keyboard doesn't currently animate as expected, we have the omnibox slide behind an already visible keyboard, which is not good. This change makes the omnibox simply fade in at its target location. BUG=835896 R=bshe Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Idb68cb9120b144aff0251e39586064a0423fbc1e Reviewed-on: https://chromium-review.googlesource.com/1024240Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#552776}
-
John Abd-El-Malek authored
Bug: 764474 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4b0997299e4780e2f1c20849fe6aa9d10bf81839 Reviewed-on: https://chromium-review.googlesource.com/1013401Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#552775}
-
Alan Cutter authored
This CL implements a review change that was missed in: https://chromium-review.googlesource.com/c/chromium/src/+/1004886 This adds whitespace to associate a comment with an if block for clarity, there are no behavioural changes in this CL. Bug: 814532 Change-Id: Ieb234227dd82c070889a28becad104b018c1833d Reviewed-on: https://chromium-review.googlesource.com/1011464Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#552774}
-
Michael Thiessen authored
Bug: 834499 Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946 Reviewed-on: https://chromium-review.googlesource.com/1023049Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#552773}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/06e2e531..c78c94ca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If2dacada3a0812a554a48dabe919ee72b1409467 Reviewed-on: https://chromium-review.googlesource.com/1023022Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552772}
-
Chromium WPT Sync authored
Using wpt-import in Chromium de678774. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16183 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=ajuma No-Export: true Change-Id: I328ec54ae069bfce1f271ac00afb72296344a3ba Reviewed-on: https://chromium-review.googlesource.com/1023021 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#552771}
-
Morten Stenshorne authored
The spec recently changed from disallowing this to allowing it. Removed a test that expected it to be disallowed, and wrote new tests for the new expected behavior. Bug: 832085 Change-Id: Id6fa0a311fe3f50414c68658d807b99e92acc226 Reviewed-on: https://chromium-review.googlesource.com/1023409Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#552770}
-
Becca Hughes authored
Create the 'transitionend' event listener on the panel on demand instead of leaving it around when we do not need it. BUG=832771 Change-Id: If722535b63052a0fc6383a7b1fbcc158a8fb284c Reviewed-on: https://chromium-review.googlesource.com/1022317 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#552769}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 831796 Change-Id: I14d6ee35c7e7969e1c8117ce8c2914a2d577e8bb Reviewed-on: https://chromium-review.googlesource.com/1024298Reviewed-by:
-
Gabriel Charette authored
Migrate MessageLoop::current() to MessageLoopCurrent in /content/browser/media/capture/desktop_capture_device_unittest.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=zijiehe@chromium.org Bug: 825327 Change-Id: Ife4c6b69dcaa445e9e8df3eb48df560c160f9931 Reviewed-on: https://chromium-review.googlesource.com/1024248 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#552767}
-
Morten Stenshorne authored
The test timed out on a bot here: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/17927 Decrease from 10 to 5. I could successfully run it locally (debug build, even), with idle_callbacks_remaining set to 300 (but not much more), but hey. Change-Id: I664fcda78339e9764e0b07629f2cbec9fe245a84 Reviewed-on: https://chromium-review.googlesource.com/1021374Reviewed-by:
-
Tarun Bansal authored
Bug: 746640 Change-Id: Ie312a7756f5e6917a4d7c2bd107951f4928e97d0 Reviewed-on: https://chromium-review.googlesource.com/1024054Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#552765}
-
Kim Paulhamus authored
The renderer now checks for empty as well as null strings. Crashing if an empty string is presented to the browser-side is technically correct, but it is now caught as a SecurityError in the renderer first. Bug: 830855 Change-Id: Id904864b8f6d57e9e0eb342d287337ba96d368d4 Reviewed-on: https://chromium-review.googlesource.com/1020187 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552764}
-
Ken Rockot authored
Invalid Mojo shared memory handles can be "successfully" unwrapped to invalid base shared memory handles. This may be a little weird, but that API is going away in favor of unwrapping new base shared memory types anyway. So rather than changing the API behavior, this fixes the check in ChildHistogramFetcherImpl so it doesn't attempt to use an invalid base::SharedMemoryHandle. Bug: 835837 Change-Id: If6f4fd5086547e671e4d86363ede9513adb2c054 Reviewed-on: https://chromium-review.googlesource.com/1024114Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#552763}
-
Xi Cheng authored
... plus all the necessary code migration. A follow-up CL will be used to update relevant comments. Bug: 734095 Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b Reviewed-on: https://chromium-review.googlesource.com/1022957Reviewed-by:
-
Xida Chen authored
Looks like mac has a different expected file, this CL changes it. TBR=smcgruer@chromium.org NOTRY=true Bug: None Change-Id: I0d669c8dd8f8b834c9197a38e7a4e82576dc73a8 Reviewed-on: https://chromium-review.googlesource.com/1024448Reviewed-by:
-
Mohsen Izadi authored
A cool off period of 600ms is added between the time page is scrolled to the top and the time a pull-to-refresh can be initiated. If the user tries overscroll before the cool off period is passed, the timer will reset and the user has to wait 600ms more. BUG=702404 TEST=OverscrollControllerTest.* in content_unittests Change-Id: I151ec8ef2faab297e9a80251942040acd40af399 Reviewed-on: https://chromium-review.googlesource.com/1022512Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552760}
-
Cary Clark authored
Replace SkColorSetARGBMacro with SkColorSetARGB. Replace SkColorSetARGBInline with SkColorSetARGB. SkColorSetARGBMacro and SkColorSetARGBInline are macros which will be deleted. R=sky@chromium.org,fmalita@chromium.org Bug: 834984 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I08eb888f0848b9ebad93d2dc782c7a7f73bf7987 Reviewed-on: https://chromium-review.googlesource.com/1020043Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Cary Clark <caryclark@chromium.org> Cr-Commit-Position: refs/heads/master@{#552759}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=scottmg@chromium.org Bug: 825327 Change-Id: I3fe0959f4d7e62f3a05a0748782a44ae2306d496 Reviewed-on: https://chromium-review.googlesource.com/1024439 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552758}
-
Gang Wu authored
Update of feed library and build file. Monochrome.apk_Dex +5 entries methods +225 bytes Java code size +1,080 bytes Compiled Android resources size +601 bytes Transfer size (deflate) +1,491 bytes normalized apk size +396 bytes main dex size +1,095 bytes APK size +2,694.84 bytes Estimated installed size +396 bytes Java code size +36 bytes DexCache +15 bytes Package metadata size +1,824.84 bytes Java code size +1,080 bytes Compiled Android resources size Change-Id: I932caf40786751fa3ca0264534c1cbfb29e26434 Reviewed-on: https://chromium-review.googlesource.com/1023376Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552757}
-
Oksana Zhuravlova authored
Bug: 799482 Change-Id: I2479eb45e4764cc27ce3d56d86e54a8522b223bd Reviewed-on: https://chromium-review.googlesource.com/1020225Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552756}
-
Jonathan Backer authored
This is a deplumbing CL where we remove the unnecessary passing of nullptr around. We don't use client side share groups now that we use mailboxes. Removing this preps for the eventual switch over to RasterDecoder backend for RasterInterface because RasterImplementation is always in it's own client side share group. TBR=boliu@chromium.org,kenrb@chromium.org,haraken@chromium.org,rbyers@chromium.org,sky@chromium.org Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I86bd2e2d9c42064da3d2d3bd1a7881d5392a1b38 Reviewed-on: https://chromium-review.googlesource.com/1015701 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#552755}
-
sczs authored
Inserts the top History message using a TableViewTextItem. The UI will be updated on a followup CL. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I56ef6eece234eb1be50df0949f1400532a961ac6 Reviewed-on: https://chromium-review.googlesource.com/1018014 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552754}
-
Wenzhao Zang authored
1) Prefer to keep the implementation of customized default wallpapers in //chrome. 2) There's no need to put the constants of small/large file suffixes to //ash/public, since they are implementation details, and //ash only needs to know the entire file path. 3) The original idea was to put |ash::WallpaperController::ResizeAndSaveWallpaper| to //ash/public but customized default wallpaper only needs a simplified version of it, so it's inlined. Bug: 827062 Change-Id: I4c94adff973af697ea5f929ba751eb2fe8f019de Reviewed-on: https://chromium-review.googlesource.com/1015744Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552753}
-
Lukasz Anforowicz authored
Bug: 835572, 835573 Change-Id: I76a2d7407d376a92c0dea7649bc877349d862f2f Reviewed-on: https://chromium-review.googlesource.com/1024233Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#552752}
-
Etienne Bergeron authored
This CL is adding DebugID for modules present in chrome. The intent of that CL is to help trace symbolisation by providing the appropriate debug id. R=erikchen@chromium.org Change-Id: I6db22b1020dc3c00e20da781e63be8755f1fb913 Reviewed-on: https://chromium-review.googlesource.com/1014710 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
-
Eugene But authored
This API matches ContentRendererClient::PrepareErrorPage from //content and will be used to load errors into WKWebView as HTML. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I656f2c892430de2840196a224a446111b44f4d9c Reviewed-on: https://chromium-review.googlesource.com/1011383 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552750}
-
Andrew Grieve authored
Change-Id: I7ac0ec87a2f27aba3cf2b93f8cf890d179369055 Reviewed-on: https://chromium-review.googlesource.com/1023911Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#552749}
-
Theresa authored
Use the real FetchHelper, with the request delay removed, for tests. This is a better end-to-end integration test as fewer things are stubbed out. BUG=827348 Change-Id: I34e588d032b0a48871b71a531328f87f705d3716 Reviewed-on: https://chromium-review.googlesource.com/1024055Reviewed-by:
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibf6a5170c220727f537e78722a3555f2e3351f9f Reviewed-on: https://chromium-review.googlesource.com/1024246Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#552747}
-
