- 05 Jan, 2021 24 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f424e015364..1497e56c0f3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com Change-Id: I784e2eddf590adbd264923143ef8ad9776ec29ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610148Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840075}
-
Eric Willigers authored
Attempting to launch an app that has been uninstalled results in nullptr WebContents being returned, with no check failures. Change-Id: I911904a068f9b03d92d5453cbbbdd243fbab2419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608102 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#840074}
-
Stefan Zager authored
This removes all responsibility for setting contents_opaque on foreign layers from GraphicsLayer. Bug: 1069546 Change-Id: Ic0e71392e354b919867e120515dd6235e0c382ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607665 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840073}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eae5c1619083..04ccda6c28c4 2021-01-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I10a1eef4a9840e54d5fdc88aa362bce083632270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840072}
-
Stefan Zager authored
contents_opaque on the canvas cc::Layer shouldn't depend on its host GraphicsLayer; and the host GraphicsLayer shouldn't use any special logic to determine contents_opaque. This also fixes a CAP-specific bug where the paint code would emit a background DisplayItem for a canvas even when the canvas has responsibility for its own background. As a side effect, this appears to fix a Mac-specific webgl bug that was hidden due to bad test expectations files added by: https://chromium-review.googlesource.com/c/chromium/src/+/1005017/ Bug: 1069546 Change-Id: I2a347a6d4a04d2d8b4e299dd0cb10a3c57acbfb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607423Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#840071}
-
Glen Robertson authored
Apps should always declare at least one Purpose::ANY icon (or no purpose declared) to be handled properly on all platforms. Even when a maskable icon is preferred as the primary icon (eg. on Android) an 'any' purpose icon is still needed for other contexts. Companion CL to update DevTools error messages: crrev.com/c/2557277 Bug: 1151835 Change-Id: I1995b1677d1392a5e852e544f34435826cce4e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599733Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#840070}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ia40c893634935ebd430d666c7708e6bf2459ab55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606137Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840069}
-
Eric Willigers authored
This reverts commit 813f4fa3. Reason for revert: Findit suspects test caused failures. Original change's description: > System web apps: Do not launch apps during shutdown > > If the browser process is shutting down, LaunchSystemWebApp now > exits early instead of attempting to launch a system web app. > > Bug: 1121894 > Change-Id: I4ed8baf23e2e58d79cc097566e2b566fdef78619 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607978 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840053} TBR=calamity@chromium.org,ericwilligers@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I885b3f75016ac816c4c4ee715b024e395e9ebf75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610403Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840068}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 5c951623bc8965fa1e89660f2f5f4a2944e4981a`. Bug: 1154382 Change-Id: Iff83fc56e3f0e0172ee4dfdea95cc1144d1d819b Binary-Size: See analysis in crbug.com/1159421 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605479 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#840067}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/da2d927bb127..4110684aa07a 2021-01-05 jiawei.shao@intel.com Vulkan: Fix a bug in the impl of T2T copy with 2D array textures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1161355 Tbr: enga@google.com Change-Id: I16564dab5da0bc077645f2c60c507ba92994599d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610334Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840066}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1041b44508289e65fad6696c32c42e5cc5861a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840065}
-
Song Fangzhen authored
Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 905818 Change-Id: I3d956d6310e865b603a25122d937d70d6dcf2383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608092Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Ke He <kehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#840064}
-
Eric Willigers authored
If the browser process is shutting down, WebAppLaunchManager::OpenApplication now exits early instead of attempting to launch a web app. Bug: 1121894 Change-Id: Ic67f4c89a02082d13d867a8484b3b2c368c96900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608095Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840063}
-
Jing Wang authored
Implemented a first version of grammar check client, which just throw the entire requested text to grammar service and if it returns with any suggestion other than the original text, we will mark the whole sentence and show the suggestion in context menu. Design doc of the feature: go/cros-grammar Screenshot of the feature: https://screenshot.googleplex.com/BqkRhx6BYC2LPiF This feature is ChromeOS only and is hidden behind a by-default disabled flag. When the flag is enabled, and when enhanced spell check is enabled, we will call grammar check when enhanced spell checker detects no spell errors and display grammar error if we find any. It is not ideal to always check the entire input and mark the whole sentence. The feature is to be improved in the follow-up CLs, but I think this is good enough as a first version. Bug: 1132699 Test: tested on DUT Change-Id: Ie2a8ca99e2f6910e9eef6bb3c7eb5da980a4db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585245 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#840062}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609782840-839bd136deb880fc20cbdc9d089b73d42309602b.profdata to chrome-mac-master-1609804351-3203bece27fc3ccf79be3681f60781e79b3a670b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I61fbb4918526715c137c3dd543e16f554b0f0806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840061}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/364205c70ed1..81098e59adfc 2021-01-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I52a1abf0f473c896503230eb12fbef597c4e7866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840060}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609782840-2863408690cf666d03abe5466bfc61c0dcf0aee3.profdata to chrome-linux-master-1609804351-8e613a6255234d0544dc8b2f463c1386e923a27d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I486eb928d661f1afbaa0be668b16d42d67b5c612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840059}
-
Angela Gyi authored
This CL adds a single example of a ShareAction for testing the content previews feature on Chrome OS devices. Bug: 1159279 Change-Id: Ia8e0e5dfbc00ab664468667363ece01f4b71ad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592276Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Angela Gyi <angelagyi@google.com> Cr-Commit-Position: refs/heads/master@{#840058}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6dd30db1029..8f424e015364 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I82e826e53cf8f47ecc5ee35fb04c6fd2b8bb84a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609846Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840057}
-
Daniil Lunev authored
The actual usage of the field is removed as of https://chromium-review.googlesource.com/c/chromium/src/+/2513592 And after this CL the field is deprecated in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2594928 Bug: none Test: none Change-Id: If86b0b65c9dd28b25d68778d640380dd55b46b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596276Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#840056}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.139. R=rmhasan@google.com, tikuta@chromium.org Bug: 1041619 Change-Id: I4425be5bb5d32f7c80659af6654c3474da000044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609784 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840055}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.74. R=rmhasan@google.com, thakis@chromium.org Bug: 1041619 Change-Id: I26c3061f6b12bcba5f5a33165bad501c3e0b4ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609785 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840054}
-
Eric Willigers authored
If the browser process is shutting down, LaunchSystemWebApp now exits early instead of attempting to launch a system web app. Bug: 1121894 Change-Id: I4ed8baf23e2e58d79cc097566e2b566fdef78619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607978Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840053}
-
Jinsuk Kim authored
This CL moves some of c.b.toolbar/ classes in the core build target to a new modularized one under chrome/browser/toolbar. The rest still stay in the core target due to direct or indirect references to dependencies such as omnibox. Bug: 1127732 Change-Id: I160deef07817b05dfd8e22adbd65225456de29ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592277 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#840052}
-
- 04 Jan, 2021 16 commits
-
-
Chloe Pelling authored
Now it's fully general, so can be used by Borealis. The unit tests do still depend on Crostini, for now. Bug: b:173546714 Change-Id: Id88527e2bc631f60b8885a56c88cd619d4172250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578421 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#840051}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0149043b4b69..9d7f897b22c2 2021-01-04 chrche@microsoft.com [Loc] Migrate recorder to localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I43d774bc546dbb3b4fd841ccc5cddc781b526124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840050}
-
Aleks Totic authored
wpt/css/css-position/sticky/position-sticky-nested-table.html test was broken. It failed in FF/Safari, and Chrome with TablesNG. https://wpt.fyi/results/css/css-position/sticky/position-sticky-nested-table.html The broken part of the test insterted an absolutely positioned element as a sibling of every element with sticky position. The abspos element is then positioned so that its position matches sticky elements position. I am not sure what this was testing. This does not work for tables, because instertion of abspos sibling to td element creates an anonymous table wrapper. The anonymous wrapper becomes abspos container. This CL removes creation of the abspos element. The test now passes in all browsers. Change-Id: I548afad533040509567ca24265306ace0d28d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610190Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840049}
-
Xianzhu Wang authored
Previously the main frame widget was 0x0, which was not realistic. Some tests relying on painting would fail if we didn't paint empty frames. Also modify NotifySwapTimesWebFrameWidgetTest to meet the requirement of cc for layer lists. Otherwise the cc would complain about incomplete paint property setup. Change-Id: I774b166dc96396706075fa7129e07337ba2a06c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609913Reviewed-by:
Stefan Zager <szager@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840048}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2204594104f3..c6dd30db1029 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I899c3911d2f5ed9ba5c8be9d875edb7fd85c3d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840047}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8ff313e4485..eae5c1619083 2021-01-04 csmartdalton@google.com Reland "Enable GrTessellationPathRenderer by default" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ia554a562fd46e5f67ddda445ca39b5176a322f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840046}
-
Stefan Zager authored
Currently, the only case where remote frames let the blink compositor set contents_opaque for a remote frame is when displaying the sad tab graphic for a crashed frame. The sad tab graphic is not opaque, and we shouldn't ever set contents_opaque on its layer, regardless of the style of its containing <iframe> element. Bug: 1069546 Change-Id: I04636d2b6cead84d224913563fd6e9bab34069d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606659Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#840045}
-
Caroline Rising authored
Bug: 1156133 Change-Id: Ib2ec4b378efee1a3bed0243654b80c70af65ce63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595458Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#840044}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8673643bc2e3..92d8ee9b37c0 2021-01-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5749e436..4ae11810 (839925:840025) 2021-01-04 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-04T04:02:59). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b3b23710ab0af8ddd53b74c07bffcf24b21a313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840043}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9f0b827df13b..da2d927bb127 2021-01-04 cwallez@chromium.org Add TypeTraits.h for Dawn's additional type traits. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I17fadb50fb37fd93f0f3a83839b1f8b2978bf2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840042}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3c28bc9374300c0bfc9aaa6d3e6618f05787dd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610284Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840041}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609761589-0c82de93ff4d6fbe86c8ef40f71edb36be45c2bb.profdata to chrome-mac-master-1609782840-839bd136deb880fc20cbdc9d089b73d42309602b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I402956557f2f7ea11390ccde4274cc194741d1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840040}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609761589-bf0cb2913712fa2a4ac89d01acd5cc080b4903cf.profdata to chrome-linux-master-1609782840-2863408690cf666d03abe5466bfc61c0dcf0aee3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I37f6a532e86bd25cf9ea3892a6f83f74bfcd5a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609678Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840039}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a92f13579fb..d8ff313e4485 2021-01-04 reed@google.com Plumb sampling to drawSpecial, drawDevice 2021-01-04 reed@google.com Use sampling instead of (deprecated) filter-quality If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I69ffe23df1615f422b2555ecc4623d1a30895813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94096d83a38e..2204594104f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I47aae6576c2f9b1e396f2530b4c95ff6b1ef21fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610124Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840037}
-
Manuel Rego Casasnovas authored
This patches converts the js-test.js test into a testharness.js, and move it to WPT upstream repository. BUG=523126 Change-Id: I3f5a6338f38af731d18f547c75bd9fd7274b5ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610084Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#840036}
-