- 16 Jan, 2021 19 commits
-
-
adamta authored
Ensures correct scroll position on refactored NTP when opening new tabs and when navigating back from a webpage to the NTP. Bug: 1114792 Change-Id: I365034f218445e6ff8e1483dabb18202f7af976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633581 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#844311}
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I19542959e230536269b4efe8b707c95957a8bce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618140 Owners-Override: James Cook <jamescook@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844310}
-
Patrick Noland authored
This move also allows/requires us to: * Move backKeyPressed/mOriginalUrl/getOriginalUrl * Stop overriding backKeyPressed and setUrl in SearchActivityLBL In the latter case, we continue to override back key behavior via a delegate. As far as I could tell it's safe to stop overriding setUrl, since: * SearchActivity's LocationBarDataProvider only ever returns an empty UrlBarData * SearchActivity's's UrlBar can't be unfocused Just to be sure, I've added a test for this scenario. Bug: 1147581 Change-Id: Ic1291b788a4913980d542135a828120e4a7cb353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594214 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844309}
-
Aaron Colwell authored
Changing the RenderViewHost parameter to a WebContents to more closely match the signature of OverrideWebPreferencesAfterNavigation(). This change also makes it clearer that the RenderViewHost that was being passed in was actually one for the WebContents main frame. This in turn makes it easier to replace GetSiteInstance() calls on the RVH with calls on the WebContents and be assured that the behavior is still correct. Replacement of these calls is part of the refactorings needed to remove the SiteInstance member from RenderViewHost. - Replaced RenderViewHost parameter with WebContent pointer and updated all function signatures of overrides. - Removed a few RenderViewHost to WebContents conversions in overrides since the WebContents is passed in directly now. - Replaced RenderViewHost::GetSiteInstance() calls with WebContents::GetSiteInstance() calls. - Replaced rvh->GetProcess()->GetBrowserContext() calls with web_contents->GetBrowserContext(). TBR: boliu, jamescook, rdevlin.cronin, dalecurtis, mlamouri, dpapad, seantopping,falken, ddorwin, dgozman Bug: 1166021 Change-Id: Ie39614b3de07383114915813fb959be017dd4b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626355 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844308}
-
Lijin Shen authored
MessageUtils resets the accessibility utils to null when one of the activities is destroyed, which causes the crash when another activity is about to show a message. This CL removes static message utils and passes in the a11y util directly to the classes which need a11y info. Bug: 1167098 Change-Id: I5404f35ec173ab25334e8108a27b4886f1bb9478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634122Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#844307}
-
chinsenj authored
This CL renames AssignToDesksMenu to MoveToDesksMenu. It also updates comments related to this. Additionally, this CL also updates the command ids and strings related to this menu. Test: manual Bug: 1166856 Change-Id: I24813b042e674031f3c09b74f4aaa5967df77aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630769Reviewed-by:
-
Azeem Arshad authored
This adds OWNERS for //chromeos/dbus/hermes. Points to //chromeos/network/OWNERS Bug: 1093185 Change-Id: I31373e9644a9f2100956b3a54c79010736e1fd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633804Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#844305}
-
Elaine Chien authored
Allow Enterprise admins to apply the policy without needing a browser restart. Bug: 1158427 Change-Id: I52dc1488eb1c29ec4d93c73169e4523efd838244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633070 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#844304}
-
Tom Anderson authored
This is needed as a prerequisite for [1]. It also improves performance a bit by replacing a node-based data structure with a flat one. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2622521 Change-Id: Ibe2e522f6c131876ed73793305524c25b42ab910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625784 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Yue Zhang authored
Bug: 1157892 Change-Id: If79167aa5cb6af2a9e639a93596410f18d39a144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616974 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844302}
-
Jon Mann authored
Existing users of the multidevice suite will have Wi-Fi Sync set to be disabled by default when it is first. This adds a notification to announce the feature to these users on the first unlock after the feature is available. Bug: 1117619 Change-Id: Ia580ed2b4f99561a7295e585bc3cfa592ee5f1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630733 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Bug: 1167174 Change-Id: If793ee4b3e96782abf0f812f771840020b9f5741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633827 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844300}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610722723-5f792ea0c486212ce0348d8664e26e62d0b387f7.profdata to chrome-win32-master-1610733364-857d9e0d0931ba77d21c7c00c0f6edaa64750af0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6740749d2b86af053c3ebcf696f8b1b0f567d788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844299}
-
Ken Rockot authored
The mock geolocation service expects a new position to be set by the time any new queryNextPosition request arrives. This test was designed to call watchPosition and iterate over multiple steps, with each step updating the mock position so that the watcher's next queryNextPosition can be appropriately satisfied. Unfortunately one of the steps does asynchronous work before updating the mock position, so if the mock happens to receive a queryNextPosition on behalf of the watcher before that work completes, it will throw and fail the test. Flake ensues. This addresses the issue by more carefully synchronizing the mock state against the test logic, ensuring that stray queryNextPosition handling is deferred during the asynchronous work. Fixed: 1083824 Change-Id: I53b60d1104616bc1644573b48271823060698569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634006 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844298}
-
Stefan Zager authored
Both of these structs contain information based on the geometry of an iframe within its embedding document, and they are updated at the same time, but they are transmitted to the remote render process via independent IPC's. This creates a race condition in the remote render process: if it happens to run a lifecycle update in between receiving the two IPC's, it will have an inconsistent view of its frame geometry. With this patch, the remote render process will receive both updated structs via a single IPC. Bug: 1135714 Change-Id: I93224e0a97c7f37896c925b6b97caa2328267710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628746 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#844297}
-
Keren Zhu authored
A DCHECK in ~EventHandler() of OverlayAgentAura checks if the event handler is removed from its target. Call RemovePreTargetHandler() in ~OverlayAgentAura() so that this condition is met when closing the browser window. Bug: 1163950 Change-Id: Ia8096f057af3bbfc54bc45ccde538dfdb09bf895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633691Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844296}
-
Jerry Zhang authored
On Windows, Chromium may fail to read the function path in GetFunctionInfo() after the USB device is plugged in. But the empty function path is still added to the functions vector which is passed to the constructor of UsbDeviceWin. We need to update the FunctionInfo in the calling of UsbDeviceWin::UpdateFunction later on. Otherwise, Chromium will report errors while the USB APIs are called from upper apps due to the empty path check. Bug: 1166403 Change-Id: I539890dd66cb2f313f2dd413cce1a8ece56a4e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628704 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL update the codes so that all tests from JavaBridgeArrayTest pass with MojoTestParams. Bug: 1149011 Change-Id: Icc090585fa6cf95818ec9d5e1609f1791c5a9427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613084Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#844294}
-
Fabrice de Gans-Riberi authored
TBR=abigailbklein@google.com Bug: 1162238 Change-Id: I3223a7d38889f7a1925a37be5ede03839675cee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633188Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844293}
-
- 15 Jan, 2021 21 commits
-
-
Azeem Arshad authored
This CL adds a flag that when enabled will cause Cellular Setup and Settings UI to use the external Euicc instead of the on-board Euicc. This is useful for testing with test eSIM cards that can be inserted in physical slots and appears as an additional Euicc in Hermes. Loadtime data value will be used in polymer elements in followup CL. Bug: 1166697, 1093185 Change-Id: Iccccd2152f588dd7cae9f6d7fdd108795a46f118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630431 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Nina Satragno authored
Show an error message on the Security Keys Set PIN settings page when the new PIN is the same as the current PIN. Under some circumstances, keys won't accept a PIN that is equal, so show an error early to be safe. The string provided was wider than the input, so to avoid shifting the confirm input to the right, the error text is allowed to overflow with white-space: nowrap (see the screenshot). UXR review: go/force-pin-change-ux Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/a775ab5fe5a6302c4f83dc1b4863d21ff7b20ff0 Tbr: cpu@chromium.org Fixed: 1152510 Change-Id: Id17f114c240469608fb0ef785bc5db4daba11a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615458Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#844291}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f4c064d5b74..bfd330d08195 2021-01-15 reed@google.com Add filter param to picture-shader 2021-01-15 hcm@google.com update release notes for m89 2021-01-15 johnstiles@google.com Add Type::isEnum helper method. 2021-01-15 tdenniston@google.com [svg] Implement feBlend filter 2021-01-15 brianosman@google.com Fix an (int + float) error in "cube" particle demo 2021-01-15 mtklein@google.com pull arm64 binary on arm64 Mac/Linux 2021-01-15 tdenniston@google.com [svg] Fix incorrect optimization for opacity layer 2021-01-15 csmartdalton@google.com Disable the MSAA atlas mode for CCPR 2021-01-15 reed@google.com Simplify common case for recttorect 2021-01-15 johnstiles@google.com Restrict the creation of built-in types to BuiltinTypes class. 2021-01-15 fmalita@chromium.org [svg] Minor cleanup 2021-01-15 johnstiles@google.com Migrate BuiltinTypes to a separate file from Context. 2021-01-15 reed@google.com Simplify common case of linear filtering with no mips If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: Ia8da9b9b594005f641d3b9f04bf0d50bfc985f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633396Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610722723-f9a37ccb3c40c7cf55cb95edac87150ac0997011.profdata to chrome-win64-master-1610733364-0048730fde812fecdb18597677d6c98bc22e5905.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I97f744a472bd2fff384507b9fca309e0507865ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634007Reviewed-by:
-
Scott Violet authored
I'm hoping to use this as a debugging aid for folks that encounter problems. Specifically I'm planning on creating a page that shows this information, so that if a user thinks restore should have happened they can open this page for some diagnostic information. This is just the persistence part. BUG=1167296 TEST=SessionServiceLogTest* Change-Id: I0385c45e4b2913bcf7e601a3caf9c8f26ca15546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633072Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844288}
-
Leonid Baraz authored
Convert uint64->int64 where necessary. Also, when uploading, generate double sequeincing information in EncryptedRecord to enable gradual server transition (unsigned one will go away later, with only signed one remaining). Bug: b:174509632 Bug: b:177677467 Change-Id: I8deec42dfa4978b5fdf3fbee9ee8e77cb58f0a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631725 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#844287}
-
kyle Ju authored
Bug: 1167318, 1167321 Change-Id: I444c090f5e9ae90168fa29cb3a4cec788bb6cb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633372Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#844286}
-
James Cook authored
This is a step towards allowing existing interactive_ui_tests to use the TestController crosapi interface to interact with the ash window manager. We have to filter out one test, because hooking up crosapi applies a restriction to the main browser profile that it is a "regular" profile that matches the device account. This restriction matches production behavior, so this is desirable in general. Bug: 1166936 Test: interactive_ui_tests Change-Id: I20ace7c9f98be32596437de8223c069bd7fcffaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631746Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844285}
-
Stephen McGruer authored
Due to mandatory code review, we need to migrate off of the automatic copy of tools/ in external/wpt, and instead use the manually rolled copy in blinkpy. Bug: 1165950 Change-Id: Ib38a8db4de3d52e2b590b7aaef35b5c01bdaad91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626048Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#844284}
-
Lachlan Ford authored
This change contains the flags, IDL definitions and blink stubs for the WebXR Hand Input module. https://immersive-web.github.io/webxr-hand-input/ https://github.com/immersive-web/webxr-hand-input/issues/ Subsequent changes will provide the Blink implementation, OpenXR device implementation and test code. Change-Id: I90169c4be02cf5daa29283a3fdf7fda6a4a2c319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623532 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#844283}
-
Hui Yingst authored
Change-Id: I660cee5c3c59c263a01935ee6b16a283f7680cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634008Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844282}
-
Ken Rockot authored
Bug: 1004256 Change-Id: Ib3d235767a074de954326085484e737ba6c8457a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633269Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#844281}
-
Adam Langley authored
With CTAP 2.1 it's possible for a security key to have an RP ID hardcoded into it which can receive enterprise attestation on request. If the RP ID is listed in the enterprise policy then this is permitted automatically. Otherwise, we need to alert the user that this is happening. This change adds an attestation permission step to the WebAuthn UI which acts the same as the current one, but with different wording to reflect the greater impact of enterprise attestations. Change-Id: I27fb9f7978b112910a51424f48c8e2567b146719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616736 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#844280}
-
Gavin Williams authored
This changes fixes a bug where the wrong option in the dropdown is selected when the selected scanner is changed. This happens when the new scanner has different available options than the previously selected scanner. Bug: 1166808 Change-Id: I2f81f39358ad6c104e1dc360d429cc14cbe94055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633087Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#844279}
-
Aaron Leventhal authored
R=chrishtr@chromium.org Bug: 1166296 Change-Id: I26d9e83ce62d9b28a610cf7e747cc4403af3c2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633027 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Yi Gu authored
See linked bug for details. TBR=aleventhal@chromium.org Bug: 1167331 Change-Id: I4b9ec1ec4acd90d59765655f18ea7a406962c7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633924Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
Scott Violet authored
I believe these should all be converted to other more appropriate conditionals. BUG=none TEST=covered by other tests Change-Id: Ibd81116aa800ce25876fe3816569b71139007b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631350 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844276}
-
Josh Santana authored
Added UMA histogram metrics for the browser settings UI. Mainly affects language_page.js and add_languages_dialog.js. The metrics tracked should now match the android version's implementation here: https://uma.googleplex.com/p/chrome/histograms?sid=475eec68a50e5bcf24652249c380d74e Bug: 1159266 Change-Id: Id533c550b27ca3630a793131f47258b64a404e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600455 Commit-Queue: Joshua Santana <joshsantana@google.com> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#844275}
-
Kaiyu Chen authored
The feature flag controls the GPay native app integration for dynamic update on Android. If this feature flag is enabled, the GooglePayPaymentApp would enable a callback service and handle communications between the native GPay app and the browser for dynamic updates on shipping and payment data. Design doc is go/dynamic-update-mweb. Bug: 1074423 Change-Id: I898199446179d6c314b833c3ecb8f017481fc596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628745 Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#844274}
-
Joshua Peraza authored
Bug: 1163660 Change-Id: I272e8006207b917d8b58b67a783f81c919952c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622956 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844273}
-
Alex Newcomer authored
Files app copies raw images onto the clipboard by: 1. In JS, save files app metadata. 2. Later, on the chrome side, add raw image data by: - Reading step 1's data from Clipboard. - Add raw image data. - Write to clipboard a second time. In a way, files app uses the clipboard as a temp variable. This results in two entries to ClipboardHistory. Delete the old one, then allow the second Write to create a new entry in history. Bug: 1150155 Change-Id: I90649d9b56ebfc538ab962e4c769a869b9d5d082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630405Reviewed-by:
-
