- 11 Dec, 2020 40 commits
-
-
Dirk Pranke authored
This reverts commit bb97ab9b. Reason for revert: Various breakages. Original change's description: > Force Python 3 to be used in build. > > This CL makes Python 3 be the default script executable used by Ninja > to run action() and action_foreach()'s during the build. > > This does *not* mean that everything works with Python3; many targets > may still use Python 2 via the python2_action() and > python2_action_foreach() targets or via custom logic. > > However, it does mean that it should prevent regressions from > creeping in. > > This CL should not be taken to imply that we can start to write > Python3-specific code that can run during the build; we should > still be trying to ensure that everything is compatible with Python2. > > Also, this CL does not enable the use of vpython in actions; we should > still avoid that because vpython is slower than direct Python > invocations. > > Bug: 1112471 > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#836234} TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#836284}
-
Carlos IL authored
Features were enabled by default in crrev.com/c/2583141 and are no longer required to be in fieldtrial_testing_config.json Bug: 1105210 Change-Id: Ie984ea0e17d151cf9105ab85ba11e6a4c4762457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586771 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#836283}
-
Carlos IL authored
As discussed with a11y team in comments 29 and 31 crbug.com/1061611, it is desirable that the net error code in SSL interstitials (which can be clicked to show the certificate information) has a button role for screen readers and other accessibility devices. This adds the role when the error code is clickable. Bug: 1061611 Change-Id: I02ac3ba3253fae3fcecff09da5fb7b683ba09258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582469 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#836282}
-
Joon Ahn authored
String spec "Nearby Share - Receiving - Confirmation" Bug: n/a Change-Id: I487c5c991c66eaa75cce9f59ce94e481d3cb57e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586253 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#836281}
-
Alex Moshchuk authored
Bug: 1157861 Change-Id: If1867229c04d823bea330375546f7dfe910d9262 Tbr: tvanderlippe@chromium.org No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587395Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836280}
-
behdad authored
Submitting a bulk of skipped compositor frames as dropped frames can affect the normalized worst case percent dropped frames. This change stops submitting skipped frames more than the limit (100 frames). Bug: 1157101 Change-Id: I63c6f57c9d6c7fa2021842f13f1ca86ff7c9fd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583008Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836279}
-
behdad authored
Frames which are started prior to first contentful paint will not be added to frame_sorter and as a result would not be reported as part of normalized smoothness metrics. Bug: 1157479 Change-Id: I665172b297c38ada0e2d468417342e5c2df06374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584647Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8b9cff42b376..7542517e29ce 2020-12-11 heiserya@google.com Escape user_agent when launching Lacros If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1148485 Tbr: wenbinzhang@google.com Change-Id: I739a914a8742d5cb2cdd1307c4f19c7accc43a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836277}
-
Alex Moshchuk authored
This reverts commit a28187dc. Reason for revert: After this change, PermissionPromptBubbleViewBrowserTest.AlertAccessibleEvent is failing consistently on some Mac try bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/58202 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/40075 Sample failure: ../../chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view_browsertest.cc:199: Failure Expected equality of these values: 2 counter.GetCount(ax::mojom::Event::kAlert) Which is: 1 Original change's description: > Implement a11y support for permission chip UI > > Announce to screenreaders that a permission has requested if chip UI is > used. For prompt UI, the bubble is shown and it takes over the focus. > Chip UI is less intrusive so it must be explicitly annouced for screen > reader users. To avoid users not hearing the announcement, it would be > reannouced after 2 minutes. > > Chip UI is now one of the panes (users can cycle through panes with F6). This way users can easily access it with keyboard which is very important for screenreader users. > > Also to make sure that users don't miss pending permission request, added message about having pending permission request to tab announcement. > > Bug: 1150836 > > Change-Id: I7118abcf0bed9702cf17d15a9bb59f9a1d8783b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578843 > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836198} TBR=bsep@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,olesiamarukhno@google.com Change-Id: I3f11f1b4de624199c5ba2a4c4f4c7c327a7cde8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586966Reviewed-by:
-
chrome://accessibilityKurt Catti-Schmidt (SCHMIDT) authored
This change creates a ViewsAXTreeManager for each top-level Widget behind the runtime flag "--enable-features=AccessibilityTreeForViews". This change also displays the contents of the entire tree built by ViewsAXTreeManager under chrome://accessibility under a new "Top Level Windows" section that is only visible when the runtime flag is enabled. Much of the code changes here are converting methods that serialize BrowserAccessibility nodes to instead take AXNode's. This was fairly straightforward for most of these, however AccessibilityTreeFormatterBlink::AddProperties had to be forked due to all of the properties that depend on the delegate. WidgetAXTreeIDMap is added to map between Widget objects and their root AXTreeID. In order to suppress build errors on ChromeOS and macOS, this change is limited to non-ChromeOS Aura builds (Windows and Linux). AX-Relnotes: Displays internal UI tree in chrome://accessibility. Bug: 1049261 Change-Id: Id3918e177df360b284d186638a04d8be494508c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402398 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#836275}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/29339074e443..82e0d524143f 2020-12-11 nifong@google.com Don't crash debugger on missing images 2020-12-11 bsalomon@google.com Improve clamp mode in GPU blur with downsampling. 2020-12-11 tdenniston@google.com [svg] Prep work for filter primitive subregion 2020-12-11 egdaniel@google.com Add gr_cb class to help tracking command buffer uses of GrGpuResources. 2020-12-11 bsalomon@google.com Add new SkCanvas methods for Android Framework WebView queries. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1156804 Tbr: jmbetancourt@google.com Change-Id: I32ec8fb58d79617e115a18c825eda38c107e6531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587509Reviewed-by:
-
Toni Barzic authored
Leaves HoldingSpaceTrayIcon to only handle the content forward icon. Adds another image view for the default icon, and lets HoldingSpaceTray manage which icon is visible. Removes holding space observation logic from HoldingSpaceTrayIcon to avoid duplicate event handling to avoid HoldingSpaceTrayIcon getting duplicate holding space model events - e.g. if the icon is created or initialized during OnHoldingSpaceModelAttached, and starts observing model changes itself, it may handle model attachment twice. Relying on HoldingSpaceTray to notify HoldingSpaceTrayIcon about model changes makes avoid such scenario easier. The end goal is to make HoldingSpaceTrayIcon not depend on individual holding space model changes, and just have an API that would specify the list of items whose previews should be shown in the tray icon - will be done in a follow-up. BUG=1142572 Change-Id: Iad3bc7089d2aec770e03ef88bf168d3e43f706da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586554 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#836273}
-
Ryan Sturm authored
This adds three histograms: -- Why the prefetch was started/not started -- Why the navigation was served/not served from prefetch -- What the final status of the prefetch was when it was served or deleted by expiry policy Bug: 1138652 Change-Id: I6d8dc6ca34c4fda81be926d65ee66f96a3cadf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586067Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#836272}
-
Anthony Polito authored
this was generated by an automated workflow Bug: 1113033 Change-Id: I67ec1b9e9684533a83adfed681abe68ff21f564c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586382Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#836271}
-
James Cook authored
I forgot to update the test expectations when I added LacrosMetricsProvider back in June. We weren't running lacros unit_tests in CQ/CI back then, so it got filtered out when the bots were brought up. Fix the test expectations and remove the filter. Bug: 1150115 Change-Id: I7e87e109ce94532a6a0bc9cf609126b4e80efd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587259 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Ajit Narayanan authored
Adds new user actions for when the user manually pauses or resumes Select-to-speak. Additionally, since the new STS bubble provides an alternative way to cancel, adds a new point of logging for CancelSpeech when performed through the close icon. Bug: 1143817 Change-Id: Ifc53543d4e6278b725ff418e4461562d37e56501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580479Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Cr-Commit-Position: refs/heads/master@{#836269}
-
David Black authored
In anticipation of additional animations being implemented in the holding space view hierarchy, taking the opportunity to refactor for greater reuse. This CL intentionally does not rename existing files so as not to lose diff tracking, but it is intended to perform the following renames in a fast follow up CL: - HoldingSpaceItemViewsContainer --> HoldingSpaceItemViewsSection - PinnedFilesContainer --> PinnedFilesBubble - RecentFilesContainer --> RecentFilesBubble Following those changes, the holding space view hierarchy will be generically structured as follows: - HoldingSpaceTrayBubble ---- HoldingSpaceTrayChildBubble -------- HoldingSpaceItemViewsSection ---- HoldingSpaceTrayChildBubble -------- HoldingSpaceItemViewsSection -------- HoldingSpaceItemViewsSection The actual implementation of this structure will be: - HoldingSpaceTrayBubble ---- PinnedFilesBubble -------- PinnedFilesSection ---- RecentFilesBubble -------- ScreenCapturesSection -------- DownloadsSection Bug: 1154998 Change-Id: I608e8983ce6484228c043d29ff002f62f31b5968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581034 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836268}
-
Ahmed Fakhry authored
The test delegate should now return a valid temp directory for the user's downloads dir. BUG=none TEST=Existing tests Change-Id: I159690b0d3bc330e473c33b52f5057cb823a7363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587550Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#836267}
-
Aleks Totic authored
This test failed the same way in all browsers: https://wpt.fyi/results/css/CSS2/tables?label=experimental&label=master&aligned With the fix, the test passes in all browsers. offset1: Collapsed - cell border box height is 36 (2* half border + padding) - cell content box height is 30 Non-collapsed - cell border box height is 40 - cell content box is 30 (40 - 2*border - padding) Similar problem with offset2. I believe original test did not account for padding. Bug: 958381 Change-Id: I1c851f24a33aa16152b2a7607804ecfed3d1f8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587551 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836266}
-
Nico Weber authored
No behavior change. Bug: 1147069 Change-Id: I8c0e3128e8799f068277860aed6475586c1f24e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585840 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#836265}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //ui. Bug: 1113033 Change-Id: I6c6e60157e9dc9b44cbccd8c3d173db21be0b94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583183Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f48161bc4b8c..40dbba6dda38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alexmos@google.com,eirage@google.com Change-Id: Id5ba4aecd4a84730e19ab68e68aeacfb52b0d0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586974Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836263}
-
Takumi Fujimoto authored
Sample failure: https://ci.chromium.org/p/chromium/builders/ci/UBSanVptr%20Linux/51514 Bug: 1137496 Change-Id: I462398f4d452cf6755fa40c72cbbfdacbbeaac34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585995Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#836262}
-
David Dorwin authored
Added in https://crrev.com/c/1030951, they are no longer used. Change-Id: I262060a2e946b9671e3179035987e0ab690c114e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583482 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836261}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607687924-a60f129d913249bc70405ac39567e1c7a8e8f34e.profdata to chrome-linux-master-1607709601-325646cf3b47651e58817955f6116187a5cde36c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I63cc1b1777fc5610dfb256f053409c254d58d425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587512Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e94526b4043b..74ccf7b62fc6 2020-12-11 lalitm@google.com Merge "tp: split track event resolution from track creation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9cbdc77648394212ba9f78e12449105a6850a441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586152Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2d81b7d4073..e94526b4043b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0b03e2dde72b99eb886c6c5b8474b6a45d2a92c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587109Reviewed-by:
-
David Tseng authored
R=akihiroota@chromium.org AX-Relnotes: n/a Fixed: 924976, 622387, 1085666 Change-Id: Id331e8cb005a54b2cbd804ac563b8c814bc80668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585680Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836257}
-
Chris Fredrickson authored
Change-Id: Ia412350582a5a6002d5a85797746d7d09594c2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583042 Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836256}
-
Vladimir Levin authored
DevTools exposes info if the node shown is a locked ancestor instead of the element itself. This patch adds an additional piece of information that shows if the highlighted element itself locked and as a result skips its descendants. The actual string representation of this will be in a separate patch in the devtools-frontend repo R=chrishtr@chromium.org Bug: 1147510 Change-Id: I6c4dcf8f57eebd40b458f74a73d395daf3442c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585144Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#836255}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7a519d34f57a..31cc1f148e42 2020-12-11 capn@google.com Fix typo in 'maxPos' constant vector 2020-12-11 capn@google.com Disable SPIR-V validation during pipeline compilation 2020-12-11 capn@google.com Remove support for R16G16B16 and R32G32B32 sampling 2020-12-11 capn@google.com Enable sampling and filtering of 16-bit SNORM formats 2020-12-11 nicolascapens@google.com Enable sampling and filtering of 16-bit UNORM formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie1016858790bee726cc52d85cb8b9b7dcb26b8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586530Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/977eeb69af7b..0d5c00517887 2020-12-11 michael.liao@microsoft.com [Accessibility]: Improve screen reader text to include count and position of suggest box (e.g. 'suggestion 3 of 5') 2020-12-11 kahinds@microsoft.com [Loc] Fail presubmit on modifications to en-US.json 2020-12-11 chrche@microsoft.com [Loc] Migrate node_debugger to Localization V2 2020-12-11 chrche@microsoft.com [Loc] Migrate js_profiler to Localization V2 2020-12-11 tvanderlippe@chromium.org Improve formatting for CSS variable definitions 2020-12-11 morlovich@chromium.org Add a utility for structured header handling (3/3) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073909,chromium:1136655,chromium:1157329 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75e521d058d51963d2de1a47c5c79f7a63684888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585683Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607677133-25f70964da7400c139fdb96077d2bf8b05dd84bf.profdata to chrome-win64-master-1607687924-42a73eb0331784066b7e53d64e9d9a239913c74b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fc508813b0e291cec2b86e82764b8cd1d7218d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586102Reviewed-by:
-
Guido Urdaneta authored
This CL makes sure that the destroy method is automatically invoked on VideoFrames when they are sent to a sink. This automatic invalidation is important because there are cases when frames are automatically sent to a sink without the possibility of manual invalidation (e.g., when automatically piping a readable stream to a writable stream). This is also consistent with the automatic invalidation in WebRTC Insertable Streams. Drive-by: Re-enable a disabled test that flaked because of a missing call to wait for a promise to be settled. Bug: 1151913,1153092 Change-Id: I3bc40df3bb02a1ae9852b03af2c94898400a2d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587037 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#836251}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd5c6c03c06f..e94526b4043b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0d6236400c628dac6ac89a6d5378d8da8e657d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587256Reviewed-by:
-
Dave Tapuska authored
Since there are multiple WebViewHelpers running around setting the InstallCreateWebFrameWidgetHook for the entire duration of the object is problematic. Centralize widget creation on methods on WebViewHelper. Set the hook for the duration of the CreateFrameWidget call and that is all. This change collapses a lot of duplicate code into a method on the WebViewHelper. BUG=1097816 Change-Id: If17115ccafe724a365968e7fe299054809837644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585839 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836249}
-
Ben Wagner authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/2566935/5#message-8b391d170d115a9b89c0a985ab0a8a42a208695b The license was discussed in the original code review in https://codereview.chromium.org/2761163003#msg15, but it seems that changing the license was chosen instead. There no longer appears to be an issue with presubmits when a compatible license is used. Only tools/perf/page_sets/update_webrtc_cases is manually edited in this CL. Other changes were generated by this script. `./tools/perf/run_benchmark run webrtc --browser=system` passes locally on Mac. Change-Id: I6fc40e29731205b7115c91127015a9f299449389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573141Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#836248}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c52956d0..84a26597 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I773af8572b5a52b91ce09c96315fcb42e95d2588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587107Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836247}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607687924-da70153108842fcd8bad16a1d91d87a201f64cf8.profdata to chrome-mac-master-1607709601-c889cff9228ed2a408f7c416b610f665b13ded19.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I47a68475dec1edbcda89f27b0e987952fdaa5560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587510Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd5c6c03c06f..e94526b4043b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia2db1cc0609464fb9dc94564c8e7c9c5d84b9c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587488Reviewed-by:
-
