- 15 Apr, 2020 40 commits
-
-
Bruce Long authored
A new method is added to asynchronously retrieve the BCP47 language tags for registered Windows OS spellcheckers on the system, wrapping the system API ISpellCheckerFactory::get_SupportedLanguages. The method is for now only used in a unit test, but upcoming work will rely on this method to allow languages without Hunspell support to still have Windows spellchecking enabled on the languages settings page. Bug: 1000443 Change-Id: I03507650ec355e8c282695d8f25364bccb91449a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144234Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759306}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9aba22264b1b..14245e8100e9 git log 9aba22264b1b..14245e8100e9 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 niwa@google.com chromite: Remove 'ARM' target from ANDROID_VMRVC_BUILD_TARGETS 2020-04-15 vapier@chromium.org virtualenv_wrapper: fix recursive invocation 2020-04-15 sanikak@chromium.org auto_updater: add functionality to get path to hostlogs directory 2020-04-15 saklein@chromium.org flash_ap: Promote start/end logs to notice. 2020-04-14 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-14 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-14 niwa@google.com Ensure ARCVM R user builds are copied to gs://chromeos-arc-images/builds/ 2020-04-14 lamontjones@chromium.org SigningStage: print more detail on failure Created with: gclient setdep -r src/third_party/chromite@14245e8100e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I52de5d2af4655715eed9a3d2e0447c98101834be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759305}
-
Vasilii Sukhanov authored
Change-Id: Ib579960e3f43688a6f77a337e825d22599356429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144020 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#759304}
-
Aaron Leventhal authored
Bug: None Change-Id: Idf1b8b56f204165ce60f8b73fd2d993824c44134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148542Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#759303}
-
Yuki Shiino authored
Fixes the argument index (was +1'ed) and adds OnErrorEventHandler and OnBeforeUnloadEventHandler. Bug: 839389 Change-Id: Id56dad2e5ff6e048d39f10018f49e10784199f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147489Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759302}
-
Victor Hugo Vianna Silva authored
First step to remove the duplication for b4p reauth. The implementation of methods TriggerReauthForAccount and TriggerSignin are moved to a new helper class, as they are. In the next CLs, the class we'll start to internally recover the primary account id and set the opt in preference for account storage. Bug: 1070944 Change-Id: Ic6c950d28551a6b624f2c88943f880a961d9e4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150426 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759301}
-
Yue Zhang authored
There are several tests in TabGridDialogParentTest that don't run on UI thread by default. This CL modifies such tests so that things should run on UI thread are moved to UI thread. Bug: None Change-Id: Ia3064132e36de673f35ae1619d281f597002c6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148282 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759300}
-
Junyi Xiao authored
This is a reland of 402e8644 Original change's description: > WebApps: Remove install pwa icon from toolbar when page crashed > > This change 1. hides the install pwa page action icon in the toolbar > 2. grayed out "create shortcut" and "Install {pwaName}" menu items > when page crashed. > > Bug: 1057526 > > Change-Id: I63d5e3607e9aff71ab2bd799d792f025b142ec42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078771 > Commit-Queue: Junyi Xiao <juxiao@microsoft.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746305} Bug: 1057526 Change-Id: I2911dca52a8fbd2f2f0c461489823f2087328e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100022 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759299}
-
Hailey Wang authored
Added scoring of tabs before loading. Used for loading tabs based on their priority. Bug: 1059341 Change-Id: Ia059be9f35b16b01f58eb20db0057ff7e4278849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140298 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#759298}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33fac4e6. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ic1574682f1cf2a208cd0cdeca3aee00efaa1c800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150222Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759297}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I829ed695b1d82e0a8d17c56d152cb52e2902ae30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150623Reviewed-by:
-
Ben Joyce authored
Use third_party/android_deps/jsr_305 library instead. This will prevent issues with androidx_espresso having duplicate javax classes that conflict. Must land after below CL: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2880018 Bug: 1070424 Change-Id: I48fb52fc8136df2ed95860326105d9255e55e20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149698Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#759295}
-
Shu-yu Guo authored
Bug: chromium:1016767, v8:8179 Change-Id: I14d0aa2c0f458156cb03bb09d1f1175c21086659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145160Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759294}
-
Brian Geffon authored
The folder //chromeos/memory is growing larger and will continue to do so. To help keep //chromeos clean we will move it to a standalone component. Bug: 1067833 Change-Id: I7931b4a649038212aa7b87d44479958f644ff668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149947 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Auto-Submit: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759293}
-
Yue Zhang authored
Bug: 1068410 Change-Id: I77cbbff22ccd1f2b585e041da0f8f46183ebea65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145758 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Steven Bingler authored
IsFirstParty() changed recently to depend on the SchemefulSameSite feature. When SchemefulSameSite is enabled IsFirstParty() won't behave as IsBannedCrossSiteAuth() is expecting. This CL changes IsFirstParty() to only check URLs schemelessly which aligns with current behavior and IsBannedCrossSiteAuth()'s expectations. Bug: 1030938 Change-Id: I3cfe190c530333fde0d9292899a2f71d8d813364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146300Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#759291}
-
Donn Denman authored
TBR=pkotwicz@chromium.org BUG=1071080 Change-Id: Id972e8b11653857183eaf0369787017a70a7feee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150686Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#759290}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4b4e87913242..953cd08e70a0 git log 4b4e87913242..953cd08e70a0 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 dproy@chromium.org [metrics] Implement Total Blocking Time metric 2020-04-15 dproy@chromium.org [tracing] Change TTI metric to use FCP as start point Created with: gclient setdep -r src/third_party/catapult@953cd08e70a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Ied9dc7532c22a63f43ff54e12f8cdc2ef0184040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150613Reviewed-by:
-
Rahul Arakeri authored
Bug: When a thumb drag is in progress, the scroller will jump every time the scroller length changes. This happens because the pointer and the thumb always try to stay in sync with each other. Main thread scrollbars dont have this issue as they allow the thumb and pointer to get out of sync. Fix: If the scroller length increases mid thumb drag, we record the "displacement" delta and early out. This delta is then applied to every subsequent pointermove to ensure that that scroller retains its offset even when the scroller length changes. The downside of this approach is that the thumb and the pointer will get out of sync but the upside is that the scroller won't suddenly jump. Bug: 1067518 Change-Id: I773335db538b8595e96464f3306d2df9e82a58f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134923 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759288}
-
Peter Wen authored
This version of lint is up-to-date with Android Studio and the lint team intends to keep it that way. We no longer need a separate tools-lint directory for an up-to-date version of lint. Fixed previously too narrowly focused suppression (use regex instead of path for OnClick suppression). Tbr: Trivial change to fix build. Bug: 1069186 Change-Id: I3a1a03ab65e11f043bdf376bf17fe4a66108d29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147012 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759287}
-
Cliff Smolinsky authored
BrowserChangeObserver was just moved to be a publicly available class, so this change adds a comment regarding how it should be used (or not used, as the case may be). Bug: 1052096 Change-Id: I7cdff02f7e2d87b65f17a61600a54e336b0671cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149913Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759286}
-
Rohit Rao authored
These helpers are moved into //components/policy/core/common so that they can be used on iOS as well. BUG=1069528 Change-Id: I66adcf426e81ff5bdc430146e802745d276fd814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144266 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759285}
-
Gayane Petrosyan authored
Bug: 993920 Change-Id: I7d9557b8b27986012be76ae74606161653de7499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130820 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#759284}
-
Etienne Pierre-doray authored
This CL implements NativeUnwinderAndroid & tests for android unwinding support. It also enables StackSamplingProfilerTest on Android. A new target source_set is added, native_unwinder_android that contains NativeUnwinderAndroid. StackSamplingProfilerTest depends on it for android. Bug: 989102 Change-Id: Ie38fd99ca5fb053e1881d0977924b70a6fbc1e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055743 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759283}
-
Rayan Kanso authored
Bug: 1037427, 1066031 Change-Id: I522622a907938c8b4a7ada8091b2ed4dfd1d6535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148739 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759282}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dc0359178572..e6e3bfad73cf git log dc0359178572..e6e3bfad73cf --date=short --first-parent --format='%ad %ae %s' 2020-04-15 sigurds@chromium.org [devtools] Refactor issue displaying 2020-04-15 tvanderlippe@chromium.org Fix ES module import linter for module entrypoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@e6e3bfad73cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ce00f1873e61ab2ad61dc3a4c96e559b11c14e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150611Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2cc24537de78..60af4efbe0e2 git log 2cc24537de78..60af4efbe0e2 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 lalitm@google.com tp: move module code to importers 2020-04-15 lalitm@google.com tp: add importers build file and create common target 2020-04-15 lalitm@google.com Merge "tp: move util related sources to util build file" 2020-04-15 lalitm@google.com Merge "tp: move descriptor pool, proto conv and status macros -> util" 2020-04-15 fmayer@google.com Merge "Move /proc/self/stat parser to function." 2020-04-15 lalitm@google.com Merge "tp: move event, clock, hprofile and slice trackers -> importers/common" 2020-04-15 lalitm@google.com Merge "tp: move metadata, perf sample and stack trackers to improters/proto" 2020-04-15 lalitm@google.com Merge "tp: move remaining custom sqlite tables to sqlite/" 2020-04-15 ilkos@google.com Merge "Parse OOM reaper kills" Created with: gclient setdep -r src/third_party/perfetto@60af4efbe0e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7f678ce1f40141b7f01209789904eddcc8e163e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150614Reviewed-by:
-
edchin authored
This CL simply replaces about a dozen uses of @"bookmark_context_menu" with a constant accessibility identifier in bookmark_ui_constants.h. Change-Id: Ibbfb86930cb09035ff271f83e5971dbc35f1c717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146288Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759279}
-
George Steel authored
Refactor the two methods in ComputedStyleUtils for serializing transformation matrix values (ValueforMatrixTransform and part of ValueForTransformOperation) into a single method ValueForTransformationMatrix which takes a parameter controlling whether to force matrix3d serialization. This method uses the implementation from ValueForTransformOperation verbatim. Start a unit test suite for ComputedStyleUtils with tests for ValueForTransformationMatrix testing the zoom and force_matrix3d parameters. As such ComputedStyleUtils has been made CORE_EXPORT so that unit tests can link to it. This causes no behavioral change. Change-Id: If1c0727dc80caff77b77d9611bdeb613a96601ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133366Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759278}
-
Hans Wennborg authored
Bug: 1071058, 1031540 Change-Id: I9a8e9abed41a65e5571acc1b86f30adfd3e35c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150593 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#759277}
-
Becca Hughes authored
Add method to check media feed items against safesearch and store the result. BUG=1066643 Change-Id: I9779c7fdde6916f47afd60f4d5efd379853f03cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135875Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759276}
-
Alex Ilin authored
This reverts commit 4fdc53d7. Reason for revert: EntitySuggestionProcessorUnitTest.DecorationTest* crashing on android-pie-x86-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/b8882995499559718496 Original change's description: > Convert omnibox/suggestions from String URLs to GURL > > Converting String URLs to GURL also required moving some tests from > junit to native java unittests, as GURL requires the native library to > be loaded. > > Bug: 783819 > Change-Id: Id574a15715effe1845d2cfa50f698461b83bb5b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071376 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759074} TBR=palmer@chromium.org,mthiesse@chromium.org,jdonnelly@chromium.org,tedchoc@chromium.org Change-Id: Ia5f91b532a787816ef55bb7d62dd3bb44898564c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783819, 1071092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150705Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759275}
-
Maksim Moskvitin authored
Corresponding investigation is completed. This CL marks histogram as obsolete and removes instrumentation code. Bug: 1053169 Change-Id: Id0d9495ff7da2364967afdb5adb50f1aa54748b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141923Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#759274}
-
Sami Kyostila authored
This patch makes WebScopedVirtualTimePauser avoid emitting trace events if virtual time is disabled. Bug: 1069603 Change-Id: I14bfe21bcd67f325018ffeec1d17e01fe2f1dde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144143 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#759273}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: I45374678b3f35b7f41d99e94445a372d5e90d232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145529 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#759272}
-
Ian Kilpatrick authored
Previously we considered any legacy layout root as potentially having %-dependent descendants. This typically wasn't an issue for when we first rolled out LayoutNG as it was relatively common for *something* to stop the propagation of this bit up the tree. With FlexNG however, we run into far more cases due to the "definiteness" potentially changing. This patch treats images, svgs, etc has having no children for the purposes of this calculation. Bug: 845235 Change-Id: I98648b8182fd549d6e6bee1167cd8ae89d55687b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148216 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759271}
-
Alice Wang authored
This CL inlines the rarely used method AccountManagerFacade.hasAccountForName to simplify the AccountManagerFacade API. Bug: 1057040 Change-Id: I6f1e37f1fde574bc561db9efe16e134924191118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146551Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759270}
-
Yuki Shiino authored
Firefox, Safari, and Chrome agree the behavior of history.state === popStateEvent.state so update the test case accordingly. IIUC, HTML also requires this behavior. https://html.spec.whatwg.org/C/#history-traversal:dom-history-state step 13. Set history.state to state. step 16.1. If state changed is true, then fire an event named popstate at the Document object's relevant global object, using PopStateEvent, with the state attribute initialized to state. where |state| is the result of StructuredDeserialize, so it's expected that history.state === popStateEvent.state. Bug: 1070938 Change-Id: I161e415ce986be56031080e1538a0d4ac4fbf133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147169Reviewed-by: -
Wez authored
The test's failure-mode is to timeout, but because it repeatedly ran new RunLoops for each DumpLogs() call, it would take ~6 minutes to timeout, and then be terminated by the TestLauncher. Fix the test to use a single RunLoop, so that it will timeout within ~10 seconds in case of failure. Bug: 1070686 Change-Id: I054a6b6142835122b2a5f1fee18a189a78392a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146902 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759268}
-
Vasilii Sukhanov authored
Mocks: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g7c9229dfe2_22_49 Bug: 1049200 Change-Id: Ifa3e6e0211fb9ed9c4f81ec77d460c6970f5ee97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144017 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759267}
-
