- 13 Dec, 2019 40 commits
-
-
Kenichi Ishibashi authored
The [Constructor] extended attribute was superseded by constructor operations [1] and the blink code generator now supports it. Convert [Constructor] to operations. This CL was generated by a script. I manually checked that generated bindings aren't changed. [1] https://heycam.github.io/webidl/#idl-constructors Bug: 999961 Change-Id: I38d2c04ee33bb03bc58741f13b1b7b4386d05953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967012Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#724559}
-
Ilia Samsonov authored
FetchUrlTest calls mojo::core::Init() for each test. This is uneccessary and causing failure on exit in asan builder. Bug: 1018424 Change-Id: I61d66a532dfcc08987ba18df7e1cee18be657a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966694Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#724558}
-
Tomasz Moniuszko authored
Bug: 1033438 Change-Id: I0e892a2c8ea7b15e9f2c13f86162b011a3e75100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963852Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#724557}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f17b6b86ac6e..16a293640fd0 Created with: gclient setdep -r src-internal@16a293640fd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I954aeb911f71f46a541e73eca4ac1384642b97a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966027Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724556}
-
Rakesh Soma authored
Note: This is an incremental change to [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1900159 Change-Id: I401bf6ea8f30cf83b68a216e40bd1187ed9717a6 Bug: 1032807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961785 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#724555}
-
Arthur Hemery authored
A CL aimed at reducing dependencies of other concurrent CLs. Does nothing in itself but introduce an unused cross_origin_opener_policy_ member to RenderFrameHostImpl. Based on and grouped with COEP. Bug: 922191 Change-Id: I5331da7ad287d56294029fbb2885b02799ed1d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963795 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#724554}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b7e9343b7617..7d4575c695a1 git log b7e9343b7617..7d4575c695a1 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 dberris@chromium.org Save culprit finding task payload for every update Created with: gclient setdep -r src/third_party/catapult@7d4575c695a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032855 Tbr: skyostil@google.com Change-Id: I40125cdb4fb88912766fe18286f2cde6aa520c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966022Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724553}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ifb9eef57c3dc506d1eeb3c95fbde4615971bb520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950729Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up comments about old Mojo types since the code has been converted already to new Mojo types. NOTRY=true Bug: 955171 Change-Id: Iab9cb76e5ddee5fb494d5f1833a5eddbeb50f6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950046Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#724551}
-
Chih-Yu Huang authored
Originally |flush_callback_| is accessed on both child sequence and encoder sequence. This CL makes V4L2VEA only access this variable on encoder sequence to avoid race condition. Bug: 827448 Test: Run video_encode_accelerator_unittests on Kevin Change-Id: I2963aff4959527d0e0cb3ad3adf11f2076ddc8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959918Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#724550}
-
Lachlan Ford authored
Fixes: 1028408 Change-Id: I6315094b905bce84df92d74058ffb684a73a6fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935727 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#724549}
-
Miyoung Shin authored
This CL replaces Platform::GetInterfaceProvider with Platform::GetBrowserInterfaceBroker in Blink to use BrowserInterfaceBroker. Platform::GetInterfaceProvider proxies the calls to BrowserInterfaceBroker so no browser-side changes are necessary. [1] [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/exported/platform.cc?rcl=465931c14fbb262700f157ef085768b29bebaf1d&l=82 Bug: 936482 Change-Id: I9b82b1aec95dc391bf3735e032ad427840423534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961839Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#724548}
-
Peter Kotwicz authored
BUG=1032291 Change-Id: Ic2c6a4fa9bc31bcd9222df5d8f88ba70b5cff7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959047 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#724547}
-
Francois Beaufort authored
Infrared camera are supported only in Android Q and later. This CL makes sure support is checked only on those platforms. Bug: 1033422 Change-Id: Ica032c91713ede7bb0514492854d02dd8e761b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963792Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#724546}
-
Simon Que authored
This builder starts up Goma but doesn't use it. Bug: 1025334 Change-Id: I0fd2b267f3250e3a56312c3f48c43bd530767c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966807Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#724545}
-
Kuo Jen Wei authored
cca.models.Gallery serves as model of old gallery view. Remove related classes after deprecation of old gallery. Bug: 1032514 Test: Manually test on functionality of gallery button. Change-Id: Ib15e047c9dbfee5ce1a241253b109e41093bdc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961841Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#724544}
-
Mike Dougherty authored
BreadcrumbPersistentStorage stores breadcrumbs to disk and returns the breadcrumbs from the persisted file. This will allow breadcrumbs to be saved during an application run and retrieved after a crash on the next launch. Bug: 1003922 Change-Id: Iffa9dc2797b66eda0793c9eafef6bddc8c73200d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959777 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#724543}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I371431ee0ee035a8af8230fa56ab0b6852ff6db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960087Reviewed-by:
-
Victor Fei authored
This change exposes hierarchical level for list items in the accessibility tree. Hierarchical level is determined from `aria-level` or the DOM structure of the listitem in relation to its parent list group. Previously hierarchical level was only exposed for tree items and headings. WAI-ARIA spec for aria-level for list item: https://www.w3.org/TR/wai-aria-1.1/#listitem https://www.w3.org/TR/wai-aria-1.1/#aria-level Change-Id: I0ef177a3bf68cdde52a7c02f9364e61b0995f99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928639 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#724541}
-
Vitaly Buka authored
This is a reland of 4c424ef5 Windows bot is fix: crrev.com/c/1946985 base_unittests fix: crrev.com/c/1949643 crashpad_tests fix: crrev.com/c/1949846 Bug: 977230, 1030261 Original change's description: > Enable init_stack_vars for non-official Windows builds > > With crrev.com/c/1914359 merged so we can enable the flag on Windows. > Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383. > > Bug: 977230 > Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805 > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719737} Change-Id: I6f70b2a3c51fafd2ccce543a19b9d9bda5e982b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948914 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#724540}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/39cdc37bdd0f..7fb7134e7d94 git log 39cdc37bdd0f..7fb7134e7d94 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6381d7f14805..1d77542f5681 (8 commits) 2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 07958d452f93..ebb0bec91552 (4 commits) 2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 63613892..d11c1714 (358 commits) Created with: gclient setdep -r src/third_party/skia@7fb7134e7d94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I69257f8d3188020d6e4f19e6da25514dbee0c457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966018Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b132b0832d4..f17b6b86ac6e Created with: gclient setdep -r src-internal@f17b6b86ac6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I070ea7fc4993868c310d205625b00b5b58c481ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966017Reviewed-by:
-
Keishi Hattori authored
This reverts commit b5f0589b. Reason for revert: Real issue has been fixed Original change's description: > Change ScriptValue back to use SharedPersistent > > ScriptValue was modified to use WorldSafeV8Reference through r701030, > r698399, r694681 but we suspect it may have caused a memory leak. > This change ScriptValue back to use SharedPersistent. > To maintain the same level of security, the world check from > WorldSafeV8Reference has been transplanted into SharedPersistent. > > Bug: 1029738 > Change-Id: I21ed2929c3e90530a958be0503f153646f85ec7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948671 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721385} TBR=yukishiino@chromium.org,haraken@chromium.org,keishi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029738 Change-Id: Iddd5583577bef6dca066466b776fe59d25e5f537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966798 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
David Tseng authored
Change-Id: I0742339d72a375d6322f1aa8f430c322085d0d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959331Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#724536}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/319e00ca2a19..b7e9343b7617 git log 319e00ca2a19..b7e9343b7617 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 dberris@chromium.org Introduce a histogram_name property in ReadOptions 2019-12-13 sullivan@chromium.org Correct LCP metric use of Map. Created with: gclient setdep -r src/third_party/catapult@b7e9343b7617 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1033807 Tbr: skyostil@google.com Change-Id: I39951e36490eec3c81efc943129bbee74406f2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966015Reviewed-by:
-
Wei Wang authored
This patch implements ServiceWorkerGlobalScope.onmessageerror, including adding event handler attribute, adding constructor for ExtendableMessageEvent of kMessageerror type, and starting to dispatch messageerror events. This patch also modifies the existing WPT to test the implementation, including adding t.add_cleanup() to unregister the service worker and remove the iframe, and modifying the expected results of the WPT. chromestatus: https://chromestatus.com/feature/5758162755911680 Bug: 1024132 Change-Id: Icac12f62a2840e8bb694f6b80b08e50805a4b6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921521 Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Removing kHighPriorityInputOnMainThread experiment as it has been permanently enabled. Change-Id: Ief831cccdd8a312f0a25fbef9a64e7ef87a17037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957192 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#724533}
-
Yun Liu authored
Reference link: https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program Dumping data to ONLY 1 file may cause warning and data overwrite in browsertests. Pattern "%2m" is used to expand to 2 raw profiles at runtime. Example in chromium: https://cs.chromium.org/search/?q=LLVM_PROFILE_FILE+2m&sq=package:chromium&type=cs DeviceTempFile cannot be used with the pattern, and NamedDeviceTemporaryDirectory is not applicable because the directory is not created until using "with" statement. Bug: 985574 Change-Id: I8c2b9f1d289be1de3bd1b283cc35acc618a7d6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884378Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#724532}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6c479796f6e4..ebf634bcaa3e git log 6c479796f6e4..ebf634bcaa3e --date=short --first-parent --format='%ad %ae %s' 2019-12-13 johnkslang@users.noreply.github.com Merge pull request #2023 from greg-lunarg/kg109 Created with: gclient setdep -r src/third_party/glslang/src@ebf634bcaa3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliot@google.com Change-Id: I8adfdb57876fb754918c08f761d1f73312dd5402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966014Reviewed-by:
-
Andrew Grieve authored
* Renames javac.py -> compile_java.py * Makes temporary paths relative * Moves .info processing to a helper class * Moves jar.py logic into compile_java.py * Output annotation processor sources to a separate directory from .class files (via -s flag) Bug: 1020680 Change-Id: Iead62ab70d0424f112606b8e326fbd880e539468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959470 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#724530}
-
Jaeyong Bae authored
This patch means fix the size of string for test. Because, it appears to cause the devices we use on android-asan to oom on asan builds. Bug: 979668 Change-Id: I0321d76a0f69b8bc920347f3bce329e36f1a5cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879627Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#724529}
-
Alan Cutter authored
This reverts commit e2c6d84a. Reason for revert: DumpAccessibilityTreeTest.AccessibilityButtonNameCalc/uia is failing on all Windows 7 waterfall bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=DumpAccessibilityTreeTest.AccessibilityButtonNameCalc%2Fuia [4176:1936:1212/164612.912:ERROR:dump_accessibility_test_helper.cc(126)] Diff: * Line Expected - ---- -------- 1 document 2 ++button Name='InnerText0' 3 ++button Name='InnerText1' 4 ++button Name='AriaLabel2' 5 ++button Name='LabelledBy3' 6 ++button Name='LabelledBy4' 7 ++button Name='InnerText5' 8 ++button Name='Outer inner' 9 ++++description Name='Outer' IsControlElement=false * 10 ++++group 11 ++++++description Name='inner' IsControlElement=false 12 ++button Name='Outer inner1' 13 ++++description Name='Outer' IsControlElement=false 14 ++++group Name='inner1' 15 ++++++description Name='inner2' IsControlElement=false 16 ++button Name='Outer grandchild' 17 ++++description Name='Outer' IsControlElement=false 18 ++++group * 19 ++++++group 20 ++++++++description Name='grandchild' IsControlElement=false 21 <-- End-of-file --> Actual ------ document ++button Name='InnerText0' ++button Name='InnerText1' ++button Name='AriaLabel2' ++button Name='LabelledBy3' ++button Name='LabelledBy4' ++button Name='InnerText5' ++button Name='Outer inner' ++++description Name='Outer' IsControlElement=false ++++group IsControlElement=false ++++++description Name='inner' IsControlElement=false ++button Name='Outer inner1' ++++description Name='Outer' IsControlElement=false ++++group Name='inner1' ++++++description Name='inner2' IsControlElement=false ++button Name='Outer grandchild' ++++description Name='Outer' IsControlElement=false ++++group ++++++group IsControlElement=false ++++++++description Name='grandchild' IsControlElement=false <-- End-of-file --> ../../content/browser/accessibility/dump_accessibility_browsertest_base.cc(436): error: Value of: matches_expectation Actual: false Expected: true Original change's description: > Tune the UI Automation content view > > In testing we've observed scenarios where uninteresting container nodes > in the accessibility tree have caused issues with Narrator. This CL > removes some of these containers from the UI Automation content view, > which is the view Narrator uses. > > Bug: 1031302 > Change-Id: Iaee82c3add61659b9c14591d072ab49b069f5c61 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938308 > Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724335} TBR=haraken@chromium.org,nektar@chromium.org,rsesek@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,adettenb@microsoft.com Change-Id: I3159634c2c234e95c48bf6d120ef5fae2c81b05d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965745Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#724528}
-
Koji Ishii authored
Following bot results are included. 580 581 583 584 586 588 589 592 593 594 595 599 601 195 lines were removed and 30 lines were deflaked by consecutive results since 581. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I5a2d454b4814903fd8c0e7271e53699ad55f5103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958300Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#724527}
-
Xianzhu Wang authored
ToBaseValue() is not supported when a TracedValue is backed with a ProtoWriter. Previously the mistake was silently ignored. Separate JSON related API from ConvertableToTraceFormat and TracedValue into TracedValueJSON. Also fix broken ToString() usages. (TBR for simple passive changes under base/task/, base/test/ and components/.) TBR=thakis@chromium.org R=oysteine@chromium.org,pdr@chromium.org Change-Id: Iac5aeeb021f019917d61f57144b4a2a799f79a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956965 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#724526}
-
David Munro authored
Bug: chromium:930901 Test: Upgraded manually. Unit tests. Change-Id: I227d354fc36d8527cadaf0a3c2465940703ee2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966800 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#724525}
-
Alex Turner authored
Adds functionality that allows for skipping field trials that conflict with other arguments. Also adds functionality for merging field trials. Both of these will be enabled in a future change. A design document can be found in the bug ticket. Bug: 1031186 Change-Id: I4a86890fbd8edd238784db2876518fd144bfee31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902532 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#724524}
-
Kenichi Ishibashi authored
[CallWith] is translated into [ConstructorCallWith]. These extended attributes are moved into interface's extended attributes. As a consequence specifying these extended attributes on a single constructor operation affects all constructor operations. This is tricky and ideally we should avoid this kind of hack but I guess this is fine because this wouldn't break existing IDL files and we will use the new code generator soon. Bug: 999961 Change-Id: I39c817c21cea84e839d461210127444a95a2d3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961881Reviewed-by:
-
chrome://settingsDemetrios Papadopoulos authored
- Always pass |showOSSettings| as false to chrome://settings. - Delete chrome://settings tests referring to UIs that no longer exist. This is the first of many steps to fully decouple chrome://settings and chrome://os-settings codebases, now that SplitSettings is on by default. The UIs surfaces (along with any strings) in chrome://settings that become dead code with this CL, will be removed in follow up steps. Note as of this CL, --disable-features=SplitSettings will not be respected by chrome://settings anymore but the flag itself will be removed in later CLs. Bug: 1026455 Change-Id: I9a916c7686e96c9f604bed2c180ecd9a3ba9f7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962018 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#724522}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0678df30b5a5..39cdc37bdd0f git log 0678df30b5a5..39cdc37bdd0f --date=short --first-parent --format='%ad %ae %s' 2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 5855011aeee5..cd31cb38833c (1 commits) Created with: gclient setdep -r src/third_party/skia@39cdc37bdd0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ic5e757b81a4c0cbf1b36a151aa94b1be8c74e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966676Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e0f8b5d08354..1d77542f5681 git log e0f8b5d08354..1d77542f5681 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 cnorthrop@google.com Add flag to label captures 2019-12-12 jmadill@chromium.org gn: Add 'test_only' label to util targets. 2019-12-12 jmadill@chromium.org util: Always export default visibility. Created with: gclient setdep -r src/third_party/angle@1d77542f5681 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1030192 Tbr: ianelliot@google.com Change-Id: I8353fdb7b90ea72bdb3786580c03e3ccdee485db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966409Reviewed-by:
-
