GitLab

This is a follow-up after:
https://chromium-review.googlesource.com/c/chromium/src/+/989693/10/third_party/WebKit/Source/core/execution_context/OWNERS#5

Change-Id: Ief8ee8755876bedd5241d3e5977dc37cea669e12
Reviewed-on: https://chromium-review.googlesource.com/1029995Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553961}

After recent changes TestCompositorHostMac started requiring
a real AcceleratedWidgetMac, otherwise it would crash while
trying to Show. After fixing that, there was another issue
that ImageTransportSurface started crashing, because of
skipped SetAllowOSMesaForTesting in compositor test_suite.

Tests affected:
LayerWithRealCompositorTest.*

Change-Id: I60b84611406744989e2f00f13e20c1177912814f
Reviewed-on: https://chromium-review.googlesource.com/1014101Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Michal Pichlinski <mpichlinski@opera.com>
Cr-Commit-Position: refs/heads/master@{#553960}

|selectedIdentity| has to be set when starting UnifiedConsentCoordinator.
This API is required to support sign-in promo with the "Continue as"
button.
Also the avatar has to be updated when an update notification is
received by ChromeIdentityServiceObserver.

Related to:
crrev.com/c/1009906
crrev.com/c/1010346

Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I800294f36178a2776e03d28c625f234e4ecc1d2b
Reviewed-on: https://chromium-review.googlesource.com/1025895
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553959}

This change removes an unnecessary call to std::move in
AuthPolicyClient::ConnectToSignal.

Bug: none
Change-Id: Id7fcb10e6b188d0a3058815c3078405f9634801a
Reviewed-on: https://chromium-review.googlesource.com/1028229Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553958}

This reverts commit 01873a4e.

Reason for revert: This CL was cherry-picked to M-67 release branch. Let's revert this on master.

Original change's description:
> Disable enable-floating-virtual-keyboard flag by default.
> 
> This feature is not ready for M-67 stable.
> This CL will be reverted shortly after merging it to M-67 branch.
> 
> Bug: 771466, 836109
> Test: Manual testing on the device. Confirmed that the feature is disabled by default.
> Change-Id: I295319b4bdd6ae2cec18b5690308df96cff669dd
> Reviewed-on: https://chromium-review.googlesource.com/1025352
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553395}

TBR=sadrul@chromium.org,yhanada@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 771466, 836109
Change-Id: Ia0b300bd06d6ed0e25d8cb15dfe48013e611b592
Reviewed-on: https://chromium-review.googlesource.com/1029810Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553957}

Flakiness cause in the FileManagerBrowserTests was resolved on issues:
issue 831074 issue 804413 issue 829310.

Allow these tests to run in DEBUG/MSAN/ASAN after the previous patches
on the bug selectively enabled subsets of the GalleryBrowserTest tests
on those bots and are working well [1].

[1] https://bit.ly/2HKT7kc

Bug: 835794
Change-Id: I4cf7c412c51cf051283a8f8fea9a5d1118af8f51
Reviewed-on: https://chromium-review.googlesource.com/1025854Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553956}

This CL temporarily disables the SpeculativePreconnectValidation field
trial in order to assess its impact on the perf dashboard. This feature
is planned to be turned on by default after the performance evaluation.

Bug: 808036
Change-Id: I69de5a26eba86b8e4cad11c4cf534c3d13e73894
Reviewed-on: https://chromium-review.googlesource.com/1028052Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553955}

Bug: 622551
Change-Id: Ib31bd4189957bad107090db694a6857211e581d1
Reviewed-on: https://chromium-review.googlesource.com/1029930Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553954}

Using wpt-import in Chromium 3e3ab788.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."
52308ad8 "Deprecate document.origin"
7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight"
a8385691 "Make web font timeouts work for preloaded fonts"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16266

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding

TBR=qyearsley

No-Export: true
Change-Id: I8cfc93a0c40f72a054b46cd6e561a0f729fa645b
Reviewed-on: https://chromium-review.googlesource.com/1029674
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553953}

This patch removes the redundant invalidation because each LayoutObject now has
invalidation for LayoutNG.

This patch is a just revert of crrev.com/c/821394
([LayoutNG] Have LayoutText invalidating NGPaintFragments)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I37373ed9015c476544c2d719fcf7cfcf7ab1ecc7
Reviewed-on: https://chromium-review.googlesource.com/1027592Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553952}

This CL removes XML attribute that sets objectAnimator valueType to
floatType. Both Android Framework and Support Library specify floatType
as the default valueType for objectAnimator, so removing explicit
attributes doesn't change the behavior, while improving readability and
reducing resources size.

Bug: 814728
Change-Id: Iea356ca491d23fae3ed9a54339fb746a5259f33e
Reviewed-on: https://chromium-review.googlesource.com/1027812Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553951}

Currently Zip Archiver run in the normal and incognito contexts in
parallel when opening a single ZIP file in the Files app.
The instance in the incognito context also received and processed events
in onGetMetadataRequested, but it always fails because it doesn't run
the normal initialization procedure.
(i.e. loading volume and filling unpacker.app.volumeLoadedPromises)

It once had worked harmlessly because error was ignored, but now
the error in the incognito context triggers unmounting of the file.
It can cancel out the volume mounted by the other instance in the
normal context right before it.

Bug: 833603
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I712a974ca4fe287d795256fc22a62d5c85d66401
Reviewed-on: https://chromium-review.googlesource.com/1018624
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553950}

identity::IdentityManager is the new API that replaces SigninManager[Base].

This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest.

Bug: 825190, 731023
Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b
Reviewed-on: https://chromium-review.googlesource.com/1025898Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553949}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/48a13aacf880..aa6cca46950b

$ git log 48a13aacf..aa6cca469 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 lepton cros_vm: Use a smaller virtual network.
2018-04-24 laszio afdo: refining codes
2018-04-10 dgarrett chromeos_config: TRYBOT -> SWARMING.
2018-04-24 rockot Include libmojo_core.so in Chrome deployment
2018-04-19 pberny chromeos_config: Add sign_types to meowth release
2018-04-20 achuith cros_run_vm_test: Support for fetching results.
2018-04-17 bmgordon cbuildbot: Add --previous-build-state option
2018-04-13 bmgordon build_summary: Helper class to represent build summaries
2018-04-24 dgarrett cros tryjob: Always use PRODUCTION_TRYJOB display label.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:808045,chromium:829170,chromium:None,chromium:822034,chromium:835061,chromium:829665,chromium:829665,chromium:832768


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7d1aa5c4c4bd153fd47f6d7cc7532ac35cdff73b
Reviewed-on: https://chromium-review.googlesource.com/1029771
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553948}

Tbr: wychen
Bug: 837130
Change-Id: Iabc0c4f12266865ff91cd337461830db30f6067f
Reviewed-on: https://chromium-review.googlesource.com/1029850Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553947}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2acf49579846..3b9bb8131796

$ git log 2acf49579..3b9bb8131 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I7e716957db30bc61f1c23751a5787888c55bc3b5
Reviewed-on: https://chromium-review.googlesource.com/1029548Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553946}

This patch adds install_time and last_launch_time fields to the Crostini
registry. These will be used in the app launcher's recently launched
apps list, where currently Crostini apps do not appear.

As we would also like the Terminal to appear in the recents list, this
patch makes the registry support the Terminal, returning it in both
GetRegistration and GetRegisteredAppIds. We don't need to keep track of
Terminal install time as it is just a fallback for apps that haven't
been launched. Internally, we only store the last launched time, so
methods in the registry need to be careful they don't expect all pref
entries will have all the standard fields.

Bug: 821662, 836137
Change-Id: I43f34434afe61bd80c165c3a42047b184f96fcbe
Reviewed-on: https://chromium-review.googlesource.com/1027292
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553945}

The install progress now has feedback messages in the dialog.
The view also closes automatically on completion

Bug: 822507
Change-Id: I962c9975a19fb322c611c9a02c5e2cc7ab21e06b
Reviewed-on: https://chromium-review.googlesource.com/1029559
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553944}

http/tests/devtools/elements/shadow is running several tests for shadow dom's distribution
used in devtools.

shadow-distribution.js is failing with the IncrementalShadowDOM flag.

TBR=kochi,rakina

Bug: 776656
Change-Id: Id780279b397c91bf3af7136727d36f83e1179565
Reviewed-on: https://chromium-review.googlesource.com/1029392
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553943}

Currently, we're setting the "site for cookies" only by looking at the
top-level document. We ought to be verifying that the ancestor frames
are same-site before doing so. We do this correctly in Blink (see
`Document::SiteForCookies`), but didn't do so when navigating in the
browser.

This patch addresses the majority of the problem by walking the ancestor
chain when processing a NavigationRequest. If all the ancestors are
same-site, we set the "site for cookies" to the top-level document's URL.
If they aren't all same-site, we set it to an empty URL to ensure that
we don't send SameSite cookies.

Bug: 833847
Change-Id: Icd77f31fa618fa9f8b59fc3b15e1bed6ee05aabd
Reviewed-on: https://chromium-review.googlesource.com/1025772Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553942}

We encounter the following stack when destroying the RWHVMac
  RenderWidgetHostViewMac::Show
  WebContentsImpl::WasShown
  WebContentsImpl::UpdateWebContentsVisibility
  ...
  -[NSView removeFromSuperview]
  RenderWidgetHostViewNSViewBridgeLocal::~(dtor)
  RenderWidgetHostViewMac::Destroy

This is problematic, as WebContentsImpl::UpdateWebContentsVisibility
will make a bunch of calls on RenderWidgetHostViewMac that all assume
that we are not mid-tear-down.

To avoid this, make the call to -[NSView removeFromSuperview] be a
delayed callback. That way the call will happen after the RWHVMac has
been entirely destroyed, and UpdateWebContentsVisibility will no longer
have a RWHVMac to call back into.

Bug: 834931
Change-Id: I88412173b005dfdc26026db6b4c12b31e6541e7c
Reviewed-on: https://chromium-review.googlesource.com/1025396Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553941}

https://skia.googlesource.com/skia.git/+log/6b043cb9cc1a..e56ced15da1d

$ git log 6b043cb9c..e56ced15d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: Id2dee163a22eb35ed4b84db6d3c2b7dddc9dfc99
Reviewed-on: https://chromium-review.googlesource.com/1029770
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553940}

The member is always equal to:

LineLayoutAPIShim::LayoutObjectFrom(inline_box_->GetLineLayoutItem())

Hence, this patch removes it for better code health.

Bug: 822575
Change-Id: Ib9c231daa8658aa2b9212e9754bd50c76b0affbc
Reviewed-on: https://chromium-review.googlesource.com/1026643
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553939}

This is a follow-up CL for http://crrev.com/c/1025155.
SelectorQuery updates distribution only for traversing a flat tree.

Bug: 776656
Change-Id: I07312acc73abdc593a7ef81f04761bacc3d978d0
Reviewed-on: https://chromium-review.googlesource.com/1029560Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553938}

Bug: 837127
Change-Id: Iee15da96b578ca1385440716ae5b733f30559f68
Reviewed-on: https://chromium-review.googlesource.com/1029564
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553937}

The blink public API should not expose internal blink types outside
of blink. By disallowing this dependency by default we avoid
accidentally exposing those types.

Change-Id: I68883f3d7716b2309cadf32db8e5599d2fe5c8cb
Reviewed-on: https://chromium-review.googlesource.com/1028573Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553936}

This frees up the regular HeapIncrementalMarking flag for implementing an
initial incremental marking strategy.

Bug: chromium:757440
Change-Id: Iee924ef718f450b4d1e865ef6880242f501376fb
Reviewed-on: https://chromium-review.googlesource.com/1028273Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553935}

From manual review of the build 4999.

13 files now match to their base expectations. They were removed.

TBR=eae@chromium.org, atotic@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Icddb99362241928d6fefcf30868a0c198b552fd3
Reviewed-on: https://chromium-review.googlesource.com/1029752
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553934}

Using wpt-import in Chromium dc67d955.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."
52308ad8 "Deprecate document.origin"
7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16265

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
jsbell@chromium.org:
  external/wpt/encoding
kojii@chromium.org:
  external/wpt/css/css-text/overflow-wrap

TBR=markdittmer

No-Export: true
Change-Id: I1813bf668f8d6d876ec5b2dd078069c80cc00a48
Reviewed-on: https://chromium-review.googlesource.com/1029730
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553933}

CastRemotingConnector depends on MediaRouter, which should not be
created when MediaRouter is disabled by an admin policy.

Bug: 836042
Change-Id: Ibd03b5f7c0cb875173cb8c6c573f34a12f0e22b4
Reviewed-on: https://chromium-review.googlesource.com/1026252Reviewed-by: Adam Parker <amp@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553932}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie4c4d27298742436b68c2dec05749d64abf317ab
Reviewed-on: https://chromium-review.googlesource.com/1029471Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553931}

This patch adds support for storing the StartupWMClass and StartupNotify
fields in the Crostini Registry, and expands the algorithm for matching
windows to Crostini apps to use these fields. We match startup ids
against desktop file ids as the code for launching apps in the container
sets DESKTOP_STARTUP_ID to the desktop file id.

Bug: 821662
Change-Id: I34ba361a167cd5907d76cfbfed57e3903bbf9cfd
Reviewed-on: https://chromium-review.googlesource.com/1021063
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553930}

ServiceWorkerNewScriptLoader was using the ptr then letting it fall
out of scope. ServiceWorkerScriptLoaderFactory still held a ptr to the
factory which is strongly bound, so the factory shouldn't die anyway,
but it seems safer if ServiceWorkerNewScriptLoader holds the cloned
ptr too throughout its life.

I'm not sure if this is actually needed for ExtensionURLLoaderFactory,
but it seems possible to write a factory that would fail if the
cloned ptr falls out of scope.

Bug: 836129
Change-Id: Id7b4ab9d72bb758fe639e963e2747f915e67aea3
Reviewed-on: https://chromium-review.googlesource.com/1029271Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553929}

https://chromium.googlesource.com/angle/angle.git/+log/23dc90b81efb..197d52949eed

$ git log 23dc90b81..197d52949 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 geofflang Wrap all preprocessor code in the angle namespace.

Created with:
  roll-dep src/third_party/angle
BUG=chromium:836820,chromium:801364


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I4e73dc6ca51b5b8863fbcd0b266f8cd1a5df2500
Reviewed-on: https://chromium-review.googlesource.com/1029194Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553928}

The flaky failure of the test seems to be due to not waiting long enough after
resuming work again. This Cl changes the workaround logic to actually wait until
the javascript work again (or let the test fail by timing out otherwise).

Bug: 832191
Change-Id: I3c2f04ccf4d00cee6505e607566628d690f4ef00
Reviewed-on: https://chromium-review.googlesource.com/1011744
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553927}

This CL adds a preference called kCrostiniEnabled (= "crostini.enabled")
and sets it to true when Crostini is installed.

Bug: 833125
Change-Id: I58f27113e49cdcbc1c4aaf99f5aa4096fcdab902
Reviewed-on: https://chromium-review.googlesource.com/1013843
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553926}

https://pdfium.googlesource.com/pdfium.git/+log/7132ee35925f..9b8b217e6f8f

$ git log 7132ee359..9b8b217e6 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 tsepez Replace reinterpret_cast with static_cast where possible
2018-04-25 hnakashima Make XFA Caret become immediately visible when moved.
2018-04-25 rharrison Use local for return value in factory method
2018-04-25 rharrison Don't store CE (comment extension) block data when decoding GIF
2018-04-25 thestig Use a bool in FindBit() in the fax codec.
2018-04-25 thestig Add PostScript PASSTHROUGH options to FPDF_SetPrintMode().
2018-04-25 thestig Use PredictorType in more places.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:835608,chromium:833168


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib59b785d5d3425a110c42e7af4b7eb1533232813
Reviewed-on: https://chromium-review.googlesource.com/1029189Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553925}

BUG=chromium:834170
TEST=VDA/VEA/JDA/JEA unittest built scueessfully for Chrome OS on both x86 and
ARM platforms
TEST=made sure for other platforms by CQ

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I480220047ac23e4c26ee4dfff0ac2ef3bac70f6b
Reviewed-on: https://chromium-review.googlesource.com/1016222Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553924}

TBR=qinmin@chromium.org

Bug: 837104
Change-Id: I8f59a618815ce71de395af29795b891529a75ef4
Reviewed-on: https://chromium-review.googlesource.com/1029554Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553923}

Bug: 836832
Change-Id: I2930377b31e99e82704aa4d5e27780181c38c3ba
Reviewed-on: https://chromium-review.googlesource.com/1028530
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553922}