- 29 May, 2019 40 commits
-
-
Ian Kilpatrick authored
NGLayoutInputNode::Layout was only used for inflow children of the NGBlockLayoutAlgorithm. This inlines this function (which was a manual method dispatch). This also saves a little (16-bytes) of stack. Bug: 962034, 964926 Change-Id: If227ccf714afb121105875f17f10d6e493365930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629700 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#664157}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00365de163d6..2b650797a992 git log 00365de163d6..2b650797a992 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a4545bae..b3e0873d (467 commits) Created with: gclient setdep -r src/third_party/skia@2b650797a992 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I62ff27d38544d2ea55d0d34d1167b8345d8c4204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664156}
-
Anand K. Mistry authored
BUG=926138 Change-Id: I2ffc9b261ac1e81ef0791676b28b3c7c293a8084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628500Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664155}
-
Eric Seckler authored
The perfetto service now provides a signal for clearing of incremental state. This patch plumbs the signal into our data sources down to the event sink. Bug: 928738 Change-Id: If4bfb5329eb50e8222cd670ed4a0ece0ad25081e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632213Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#664154}
-
Fergus Dall authored
Currently we show the finished message as soon as we learn the packagekitd transaction has completed. This can lead to a noticeable delay before the app being (un)installed is removed/added to the launcher. This CL delays this until all pending app list updates that were running when the operation finished, have themselves finished. This CL depends on changes to cros_system_api in crrev.com/c/1612877 Bug: 937748 Change-Id: I57a36a5e71c7f4e96e2d1ab825ff3f20e05c33a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611434 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#664153}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b97d193baafa..2ee83757a109 git log b97d193baafa..2ee83757a109 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 tikuta@chromium.org [autoninja] use custom status in non-windows too Created with: gclient setdep -r src/third_party/depot_tools@2ee83757a109 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic24465fc92b2a90b9bb132744d3b40da31bd34bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664152}
-
Yutaka Hirano authored
Move the class so as to platform/loader can use it. Bug: 963306, 914739 Change-Id: I647fc6bfe13c7c895e48842861cb3b84d4e49a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634134Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664151}
-
Fergus Dall authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9c6f6cc701b1..ad9db8abe4e8 $ git log 9c6f6cc70..ad9db8abe --date=short --no-merges --format='%ad %ae %s' 2019-05-15 sidereal vm_tools: Notify chrome about pending app list updates 2019-05-16 ljusten kerberos: Add ClearAccounts() method 2019-05-21 briannorris shill: drop ad-hoc support 2019-05-23 dtor system_api: add new_name field to RegisterVm name for Plugin VMs 2019-05-24 dtor system_api: remove STORAGE_CRYPTOHOME_DOWNLOADS from concierge API 2019-04-30 dtor system_api: remove storage_location from concierge's export/destroy 2019-02-08 xiaochu dlcservice: make Install API async Created with: roll-dep src/third_party/cros_system_api Change-Id: I6df087b0cd0eeed70dc0a4da186b20937c4a6252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633693 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#664150}
-
Leo Zhang authored
Before a large code refactoring in IME service, convert it to new Mojo types first in order to avoid any conflict during the refactoring with an ongoing Mojo types converting. TEST= /out/ime/chromeos_unittests --gtest_filter=ImeServiceTest* Bug: 837156 Change-Id: I8ae669cb2fe9da980364696675278d3dc1e9516b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632131 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#664149}
-
Adam Rice authored
This reverts commit 1f54c905. Reason for revert: Speculative fix for https://crbug.com/968005 (ExtensionApiTest.ChromeRuntimeOpenOptionsPage test failing on MSAN bots) Original change's description: > [Extension test] Add ability to load event_page extension as SW extension. > > Add a flag to RunExtensionTest so that an existing event page based > test extension can be loaded as SW based extension. This can be > used to run extenision tests with Service Worker based extensions. > > This CL also converts runtime/open_options_page/ test extension to event > page extension and demonstrates that the extension be loaded > as SW extension and the corresponding test > ExtensionApiTest.ChromeRuntimeOpenOptionsPage passes with the flag in > ServiceWorkerBasedBackgroundTest.ChromeRuntimeOpenOptionsPage. > > Doc: https://docs.google.com/document/d/1PvXZ7VGRGdmd1s99SFByn9NCGj0GAiBhhPmfjj35ZeI/edit# > > Bug: 967899 > Change-Id: I8821d1c9fa22795b8fe0f65f1bd073a034e24431 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626455 > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664062} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org Change-Id: Ia818e2881a2802e981246c93d205a0ffb9ff9096 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634509Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#664148}
-
Kyle Horimoto authored
An earlier design planned to pass a "cellular network GUID" parameter to StartActivation(), but this is no longer the case, since activation should be allowed even if the device has no SIM card (and thus, no cellular network). This CL removes the parameter; a follow-up CL adds the implementation for this function. Bug: 961084 Change-Id: Ie3026c2b8400f79bd317becb0fc71c5bf740bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629124 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#664147}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15de9f2c..b7182085 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iadee9e0c334d3dcb3ba643cfcff29205232f68c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633714Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664146}
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: Ia465f59ed333d66ebda5fd2f6eeaaa5682ceeb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630385Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664145}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b4620d4523a..1a91e38ab868 Created with: gclient setdep -r src-internal@1a91e38ab868 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I4fda48e84b36fb4ad159d83a4616b78bd0695e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664144}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/5ba891aba76f..c7b49740a0c4 git log 5ba891aba76f..c7b49740a0c4 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 dneto@google.com Remove dead file (#632) Created with: gclient setdep -r src/third_party/shaderc/src@c7b49740a0c4 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Id7cc856ca25d4b2a9a13c09ef11d50c51abe5692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664143}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25b63f91b3b4..00365de163d6 git log 25b63f91b3b4..00365de163d6 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 710fcd517ea4..ca8e3d7c153e (23 commits) Created with: gclient setdep -r src/third_party/skia@00365de163d6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I2f9a1682b3016a80e6538842acdb87f326fa7e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664142}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a63e7596c1e6..f5a5c539a5ee git log a63e7596c1e6..f5a5c539a5ee --date=short --no-merges --format='%ad %ae %s' 2019-05-29 dberris@chromium.org Dashboard: Fix comparator to handle duplicates Created with: gclient setdep -r src/third_party/catapult@f5a5c539a5ee The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967559 TBR=zhanliang@google.com Change-Id: I7b2161639505f4b74a2dbd4613e6821c8de935f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664141}
-
Fergus Dall authored
Parts of the concierge API were removed in crrev.com/c/1626887 and crrev.com/c/1629870 without checking if it would break chrome. Remove the usage so we can do a dep-roll. Bug: b:130304430 Change-Id: Ia0bfaf2dae4ef8efd187cf7ff132dbb0bf960e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634111Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#664140}
-
Joel Hockey authored
Change-Id: I9bc396c2c7a4730a9dc10c7bdb3427d2468dc8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631810 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#664139}
-
Yuwei Huang authored
* Implement RemotingLogToServer to talk to the new telemetry server * Add a unittest for it * Modify existing code to use it. For IT2ME we also have to make XmppLogToServer able to be initialized on a sequence different than the constructor's sequence, so that It2MeNativeMessagingHost can create it on the main thread and It2MeHost can use it on the network thread * Make HeartbeatSender send a log when it heartbeats, similar to the behavior of XmppHeartbeatSender Bug: 966993 Change-Id: I3c313acff91bad3ff3b28dd6d803669780dbac50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629148 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664138}
-
Bill Orr authored
Specifically this adds usecounters for when an XRSession request succeeds, getting offset reference spaces, viewport scaling, ignoring depth values, and XRInputSource gamepad. It also adds UMAs to measure which runtime is used, and what reference spaces are requested/used. Bug: 947592 Change-Id: I8bbb3a495c2b0a704a7f8b75286638b4d7452be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614500 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664137}
-
Yutaka Hirano authored
Replace the calls to either UseCounter::CountUse(Document&, ...) or Document::CountUse(...). This is needed to move the class to platform/. Bug: 963306 Change-Id: I82810a760d8b2a1df1a6f4a552d2dbca23245e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614721Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664136}
-
Yutaka Hirano authored
This is a followup of [1]. It turns out FrameUseCounter is confusing given that it is not a subclass of UseCounter, so this CL renames it to UseCounterHelper. This CL also renames DocumentLoader::GetUseCounter to DocumentLoader::GetUseCounterHelper, which was another TODO in [1]. 1: https://crrev.com/7d455c057de0e1ccb28b2eb574b855ae118786dc Bug: 963306 Change-Id: Id83e39bcdb0c6957384d9dbe269deee2de203b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664135}
-
tby authored
This CL adds the most recently launched app to the info included in a hashed logging event. Note: there are now a couple of string manipulation functions in search_controller.cc that probably don't belong there, and are also duplicated elsewhere. I'll refactor them out into the utilities class in a separate CL. Bug: 951287 Change-Id: I0ea7379339aa1ae25788a6c0cc6af73f38a0f004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634029Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#664134}
-
Sara Kato authored
Ensure that filter type is correctly set when S2S is enabled. Test: Manual (follow steps to reproduce on bug) Bug: b/109637169 Change-Id: I34a6358a8aa27e5571e70f1b71866c46dd79fcd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631809Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#664133}
-
Sam McNally authored
BackgroundTrigger never ended up being used so remove it. Change-Id: I96ae083bfe60c893b7ddd97921d6432a69d207ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634129 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#664132}
-
Ramin Halavati authored
Profile::IsGuestProfile() returned true for the off the record profile of a guest session profile, and Profile::IsGuestSession() returns true for both off the record and regular profiles of the guest sessions. To prevent usage confusions, the former is removed. Bug: 947933 Change-Id: Iedf55f05d386bd190d8cb00228bfc104b5b763cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628728Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#664131}
-
Koji Ishii authored
This patch changes `ShapeResult` and `ShapeResultView` to set `StartIndex` from the original given argument. Before this change, it was computed from the start index of the first run. This was problematic when the first run is missing, such as when all glyphs in the first run are missing. LayoutNG and `ShapingLineBreaker` fails to compute when `StartIndex` and `EndIndex` are shifted due to missing runs. The way to compute `NumCharacters()` is also changed because `EndIndex` depends on it. Before it's the sum of characters in all runs, but for the same reason, this excludes missing runs. With this change, it is computed and set from the given arguments on creation. The start index of runs is also affected when copying ranges or creating `ShapeResultView`, because the old way was accumulating the number of characters in runs, which results in incorrect index after a missing run. Bug: 963521, 967167, 967439 Change-Id: Ie522285fce6468d70334cd7cca5c3ac7b358f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632134Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#664130}
-
Jay Harris authored
When window.open is called, the created app window doesn't know what url it will be opening, so we can't determine if the toolbar will be shown. Thus, once the web contents starts a navigation, the window bounds must be checked for correctness. This CL adds a property 'initial_url' function to AppBrowserController. This will be used in a future CL to determine whether or not to show the 'X' button on the custom tab bar (popups opened out of scope should not show it). Before and after screenshots for an in and out of scope popup. The popups should both have their web contents sized at 480x300 Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394814&signed_aid=zqCH2pYzkhISnPQRiPjzuQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394815&signed_aid=owOrcmaGQWpKcub8E8orNw==&inline=1 Bug: 777854 Change-Id: I893c21d0c13a12b079eb578e68f1167bf335be8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626058 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#664129}
-
Takuto Ikuta authored
This is step 2 written in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1337417 Bug: 954450 Change-Id: I12f57ceca31ab35933ea70549b77b54a3e6275ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629896Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4870b6af055..9b4620d4523a Created with: gclient setdep -r src-internal@9b4620d4523a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I429dced93cb545f5180d8750cd9f4feb8f4e5053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633537Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664127}
-
Armando Miraglia authored
Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] https://github.com/w3c/mediacapture-main/issues/585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#664126}
-
Lambros Lambrou authored
This updates the installer, and the launchd agent (whenever it is run as root) to run the upgrade tool. Bug: 954427 Change-Id: I7f4a4b89c95ec76f706f4906a207af2236c29871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633970Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664125}
-
Erik Jensen authored
On Windows, this is used to rewrite the configuration file. Bug: 954427 Change-Id: I8bca99c6cf553004936417d626b4b3e47830103e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633630 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664124}
-
Paul Dyson authored
Instead of only logging PWAs that are on a white list, use from_bookmark() to determine whether an extension is a PWA. from_bookmark() returns true for both PWAs and bookmark apps, so this is used to log bookmark apps as well. Bug: 899123 Change-Id: Ia6cc4f11fff13ff249786f229d21c6d15d1d8e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599811Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#664123}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c573ec8ab233..25b63f91b3b4 git log c573ec8ab233..25b63f91b3b4 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 herb@google.com Remove getGlyphIDAdvance() from SkStrike's API Created with: gclient setdep -r src/third_party/skia@25b63f91b3b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I6fb58c610a7d604ad31ca906de8dca9f317db18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664122}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/686be20b4556..e4470cd8b405 git log 686be20b4556..e4470cd8b405 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9b60f86c..99181c0b (663961:664078) Created with: gclient setdep -r src/third_party/webrtc@e4470cd8b405 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib1cd89606a31b2646f9d3b3f925822c7219cd136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664121}
-
Matt Mueller authored
CRLs use the same concept of thisUpdate & nextUpdate, split the date checking function out so that it can be used by both OCSP and CRL checking. Bug: 749276 Change-Id: I641db6f92062422ff70697353bd4d435016dc2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628167 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664120}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5db62d36c9b5..a63e7596c1e6 git log 5db62d36c9b5..a63e7596c1e6 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 dberris@chromium.org Dashboard: Add dberris@ to OWNERS Created with: gclient setdep -r src/third_party/catapult@a63e7596c1e6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Change-Id: I4afec78d00ade914cc2fa68e6ab06c6d24892de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664119}
-
Erik Jensen authored
Previously, we were passing the pseudo handle returned by GetCurrentThreadToken(). While this worked fine on Windows 10, but failed on Windows 7. This commit instead uses OpenThreadToken, which returns a real handle to the user token. Bug: 967928 Change-Id: Ic1f58aa03d07fb68748aff2b5c08a3aaf7b1005b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632601Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664118}
-