- 29 Sep, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f34eb4de7eca..6f79a94b4b18 Created with: gclient setdep -r src-internal@6f79a94b4b18 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ce8e0e88ff900ffdd476a2397fe47f393865878 Reviewed-on: https://chromium-review.googlesource.com/1252276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595333}
-
Eric Karl authored
Currently, we ignore updates to child LSIs while hidden. This can lead to cases where the browser never receives the update. There should be no downside to processing these (this seemed like an accidental incorrect optimization), so this CL removes the restriction. Bug: 889829, 889817 Change-Id: I3ac96f40cffd0816cc01261c4bbc7fa23e27a69e Reviewed-on: https://chromium-review.googlesource.com/1252275 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595332}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc16295f..a733a4e0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4273e641d78ab78188f50b584bd2834c7ea20a36 Reviewed-on: https://chromium-review.googlesource.com/1252775Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595331}
-
sunxd authored
We are going to implement wheel event handler region computation in ScrollingCoordinator and painting, since wheel event regions share many similarities to touch action rects, we want to use the same code path for wheel events. As a result, TouchActionRect will store wheel data as well and they should be renamed to HitTestRect. Bug: 841364 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1d9c967033846d1945163192a437f11cbebdf641 Reviewed-on: https://chromium-review.googlesource.com/1239490Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595330}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/237f00f86f1a..f34eb4de7eca Created with: gclient setdep -r src-internal@f34eb4de7eca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I90ec806b3e39e4508d26d7b1eaba240daad567d8 Reviewed-on: https://chromium-review.googlesource.com/1252274Reviewed-by:
-
John Budorick authored
This is a reland of crrev.com/c/1252630 TBR=kbr@chromium.org,zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Bug: 838970 Change-Id: I6590724352d1458bbd1c2a1fb050968ad1af025d Reviewed-on: https://chromium-review.googlesource.com/1252466Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595328}
-
Jamie Madill authored
Changing the textures_pending_binding_ from an unordered map to a flat array gives about a 15% speed improvement on the TextureDraw perf test. Bug: angleproject:2763 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I74c3a9499cca5d5854490dc70e2b3d83a6af9663 Reviewed-on: https://chromium-review.googlesource.com/1247941 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595327}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/686dfc3f..cc16295f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffa9c5a86df74d6e607e22532fc64bd123e16acf Reviewed-on: https://chromium-review.googlesource.com/1251226Reviewed-by:
-
Peter K. Lee authored
It was erroneously set to "Enter passphrase" but never discovered because Material uses ALL CAPS which hides the incorrect use of lowercase on the second word. Bug: 887932 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia3ff5efefb992ca326ac3f94be3be13d78e1f831 Reviewed-on: https://chromium-review.googlesource.com/1252535 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595325}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c0b82333ab27..79207e6e11df git log c0b82333ab27..79207e6e11df --date=short --no-merges --format='%ad %ae %s' 2018-09-28 ynovikov@google.com Skip tests failing on Pixel XL 2018-09-28 jiawei.shao@intel.com Enable several end2end tests on Windows Intel drivers Created with: gclient setdep -r src/third_party/angle@79207e6e11df The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I79909e629c778451bc4991efa160ea7dff31a3a9 Reviewed-on: https://chromium-review.googlesource.com/1252376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595324}
-
Dale Curtis authored
Since AVDA is on it's way out... this also replaces all instances of base::Bind with the appropriate version (generally base::BindOnce). BUG=none TEST=bots R=liberato Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I75f8dd4895f7404fe752cf02d495a198b8a78a6a Reviewed-on: https://chromium-review.googlesource.com/1252961 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#595323}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d525ef309fca..98289bcecf60 git log d525ef309fca..98289bcecf60 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 simonhatch@chromium.org Dashboard - Add missing index for querying last alert. 2018-09-28 chiniforooshan@chromium.org Telemetry: cpu_per_frame metrics in TBMv2 2018-09-28 manojgupta@google.com benchmark_runner: Emit all stories in a benchmark. 2018-09-28 dtu@chromium.org [pinpoint] Don't set difference_count for try jobs. 2018-09-28 jbudorick@chromium.org devil: remove host arm build rules. Created with: gclient setdep -r src/third_party/catapult@98289bcecf60 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890325,chromium:760553,chromium:888551,chromium:888114,chromium:890041,chromium:887888 TBR=sullivan@chromium.org Change-Id: I25e06429f53579449a9ebd2d1ba948ff6409f4e7 Reviewed-on: https://chromium-review.googlesource.com/1252266Reviewed-by:
-
W. James MacLean authored
This CL removes a hack from Android's TouchSelectionControllerClientManager that attempts to add the current page scale factor in to the handles' coordinates. Somewhere along the way the underlying lack of page scale factor in the coordinate transforms went away. meaning the hack was causing the coordinates to be incorrect. This CL also makes a small fix to the function RenderWidgetHostViewAndroid::TransformPointToCoordSpaceForView that generalizes how it checks for the FrameSinkId necessary to do the transformations. Bug: 809122 Change-Id: I74e7ddc8d448ae28061d34a42c295e5ae4f7f624 Reviewed-on: https://chromium-review.googlesource.com/1251023 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595321}
-
Dale Curtis authored
These traces will allow us to diagnose problems on the GPU side. Specifically the following traces are added: - MojoVideoDecoderService::Construct - MojoVideoDecoderService::GetSupportedConfigs - MojoVideoDecoderService::Initialize [async] - MojoVideoDecoderService::Decode [async] ---- [step] ReadDecoderBuffer ---- [step] Decode - MojoVideoDecoderService::Reset [async] - MojoVideoDecoderService::OnDecoderOutput - MojoVideoDecoderService::OnOverlayInfoChanged - MojoVideoDecoderService::OnDecoderRequestedOverlayInfo BUG=883620 TEST=none R=sandersd Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I24581ec28f52290856d6daf262417e632999ce21 Reviewed-on: https://chromium-review.googlesource.com/1252538 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595320}
-
Jdragon authored
The CL replaces the calls to Time::From/ToInternalValue() by the more explicit Time::From/ToDeltaSinceWindowsEpoch(). This change is backwards compatible. Bug: 889242 Change-Id: I4df4bab497465e975abc137052010ca2590a77a5 Reviewed-on: https://chromium-review.googlesource.com/1248328 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595319}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e8219b816bc..237f00f86f1a Created with: gclient setdep -r src-internal@237f00f86f1a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2d2c2be3071804682df4e3070847f02ea9fde782 Reviewed-on: https://chromium-review.googlesource.com/1252273Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baea2950878c..7e8219b816bc Created with: gclient setdep -r src-internal@7e8219b816bc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I400a39eb6a6b40d227f4cb532cbdb5e50310da76 Reviewed-on: https://chromium-review.googlesource.com/1252272Reviewed-by:
-
Thomas Tangl authored
Strings from the Clear Browsing Data dialog are updated to match the latest mocks: https://docs.google.com/presentation/d/1SrFbjYNnVzocnXHAIORey20PKYL6kPyyqSjbl5204a0/edit?ts=5bad4384#slide=id.g42e19778c0_13_8 Note: This CL only adds and changes strings in the settings_strings.grdp file. The UI will be updated in a follow up CL. TBR=jochen@chromium.org Bug: 889137 Change-Id: I2a578b9ec554b375286ab796e47ec7f267ce9475 Reviewed-on: https://chromium-review.googlesource.com/1252302 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#595316}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b864b58b70e1..baea2950878c Created with: gclient setdep -r src-internal@baea2950878c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia93484a1b0fbcc2d37f239aad354f678f6082de0 Reviewed-on: https://chromium-review.googlesource.com/1252271Reviewed-by:
-
Kenichi Ishibashi authored
Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/a6P-niHWgF4/CtJEHCnKDwAJ Bug: 719052 Change-Id: I7ed1af009b41adef50b2d73301d8577b47baa8c6 Reviewed-on: https://chromium-review.googlesource.com/1249466Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595314}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bd8951afe3f4..84f3a15fd9db git log bd8951afe3f4..84f3a15fd9db --date=short --no-merges --format='%ad %ae %s' 2018-09-29 pprabhu@chromium.org cbuildbot: Use luci_project:chromeos for skylab hwtests 2018-09-29 akeshet@chromium.org Revert "Chromite: Add Common Metric Fields for all metrics" 2018-09-29 akeshet@chromium.org Revert "failed_stage metric: Add important field" 2018-09-29 yunlian@google.com parseelf: get size of symbol table by reading section header Created with: gclient setdep -r src/third_party/chromite@84f3a15fd9db The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id6dba3edd454daf2bb37d2929d073e86b1147368 Reviewed-on: https://chromium-review.googlesource.com/1252270Reviewed-by:
-
Vaclav Brozek authored
When the user submits a form and Chrome understands that as a successful submission, it parses the submitted data into a PasswordForm ready to be saved into the PasswordStore. Currently, two codepaths exists to do so. The old one involves a PasswordFormManager and an old FormData parser, the new one involves a NewPasswordFormManager and a new FormData parser. This CL adds a metric comparing the result of both codepaths. The privacy review of password manager UKM metrics was done on https://crbug.com/728707. Bug: 845426 Change-Id: Ie8c11d4ff6e0a17029ec05104a560fe764597f1e Reviewed-on: https://chromium-review.googlesource.com/1243126 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#595312}
-
Shu Chen authored
Bug: 890561 Change-Id: Ie766224794a0b34a8f6f9d94894e9dfbe6db5f28 Reviewed-on: https://chromium-review.googlesource.com/1253262 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Lan Wei <azurewei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595311}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I3664fc85955ae52fef6be122f5a92e1799e5fb22 Reviewed-on: https://chromium-review.googlesource.com/1253204Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595310}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e12685713d9..b864b58b70e1 Created with: gclient setdep -r src-internal@b864b58b70e1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie3cb647375482647c57f5f8485af5913520783b2 Reviewed-on: https://chromium-review.googlesource.com/1252269Reviewed-by:
-
Wenzhao Zang authored
The flakiness is not related to RunUntilIdle(), but is because ScopedTempDir is not used for custom or online wallpapers: the tests do lots of operations on the directories, so we should make sure they are unique to avoid affecting each other. Bug: 823760, 823762 Test: ash_unittests (Run all tests together) Change-Id: I9cf6a70a4cfc146c8a0b91ed4cf2860dbc72394f Reviewed-on: https://chromium-review.googlesource.com/1252981 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#595308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a12891c908f..2e12685713d9 Created with: gclient setdep -r src-internal@2e12685713d9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If4763fe1ef7b966cd886e5fce011406f1d6671e1 Reviewed-on: https://chromium-review.googlesource.com/1252267Reviewed-by:
-
Greg Thompson authored
Give a little info about default buttons so that consumers think about whether or not they're a good thing. BUG=884831 R=pkasting@chromium.org Change-Id: I9f65cfdfc349fb71a270973d416decd5528c8e88 Reviewed-on: https://chromium-review.googlesource.com/1251082Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#595306}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I653a6a42d27968e1f0c313715da7d6f7683dafd2 Reviewed-on: https://chromium-review.googlesource.com/1252268Reviewed-by:
-
John Abd-El-Malek authored
Bug: 840444 Change-Id: Idb614469052bbb9bff0232513e88879e1dbd8b2c Reviewed-on: https://chromium-review.googlesource.com/1252502Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#595304}
-
Lei Zhang authored
PDFiumPrint and PDFiumEngineExports both have code to create N-up PDFs. Merge the two since they are nearly identical. For the PDFiumPrint caller, make it do fit the page into a symmetrical printable area, so N-up printing is consistent for PDF content and web content. BUG=890058 Change-Id: I933b899434f3a3cd2d853529696629aed18461e7 Reviewed-on: https://chromium-review.googlesource.com/1250162 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595303}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4260d7eed767..3a12891c908f Created with: gclient setdep -r src-internal@3a12891c908f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ief862da3ed2ded9fcaa01b7776ee5f863384209c Reviewed-on: https://chromium-review.googlesource.com/1252265Reviewed-by:
-
Jaeyong Bae authored
This CL means removing duplicate macro in base/file_path.h. PRIsFP is replaced with PRFilePath. Bug: 882796 Change-Id: I69f1dc3c13921d0f5d8f1f2de577f27f8db072f4 Reviewed-on: https://chromium-review.googlesource.com/1220406 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595301}
-
John Budorick authored
This reverts commit ef5f45ae. Reason for revert: see comments on CL. Original change's description: > Lock Win Intel GPU bots on GPU FYI to driver 24.20.100.6286 > > BUG=838970 > TEST=GPU FYI waterfall > R=kbr@chromium.org > > Change-Id: Idf1b701539c427a63ed5648396a3c6588d305733 > Reviewed-on: https://chromium-review.googlesource.com/1252630 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595257} TBR=zmo@chromium.org,kbr@chromium.org Change-Id: Ie682295188ce2a834124a3abbf02c1e59fe786ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838970 Reviewed-on: https://chromium-review.googlesource.com/1253075Reviewed-by:
-
John Budorick authored
is_chrome_branded requires an internal checkout. TBR=bpastene@chromium.org Bug: 887429 Change-Id: Ia98b948ef94e81738d695dfe2e1e0d2b5868c600 Reviewed-on: https://chromium-review.googlesource.com/1252465Reviewed-by:
-
Paul Miller authored
Chrome uses SharedPreferences to store the first-run variation seed. WebView doesn't have a first-run flow, and shouldn't use SharedPreferences; doing so is a StrictMode violation, which breaks CTS. Commit 49eebb8c addressed this by passing the seed through AwVariationsSeedBridge, rather than VariationsSeedBridge, which uses SharedPreferences. But VariationsSeedStore::StoreSeedDataNoDelta() still calls VariationsSeedBridge in WebView. Refactor the VariationsSeedBridge part out of VariationsSeedStore and into the on_initial_seed_stored_ callback. In Android Chrome, the callback will call VariationsSeedBridge, while in WebView, it will be a no-op. Refactor VariationsSeedBridge into an injected dependency of VariationsFieldTrialCreator, so that Chrome and WebView can prepare a VariationsSeedBridge with and without the callback, respectively. Chrome prepares the VariationsSeedBridge in VariationsService, which is manages seed downloads in Chrome. WebView doesn't use VariationsService; WebView creates its VariationsSeedBridge in AwFieldTrialCreator. BUG=876862 Change-Id: Idcc9b4bc484d37efd1f41ca6897fca6e5e2df9c6 Reviewed-on: https://chromium-review.googlesource.com/1247682Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
Before this patch: The SXG accept header is sent to all origins when SignedHTTPExchange feature or SignedHTTPExchangeOriginTrial feature is enabled. After this patch: The SXG accept header is sent when - SignedHTTPExchange feature is enabled. or - SignedHTTPExchangeOriginTrial feature and SignedHTTPExchangeAcceptHeader feature are enabled and the origin of the URL is in the OriginList of SignedHTTPExchangeAcceptHeader field trial. Bug: 887201 Change-Id: Id335fec1c791c2436cb4ce304b90aca4b71ee8ee Reviewed-on: https://chromium-review.googlesource.com/1248347 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595297}
-
Lei Zhang authored
- Fix #includes / remove unused ones. - Fix some lint errors. - Fix nits and use more constexpr. Change-Id: I73af034b6855b4b7e4456aee6c1ae544cc7216b0 Reviewed-on: https://chromium-review.googlesource.com/1250641 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595296}
-
Guido Urdaneta authored
This change is consistent with how device names are reported on Mac. Bug: 780492 Change-Id: I835115156a51681744f005d495459a5aa5859cba Reviewed-on: https://chromium-review.googlesource.com/1251454 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a5a40ce0acc..4260d7eed767 Created with: gclient setdep -r src-internal@4260d7eed767 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856728 TBR=mmoss@chromium.org Change-Id: I1e6032296a96df23bae5bd71f3610912381691e7 Reviewed-on: https://chromium-review.googlesource.com/1253141Reviewed-by:
-
