- 12 Apr, 2018 40 commits
-
-
chrome://discardsFrancois Doray authored
This is useful to debug occlusion tracking issues and to get a better understanding of which tabs might be discarded. Bug: 775644 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1ad43559a96eb758d3a7796186930d6a7ffa4b39 Reviewed-on: https://chromium-review.googlesource.com/993702Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#550316}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. SurfaceAggregatorPixelTest is one such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8ea6b0cde545dd2a0a60cff2294028baf5569747 Reviewed-on: https://chromium-review.googlesource.com/1010705 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550315}
-
Carlos IL authored
Added a GetErrorDescription method to chrome_content_renderer_client, which unlike PrepareErrorPage, does not set pending_error_page_info_. Bug: 829554 Change-Id: I91f310b1bb9539f07e7d1dd3f33b2269cd862bd0 Reviewed-on: https://chromium-review.googlesource.com/1000723Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#550314}
-
Fredrik Söderquist authored
This flag is never set to true anymore. Bug: 442939 Change-Id: I03bc6129d923ff90d39e32b7508bb56cf1139b31 Reviewed-on: https://chromium-review.googlesource.com/1010164 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550313}
-
Evan Stade authored
Move the accelerator data to ash/public for those that need it and remove references that are redundant. Bug: 826411 Change-Id: I3c20bc590dd9b3c1920dde65431dad09cdc59da4 Reviewed-on: https://chromium-review.googlesource.com/996473 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#550312}
-
dpapad authored
Latest version of Closure compiler is smarter and stricter. The errors need to be fixed to unblock rolling the latest Closure compiler version. Bug: 831004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5cf2abbcba1a209e28fb826b16f57e5dbd084853 Reviewed-on: https://chromium-review.googlesource.com/1006195 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#550311}
-
Nicolas Pena authored
This CL moves the final user-timing tests to external/wpt and removes the folder. The performance_entrylist_checker is changed as in the http counterpart to allow de-duplicating test messages. There are some tests that are related to the wpt counterparts, but not equivalent and in a different format, so unifying some of these tests can be done in the future. Bug: 498037 Change-Id: I6f35d962ba088d92a9768e49a65dea4d5c267491 Reviewed-on: https://chromium-review.googlesource.com/1007888Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#550310}
-
Peter K. Lee authored
SSO Sign-In for FeedbackKit V2 was disabled because "Add another account" would cause a crash. FeedbackKit V2 now provides a configuration option to not show "Add another account" http://crrev/i/605488. With this option SSO Sign-In can be re-enabled. Bug: 816883 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I071548a178be47f9b260359d0aeb76642562c4bd Reviewed-on: https://chromium-review.googlesource.com/1009006 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550309}
-
Sergey Ulanov authored
New SDK contains - fixes for goland fdio namespace - pkgfs perf improvements - updated async API Bug: 707030 Change-Id: Ie97e68fc9a7623575d2673b6bba7647b5ef33733 Reviewed-on: https://chromium-review.googlesource.com/1010824 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550308}
-
John Abd-El-Malek authored
The code switched threads but a DCHECK_CURRENTLY_ON wasn't updated. Bug: 825242 Change-Id: I68a93bfd9e3a1aee2bd8abdb599b832b4226c3b4 Reviewed-on: https://chromium-review.googlesource.com/1010407Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#550307}
-
Steve Anton authored
This moves the reporting for the SdpSemanticRequested UMA metric to the PeerConnection handler directly and removes the usage of the SdpSemantic::kDefault WebRTC value. Bug: 811683 Change-Id: Icecd551e40fb174eb21a5bd48943d5f8b522dd42 Reviewed-on: https://chromium-review.googlesource.com/944248 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#550306}
-
Nate Fischer authored
This adds feature flags for WebResourceError and SafeBrowsingResponse methods (objects which are passed back in WebViewClient callbacks). Support for these methods landed a while ago, so this CL declares the features are implemented. Bug: 832205 Test: N/A Change-Id: I73665515915cc9305636f09b72fbad8d6a9313ca Reviewed-on: https://chromium-review.googlesource.com/1010717Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550305}
-
Michael Lippautz authored
Similar to ScriptWrappableMarkingVisitor, thread all write barrier calls through MarkingVisitor::WriteBarrier. Drive-by: - Add missing write barrier to CSSRule. Bug: chromium:757440 Change-Id: Ibc9885ac0724ec157df9c7c314be2aa14555691b Reviewed-on: https://chromium-review.googlesource.com/1010204 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550304}
-
Matt Wolenetz authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/272be0ac4cae..5af686b3cfa2 $ git log 272be0ac4..5af686b3c --date=short --no-merges --format='%ad %ae %s' 2018-04-11 wolenetz lavc/libopusdec: Allow avcodec_open2 to call .close Created with: roll-dep src/third_party/ffmpeg TBR=xhwang@chromium.org Bug: 828526 Change-Id: I07f28b8b0cc722d5f07040738fc15d3a3db3f832 Reviewed-on: https://chromium-review.googlesource.com/1008879Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550303}
-
Kevin Marshall authored
native_library_fuchsia uses the Fuchsia-specific dlopen_vmo() function instead of dlopen() as on other POSIX builds. The library is package-aware, resolving full library paths differently if the process is running inside a packaged namespace. Bug: 798847 Change-Id: I1f4e0769e8b94bff65704df4dcfd73c622df13bc Reviewed-on: https://chromium-review.googlesource.com/1003060Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550302}
-
James Hawkins authored
R=khorimoto@chromium.org, stevenjb@chromium.org Bug: none Test: none Change-Id: I0417430122f57980e62b52a40d44f9c1e38024d6 Reviewed-on: https://chromium-review.googlesource.com/1003895Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#550301}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e9e2c82bdf1..b1c21a5af2ec $ git log 7e9e2c82b..b1c21a5af --date=short --no-merges --format='%ad %ae %s' 2018-04-11 cwallez presubmit_unittest.py: use LUCI for the optional GPU tests on Windows Created with: roll-dep src/third_party/depot_tools BUG=chromium:815092 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I71e7fa6024b9faf97379628674ee729f21b50ace Reviewed-on: https://chromium-review.googlesource.com/1010762 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550300}
-
Mark Pearson authored
Can't hurt. TBR=hpayer (who LGTMed this earlier, in writing, just without the +1) Change-Id: Ia39c47bfe378182ee6e631554d5a24662598de98 Reviewed-on: https://chromium-review.googlesource.com/980590Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550299}
-
Xiaohan Wang authored
MediaService has been shipped on Android and ChromeCast, to support remote CDM, AudioDecoder and media Renderer. It will be shipped on Mac and Windows soon to support hardware audio/video decoders running in the GPU process. CdmService (also covered by this test) has been shipped on all desktop platforms to support CDMs. Hence, it's getting more important to have proper test/bot coverage on both MediaService and CdmService. This CL enables "media_service_unitests" in "chromium_gtests" so we run the test on more bots. More test cases will come later. Bug: 826039 Test: This CL enables the test on more bots. Change-Id: I4ef9508f47386dfb61a0fefeba4640657aa1b725 Reviewed-on: https://chromium-review.googlesource.com/994873Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550298}
-
Shenghua Zhang authored
Manage Android SDK binary deps via CIPD logic. Move CIPD dependencies in DEPS. Adding cipd_*.yaml files for SDK packages, which are used to create and upload the CIPD packages to service url. Changing config.gni to point the android sdk root to //third_party/android_sdk/public. Split package /sources out to third_party/android_sdk/sources due to different gclient condition. Modify update_sdk.py to 1) Support changing pkg version in DEPS 2) Change --sdk-root default path for sources 3) Fix bugs Bug: 659808 Change-Id: Ia9bafae24a15d8b1c917cf8c0953eb74b8daa0db Reviewed-on: https://chromium-review.googlesource.com/807594Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550297}
-
Adam Parker authored
Local Media Casting will be shipping in 66 so it can be turned on by default in 67. Bug: 721802 Change-Id: Ia8db6abad8a022054e54e9999f798fff9fb0b70b Reviewed-on: https://chromium-review.googlesource.com/1010413 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550296}
-
Maria Khomenko authored
CFIBacktraceAndroidTest.TestFindCFIRow is flaky on Android. TBR=torne@chromium.org Bug: 829555 Change-Id: I7cab963e1cde280cbd47ad51bc7d569055d9dfc9 Reviewed-on: https://chromium-review.googlesource.com/1010825Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550295}
-
Alexis Hetu authored
Loading EGL libraries on MacOS works properly for chromium, but not for running gl_tests. This change makes it work for both cases. Bug: chromium:757974 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I14ad47e1f88270f5a1a1c83bd33c32373f57dc62 Reviewed-on: https://chromium-review.googlesource.com/1010032Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550294}
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' net`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done One include was added to net/cert/multi_threaded_cert_verifier.cc which previously depended on ptr_util.h being included by one of its headers. Bug: 755727 Tbr: kerrnel@chromium.org Change-Id: I61a99097ffab3ad39b77a6506d793c9bde54d8ef Reviewed-on: https://chromium-review.googlesource.com/1010402Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550293}
-
Fabrice de Gans-Riberi authored
This sets is_posix to false for the Fuchsia build as it will rely less and less on the POSIX implementation. Follow-up CLs will clean up build files from redundant checks and stop including _posix files by default. Bug: 812974 Change-Id: I6dc625ba2d4919a775041b1516e051b471c50e97 Reviewed-on: https://chromium-review.googlesource.com/987377 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550292}
-
Xiaohan Wang authored
Remove the logic that strips trailing period in the message text of Android permission dialog. Also add a trailing period in the message text of protected content permission prompt. Also remove a trailing period in the message text of notification permission prompt. Previously it was stripped pragmatically. Now remove it from the text to keep the same UX. See screenshot: https://photos.app.goo.gl/UKNWdos0ZmIPPuEE2 TBR=srahim@chromium.org Bug: 831881 Test: Manually checked the result Change-Id: I69ba2992214c438761262f51634c9b0c0d88c58e Reviewed-on: https://chromium-review.googlesource.com/1008995 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#550291}
-
Tibor Goldschwendt authored
Change-Id: If7daab69e1eaabbcde38ae4151b5a3839ee25472 Reviewed-on: https://chromium-review.googlesource.com/1006165Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#550290}
-
Dmitry Skiba authored
Right now low end Android devices use "low" demuxer limits, the same limits used by Chromecast. Turned out that even with low limits Chrome is still dangeoursly close to being killed by Android. Plus, we don't need to care about playing 1080p on 512MiB Go devices (consideration used by Chromecast to select low values). Bug: 831356 Change-Id: I8161f133ae71881ea29108ffa8b5a5175a841e8c Reviewed-on: https://chromium-review.googlesource.com/1006071 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550289}
-
Mohsen Izadi authored
This CL changes --pull-to-refresh flag to have 4 possible values: - "Default": Currently the same as Disabled; - "Disabled": No PTR; - "Enabled": PTR enabled for both touchpad and touchscreen; - "Enabled for touchscreen only": PTR enabled only for touchscreen. BUG=702404 TEST=OverscrollControllerTest.PullToRefresh* in content_unittest Change-Id: I18e1e39f967e1041f56f25b49e42b9a6dfc934fa Reviewed-on: https://chromium-review.googlesource.com/998549Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550288}
-
Lukasz Anforowicz authored
This CL adds a feature for always keeping a separate RenderProcessHost for the most recently used BrowserContext. The feature is enabled by default, but only consulted in presence of site-per-process. Having a spare renderer should hopefully avoid regressing page load metrics in cross-site navigations (which before this CL needed to wait in site-per-process mode until a new process was spawned). After this CL, MaybeTakeSpareRenderProcessHost won't discard a mismatched spare when in site-per-process mode (unless over the process limit). SpareRenderProcessHostManager::PrepareForFutureRequests method has also been added - this method is responsible for warming-up another spare in site-per-process mode. PrepareForFutureRequests is called when: 1. The previous spare was taken (in RenderProcessHostImpl::GetProcessHostForSiteInstance) Note: A new spare is not warmed-up when the previous spare was mismatched and not taken to avoid spawning two processes at the same time. 2. A navigation redirects into a SiteInstance that needs a new process (in NavigationRequest::OnRequestRedirected) 3. A navigation is ready to commit (this handles postponing spawning of the spare in the scenario handled in the note of scenario #1 above; this happens in NavigationRequest::CommitNavigation) 4. A same-site navigation happens (this retains the behavior from before the CL that allows discarding of the spare in this scenario; this happens in RenderFrameHostManager::GetSiteInstanceForNavigation) This CL also ensures that the spare is considered (and potentially discarded) before considering process reuse because of the process limit. The change of the order of operations helps avoid process reuse in some scenarios. Remaining changes in this CL update various tests, so they can properly account for the extra spare renderer. Bug: 808114 Change-Id: Ica0226c2dc390102789b2c33f6b538c3e27eea82 Tbr: sky@chromium.org, sadrul@chromium.org, pavely@chromium.org Reviewed-on: https://chromium-review.googlesource.com/963405 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#550287}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1119ce6..9151a3c BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I323cce0bf44d984042701ac306017628368217b9 Reviewed-on: https://chromium-review.googlesource.com/1007005Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550286}
-
John Chen authored
To click on an element that is currently off the screen, ChromeDriver first scrolls the element into view. The scrolling can cause some event handler to move the target element, resulting in ChromeDriver attempting to click at the wrong location. When this happens, try again to get the updated target location. Bug: chromedriver:2142 Change-Id: Id0b48d8a9eb5632e884212a48d7f3b3f1cd90ebc Reviewed-on: https://chromium-review.googlesource.com/1008523Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550285}
-
Alex Moshchuk authored
Previously, we sent the IPC to forward a cross-process postMessage immediately. This caused a behavioral difference from the same-process case where the postMessage is always scheduled. Namely, in a scenario like this: frame.postMessage(...); doSomethingThatSendsIPCsToFrame(frame); the IPCs from JS following the postMessage would've been ordered incorrectly, causing |frame| to see their side effects after the postMessage dispatch in the cross-process case, whereas they would be seen before the postMessage dispatch in the same-process case. One example of this is frame.focus(), and another is a frame element onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after a postMessage dispatched from an inline script while the frame was still loading. To resolve these ordering concerns, this CL changes cross-process postMessage to do a PostTask on the sender side before sending the message to the browser process. This improves the current state of the world, but does not yet achieve a perfect match for the IPC ordering in the same-process case - see discussion on the bug. Bug: 828529 Change-Id: I1138bcdcd18c458a92dec92e145761b226596c7a Reviewed-on: https://chromium-review.googlesource.com/999182Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Expand a mime type sniffing test to include testing a newly-minted crx. This ensures that we always recognize the modern crx packaging as the extensions mime type. Bug: 831284 Change-Id: I4622b9eb0911c76a59cf0c25068f8e9dffd97977 Reviewed-on: https://chromium-review.googlesource.com/1005843Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Becca Hughes authored
Update the transition CSS for the panel to hide and show based on the new timings and curves. Also removes the timer from the panel and replaces it with a transitionend event listener. BUG=780051 Change-Id: Idf6204b4a021b19f3530dc33a1dbe34193e2837e Reviewed-on: https://chromium-review.googlesource.com/1006034 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#550282}
-
wutao authored
Currently Shortcuts window can only be closed by mouse click. This cl adds CTRL+W accelerator to close the window. Bug: 819815 Test: KeyboardShortcutViewTest.CloseWindowByAccelerator Change-Id: Icfa340e5c947f823ea62e25df06536f216563ec7 Reviewed-on: https://chromium-review.googlesource.com/1006115 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#550281}
-
Jian Li authored
Additional extra headers should be retrieved right before passing it to launch the URL for the intent. This fixes the issue that the logic to transform the url for trusted MHTML file gets bypassed if the additional extra headers are obtained before that. Bug: 830637 Change-Id: I3ee1fd87a6d179a81c67ae3031cfd020c8b8b523 Reviewed-on: https://chromium-review.googlesource.com/1009000Reviewed-by:
-
Maria Khomenko authored
SitePerProcessBrowserTest.ScrollFocusedEditableElementIntoView is flaky across many Android bots. TBR=kenrb@chromium.org Bug: 793616 Change-Id: If0f61953ee4dadcf0066f6fdb5ba75929bae10c2 Reviewed-on: https://chromium-review.googlesource.com/1010763 Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550279}
-
Mitsuru Oshima authored
This will be used for ARC++ windows. This a) is always placed at the topof the display and covered full width. b) supports immersive mode c) is resized when the display metrics changes. BUG=b/33693796 TEST=covered by unittest Change-Id: I27c8e9d27b673b5f85ff6992380c8ea707d3ea55 Reviewed-on: https://chromium-review.googlesource.com/990203Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550278}
-
Sarah Hu authored
This CL includes the following: 1. Create an expanded public session view which wraps a LoginUserView , a submit button to enter the public session and two drop down menus for user to select language and keyboard settings. The views for the menus will be in a follow-up CL. 2. When the expanded view is shown, other views like big user view, user list and top header view will be hidden in the login screen. The expanded view will be dismissed by escape key or click outside its bounds. Bug: 809635 Change-Id: Iac0a842a98e6eacd15bf9e91756e512f0d5dd364 Reviewed-on: https://chromium-review.googlesource.com/977230 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#550277}
-
