GitLab

Review URL: https://codereview.chromium.org/890043002

Cr-Commit-Position: refs/heads/master@{#313985}

BUG=451321

Review URL: https://codereview.chromium.org/880613005

Cr-Commit-Position: refs/heads/master@{#313984}

SetDisplayPower() is called by powerd to turn the panel on. After that
powerd will set the backlight level. Since DisplayConfigurator may be
executing the SetDisplayPower() operation asynchronously, the panel
may still be off when powerd tries to set the backlight level. So
powerd's operation would be ignored by the driver.

BUG=chrome-os-partner:35662

Review URL: https://codereview.chromium.org/886103002

Cr-Commit-Position: refs/heads/master@{#313983}

This is also adding some logic about empty and invalid
ServiceWorkerClientInfo.

BUG=450634

Review URL: https://codereview.chromium.org/871013003

Cr-Commit-Position: refs/heads/master@{#313982}

This creates a new thread for polling evdev on, and moves the
InputDeviceFactoryEvdev object onto that thread. We'll use this new
thread to avoid UI-thread jank affecting the cursor.

BUG=449710
TEST=boot link_freon & move cursor with simulated UI jank.
     cursor moves while UI thread is stalled.

Review URL: https://codereview.chromium.org/873833002

Cr-Commit-Position: refs/heads/master@{#313981}

This instance will be created by the DataReductionProxySettings class,
and take ownership of the DataReductionProxyParams (currently owned by
DataReductionProxySettings).

BUG=452773

Review URL: https://codereview.chromium.org/880963006

Cr-Commit-Position: refs/heads/master@{#313980}

Cr-Commit-Position: refs/heads/master@{#313979}

BUG=426897
R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/800013002

Cr-Commit-Position: refs/heads/master@{#313978}

This change prepares the client to deal with implicit permanent folders
in Sync server updates. That includes the following:
- Expect type root folders to not come from the server on the initial
  sync. The client auto-creates type root folders for all types except
  Bookmarks and Nigori when progress marker changes from empty to
  non-empty. These folders are created as local nodes (with client IDs)
  that aren't expected to sync back to the server.
- Expect empty parent IDs in updates for both new and existing items.
- Because the client code updates first, the client must expect server
  to override locally created type root folders. To enable that the
  directory update code that matches update entities to local entities
  was updated to look at server unique tags in addition to client
  unique tags. Later when the server stops generating folders we
  should be able to remove that code.
- Added some extra special cases in Directory::CheckTreeInvariants to
  deal with client side created type root folders.
- Added / modified a few tests to cover cases with implicit parent IDs
  in updates.

BUG=438313

Review URL: https://codereview.chromium.org/867793003

Cr-Commit-Position: refs/heads/master@{#313977}

Apparently nobody has tried to run them locally in months.

BUG=452130
TBR=eroman@chromium.org

Review URL: https://codereview.chromium.org/876633004

Cr-Commit-Position: refs/heads/master@{#313976}

Also fix up some padding so the demo looks better

BUG=451654

Review URL: https://codereview.chromium.org/873313011

Cr-Commit-Position: refs/heads/master@{#313975}

Revert of Mark AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen as flaky. (patchset #1 id:1 of https://codereview.chromium.org/893533006/)

Reason for revert:
Root cause reverted (https://codereview.chromium.org/888903002/) so enabling test again.

Not skipping cq

Original issue's description:
> Mark AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen as flaky.
>
> TBR=torne
> NOTRY=true
> BUG=453857
>
> Committed: https://crrev.com/4be6e487bb78f3294657c9aca8ab13aaf641c2fa
> Cr-Commit-Position: refs/heads/master@{#313946}

TBR=torne@chromium.org,igsolla@chromium.org,tedchoc@chromium.org
BUG=453857

Review URL: https://codereview.chromium.org/890003003

Cr-Commit-Position: refs/heads/master@{#313974}

Refactor AutofillProfileEditor to use cpp third_party/libaddressinput
and custom Java UI (rather than libaddressinput's Java AddressWidget).
Add FloatLabelLayout.java and change autofill profile and credit card forms
to use floating labels.

BUG=414438

Review URL: https://codereview.chromium.org/872023002

Cr-Commit-Position: refs/heads/master@{#313973}

Previously, task nodes were all fed the same priority. While certain
heap implementations ensured a consistent prioritization given the same
task priority and input ordering, this is not guaranteed by the spec.
In particular, Android's libc++ implementation appears to differ in this
respect, resulting in tasks from different sets being processed in an
order different from node creation order.

Avoid this by including the task set type in the node priority. All
conforming heap implementations should now yield the same ordering
with respect to task set type.

BUG=427718

Review URL: https://codereview.chromium.org/875573006

Cr-Commit-Position: refs/heads/master@{#313972}

Driveby lint while working on https://crrev.com/665083009.

* Remove redundant net:: namespace qualifiers.
* Remove one redundant line.
* Change probability literals from int to float.
* Fix typos in comments.
* Add https to one link in a comment.
* git cl format to fix one indent and to reduce number of lines.

BUG=392575

Review URL: https://codereview.chromium.org/882973006

Cr-Commit-Position: refs/heads/master@{#313971}

net: add a batch of submitted HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#313970}

so that it only fires when a cookie was actually sent.

Review URL: https://codereview.chromium.org/890953002

Cr-Commit-Position: refs/heads/master@{#313969}

BUG=453200
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/886873003

Cr-Commit-Position: refs/heads/master@{#313968}

Previously It2Me host was shutting down before letting all shutdown
tasks finish, which would often cause crashes.
Now NativeMessagingPipe is responsible for host and channel deletion
and the task runner for the main thread doesn't stop until the host
is destroyed.

BUG=453016

Review URL: https://codereview.chromium.org/887853002

Cr-Commit-Position: refs/heads/master@{#313967}

In document mode, we used to start loading the web contents of a newly
opened tab before the chrome tab object is ready. This would result in
chrome intercept delegate not being initialized in time to figure out
whether the loaded URL needs to be sent as an intent instead.

This changes the order of operations to create the chrome tab first with
the given web contents and only then initiate the load.

BUG=432562

Review URL: https://codereview.chromium.org/883153002

Cr-Commit-Position: refs/heads/master@{#313966}

Revert of Add build targets for Opus tests. (patchset #5 id:80001 of https://codereview.chromium.org/890473002/)

Reason for revert:
Broke Mac GN (dbg) bot.

[169/1394] STAMP obj/third_party/cacheinvalidation/cacheinvalidation_unittests.inputdeps.stamp
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/opus/src/tests/test_opus_decode.test_opus_decode.o.d -DCHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_OPENSSL=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DCR_CLANG_REVISION=223108 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -I../../third_party/opus/src/celt -I../../third_party/opus/src/silk -I../../third_party/opus/src/include -fno-strict-aliasing -fstack-protector-all -arch x86_64 -fcolor-diagnostics -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wnewline-eof -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -Wno-inconsistent-missing-override -fvisibility=hidden -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O0 -g2 -Wno-absolute-value -std=c99 -c ../../third_party/opus/src/tests/test_opus_decode.c -o obj/third_party/opus/src/tests/test_opus_decode.test_opus_decode.o
../../third_party/opus/src/tests/test_opus_decode.c:138:64: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
         out_samples = opus_decode(dec[t], packet, 0, 0, 0, fec);
                                                      ~        ^
1 error generated.
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/3538

Original issue's description:
> Add build targets for Opus tests.
>
> test_opus_api, test_opus_encode, test_opus_decode, and test_opus_padding
> can be run directly, with no command-line options, and they print out
> "OK" during the test and an overall status message such as
> "All API tests passed." or "Tests completed successfully." at the end.
>
> The celt component has several unit tests. I didn't add build targets
> for them because some of them don't print any output, so you'd need a
> test harness script to examine their exit status.
>
> R=henrika@chromium.org,sergeyu@chromium.org
> BUG=452984
>
> Committed: https://crrev.com/bfcc6156a8f2107ecd70445b08e60299737caffa
> Cr-Commit-Position: refs/heads/master@{#313964}

TBR=henrika@chromium.org,sergeyu@chromium.org,brettw@chromium.org,wtc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=452984

Review URL: https://codereview.chromium.org/888963002

Cr-Commit-Position: refs/heads/master@{#313965}

test_opus_api, test_opus_encode, test_opus_decode, and test_opus_padding
can be run directly, with no command-line options, and they print out
"OK" during the test and an overall status message such as
"All API tests passed." or "Tests completed successfully." at the end.

The celt component has several unit tests. I didn't add build targets
for them because some of them don't print any output, so you'd need a
test harness script to examine their exit status.

R=henrika@chromium.org,sergeyu@chromium.org
BUG=452984

Review URL: https://codereview.chromium.org/890473002

Cr-Commit-Position: refs/heads/master@{#313964}

Revert of [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var (patchset #5 id:80001 of https://codereview.chromium.org/737653003/)

Reason for revert:
Broke compile on Google Chrome ChromeOS bot.

[8069/19495] CXX obj/components/policy/core/common/cloud/policy_component_common.external_policy_data_updater.o
FAILED: cd ../../third_party/liblouis; python ../../native_client_sdk/src/tools/create_nmf.py ../../out/Release/chromevox_test_data/braille/liblouis_nacl_x86_64.nexe "--output=../../out/Release/chromevox_test_data/braille/liblouis_nacl.nmf"
Traceback (most recent call last):
  File "../../native_client_sdk/src/tools/create_nmf.py", line 680, in <module>
    rtn = main(sys.argv[1:])
  File "../../native_client_sdk/src/tools/create_nmf.py", line 633, in main
    options.lib_path += GetDefaultLibPath(config)
  File "../../native_client_sdk/src/tools/create_nmf.py", line 507, in GetDefaultLibPath
    sdk_root = GetSDKRoot()
  File "../../native_client_sdk/src/tools/create_nmf.py", line 478, in GetSDKRoot
    assert(os.path.exists(os.path.join(sdk_root, 'toolchain')))
AssertionError
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/76569

Original issue's description:
> [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var
>
> create_nmf should determine the root of the SDK relative
> to its own location.
>
> The exception to this is when its run as part of the
> chrome build, when it is not yet installed.  In this
> case we pass --no-default-libpath and --objdump to
> create_nmf to remove any use of the SDK root.
>
> Committed: https://crrev.com/088561ac99314a79866a39f79bb32bd5e1196217
> Cr-Commit-Position: refs/heads/master@{#313957}

TBR=binji@chromium.org,dmichael@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/890033003

Cr-Commit-Position: refs/heads/master@{#313963}

Now Chrome start using ChannelMojo. The ipc_fuzzer has to
follow the move.

R=tsepez@chromium.org, inferno@chromium.org
BUG=453571

Review URL: https://codereview.chromium.org/875513007

Cr-Commit-Position: refs/heads/master@{#313962}

BUG=453875
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/868203004

Cr-Commit-Position: refs/heads/master@{#313961}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2d45b1e..f76ca40

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/892683002

Cr-Commit-Position: refs/heads/master@{#313960}

Cr-Commit-Position: refs/heads/master@{#313959}

WebRTC 8214:8220
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/29882bb..cfe4b49

Libjingle 8213:8221
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d0c206c..18f533d

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/893583004

Cr-Commit-Position: refs/heads/master@{#313958}

create_nmf should determine the root of the SDK relative
to its own location.

The exception to this is when its run as part of the
chrome build, when it is not yet installed.  In this
case we pass --no-default-libpath and --objdump to
create_nmf to remove any use of the SDK root.

Review URL: https://codereview.chromium.org/737653003

Cr-Commit-Position: refs/heads/master@{#313957}

Adding a UMA to keep track of the number of times RequestMediaKeyAccess
is called with a particular key system, and the number of times the
request succeeds. The counts are only incremented once per renderer
frame.

BUG=351501
TEST=existing EME tests pass, verified UMA locally

Review URL: https://codereview.chromium.org/881853002

Cr-Commit-Position: refs/heads/master@{#313956}

Was causing a bug where identities were slightly different.

BUG=453792

Review URL: https://codereview.chromium.org/864223006

Cr-Commit-Position: refs/heads/master@{#313955}

BUG=453126
R=rch@chromium.org

Review URL: https://codereview.chromium.org/885233002

Cr-Commit-Position: refs/heads/master@{#313954}

Revert of IPC Fuzzer: Make ChannelMojo work when --enable-channel-mojo is givne (patchset #1 id:1 of https://codereview.chromium.org/885143002/)

Reason for revert:
The flag was wrong. It needs finer configuration.

Original issue's description:
> IPC Fuzzer: Make ChannelMojo work when --enable-channel-mojo is given
>
> This adds an option to enable ChannelMojo on ipc_fuzzer.
>
> R=inferno@chormium.org, mbarbella@chromium.org
> BUG=453571
>
> Committed: https://crrev.com/9b1b6da70aab6c78bbecb5f86081ec5abc101f86
> Cr-Commit-Position: refs/heads/master@{#313840}

TBR=inferno@chormium.org,tsepez@chromium.org,mbarbella@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453571

Review URL: https://codereview.chromium.org/893603004

Cr-Commit-Position: refs/heads/master@{#313953}

Following up on https://codereview.chromium.org/825773003/#msg26, this CL adds weak_erase() calls at some places, to speed-up deletion of ScopedVectors, which are arguably only containing null or dangling pointers.

The benchmark from https://codereview.chromium.org/825773003/#msg24 showed on Mac, unlike on Linux, that weak_erase() + destruction takes (not surprisingly) constant time, whereas ommitting the weak_erase() is linear in the size of the vector.

The CL adds the weak_erase in a slightly complicated way. Instead of just adding the weak_erase() calls, it creates a dedicated method for doing the operation of passing all owned objects out of a scoped vector, to ensure that future changes in the code don't easily add leaks through the weak_ptr.

BUG=451018

Review URL: https://codereview.chromium.org/885033002

Cr-Commit-Position: refs/heads/master@{#313952}

This changes adds four histograms to UMA. Profile.NumberofSwitches
collects the number of profile switches happening over a session.

The others are:

- Profile.ProfileSwitch.ToOpenedProfile counts the number of switches to
  opened profiles and buckets depending on the UI flow used to switch.
- Profile.ProfileSwitch.ToUnopenedProfile does the same but for switches
  to unopened profiles
- Profile.ProfileSwitch aggregates the data from the previous two

BUG=448982

Review URL: https://codereview.chromium.org/844193005

Cr-Commit-Position: refs/heads/master@{#313951}

Revert of Flip flag to turn CrOS Browser Compositor Single Threaded (patchset #5 id:80001 of https://codereview.chromium.org/781163003/)

Reason for revert:
Possible cause for veyron: Chrome crash in SW Mirror mode (at login screen)

https://code.google.com/p/chromium/issues/detail?id=453732

Original issue's description:
> Flip flag to turn CrOS Browser Compositor Single Threaded
>
> Simply stop using threaded browser compositor for CrOS. Clean up would
> be in follow up patch.
>
> R=danakj@chromium.org, piman@chromium.org
> BUG=329552
>
> Committed: https://crrev.com/e111a7d64d9ba12833900ab743beaf4ee6d267ed
> Cr-Commit-Position: refs/heads/master@{#313842}

TBR=danakj@chromium.org,piman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=329552

Review URL: https://codereview.chromium.org/893623002

Cr-Commit-Position: refs/heads/master@{#313950}

 ultrasound32 and audible32
BUG=449864

Review URL: https://codereview.chromium.org/874163002

Cr-Commit-Position: refs/heads/master@{#313949}

Revert of Move AW renderer compositor context to gpu thread (patchset #6 id:100001 of https://codereview.chromium.org/769703005/)

Reason for revert:
Suspect causing AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen to time out

Original issue's description:
> Move AW renderer compositor context to gpu thread
>
> Use TexSubImage2D instead of TexImage2D to avoid orphaning
> EGLImage
> Create the renderer compositor context on the gpu thread.
>
> BUG=448168, 259924
>
> Committed: https://crrev.com/a4baed454be2bb165cb12eb7df432e9138e746e6
> Cr-Commit-Position: refs/heads/master@{#313846}

TBR=epenner@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448168, 259924

Review URL: https://codereview.chromium.org/888903002

Cr-Commit-Position: refs/heads/master@{#313948}

Review URL: https://codereview.chromium.org/879783004

Cr-Commit-Position: refs/heads/master@{#313947}

TBR=torne
NOTRY=true
BUG=453857

Review URL: https://codereview.chromium.org/893533006

Cr-Commit-Position: refs/heads/master@{#313946}