- 26 Oct, 2018 35 commits
-
-
Dominick Ng authored
On Android, Chrome is responsible for handling external protocols and determining if an external activity should be launched. When an installed WebAPK opens a Chrome Custom Tab for an out of scope link, the external protocol handling code was not being triggered for links like mailto: and tel:, resulting in a broken CCT launch to the mailto: link containing a blank page. This issue was caused by two reasons: 1. The navigation type for the Custom Tab intent was set to PageTransition.FROM_API, indicating it came from an external intent. This would trigger a code path that explicitly avoided launching an external program. 2. Once (1) was addressed, the lack of a user gesture on the resulting navigation created by the intent also blocked external program launch. This CL fixes both issues by introducing a new Custom Tab extra indicating whether a Custom Tab intent came from a WebAPK. When this extra is present, we do not set the FROM_API transition type, and we add a user gesture on the resulting new tab navigation. This essentially passes on the user gesture that must have been present to create the new tab in the first place, mimicking the behaviour that should be present when not in a standalone window. BUG=792990 Change-Id: Ifad590228b10fa7a09c1c34611124957ba857ac1 Reviewed-on: https://chromium-review.googlesource.com/c/1270204Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#602970}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71f5a0b56d38..5281f369f4f0 git log 71f5a0b56d38..5281f369f4f0 --date=short --no-merges --format='%ad %ae %s' 2018-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1f3ef0d6d533..5978150ed763 (1 commits) 2018-10-25 herb@google.com Move perX closures into loops Created with: gclient setdep -r src/third_party/skia@5281f369f4f0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: Id61602555707b308cfbd568a40d6f496ffad0820 Reviewed-on: https://chromium-review.googlesource.com/c/1300575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602969}
-
Brian White authored
Previously, these metrics were loaded on the UI thread which, because they are in a memory-mapped file, can cause blocking I/O and cause jank. Bug: 882892 Change-Id: I23b1808b5233b5bd05a1dbe5e96ace32c73ef46b Reviewed-on: https://chromium-review.googlesource.com/c/1292271 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#602968}
-
Xinghua Cao authored
BUG=867675 TEST=conformance2/extensions/ext-disjoint-timer-query-webgl2.html Change-Id: I138a046e8ac6cb3bee4b34d59b3fa4e7b0c4231f Reviewed-on: https://chromium-review.googlesource.com/c/1298757Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Cr-Commit-Position: refs/heads/master@{#602967}
-
Luciano Pacheco authored
Command used: $ lebab --replace \ ui/file_manager/file_manager/foreground/js/ui/directory_tree.js \ --transform arrow Lebab: https://github.com/lebab/lebab No change in behaviour. Bug: 778674 Change-Id: Ie67f01d023c1c762c5e7b4fdba9c7df5b0debb89 Reviewed-on: https://chromium-review.googlesource.com/c/1298526Reviewed-by:Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#602966}
-
Trent Apted authored
Currently media keys break in tablet mode, but a 'space' keypress in the same mode works fine. Media keys are in a separate handler that probably lost its plumbing when shadow dom was introduced in r592709. Merge the two key handlers into the one that works, and add a test for 'MediaPlayPause'. Adds a mapping for '[' and ']' to control tracks since its easier to test and there's no prior mapping. (Cmd+Shift+][ are next/previous tab in Chrome Mac). Bug: 899094 Change-Id: Ie57b9b0d497b1996566ea3a1842309f0191d8bff Reviewed-on: https://chromium-review.googlesource.com/c/1298820Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#602965}
-
James Cook authored
select_to_speak_extension_tests compiles and links all of chrome, so folding into browser_tests will save work on the bots. It will also give coverage for SingleProcessMash and other projects that run browser_tests with optional flags. Bug: 892179 Change-Id: I8dfce56a8b522194dfbb0d24de7cb8f5cdd45b01 Reviewed-on: https://chromium-review.googlesource.com/c/1300073Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#602964}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/9a07219dc8fb..b36c86fdfe74 $ git log 9a07219dc..b36c86fdf --date=short --no-merges --format='%ad %ae %s' 2018-10-25 fbarchard Port box filter to NEON 2018-10-24 fbarchard disable ARGBToRAWRow_AVX2 and ARGBToRGB24Row_AVX2 2018-10-24 fbarchard MJPGToNV21 2018-10-10 oprypin Autoroller: pull more updates from WebRTC's copy of the script 2018-10-10 fbarchard NV21ToRAW and NV12ToRAW functions added 2018-10-07 fbarchard clang tidy mismatch in J420ToRGB565 2018-10-05 oprypin Autoroller: pull some updates from WebRTC's copy of the script 2018-10-03 fbarchard Fix ConvertToI420() for odd crop_y Created with: roll-dep src/third_party/libyuv Bug: libyuv:820, libyuv:778, b:117522975, b:118443054, b:118386049, b:115278653 Change-Id: Ie18374507acb27d82ee123b8d2113fd65daac49f Reviewed-on: https://chromium-review.googlesource.com/c/1299839Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#602963}
-
Xing Liu authored
This reverts commit b859fdbb. Reason for revert: <INSERT REASONING HERE> Original change's description: > Download home v2: Increase thumbnail cache size. > > On Android we use an in-memory thumbnail cache to improve view recycling > performance and use a disk cache to avoid costly backend operations like > decoding images, videos etc. > > For download home v2, the thumbnail size is much larger than the old > download home, thus we need to tweak the size of cache. 90% percentile > of users have around 15 media thumbnails. The size of bitmap varies from > under 1MB to around 5MB. The disk cache uses PNG to compress, the > compression rate is around 1/3. > > This CL does the following: > > 1. The size of the thumbnail for high dpi devices are scaled down to > mdpi, which can save memory/disk. > > 2. For in-memory cache size, download home v2 uses 15MB for high end > devices. In-memory cache size is now passed in from owner of > ThumbnailProviderImpl. > > 3. Disk cache size is increased. This should be shared by multiple > owners of ThumbnailProviderImpl, or the owner with smaller disk cache > size may remove files unexpectedly used by other owners. > > Bug: 87292 > Change-Id: If7cb700a60a8d119bca136b1a7d1fe7feb787d8b > Reviewed-on: https://chromium-review.googlesource.com/c/1296546 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602957} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org Change-Id: I1c63b7c1d6aa4af322080f4d27cd84b1ccc244bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 87292 Reviewed-on: https://chromium-review.googlesource.com/c/1300795Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602962}
-
Chris Blume authored
The Vulkan validation layer used to error when a platform-specific surface (in this case, a X11 surface) was used. A build flag which enables the validation layer to recognize that platform-specific surface was missing. When the Vulkan validation layers moved to ANGLE they also added this build flag. As a result, we can re-enable the validation layers on X11. BUG=843346 Change-Id: Ifb634a60a1cd9698b5cf51e03b426a58b4387a5d Reviewed-on: https://chromium-review.googlesource.com/c/1300335Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#602961}
-
Steven Bennetts authored
This is in preparation for deprecating ChromeKeyboardUI when the WS is running, at which point GetVirtuallKeyboardUrl will also be called from ChromeKeyboardControllerClient directly. Bug: 843332 Change-Id: If82b9e6c166888b76176e6990397a77b6213be6c Reviewed-on: https://chromium-review.googlesource.com/c/1297276 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#602960}
-
Min Qin authored
This class is deprecated, removing it BUG=765327 Change-Id: Icb4b8e6fa48da20324517dc3ddadd521b88d3145 Reviewed-on: https://chromium-review.googlesource.com/c/1299922Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602959}
-
Becca Hughes authored
Client using MediaController should be able to add MediaSessionObserver's to observe the active media session state. The primary user here is the media notification which needs to be notified of state and metadata updates through media controller. BUG=892771 Change-Id: I7aa343207d3eb2ffa713eb41272646c10e9e6784 Reviewed-on: https://chromium-review.googlesource.com/c/1298477 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#602958}
-
Xing Liu authored
On Android we use an in-memory thumbnail cache to improve view recycling performance and use a disk cache to avoid costly backend operations like decoding images, videos etc. For download home v2, the thumbnail size is much larger than the old download home, thus we need to tweak the size of cache. 90% percentile of users have around 15 media thumbnails. The size of bitmap varies from under 1MB to around 5MB. The disk cache uses PNG to compress, the compression rate is around 1/3. This CL does the following: 1. The size of the thumbnail for high dpi devices are scaled down to mdpi, which can save memory/disk. 2. For in-memory cache size, download home v2 uses 15MB for high end devices. In-memory cache size is now passed in from owner of ThumbnailProviderImpl. 3. Disk cache size is increased. This should be shared by multiple owners of ThumbnailProviderImpl, or the owner with smaller disk cache size may remove files unexpectedly used by other owners. Bug: 87292 Change-Id: If7cb700a60a8d119bca136b1a7d1fe7feb787d8b Reviewed-on: https://chromium-review.googlesource.com/c/1296546 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
wutao authored
This patch removes the old keyboard overlay, which is replaced by keyboard shortcut viewer. Bug: 894219 Test: passed unittest. Change-Id: I51317d723760f0c7ca2722a9bbfc619eb1106312 Reviewed-on: https://chromium-review.googlesource.com/c/1276892 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#602956}
-
Xu Xing authored
The only case to use current surface is CopyDrawnRenderPass. No matter overdraw or not, this should copy from the current surface. Bug:889122 Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9ff3cb901a7060a3324659d65b354020a26ba27b Reviewed-on: https://chromium-review.googlesource.com/c/1286195Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#602955}
-
Xianzhu Wang authored
It's not used in our system. Bug: 703899 Change-Id: I13605ab3f22eb578d0c834d8b78fa908ed4e1644 Reviewed-on: https://chromium-review.googlesource.com/c/1297987Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602954}
-
Joel Hockey authored
Bug: 878324 Change-Id: I50a96135175f6f16f0a33b0c95cc802f1108123c Reviewed-on: https://chromium-review.googlesource.com/c/1298815Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#602953}
-
Theresa authored
BUG=884743 Change-Id: I5308c8f1496e39abc7d492fa0aa7e0be21c5d0b4 Reviewed-on: https://chromium-review.googlesource.com/c/1298244 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#602952}
-
Weidong Guo authored
Changes: Make sure to stock tracking when a window with modal dialog is shown in HomeLauncherGestureHandler::OnPressEvent(). Bug: 897894 Change-Id: I73267f5f71b6cdab909183d30318dd6166a75e1e Reviewed-on: https://chromium-review.googlesource.com/c/1300215 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602951}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after M71. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I541a6cba2d620d8a96f92ac3d95a96de54dd63dc Reviewed-on: https://chromium-review.googlesource.com/c/1126200 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#602950}
-
Dale Curtis authored
Each decoder implements its own desired count along with boilerplate clamping based on --video-threads, the logical processor count, and different min/max thread values. Lets unify them all into one place. This makes the following changes: - AOM decoder would allow < 2 threads at very small resolutions; this is no longer allowed. - FFMPEG decoder decided to reduce the core usage by two arbitrarily; this is no longer done. - Restrictions are no longer applied to --video-threads, it can be any value > 0. There's now a VideoDecoder::GetRecommendedThreadCount() method which takes in a desired count and returns the recommendation. BUG=none TEST=everything still passes. Change-Id: If91014467791b2aecc9b286b50507410bbda4ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1300413Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602949}
-
Jesse McKenna authored
I am currently working on a change to TaskScheduler that will use IntrusiveHeap. This change is a no-op that simply moves IntrusiveHeap, previously used only by SequenceManager, into a common directory base/task/common/ for use by both SequenceManager and TaskScheduler. Bug: 889029 Change-Id: I70cd900931dbabfd8d292228c87206a66c78a8d0 Reviewed-on: https://chromium-review.googlesource.com/c/1298076 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602948}
-
Ted Choc authored
This moves the logic into the adapter. Sets up the preliminary APIs on the View itself to allow a binder to interact with it, and slowly cleans up a few of the broken dependencies. The uphill battle goes on. BUG=898522 Change-Id: Ib8c8c00049a929af723003ad5533caf356c074f1 Reviewed-on: https://chromium-review.googlesource.com/c/1298171 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#602947}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a9fb482b9859..f74d12074e19 git log a9fb482b9859..f74d12074e19 --date=short --no-merges --format='%ad %ae %s' 2018-10-25 dgarrett@google.com postsubmit: Create a new 'postsubmit' class of builder. Created with: gclient setdep -r src/third_party/chromite@f74d12074e19 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8261754519b5030eb4af75161356739bcbc2d970 Reviewed-on: https://chromium-review.googlesource.com/c/1299982Reviewed-by:
-
tzik authored
This updates all usage of base::Callback in //ct/br/sw to use base::RepeatingCallback or base::OnceCallback. Change-Id: I9c575e416618da370c7c6250bd44cf2f8577f408 Reviewed-on: https://chromium-review.googlesource.com/c/1286232 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#602945}
-
Robert Ogden authored
This Google domain is used to serve a new type of Preview to users but will respond differently depending on the field trial the user is in. The added header will also be used to assert that the user is properly setup to get this preview. Bug: 898992 Change-Id: I40212fdf5ab1fade959d678f0c57f8ade2b9403a Reviewed-on: https://chromium-review.googlesource.com/c/1299915Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#602944}
-
Xi Han authored
This was introduce in https://crrev.com/c/1034133. In the follow up CL, we plan to create the entire ResouceBundle earlier, not just loading the DataPack which contains the service manifests earlier. Bug: 815230 Change-Id: I64b12d5f7d28c5aa51678bd077415ddc8155a0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1294591 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Also use NOT_DRAWN layer for shelf because it has no real content. All child views have its own layers. This also chagnes the opacity to 100% per discussion with sgabriel@ Bug: 899079 Test: manual. No Change-Id: I6ea82784e49e929902a7a7d00fc934d9c8033045 Reviewed-on: https://chromium-review.googlesource.com/c/1300108Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#602942}
-
Sammie Quon authored
Introdue a new overview observer which notifies observers when the start animation for overview is different. Uses will be both in and out of overview - for example adding mask, shadow and animating tray, shelf. Also modify CleanupObserverTest to use some new stuff. Test: ash_unittests StartAnimationObserverTest.Basic Bug: 898222 Change-Id: I86bdd253f0a4a4dd81ad6ba03780baf07923d256 Reviewed-on: https://chromium-review.googlesource.com/c/1297405 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#602941}
-
Carlos IL authored
With committed interstitials, interstitials are no longer a special case of navigation. Adapted interstitial related WebView tests so they are compatible with committed interstitials. Bug: 752372 Change-Id: I5df2d2fa6b96632704828df66af0f61e33dc8d1e Reviewed-on: https://chromium-review.googlesource.com/c/1299929Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#602940}
-
Becky Zhou authored
Bug: 898165 Change-Id: I89612def0f3c67ad04fc937f80f12162dc4662cc Reviewed-on: https://chromium-review.googlesource.com/c/1297174Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602939}
-
Kevin Strohbehn authored
Bug: 898712 Change-Id: I96ba08fec3f7df8547d753ff4d31366345be0ac8 Reviewed-on: https://chromium-review.googlesource.com/c/1298507Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/331ccfd8e4ca..71f5a0b56d38 git log 331ccfd8e4ca..71f5a0b56d38 --date=short --no-merges --format='%ad %ae %s' 2018-10-25 reed@google.com update more gms to use textutils 2018-10-25 kjlubick@google.com [canvaskit] Remove ReadBuffer Created with: gclient setdep -r src/third_party/skia@71f5a0b56d38 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I510ed66a5bd2c81b786f2eb3da85be5ed66c066b Reviewed-on: https://chromium-review.googlesource.com/c/1299979Reviewed-by:
-
Sergey Ulanov authored
SDK now includes async-loop, so we no longer need AsyncDispatcher. Change-Id: I3d06aa6e937d4150d6244e7de965d497a3a62a8c Reviewed-on: https://chromium-review.googlesource.com/c/1298192 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
- 25 Oct, 2018 5 commits
-
-
David Bokan authored
In https://crrev.com/9f54d240af5d366b1d6a4d9b84438192a9f0a11c we moved ScrollCustomization from using Elements to Node. This allows us to use Nodes in the scrolling code which is much more natural since the viewport scrolls using the LayoutView (document Node)'s scrollable area. The main change in this CL is letting the Document node be part of the scroll chain, instead of using the documentElement in its place. This removes some special-casing all the way through the scrolling pipeline. As a result the Global Root Scroller now sets the viewport scroll callback on the document node. Bug: 897288 Change-Id: I899e6007b676efb94675d94b3d97702c8f1f2a94 Reviewed-on: https://chromium-review.googlesource.com/c/1299205 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#602935}
-
Sara Kato authored
Screen rotation may be triggered using Ctrl + Shift + Reload (F5). The screen will be rotated if the user presses "Continue". UI Strings for ash_strings are still in review. TEST: Manual Bug: 881929 Change-Id: Ie6c067f164b0a0d6f4d68f0d29360d7166937e70 Reviewed-on: https://chromium-review.googlesource.com/c/1272556Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#602934}
-
Jun Mukai authored
When the window is moving across displays, GetBoundsInScreen() may return an incorrect location because it hasn't moved to the new display yet completely. This CL adds a new method to aura::Window to indicate this intermediate status so that ws::ClientRoot can wait slightly on sending the bounds change. ClientRoot still emits the OnWindowBoundsChanged synchronously upon bounds change, but it can wait for the new root window when moving across displays. See crrev.com/c/1284952 for my previous attempt. BUG=892714 TEST=the new test case covers Change-Id: I32fad8cc17c373705e1e27b46b4617784a15a869 Reviewed-on: https://chromium-review.googlesource.com/c/1298087 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Adrienne Walker authored
The jitter benchmark has been removed in issue 717217, and nobody is looking at these metrics. Just cleaning up old code. Bug: 542813,717217 Change-Id: I2d4d806d30ef98873fbf64629ddf5fb883756ca6 Reviewed-on: https://chromium-review.googlesource.com/c/1299925Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602932}
-
Thomas Tangl authored
When there is no spellcheck dictionary, the "Enhanced spellcheck" toggle is hidden. TBR=jochen@chromium.org Bug: 855945 Change-Id: I490abeba215382853462d092937f7e8607c84439 Reviewed-on: https://chromium-review.googlesource.com/c/1297140 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602931}
-
