- 13 Aug, 2019 40 commits
-
-
David Benjamin authored
This CL comes with a behavior change: set_allow_credentials(false) additionally sets LOAD_DO_NOT_SEND_AUTH_DATA. However, this would only matter if the origin server actually used HTTP auth. Bug: 799935 Change-Id: I764586d72b69c1a24d4981a4a5ba1127bf4e91aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752622 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#686556}
-
Dan Sanders authored
Bug: 993311, 985144 Change-Id: I36104029d3fdfafcfee5be53b79a250017e9f86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751910 Auto-Submit: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#686555}
-
Antonio Gomes authored
... when posting tasks. A task posted runs once, so CrossThreadBindRepeating is not strictly correct. This is now possible, after [1]. [1] crrev.com/c/1750043 R=jbroman@chromium.org Change-Id: I3d783e09b91aa4b0fa4274d83600d401873fb45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752075 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686554}
-
Etienne Pierre-doray authored
This CL refactor TaskSource tear down so that Clear() can be called in production by the task tracker and clear sequence in one go. -Uses WillPostTaskNow to drop delayed tasks early. This replaces effective_shutdown_behavior so that a task doesn't need to be popped first before deciding whether it is run. -Fix a logic bug in WorkerThreadDelegate::PostTaskNow. -TaskSource::Clear() now eats a RunIntent and returns a task to run. -The extra parameter to DidProcessTask is replaced by a call to TaskSource::Clear(). Bug: 839091 Change-Id: I331336a84c62a282c5efef1fb8ac84b4fe33e259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719104 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#686553}
-
Tommy Li authored
This reverts commit 0297659d. Reason for revert: Build failures here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI Original change's description: > Stablizing Mac autofill accessibility when popup show/hides > > This is a follow up change of CL:1667787, which introduced > AutofillPopupControllerImpl::FireControlsChangedEvent for autofill > popup accessibility. > > On Mac and potentially other platforms, when accessibility is > enabled, upon invoking autofill popup and FireControlsChangedEvent > we end up dereferencing a nullptr of AxPlatformNode due to > Mac does not have a complete implementation of AxPlatformNode yet. > > This CL fixes the above by adding a check for AxPlatformNode in > FireControlsChangedEvent. > > Changes: > 1. Introduced a check for invalid AxPlatformNode in > AutofillPopupControllerImpl::FireControlsChangedEvent to return > early from firing event. > 2. Added associated unit tests for FireControlsChangedEvent. > 3. Exposed GetWebContentsPopupControllerAxId virtual to > AutofillPopupDelegate.. > > Bug: 986587 > Change-Id: I9a6ed49330a9ea9d7d4e5483c3ee06d5675919ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714297 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686461} TBR=sky@chromium.org,estade@chromium.org,nektar@chromium.org,ftirelo@chromium.org,akihiroota@chromium.org,iapres@microsoft.com,vicfei@microsoft.com Change-Id: I67ef1a599f54569e9cd9a964bc3b1b27f7c27c4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752863Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686552}
-
David Benjamin authored
allow_credentials, removing HTTP authentication data. This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935, https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4, and go/allow-credentials-tracker for the motivation and progress of this change. This CL handles the final third of cases where LOAD_DO_NOT_SEND_COOKIES and LOAD_DO_NOT_SAVE_COOKIES were set, but LOAD_DO_NOT_SEND_AUTH_DATA was not. This CL will set allow_credentials = false instead, which will make two changes to the requests: - The request will no longer participate in HTTP auth if the server requests it. HTTP auth credentials identify the user, so private requests should not send them. Note this only affects server auth, not proxy auth. Unless the server your feature speaks to requests HTTP auth, this is a no-op. - The request will be pooled with sockets used for uncredentialed requests, rather than credentialed requests. This is not expected to meaningfully change behavior. If your code requires HTTP authentication, let me know. You may need to allow credentials for your request. Bug: 799935 Change-Id: I920651ad921c0b042e765b81520ea49955014100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580465 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#686551}
-
Mike Frysinger authored
For people diving into pylint development, add a tip so they don't get lost hacking on this copy thinking it's the one run by presubmit. Bug: 866772 Change-Id: Ib1ba7392d110d95b1ebf5e2a0abd2cd1bcabbb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745817Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686550}
-
Dana Fried authored
Preparation for AnimatingLayoutManager; design: https://docs.google.com/document/d/1fZOg120fswUdaV7tfZh8cXIlcvAL1Gg70GVrsQVXl3g These changes are required in order to add the animating layout manager in c/b/ui/views/layout, alongside interpolating layout manager. The animating layout manager CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1742509 There is very little actual change to InterpolatingLayoutManager - mostly just adding views:: qualifiers since we've moved it out of the views project for now. The ultimate goal is to do a couple of proof-of-concept uses of both interpolating and animating layouts and then migrate the code back to views. Bug: 898632 Change-Id: I6d26fb21b05f1bca317907f15bf825751a1d5943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737744Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#686549}
-
Tommy Li authored
This reverts commit 3d69d15e. Reason for revert: Causing build failures here: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Linux Original change's description: > Force subtree update when visual viewport adds/removes paint property nodes > > This is like what we do for paint properties in the document. > > Bug: 984881 > Change-Id: Ib799e852017642d31de2616a5ebab554cbeb3770 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752502 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686504} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I022da21f3679ab0ecf849439fe117fd6be6189ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752561Reviewed-by:
-
Ethan Jimenez authored
1. There was a bug in `AXPosition::CreateNextLineStartPosition` where we assumed that, after moving past the end of an `AXTree` not finding a next line start, the end of the original anchor would be the same as the end of the entire tree's text representation. This was not true if the last line of the text representation was composed by multiple anchors and the function was called from a leaf text position located at one of such anchors other than the last. Fixing such issue by returning `CreatePositionAtEndOfAnchor` from the last leaf text position of the `AXTree` (rooted at the original position's anchor if the result is its descendant). The same bug was present in `CreatePreviousLineEndPosition`, but in the inverted scenario of the previous line end of the first line. 2. Adding unit test to cover the scenario mentioned above. Bug: 928948 Change-Id: I7c98aa5ae6d881cc884cd2fc8bf517780e82dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747854 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686547}
-
Francois Doray authored
RenderWidgetHostViewAura avoids calling DelegatedFrameHost::WasShown() when it is already shown. RenderWidgetHostViewMac does not have the same protection. This CL adds the protection to allow TabSwitchTimeRecorder to assume that TabWasShown() is not called multiple times in a row without TabWasHidden() being called in between. Bug: 981757 Change-Id: I75549dc0286db99e06356a68ddbb675456285cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749536Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#686546}
-
Ted Meyer authored
Splits event batching and event handling that was present in RenderMediaLog so that a new InspectorMediaLog can share the behavior. InspectorMediaLog converts the events from media::MediaLogEvent into both blink::InspectorPlayerEvent and blink::InspectorPlayerProperty. media::MediaLogEvent will eventually be refactored to look more like the blink side of things, but not until the old media-internals page is deprecated. Adds a flag MediaInspectorLogging which when enabled replaces the RenderMediaLog with InspectorMediaLog, which sends events to the chrome devtools inspector instead of chrome://media-internals. Bug: 794255 Change-Id: I51408ae16954e014a16e495d3b901ef2815daf75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679230 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#686545}
-
Sophie Chang authored
Bug: 969558 Change-Id: Iebeb0e09700f3b4878a6a55507a7ef416f46a9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750092Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686544}
-
Liquan(Max) Gu authored
As we already have LCP-handler since this CL https://chromium-review.googlesource.com/c/chromium/src/+/1500254, the main-frame-LCP can benefit from it by reusing the LCP-handler's functions. Bug: 940587 Change-Id: I24d2fbb6d11a50c114d767c4c87c048aaea4c167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517162Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686543}
-
Peter E Conn authored
Bug: 937871 Change-Id: I95efef32433b0daab3b62d55f427e8b883d3917b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751731 Auto-Submit: Peter Conn <peconn@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686542}
-
Roger Tawa authored
Bug: 993468 Change-Id: I4e0ac084f44853d4e566d288c4807873cc398c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752081Reviewed-by:
-
zhaoyangli authored
Organized source_set in page_info BUILD.gn file to make app target not pulled by EG2 test target. In page_info_egtest.mm, made rotateDeviceToOrientation call different under EG1 and EG2 to deal with the minor change in API. Added this test target to EG2 test module in earl_grey2 Build.gn. Bug: 987646 Change-Id: I65bab0b418d9aa491b7d5e65f72decb19e4bd8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750195Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686540}
-
Andrew Grieve authored
Since we enabled r8, this variable is ignored. Stop setting it. Bug: 908988 Change-Id: I0aa9e3e0a0a6133be81916bf36126bed86aab116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752292 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686539}
-
Pavol Marko authored
Allow ONC policy to specify a Scope for policy-provided certificates. Currently, all consumers only use certificates with profile-wide scope (no Scope specified in ONC). Using extension-scoped certificates will be done in a follow-up CL. Bug: 939344 Test: chromeos_unittests --gtest_filter=*OncParsedCertificates* Change-Id: Ic5b824d3d7fc36b89a2695f5ec0d1099a1600171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702308Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686538}
-
Robert Sesek authored
Swiftshader now passes MAP_JIT when allocating its code pages, so this entitlement can be locked down. Bug: 985816 Change-Id: Id71cca3ed7300da7990085a19652bbba5b6c92c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742835Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#686537}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/12c357b447a4..5e97d0125fd9 git log 12c357b447a4..5e97d0125fd9 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 tsepez@chromium.org Remove dependence on fxfa/parser on fx_barcode. 2019-08-13 tsepez@chromium.org Remove xfa/fxfa dependence on fpdfapi/font Created with: gclient setdep -r src/third_party/pdfium@5e97d0125fd9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I02b09ea85cd34f4d2f64e1140366a6a61c62c419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686536}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7741db7456bc..f9fbd0f9b5e9 Created with: gclient setdep -r src-internal@f9fbd0f9b5e9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I84e9d3119aac0c67dcdc1d45636cd06b532b5934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752248Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686535}
-
Andrew Grieve authored
Guessing this was an IDE mistake :P. Came across this when doing proguard testing. Change-Id: Ib3ed490ff65635f6f6f8c725f522ed66ac0d5697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752586Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#686534}
-
Rayan Kanso authored
Also updates related metrics around it to include more than one owner and expiration dates. Bug: 984282 Change-Id: I25f3804b47d2d7ce2d0185c99c81139956d57a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751204 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Michael Thiessen authored
The test was launching the NTP from the wrong thread. Change-Id: I99f72187c2ce8d129ed388f7f712795c95aa364e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752553 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686532}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/827c26f6435e..5c7d9733468d git log 827c26f6435e..5c7d9733468d --date=short --no-merges --format='%ad %ae %s' 2019-08-13 treehugger-gerrit@google.com Merge "trace buffer: Clear kChunkNeedsPatchingFlag for incomplete chunks" 2019-08-13 treehugger-gerrit@google.com Merge "proto/processor: Add TrackEvent type for instant events" 2019-08-13 taylori@google.com perfetto-ui: Tickmark panel Created with: gclient setdep -r src/third_party/perfetto@5c7d9733468d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:111169965 Change-Id: I782bf23a8104b85164a59ffceaec44879aff8fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751753Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/34c59c9b88b7..5e4e8b0af5fa git log 34c59c9b88b7..5e4e8b0af5fa --date=short --no-merges --format='%ad %ae %s' 2019-08-13 bclayton@google.com Add Visual Studio CMakeSettings.json file 2019-08-13 bclayton@google.com Reactor: Add self() method to LValue<T> and Array<T> Created with: gclient setdep -r src/third_party/swiftshader@5e4e8b0af5fa The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139189696,chromium:b/133213304 Change-Id: Ib842c1ab0b88bd73aa0da91edf7fd79b1e36775b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751749Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b6d7c5370888..35670f183a73 git log b6d7c5370888..35670f183a73 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 shaobo.yan@intel.com Skip InheritDynamicOffsetsComputePipeline test on Windows Created with: gclient setdep -r src/third_party/dawn@35670f183a73 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I3ce5f3276512ed8818a9dcb32269521fadec4099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752250Reviewed-by:
-
Matt Mueller authored
Allow SupportsUserData to be used by subclasses which can be "reset", by letting the subclass clear all associated user-data if required. (e.g. CertVerifyResult has a Reset method, so if it subclass SupportsUserData, it also needs a way to clear any attached user data when Reset is called.) Bug: 991247 Change-Id: I3b3edaa58b2e70daac453edd28e4aa37eee17bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738628 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686528}
-
sczs authored
Screenshots: iPhoneX Portrait: https://drive.google.com/open?id=1EuSPpb_-7yGjbxSaz5bOkWWWKmq74zq8 iPhoneX Landscape: https://drive.google.com/open?id=1sfpAppZAvrMp3k20527vxXbu7WG8ZiPi iPadPro Portrait: https://drive.google.com/open?id=1EuL2t9yWlU4IpIERGMHxxlYBYKoLYA5M iPadPro Landscape: https://drive.google.com/open?id=1nBDidl8oYXjrx9_NOtF-trfts_0x7Ea5 iPadPro Portrait DynamicType: https://drive.google.com/open?id=1k5pwO0agJ5uf-pmOVeFf4frmHOR25W8W Bug: 979201 Change-Id: I97a59a5ac32f9f45a091f32fe73e90d8cfd8ec61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709650Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686527}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ef31815a694..e73aa7573279 git log 6ef31815a694..e73aa7573279 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 halcanary@google.com experimental/editor: up,down preserves x-coordinate 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-13 bsalomon@google.com Add tolerance to ProcessorCloneTest and dump images on failure. 2019-08-13 csmartdalton@google.com Return kNearest from GrSkFilterQualityToGrFilterMode for 1x1 images 2019-08-13 benjaminwagner@google.com [gn] Don't use cc_wrapper for link steps 2019-08-13 senorblanco@chromium.org SkSL: implement full support for separate textures and samplers. 2019-08-13 bungeman@google.com Clean up some gm factory use. 2019-08-13 mtklein@google.com less clever skipMoveTo logic 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-13 ethannicholas@google.com added error check for invalid 'in' variables 2019-08-13 mtklein@google.com rewrite SkDashPath.cpp's cull_path() logic 2019-08-13 halcanary@google.com experimental/editor/application: pre-shape text before showing window 2019-08-13 halcanary@google.com experimental/editor: README.md multilingual example Created with: gclient setdep -r src/third_party/skia@e73aa7573279 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: I04546731e364989ebf8547ddda5501ce4fd5017c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752585Reviewed-by:
-
Antonio Gomes authored
BUG=704136 R=haraken@chromium.org Change-Id: I87cd65f441fd8da7cc54ed824ae7a647a696da33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752064 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#686525}
-
Jun Cai authored
This CL refactors SmsDialog to use event handler. An enum SmsDialogEvent is added to SmsDialog class and can be used by both C++ and Java code. Bug: 985441 Change-Id: I1ecc4e70609479124c80a7166a9551ffa77566a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737875 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#686524}
-
Antonio Gomes authored
... and use the WTF counterparts, Vector and String. BUG=704136 R=haraken@chromium.org Change-Id: I99adf8785525376a47b1a5e52cfee345f5618d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752063Reviewed-by:
-
lgcheng authored
Re-center opt in dialog upon launching when no resizing is needed. Bug: b/132199704 Change-Id: I2cbfd157c7b1be2428e3f76e82b8f389aa7a6976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752173Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#686522}
-
Rakib M. Hasan authored
In the build found at https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/82258 the benchmark is causing one of the shards to time out. Bug: chromium:992837 Change-Id: Ib0110a8bb379e89fd94389ed6a7d68fa2cf812e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750802 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#686521}
-
Richard Knoll authored
As part of the Click to Call feature, we open the dialer with a prefilled phone number. We want to track how many times an actual call is made shortly after that to measure an end to end user journey. Bug: 976311 Change-Id: If966f2fd87f7e7c3675805bac31e547774349989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746466 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686520}
-
Nate Fischer authored
WebView currently has no UMA records. One possible explanation is if the client_id is always a consistent value. It's hard to check if it's always a consistent value, but we can check for a few classes of invalid values (incorrect length, invalid characters). Tentatively add CHECK()s so we can look for crash data. We'll remove these CHECK()s when we know the root cause. Bug: 992250 Test: None Change-Id: I920061f973a8320bb5b6df14cf2a3a193751e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750346Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686519}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d37448e..83ed3059 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I708b4d67c5b3a6778a885acc34123fb6193f1519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751702Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686518}
-
Ian Kilpatrick authored
This may not be strictly better, as now we have to initialize, and directly compare these flags. However this harmonizes everything to be similar in the constraint space now. Initially we had this enum to save us from manually copying all of the flags from the builder to the final space. However we changed the builder to directly mutate a space at a later date making this less needed. We then also started to move flags out of this enum, e.g. "size constraints" which go through a different set of checks. Change-Id: I662f2eaf03ebe64bf6d9b51ccc4d1f7de263091b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751923Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686517}
-
