GitLab

This CL is moving the speech synthesizer code to a worker thread.

The TtsPlatformImpl is using an ISpVoice COM interface to perform
text-to-speech actions. The instance was living on the UI Main
Thread which was using STA Apartment.

This CL is splitting the logic in two parts. The first part is the
control logic which stay on the UI Thread. The second part is the
synthesizer logic which is running on a worker thread.

Bug: 869399, 1133813
Change-Id: I8f8d939950cc39637f87d101ed362123a51e985e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462341
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820340}

Typed events' phases, categories, and names are already exported to ETW
via TraceLog::ShouldAddAfterUpdatingState(). However, when the typed
event is emitted onto a different track, this wasn't yet reflected in
the phase of the event as exported by ETW.

This patch overrides the phase passed on to ETW export for such events
with explicit tracks.

Bug: 1141860
Change-Id: Ia7b0b5b3dcb44e415110396baf9c2239f2fc656b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494937
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820339}

This CL adds a Blink counterpart and client for the
PolicyContainer. The Blink PolicyContainer is connected via mojo to
the content PolicyContainer and can update policies.

On CommitNavigation, the Browser sends to Blink the PolicyContainer of
the target document, together with a mojo remote that connects to the
Browser counterpart. Blink stores it into the LocalFrame.

Change-Id: I8231d205057f0c3af720b339e409af86301c2add
Bug: 1130587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418381
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820338}

This patch means the code change to apply first line style on the first
innermost in-flow block even if there are out-of-flow blocks.
Following the spec (https://drafts.csswg.org/css-pseudo-4/#first-line-pseudo),
The first formatted line of an element must occur inside a block-level
descendant in the same flow (that is not out-of-flow due to floating or
positioning). So, we should skip out-of-flow children in
LayoutBlock::EnclosingFirstLineStyleBlock().

Bug: 979253
Change-Id: I58836b223b58816f731096a7a9f93e612278d42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485667
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820337}

https://webrtc.googlesource.com/src.git/+log/213fa85f73cd..9d69cbeabf5d

2020-10-23 sprang@webrtc.org Changes default pacing factor to 1.1x

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Id2b678ad73a9258b1eaa8a7df6219ec7bd1991c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495386Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820336}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e323f012..42c17639

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I64c1f4bab6ff9dc7d4452167315dfbb1a4c14fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495243Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820335}

This CL allows to change max number of stored and restored navigation
items via Finch within [40, 75] range. This experiment will allow to
understand if reducing stored session size can reduce out of memory
crashes.

Bug: 1115279
Change-Id: I2a4c40f6949631df4eaa503f21b909cd0c3994ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493120Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820334}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Ic17a94146752dc154d2459e5f8eff063a9f2c827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495387Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820333}

We needed the special SVG code to disable compositing. Now we can
composite the element while disable composited animation, so we can use
the common code path for unsupported CSS properties for animation.

Bug: 1134652
Change-Id: Ifa30c2ca90e0574be537b7f235aae027afa16653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493724
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#820332}

https://android.googlesource.com/platform/external/perfetto.git/+log/6b3c8d667a5f..4cd11945c5a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I50ce94cdf5b9f72708f35f403b5edd39cac13bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495500Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820331}

Change-Id: I37cf93456db505479775fb05bf59cb32cacad2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493096
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820330}

https://screenshot.googleplex.com/3D6kchnMu4Dx2Ez

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I17237736ae391af7e82bc747b09bbb4749a3c548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492969
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820329}

Add pointer support to the mostVisited and shortcut buttons
on the NTP.

BUG=1139054

Change-Id: I9486aca3c27871312df0051149f8ed1e6f1dea22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476957
Auto-Submit: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820328}

Bug: 1136043
Change-Id: Ic77b9a0f7c91116931ef1f7f73b7d2f2108f9124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495285
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820327}

Before, we had to manually add an obsolete tag to each variant when the
entire <histogram_suffixes> node was marked obsolete. This fix attaches
an <obsolete> tag to each generated variant.

Bug: 758782
Change-Id: I6986b912b3646de42b8564cdb302cb9eddf8decc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481789Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Karthika Pai <karthikapai@google.com>
Cr-Commit-Position: refs/heads/master@{#820326}

This CL adds a new onboarding dismiss prompt by:
- Introduced a superclass |PhoneHubContentView| for all content views
  with an |OnBubbleClose| function.
- Separate the previous |OnboardingView| to |OnboardingMainView| which
  is responsible for displaying the main page of the onboarding view,
  and |OnboardingDismissPromptView| which is responsible for displaying
  the dismiss prompt.
- Refactors the content view classes to inherit from the superclass.
- Updates and refactors the unittest.

Screenshot: https://screenshot.googleplex.com/7vqNqrD9im5vvVS.png

Future work:
Update the UI to spec by removing the phone status bar.

BUG=1106937,1126208

Change-Id: I6d4f164526d37e7018aa696324e8b1f7878492bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474253
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820325}

This CL is keeping track of the language returned by the speak
synthetizer. The language attribute is used by the TTS controller
GetMatchingVoice(...) to choose the most suitable voices.


For an empty test that do:
  speechSyntheizer.speak(...)

My local computer is choosing:
  Afrikaans espeak-ng
which is the first alphabetical entry.

With the patch, it is choosing:
  English (America) espeak-ng
since my app-locale are taken into account by the TTS controller.

Bug: 1133813
Change-Id: Ie04657dec7f947ddd91c9e672bcb36a54863d88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493021Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820324}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91ad80de0e11..1315d1d2d5a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC bsep@google.com,mohsen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: bsep@google.com,mohsen@google.com
Change-Id: I74c32f2f93ab8660ff15ee6f8116a9639b746be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495381Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820323}

Bug: 1080832
Change-Id: I4ff90e0040dfba8a2432d51f4f3dcdd7aa2e7f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495505
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820322}

On macOS versions running versions below 10.10 images did not conform to
NSSecureCoding protocol. Now that Chrome only supports macOS 10.10+ this
check is unnecessary.

Bug: None
Change-Id: Ief414b6e6e7f183b2e9e2b5065231579b92578e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494873Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mohamed Adel <adelm@google.com>
Cr-Commit-Position: refs/heads/master@{#820321}

On Linux AMD ES3MapBufferRangeTest.ReadPixels has begun failing
consistently reporting errors from the drivers. A device reboot did not
resolve this.

This change skips the test on that configuration while we look into the
root cause.

TEST= gl_tests_passthrough
      ES3MapBufferRangeTest.ReadPixels

Bug: angleproject:5213
Change-Id: I8a25c357d8eeea7bd6dc17023402bc84a6309e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495042Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820320}

a.Then(b) will return a new callback that when Run() will
1) run |a|
2) run |b|, passing it the return value from a
3) return the result from |b|

OnceCallbacks must be destroyed when joining them together with Then(),
so the method is rvalue-qualified. This means it is used in the
same way as Run(), for example, this function posts two callbacks to
run together as a single task:

void PostTwoTasks(base::OnceClosure c1, base::OnceClosure c2) {
  PostTask(std::move(c1).Then(std::move(c2)));
}

RepeatingCallback can be joined destructively via the rvalue-qualified
overload, or non-destructively otherwise. The latter is allowed for a
RepeatingCallback because it is meant to have multiple callers and
therefore having both the original callbacks and the joined callback
pointing to the same underlying functor is not problematic.

R=chrisha@chromium.org, gab@chromium.org

Bug: 1140582
Change-Id: Ie147f01d1c8adeb5ed34e4933f211e7d247e3c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485642
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820319}

The page does not load because failing the trusted type policy.
Removing import "strings.m.js" since we are not using it.

Bug: 1141097
Change-Id: Ief36638834ac481f1da6ce98c94c6c60308f54c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492890Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820318}

Bug: 1077217
Change-Id: Ie0081edc73c8b8ed0669c0aacaad9ccbb2ead003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490800Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820317}

Bug: 1037760
Change-Id: Ie4043cc704a59da892638d07335080f47fe26ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469217
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820316}

This CL moves mock_logger.* from chrome/browser/ to components/ so that
it can be reused by mirroring service tests in components/ directory.
Mirroring service tests will be changed in a later CL.

Bug: b/165366974, 1117673
Change-Id: I225de779b0caa476fd253b56e0ecc10f16e13688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482092Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/master@{#820315}

This change creates the DiagnosticsManager class which is responsible
for managing the lifetime of the various services used by the
Diagnostics SWA. DiagnosticsManager will be owned by the SWA's
MojoWebUIController and is brought up and torn down when the app is
opened/closed.

Bug: 1128204
Change-Id: Ie9be65e3d6ab74aa4037cc1e916cdbd3f2981da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492641Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820314}

Bug: 1121185
Change-Id: I7f4d0a0517f7286c120c0dd114d48da90488bd17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493047Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820313}

The test is flaky on Lollipop, i.e. on the "Lollipop
Phone Tester" bot.

BUG=1141889
TBR=arbesser@chromium.org

Change-Id: I7bf333a73e5af9a46fcac6ac8f12e72cf76954a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494890Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820312}

There are no real reasons for COEP not to be enforced on Android
WebView.

See also:

[PSA-COEP-expanded-to-webview]:
https://groups.google.com/a/chromium.org/g/blink-dev/c/Wc_uYYkcviw

[Updated chrome-status entry]:
https://chromestatus.com/features/5642721685405696

[original-intent-to-ship-coep]:
https://groups.google.com/a/chromium.org/g/blink-dev/c/XBKAGb2_7uA/m/ajpc6_9zAAAJ

[crossOriginIsolated spec to be updated]:
https://github.com/whatwg/html/issues/6060

Bug: 1140432
Change-Id: I9a7c44671846f20bd0ac2a06b181ed584ad606eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485507Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820311}

Keep bounds we are given instead of only keeping the size. Allows tests requiring this information to pass.
Create allow_null_view_token_for_test, which allows tests to create a view themselves.

Change-Id: Icab59c3d622537d5651c128a6c9572c667187338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462241Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Auto-Submit: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#820310}

macOS Big Sur lies about its version number to apps
built with SDKs earlier than the 11.0 SDK. We already
have code (daad98ce)
to undo that lie for version functions that return
numbers, but the version functions that return a
human-readable string were still lying.

Set SYSTEM_VERSION_COMPAT to fix the lie of that
string.

SYSTEM_VERSION_COMPAT alone is not adequate; it has
no effect on tests that do not share that Info.plist
and that we do not go through the trouble of giving
Info.plists because they are not bundled. But at
least for the Chromium app launched by Launch Services
we can improve system version number display.

Fixed: 1141569
Bug: 1108832
Change-Id: If064037bbb27ad42198bdebaf687e90e526e8751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495266
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820309}

As of r820148 the PRESUBMIT is tripping on bogus grd files only
used for the purposes of testing. With the following error:

[Errno 2] No such file or directory: u'/../ui/webui/resources/tools/tests/foo_resources.grdp'

Fix by explicitly ignoring such grd files from the PRESUBMIT checks.

Bug: 1132403
Change-Id: I4a8b1f2b69c7bec6e26bf7a1a0790969d1b57bfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495320
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820308}

AbortClientNavigation() resets the navigation client message pipe, so it
is impossible to be in a state where the navigation client message pipe
is still connected but the commit should be ignored.

Unfortunately, this doesn't mean that the race previously fixed in
https://crbug.com/763106 is gone. It just means that the browser process
can send a CommitNavigation() that the renderer will never hear about
because the renderer's endpoint is already gone.

There is one tricky case with CommitNavigationWithParams(), which
previously also checked if the commit should be ignored. This method is
asynchronously called by MHTMLBodyLoaderClient when the MHTML archive
body is fully loaded. However, since MHTMLBodyLoaderClient is reset with
the same timing as the navigation client message pipe, this turns out
not to be a problem in practice.

Bug: 1020175
Change-Id: I3a8dc816030071a30f315ebc62a819ef3cde143a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493669
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820307}

DismissButton is only used within one file and the button instance is
set to always focusable. This CL moves the focus behavior setting
directly into the class so it is clearer that this kind of button should
be always focusable.

Bug: 1001103
Change-Id: I6d2f8c59815170b19da776b029ba474fde8c03f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493088Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820306}

This CL uses the fallback mechanism available for fast API calls in V8
for the WebGL methods bindTexture and bindBuffer, which are known to
check error conditions and throw JS exceptions in case of errors.

Bug: chromium:1052746
Change-Id: I8c2e8ce7e152977ec3ace0827a102eae73d4151b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465849Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820305}

This changes mojo::Wrap/UnwrapPlatformFile to use
base::ScopedPlatformFile instead of raw PlatformFile values.

In the process, this fixes potential file descriptor leaks in
chromeos_camera code.

Fixed: 710376
Change-Id: Id86db91695bf3a6e87e210c2226739dbc9d8fa01
Tbr: lamzin@google.com
Tbr: drubery@chromium.org
Tbr: rakeshsoma@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491545Reviewed-by: Shik Chen <shik@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#820304}

Bug: 1047547
Change-Id: Ia3de37aad0f0a004a14bd9311f658d0b78ae22ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494780Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820303}

This CL is moving the libspeech synthesizer code to a worker thread.

This CL is splitting the logic in two parts. The first part is the
control logic which stay on the UI Thread. The second part is the
synthesizer logic which is running on a worker thread.

Bug: 869399, 1133813
Change-Id: I212f58ff94e5deac7950e206e4aac484d285f0f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488045
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820302}

This addresses a bug where preview sticks around forever when there is
no internet connection and an offline version of the page is available.

We should remove the preview and display the offline version when one
is available.

Bug: 1141086
Change-Id: I3b4ca2481899c3dd8fea5a3cb46ee7da140d15bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490268Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820301}