- 03 Apr, 2018 20 commits
-
-
Mike Wittman authored
TBR=sullivan@chromium.org Change-Id: Ib495ea4e4f1bcb82470bc242bb4f613e2c323b3f Reviewed-on: https://chromium-review.googlesource.com/991459Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547592}
-
Xiaohan Wang authored
According to the gn reference (and from brettw@): the "loadable_module" target type allows you to create an object file that is (and can only be) loaded and unloaded at runtime, which is exactly what we want for Clear Key CDM. Bug: 584449 Test: Existing tests pass. Change-Id: I2a3a322cb13a7c052c7c43fdd1235ccadd0742ce Reviewed-on: https://chromium-review.googlesource.com/988814Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547591}
-
Shenghua Zhang authored
Flipped LUCI and Buildbot for Android x64 Builder (dbg) and Android x86 Builder (dbg). Removing them from migration side-by-side UI. Bug: 790521, 790536 Change-Id: I593f5c76205b1264b81f0851a5e5ff9eac2fed3a Reviewed-on: https://chromium-review.googlesource.com/990811Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547590}
-
Aaron Leventhal authored
When two spans are separated by a line break, and the second span's text node also begins with a line break, the space shown in the layout is not rendered in the accessibility presentation. The computation to determine if there is rendered space adjacent to a space-only node must use the inline text boxes to get the most accurate representation of what is ultimately rendered. Bug: 821906 Change-Id: Ie81134a95a8878d22a370e97b330e0eae5101d67 Reviewed-on: https://chromium-review.googlesource.com/988375 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#547589}
-
Ovidio Henriquez authored
This change updates the blocklisted UUID tests to use the Web Bluetooth Test API. This will allow the test to be migrated into wpt/. BUG=509038 Change-Id: I72acd10e5aabc4c03f955dc4c7b2a8620930cc2d Reviewed-on: https://chromium-review.googlesource.com/894738 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#547588}
-
dpapad authored
With this change, the user is correctly forwarded to chrome://extensions, if an invalid URL is entered, for example chrome://extensions/foo/bar.html. Bug: 828174 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I18598c6b3367bcb972efda64bf56cdd1496f2ed7 Reviewed-on: https://chromium-review.googlesource.com/991083Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#547587}
-
Bret Sepulveda authored
To match the OS the button should be flush with the right edge of the window. This was also causing the top-right pixel of the screen to not activate the button when the window was maximized. Bug: 827664 Change-Id: Ie9f6a080c9374a842be729702c33ddbde9199e7e Reviewed-on: https://chromium-review.googlesource.com/988845Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#547586}
-
David Grogan authored
Some scrollbar refactoring left unnecessary code around. Change-Id: I459e500a3ed6bc6006a0fd9c8f6d78b1325b010e Reviewed-on: https://chromium-review.googlesource.com/991115Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#547585}
-
dpapad authored
This file was renamed at https://codereview.chromium.org/1409933012, but somehow both the new and previous files remained in the repository. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2ea7152f168bbae9290b961397d70f4f853ed04b Reviewed-on: https://chromium-review.googlesource.com/990727Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#547584}
-
Ned Nguyen authored
TBR=charliea@chromium.org NOTRY=true Bug: 828222 Change-Id: I075a12c7733d055f2264322401dae6dbeccefc92 Reviewed-on: https://chromium-review.googlesource.com/991399Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#547583}
-
Kristian H. Kristensen authored
In preparation for hardware plane underlay support in ChromeOS, we need to allow for RGBA primary framebuffers. When using an underlay, we cut out a transparent rectangle in the primary framebuffer to allow the underlay to show through, while still allowing for RGBA content on top of the underlay (for example, video controls or annotations). When not using an underlay, the primary framebuffer will be displayed as RGBX (opaque) to avoid unnecessary blending in the display controller. Previously review and landed as CL:801974 and then reverted and relanded a few times as we added support for ARGB+AFBC to the mali driver and reverted CL:985033 which broke ozone on older boards without ARGB scanout support. As of this new CL, the patch has been tested succesfully on all boards that previously regressed, but the chromeos bvt bots are still stuck on an old image (see https://bugs.chromium.org/p/chromium/issues/detail?id=826973#c18). Bug: 789288 Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,alemate@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org Change-Id: I9ffb41e8f475ba6e4075b2abbe46c05456a5413a Reviewed-on: https://chromium-review.googlesource.com/991261Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547582}
-
David Black authored
Bug: b:77235133 Change-Id: I0af7895ce28fe58195845f2ad4c130956e3518e6 Reviewed-on: https://chromium-review.googlesource.com/986667 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547581}
-
Jay Civelli authored
This CL adds the original_url, request_start and net_error to ResourceLoadInfo. Bug: 816684 Change-Id: Ic4659292100165a054c2a5b5adfde7d3c207bc03 Reviewed-on: https://chromium-review.googlesource.com/988808 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#547580}
-
Mitch Foley authored
Change-Id: I8c7576108610fb20b3490460e9d9804689c2e1a5 Reviewed-on: https://chromium-review.googlesource.com/990498Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#547579}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31e7d56c28f1..81b26429c8f6 $ git log 31e7d56c2..81b26429c --date=short --no-merges --format='%ad %ae %s' 2018-04-02 bpastene depot_tools: Kick the recipe roller. 2018-04-02 agable Revert "Remove Rietveld support from presubmit" 2018-04-02 ehmaldonado bot_update: Don't patch if gerrit_repo or gerrit_ref are empty/None. 2018-04-02 agable Disallow TBRs to OWNERS files 2018-04-02 agable git-cl-try: document auth_config for buildbucket 2018-04-02 agable Remove Rietveld support from presubmit Created with: roll-dep src/third_party/depot_tools BUG=chromium:828154,chromium:770408,chromium:643346,chromium:688115,chromium:770408 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I830e86112dda7d11bdca0537ab8879e1a8d745b2 Reviewed-on: https://chromium-review.googlesource.com/991085 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547578}
-
Noel Gordon authored
Re-enable two GalleryBrowserTestInGuestMode tests, listed below, which were disabled in issue 804413 due to linux-chromeos-release bot flakes on the CQ. GalleryBrowserTestInGuestMode.SlideshowTraversalOnDownloads GalleryBrowserTestInGuestMode.StopStartSlideshowOnDownloads Tbr: yamaguchi-san Bug: 804413 Change-Id: I2928ba5a849b47a911bbd89382ef5c32d76edec2 Reviewed-on: https://chromium-review.googlesource.com/991212Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#547577}
-
François Degros authored
Change-Id: Ie13dbd479024c1a0b3bec97f8e7cb2a7183685ec Reviewed-on: https://chromium-review.googlesource.com/991213Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#547576}
-
Takumi Fujimoto authored
This CL changes a ctor for HoverButton to take an optional View object for showing an arbitrary secondary icon, instead of taking a boolean for whether to show an arrow icon. The HoverButton will be used by the Cast dialog to list devices. Bug: 826089 Change-Id: Iac36c2bc8a60666bc6aa035fbcbbedd0f59c66cf Reviewed-on: https://chromium-review.googlesource.com/989023 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#547575}
-
https://skia.googlesource.com/skia.git/+log/3070926579a6..1a291b354f54 $ git log 307092657..1a291b354 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 herb Cleanup Ops - remove extra bytes sent and received 2018-04-02 liyuqian Simplify SkDrawTiler; check emtpy pixmap and overflow 2018-03-29 bungeman SkScalerContext::getMetrics to not request metrics it will ignore. 2018-04-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 4a77de482..ad0c4f19b (1 commit) 2018-04-02 brianosman Revert "Disable GPU support by default when building for host in Fuchsia" 2018-04-02 mtklein Revert "implement SkTDArray with std::vector" 2018-04-02 mtklein Revert "In older STLs, std::vector::insert() returns void." 2018-04-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ d2cc6a7f7..4a77de482 (2 commits) 2018-04-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d104918fd..5a7e61bbd (1 commit) 2018-03-29 halcanary SkPDF/SkTypefaceMetrics: Set PostScript Name in Directwrite backend. 2018-04-02 djsollen Add multilib support as the default build option for libskqp 2018-04-02 mtklein In older STLs, std::vector::insert() returns void. 2018-04-02 benjaminwagner Revert "Temporarily remove Win10 QuadroP400 from CQ." 2018-04-02 halcanary SkPDF/Clusterator: a second test 2018-03-28 csmartdalton ccpr: Normalize homogeneous coords with frexp/ldexp 2018-04-02 robertphillips Turn on rendertarget sorting 2018-03-22 mtklein implement SkTDArray with std::vector 2018-04-02 egdaniel Remove specVersion check on vk extensions. Created with: roll-dep src/third_party/skia BUG=chromium:b/77249109,chromium:821040 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ib45a57c51ee4a0e1efd4c7c14107e9a2bb728f20 Reviewed-on: https://chromium-review.googlesource.com/990810Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547574}
-
Benjamin Pastene authored
Bug: 793907 Change-Id: Id31acad64245e66741e0271941c55ea5d71986a1 Reviewed-on: https://chromium-review.googlesource.com/990582Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#547573}
-
- 02 Apr, 2018 20 commits
-
-
https://webrtc.googlesource.com/src.git/+log/a859c1ac3e12..7eca09361d6d $ git log a859c1ac3..7eca09361 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:826972 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib774178d6b9aa204e20bde42728730c640188818 Reviewed-on: https://chromium-review.googlesource.com/990933Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547572}
-
Matthew Jones authored
Bug: 827371 Change-Id: I48efd505632d33e935d1676ff298a53e9da1579e Reviewed-on: https://chromium-review.googlesource.com/991156 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#547571}
-
Kai Ninomiya authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3c1cb02..da5abe6 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng Change-Id: I4f9cd170e9767b959d73288f4e0a063caca59e95 Reviewed-on: https://chromium-review.googlesource.com/987372Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547570}
-
Adam Langley authored
This is a trivial matter but makes a bit more sense when I make the inner Read call a little more complex in the next change. Change-Id: Ie1c19e8760a598cf36914e634037c519e7f78d72 Reviewed-on: https://chromium-review.googlesource.com/990194Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#547569}
-
Kevin Marshall authored
This CL grows Fuchsia blobstore by a specified amount, large enough to accommodate packaged executables installed at machine (QEMU) runtime. Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion of fvm.blk. Bug: 798851, 707030 Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 Reviewed-on: https://chromium-review.googlesource.com/987012 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547568}
-
Evan Stade authored
Also move the first run/force-maximizing logic into Chrome/, i.e. WindowSizerAsh. Removing it from ash::WindowPositioner seems OK because the logic should only really apply to browser windows. UX contact: jennschen PM contact: kuscher Bug: 764009 Change-Id: Ie0642d1a50c4047082de025a36f59fadc1a3fc1d Reviewed-on: https://chromium-review.googlesource.com/985015Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#547567}
-
David Grogan authored
It got dropped a long time ago http://wkb.ug/98464 Without it the second flex box is row instead of the intended column. Change-Id: Ic4e60cb14eb8584e89b5ac019e837647d1280c13 Reviewed-on: https://chromium-review.googlesource.com/991084Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#547566}
-
Lukasz Anforowicz authored
https://tools.ietf.org/html/rfc7303 says that if "new media type is introduced for an XML-based format, the name of the media type SHOULD end with '+xml'". https://tools.ietf.org/html/rfc6839 covers '+xml' and '+json' suffixes. https://mimesniff.spec.whatwg.org/#xml-mime-type says "An XML MIME type is any MIME type whose subtype ends in '+xml' or whose essence is 'text/xml' or 'application/xml'. [RFC7303]". https://mimesniff.spec.whatwg.org/#json-mime-type says "A JSON MIME type is any MIME type whose subtype ends in '+json' or whose essence is 'application/json' or 'text/json'." There are no occurences of "application/xml+", "text/xml+", "application/json+", "text/json+" or "text/x-json" in the specs above and on various lists of MIME types like: - https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Complete_list_of_MIME_types - https://en.wikipedia.org/wiki/Media_type - https://www.freeformatter.com/mime-types-list.html - https://www.sitepoint.com/mime-types-complete-list/ Bug: 826756 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ied30f9728bd4f082bb620fea150f342457ea4833 Reviewed-on: https://chromium-review.googlesource.com/985211 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547565}
-
Sergey Ulanov authored
The test timeouts when running on bots with nested virtualization due to slow IPIs and CPU contention. Bug: 826952 Change-Id: I2f8583922bf0591357dd1a0259c879df99b845c2 Reviewed-on: https://chromium-review.googlesource.com/990731Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#547564}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd5d1859f1e0..b90af5c203f7 $ git log fd5d1859f..b90af5c20 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 chrome-bot Update config settings by config-updater. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9966fa6f5f53d7afe88ee46d728cdbdf79b65082 Reviewed-on: https://chromium-review.googlesource.com/990206Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547563}
-
Nektarios Paisios authored
Relational operators need to work when one of the positions is a text position and the other an anchored position that is the sibling of the text position, i.e. when comparing the order of container objects is not enough to determine position order. R=dmazzoni@chromium.org Change-Id: Idf720b9e35e77c0da6b970017dc45c07d73b6c82 Reviewed-on: https://chromium-review.googlesource.com/988740Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#547562}
-
Filip Gorski authored
* Wires the new bridge to the old prototype * Tentatively takes dependency on the content suggestion service to simplyfy favicon fetching (this may still not work, because the database is not filled with contextual suggestions). * Next step to fetch favicons is to extract and reuse the code, while dropping the dependency on content suggestion service. Bug: 824183 Change-Id: I50d6879b837a06f64ac9c376de4a1f6f6c151d2b Reviewed-on: https://chromium-review.googlesource.com/989612 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#547561}
-
Troy Hildebrandt authored
Right now we only record a metric on when a voice search is triggered in the omnibox, and nowhere else. This patch records where the start of a voice interaction comes from, and if completed successfully resulting in either suggestions or a navigation to a SRP, the source of the finish event as well. This currently includes omnibox, NTP, and the search widget. This also includes a minor refactoring, pulling voice search logic out LocationBarLayout and into its own class, LocationBarVoiceRecognitionHandler. Bug: 817228 Change-Id: Ie0a97ecbbec92c9189e4454e67c94b18ca4c7ffe Reviewed-on: https://chromium-review.googlesource.com/943598 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547560}
-
Tom Anderson authored
BUG=827899 R=dpranke Change-Id: Idb5832232d46ffda9df2d540523031a9edfdad44 Reviewed-on: https://chromium-review.googlesource.com/990959Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547559}
-
Eugene Ostroukhov authored
1. Disable pointer events in the HTML preview. 2. Fix font size in the IDB object store display header. Change-Id: I0b19333c28392cc7641fb551aac9ab3deb27f1e1 Reviewed-on: https://chromium-review.googlesource.com/990207Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#547558}
-
James Cook authored
Clean up before making it work with out-of-process ash (go/mustash). * Make FirstRunHelper a concrete class * Eliminate ash::Shell::CreateFirstRunHelper * Move some methods to FirstRunController in chrome Bug: 756057 Test: existing ash_unittests, browser_tests Change-Id: I6d3660f64e2184a03c2f92b204200a26b5f7dab8 Reviewed-on: https://chromium-review.googlesource.com/990725Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#547557}
-
Andre Goddard Rosa authored
It's okay to pass nullptr to delete, as by default it will call free() that will check for NULL, so there's no need for redundant checks. Bug: none Change-Id: I450ee684f78d0cf3f1394d18de788df67f6435c9 Reviewed-on: https://chromium-review.googlesource.com/988960Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andre Goddard Rosa <andre.rosa@lge.com> Cr-Commit-Position: refs/heads/master@{#547556}
-
Hector Carmona authored
Bug: 819567 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3683ea8b25ef5e8df47a897eb8f12d392f091b7a Reviewed-on: https://chromium-review.googlesource.com/988737Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#547555}
-
Takuto Ikuta authored
This is build dependency optimization for the build like below https://chromium-build-stats.appspot.com/ninja_log/2018/04/02/win75-c4/ninja_log.win75-c4.chrome-bot.20180402-000428.8888.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/135170 obj files for browser_tests compiled around 215s~245s wait remoting/webapp unnecessarily. Change-Id: I47fecd63b063382fde5e4c200f378eff7563521e Reviewed-on: https://chromium-review.googlesource.com/989855Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#547554}
-
Katie D authored
This makes the STS EventRewriter work with Sticky Keys mode, and is basically a revert of commit 0c0f3795 along with porting other modifications made since that commit. Bug: 819860 Change-Id: I340295ac0ca6e24057fcb9d4a0890d77b3cf0439 Reviewed-on: https://chromium-review.googlesource.com/988849 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#547553}
-