- 25 May, 2018 40 commits
-
-
Emily Hanley authored
NOTRY=true Bug: 840427 Change-Id: I3c1336cccc6e0af88aea9b7ad5e7d10a8cdd5b6f Reviewed-on: https://chromium-review.googlesource.com/1069659 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#561849}
-
Chris Hamilton authored
A follow-up CL will refactor existing consumers of WC::WasRecentlyAudible to use this API instead, before removing the relevant content API. More details in the bug. BUG=846374 Change-Id: I7a758b7fc4d01ca7e0a98676978d1de333829866 Reviewed-on: https://chromium-review.googlesource.com/1072748 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#561848}
-
Hajime Hoshi authored
Before this CL, null was passed to Mojo binding as a compositor task runner in offscreen canvas on worker thread as NonMainThreadTaskRunner:: CompositorTaskRunner() returns null. In this case, SingleThreadTaskRunner::Get() was used internally Mojo. This CL implements WorkerThreadScheduler::CompositorTaskRunner() with a new task type kWorkerThreadTaskQueueCompositor so that we can know the task runner's usage on UMA for task duration per task type. Bug: 841172 Change-Id: I8caf3244169300aed45eeab4fcd01999bc823976 Reviewed-on: https://chromium-review.googlesource.com/1073169Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561847}
-
Mark Pilgrim authored
Bug: 844934 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I480fe2d42be09e6b295f5e7f1e53548e1e912ede Reviewed-on: https://chromium-review.googlesource.com/1072048Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561846}
-
Mark Pilgrim authored
As part of the effort to bring the new Network Service online, we are deprecating URLFetcher in favor of SimpleURLLoader. Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit Bug: 844937 Change-Id: I4a00c42b481f10c03657aa52b9a3d197febdc6ed Reviewed-on: https://chromium-review.googlesource.com/1070110Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This relands r561423 and r561793. Original code review: https://chromium-review.googlesource.com/1069956 Second code review: https://chromium-review.googlesource.com/1073037 This collided with the landing of the S13nSW virtual test suite. I'm relanding with an expectation for the S13nSW failure. Probably we're using NetworkService when S13nSW is on and NetworkService is off. Bug: 839982, 846545, 846637 Change-Id: Ib1c3122ee532cce56a040356433002a24edc5553 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR: nhiroki, kinuko, dcheng Reviewed-on: https://chromium-review.googlesource.com/1072991Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561844}
-
Olga Sharonova authored
Expectations for virtual/threaded/animations/responsive/zoom-responsive-transform-animation-002.html. Crashes/fails/times out (see the bug). NOTRY=true TBR=sky@chromium.org Bug: 846632 Change-Id: I8d5315ca84019ef980105ca9693fde0ec84b0fb3 Reviewed-on: https://chromium-review.googlesource.com/1072651Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561843}
-
Alexandr Ilin authored
TBR=bsheedy@chromium.org Bug: 846661 Change-Id: Idc30a69a9cea6ac7e39834fe5f0218c218a17797 Reviewed-on: https://chromium-review.googlesource.com/1073369Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561842}
-
Olga Sharonova authored
Failing flakily. NOTRY=true TBR=sky@chromium.org Bug: 846631 Change-Id: I5378035496d8b0009c5cc024d3feb68dcccc027a Reviewed-on: https://chromium-review.googlesource.com/1073448Reviewed-by:
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/34f5f28603eb..3543e21830b9 $ git log 34f5f2860..3543e2183 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 maruel Revert "[client] First local_caching improvement" 2018-05-22 maruel [client] First local_caching improvement 2018-05-18 maruel [client] Move named_cache into local_caching 2018-05-18 maruel [client] move DiskCache into local_caching 2018-05-18 maruel [client] Fix swarming trigger with secret bytes on Windows Created with: roll-dep src/tools/swarming_client R=qyearsley@chromium.org Change-Id: Iecce181fef85587704cd48ec5b7ce51b5f7d8d93 Reviewed-on: https://chromium-review.googlesource.com/1072320Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561840}
-
George Adams authored
This file is necessary for builds in which the gn args v8_use_external_startup_data and use_v8_context_snapshot are both set to true. There was aprevious change to include this in the headless component, but it was only generated for component builds. The commit sha for the previous change is 8e676c03. R=alexclarke@chromium.org, skyostil@chromium.org Bug: 829561 Change-Id: I34a6c8778d6cd7a8b9e635ab48d299163ddea936 Reviewed-on: https://chromium-review.googlesource.com/999013Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#561839}
-
Mikel Astiz authored
This is a partial revert for https://chromium.googlesource.com/chromium/src/+/87d0207fea94e8f64ca053c813b96e2ddcd3da27 Tabs not only get restored from tab entities (which is usually the case) but can also be restored directly when processing a header entity. For cases where a header references a tab that doesn't have a corresponding tab entity (e.g. was unsyncable), we need to simply skip the reasociation step. Bug: 846480 Change-Id: I5d534645a42e4e660bf2cd110a7a4ee0f57b9c25 Reviewed-on: https://chromium-review.googlesource.com/1073328 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#561838}
-
Ned Nguyen authored
** Perf bot health sheriff: if there are test cases in this benchmark that fails on windows, please disable individual failed test cases instead of revert this CL ** TBR=cbruni@chromium.org, hablich@chromium.org Change-Id: I20b8026608164107f13a6a62a73c812bef4ab12e Reviewed-on: https://chromium-review.googlesource.com/1072502 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#561837}
-
Olga Sharonova authored
(flaky). NOTRY=true TBR=sky@chromium.org Bug: 846656 Change-Id: I711631f169c28c525ed8ce97ae5799ca6a07adae Reviewed-on: https://chromium-review.googlesource.com/1073410Reviewed-by:
-
Hajime Hoshi authored
This CL also removes MediaElementEventQueue::CancelEvent, which is not called anywhere. This is one of the steps to eliminate EventQueue. Bug: 846618 Change-Id: I6e67a84d7bbd5344a5758e58d1db7be0192ac53f Reviewed-on: https://chromium-review.googlesource.com/1072992Reviewed-by:
-
Andy Paicu authored
Bug: 845961 Change-Id: Ifc9609058cd7cbd268785db46534e3ed09da6ce3 Reviewed-on: https://chromium-review.googlesource.com/1071510 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#561834}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c6fb49f6. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18556 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=kereliuk No-Export: true Change-Id: Ifc6a156705f0264de5db0e2aef74c4b558436e83 Reviewed-on: https://chromium-review.googlesource.com/1073086 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561833}
-
Manuel Rego Casasnovas authored
Text from the spec (https://drafts.csswg.org/css-contain/#containment-paint): "... if the element's principal box is a non-atomic inline-level box, paint containment has no effect." The patch disables "contain: paint" in non-atomic inline-level boxes. For that a new method LayoutObject::ShouldApplyPaintContainment() is added, which is used instead of ComputeStyle::ContainsPaint() all around the code. It's worth to highlight the change in ComputedStyle::CanContainFixedPositionObjects() as it doesn't know if the element is inline or not, it cannot check if we're in paint containment anymore. Otherwise it'd make a containing block non-atomic inlines with "contain: paint", the ones in which we're disabling paint containment on this patch. More changes on that new method would be needed to fulfill the rest of requirements from the spec, as paint containment shouldn't apply to internal table and ruby elements for example. Also similar patches for other kind of containment like layout and size are going to be required. Regarding tests this patch makes us pass contain-paint-002.html. On top of that a few extra tests have been added. BUG=843329 TEST=external/wpt/css/css-contain/contain-paint-011.html TEST=external/wpt/css/css-contain/contain-paint-012.html TEST=external/wpt/css/css-contain/contain-paint-013.html Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I140fad061f5cda14e52451aa8f4bc70c9edede3e Reviewed-on: https://chromium-review.googlesource.com/1071794 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#561832}
-
Olga Sharonova authored
See the bug. Bug:846621 Change-Id: Ia3689ade53b5ee775fcc7c3f43b96925d1818e01 TBR=piman@chromium.org Change-Id: Ia3689ade53b5ee775fcc7c3f43b96925d1818e01 Reviewed-on: https://chromium-review.googlesource.com/1073367Reviewed-by:
-
David Roger authored
Going forward the default API for interacting with authentication error should be the token service rather than the SigninErrorController. This CL updates tests to use the token service instead of AuthErrorProvider to set authentication errors. Bug: 836212 Change-Id: I9b5629bad7b17b6cab70978cc23bbc828bf62d61 Reviewed-on: https://chromium-review.googlesource.com/1016904 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#561830}
-
Koji Ishii authored
This patch fixes a case where ShapingLineBreaker may produce incorrect number of characters in the ShapeResult. It was probably introduced in r471636 [1]. When searching for the last safe position, there is a case where last_safe and line_end_result lost sync. Then ShapingLineBreaker constructs the final ShapeResult assuming they are in sync. The fix is done by simplifying the logic for when including more characters can shorten the width. Two nested loops, one to find previous then another to find next is changed to single loop. This also avoids trying opportunities once tried and failed. When no break opportunities can fit and that multiple break points are valid, this patch picks a different break than before. I think the new break is better, but we may want to revisit this as we learn more. Includes following related changes: 1. Add is_overflow state. When it overflows, no need to look for previous opportunities. 2. Add BreakOpportunity struct to ensure the offset and is_hyphenated are in sync. 3. Add more DCHECKs to ensure start, first_safe, last_safe, and break_opportunity are always in this order. 4. Add more DCEHCKs to ensure the offsets above are in sync with each corresponding ShapeResult. 5. Uncommented DCHECK that used to fail on Mac. [1] https://codereview.chromium.org/2875933006 Bug: 636993, 846138 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8e740f9f59ce4d50f20cf4cb360f460685418583 Reviewed-on: https://chromium-review.googlesource.com/1072208 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Stuart Langley authored
Currently the lists of users team drives is loaded on each update using ChangeListLoader. We remove the logic from ChangeListLoader and use TeamDriveListLoader instead. The full list is loaded only on startup, after that team drive changes (new/removed/changed) will arrive via default change list processing. Bug: 845058, 829154, 723955 Change-Id: I06c8d6d8e26ca1f02003768b879af8aa96a78b5b Reviewed-on: https://chromium-review.googlesource.com/1073036 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561828}
-
Michael Lippautz authored
Wrapper tracing uses TraceWrappersWithManualWriteBarrier when dealing with raw pointers. These uses need to use TraceWithWrappers in an Oilpan world as they would not be properly forwarded otherwise. Bug: chromium:841830 Change-Id: I725d2fbc8a8ac1f8387e4efeae5b74f02a294ed7 Reviewed-on: https://chromium-review.googlesource.com/1073171Reviewed-by:
-
Findit authored
This reverts commit 665ceb41. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 561811 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY2NWNlYjQxMmZlOWEyODI2OWMyZmNiMzExMTVmMjdhZWU2NmZmZDYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/69248 Sample Failed Step: browser_tests Original change's description: > Update ContentSettingsService access to incognito profile. > > ContentSettingsService handles incognito mode requests internally, so > a flag is set to redirect incognito mode requests to the original > profile. > Also, in Set Content Settings API, incorrect use of include_incognito() > function instead of IsIncognitoEnabled() is corrected. > Two tests are added to check that all settings written in incognito > are applied and do not affect regular mode, and incognito settings > cannot be modified from regular mode. > > Bug: 832697 > Bug: 845845 > Change-Id: I7fe259af6a6cbc030483ffac445bdef4b972c7cf > Reviewed-on: https://chromium-review.googlesource.com/1061853 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561811} Change-Id: Iaba120a3b8107c9dddbf2826b72e5e4567ee3a37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845845 Reviewed-on: https://chromium-review.googlesource.com/1073088 Cr-Commit-Position: refs/heads/master@{#561826}
-
Boris Sazonov authored
This CL removes a field and a method that are no longer used. Bug: None Change-Id: I510e1cfa0a864f41618f00152c426399647b716c Reviewed-on: https://chromium-review.googlesource.com/1072090Reviewed-by:
-
Hans Wennborg authored
This roll includes: - f58d066 Add shebangs to pacify chromium presubmit error - ecc514d Parser.cpp: Fix undefined behaviour in float conversion - 59ca26e [inspector_protocol] Node.js is finally ready for transition.. - dd90116 [inspector_protocol] node uses script names inside own repository Bug: 845816 Change-Id: I3e6ddda9af210e1bfa6350d0999ce2f0ee170a44 Reviewed-on: https://chromium-review.googlesource.com/1070275 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561824}
-
Olga Sharonova authored
This reverts commit 2c2411fb. Reason for revert: Suspected cause of Issue 846609 Original change's description: > Perfetto: Fix ProducerClient threading/sequencing issues > > * TraceWriters will no longer be destroyed when their TLS slot is cleaned > up on thread shutdown as this can trigger a CommitData() call from > Perfetto and cause asserts when Mojo does a TaskRunnerHandle::Get() > for a PostTask; instead we leave the deletion to the taskrunner > Perfetto is running on (if it's getting shut down, the task should > get dropped). > * Run ProducerClients on their own sequence. > > Bug: 844379 > Change-Id: Ie45b36a4e463674122555dbec2105953a882f37c > Reviewed-on: https://chromium-review.googlesource.com/1069528 > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561356} TBR=primiano@chromium.org,oysteine@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 844379 Change-Id: I82eb4e335521ef8f39119bdd2a984f4dc81ac88c Reviewed-on: https://chromium-review.googlesource.com/1073247Reviewed-by:
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 751354 Change-Id: I9d2813bc8228bd0346e255bba24a2975fc8de310 Reviewed-on: https://chromium-review.googlesource.com/1067922Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#561822}
-
Kent Tamura authored
Add to_class_data_member() to NameStyleConverter, and use it instead of class_member_name(). * make_runtime_features.py: - Remove feature.class_member_name. Replace its usage with {{feature.name.to_class_data_member()}}. - Introduce _data_member_name() and feature.data_member_name. 'is_{{snake_case_name}}_enabled_' is used repeatedly in the python code and the templates. This CL doesn't change generated C++ code. Bug: 843927 Change-Id: I3b80460a05b155278a5f0bf46bddf0051a768457 Reviewed-on: https://chromium-review.googlesource.com/1073173Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#561821}
-
Alexandr Ilin authored
TBR=twellington@chromium.org Bug: 846619 Change-Id: I3dd36bdd5c57bcc9bfd0b3e826cb40c9b15561d0 Reviewed-on: https://chromium-review.googlesource.com/1073282Reviewed-by:
-
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true # tests by PRESUMIT Bug: 844502 Change-Id: I335e1f3b8ad43fd00bcb3057fe4bb0323fb7289d Reviewed-on: https://chromium-review.googlesource.com/1073085Reviewed-by:
-
Lutz Justen authored
Just a bunch of random cleanups, no real changes: - Don't have default switch case, so that we'll get a compile error if someone adds values. - os << foo; return os ==> return os << foo; - Use base value's operator<< instead of duplicating it. - Use range based loops. - Clang format. BUG=None TEST=Tryjobs Change-Id: I766d7eba43e5ed93cebec4734e9acafc46bcb8ca Reviewed-on: https://chromium-review.googlesource.com/1063835Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#561818}
-
Hitoshi Yoshida authored
NameStyleConverter couldn't handle special tokens that contain numbers if its input string is written in lower camel case. For example, 'uint8ArrayMember' was tokenized as ['uint', '8', 'Array', 'Member'], while ['uint8', 'Array', 'Member'] was expected. This CL adds some lower case special tokens to handle them well. Bug: 761242 Change-Id: I255c4f756b6406ab7bf9d28a504b4fee38220c23 Reviewed-on: https://chromium-review.googlesource.com/1071049 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#561817}
-
Tsuyoshi Horo authored
To distinguish the signed exchange error from network layer errors. Bug: 815024 Change-Id: I165b8d44938575c2c5092c4f0012c1f58122ba79 Reviewed-on: https://chromium-review.googlesource.com/1073182Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561816}
-
Olga Sharonova authored
This reverts commit f904fcc9. Reason for revert: Suspected of causing virtual/service-worker-servicification/external/wpt/service-workers/service-worker/worker-interception-redirect.https.html failures (example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32483) Original change's description: > Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." > > This relands r561423. > Original code review: https://chromium-review.googlesource.com/1069956 > > The original patch had a problem because the shadow page was created > before UnguessableToken. The fix is to not create the shadow page early, > which was only needed in an earlier patchset to get the task runner > from it. > > Bug: 839982, 846545 > Change-Id: Id6545d9d86a3a56a04e7f83a840d9acddd55f51b > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > TBR: kinuko, dcheng > Reviewed-on: https://chromium-review.googlesource.com/1073037 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561793} TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org,nhiroki@chromium.org Change-Id: I56e491c5d74ee738c2ce6e530b7448319e14ab20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839982, 846545 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1073248Reviewed-by:
-
Michael Lippautz authored
Add unit tests that make sure that visitor dispatch reaches the expected leafs. Reland: - Avoid anon namespace in header file. This reverts commit a398ea4f. Bug: chromium:841830 Change-Id: I870d7f06baac17661a0d8bd16ee4ece78f8cdda6 Reviewed-on: https://chromium-review.googlesource.com/1073168Reviewed-by:
-
Greg Thompson authored
BUG=818832 R=martiniss@chromium.org NOTRY=true Change-Id: I399f412947d597b7b6fb810ef2f44e64233fdc1f Reviewed-on: https://chromium-review.googlesource.com/1071568 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Kent Tamura authored
Use NameStyleUtilities.to_lower_camel_case() instead. This CL doesn't change generated C++ code. Bug: 843927 Change-Id: I3badfc7a432dcc400303d3d03e4a687f0c95fec4 Reviewed-on: https://chromium-review.googlesource.com/1073127Reviewed-by:
-
Ramin Halavati authored
ContentSettingsService handles incognito mode requests internally, so a flag is set to redirect incognito mode requests to the original profile. Also, in Set Content Settings API, incorrect use of include_incognito() function instead of IsIncognitoEnabled() is corrected. Two tests are added to check that all settings written in incognito are applied and do not affect regular mode, and incognito settings cannot be modified from regular mode. Bug: 832697 Bug: 845845 Change-Id: I7fe259af6a6cbc030483ffac445bdef4b972c7cf Reviewed-on: https://chromium-review.googlesource.com/1061853 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6b5912a. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18549 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy msramek@chromium.org, mkwst@chromium.org: external/wpt/clear-site-data tdresser@chromium.org: external/wpt/navigation-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=kereliuk No-Export: true Change-Id: I5b537b933478b46d5b0556657a36fb4915cf763d Reviewed-on: https://chromium-review.googlesource.com/1073077 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
