- 27 Oct, 2020 40 commits
-
-
Amanda Baker authored
This change enables future UI changes based on the 'window-controls-overlay' display override by adding a new method, `IsWindowControlsOverlayEnabled()`,to the web app controller that indicates whether or not the WCO should be shown. Explainer: https://github.com/WICG/window-controls-overlay/blob/master/explainer.md Design Doc: https://docs.google.com/document/d/1k0YL_-VMLIfjYCgJ2v6cMvuUv2qMKg4BgLI2tJ4qtyo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cper6nNLFRQ/hU91kfCWBQAJ Bug: 937121 Change-Id: Ibe5615393e50edc09e2464abe9eaa09e52559be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486780Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Amanda Baker <ambake@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821037}
-
Glen Robertson authored
Parent CL has related mojo changes: crrev.com/c/2486525 . Will need a separate CL to land for impl on Android side. Explainer: https://github.com/WICG/digital-goods/blob/master/explainer.md#full-api-interface Bug: 1140345 Change-Id: I06fa43dc79cf37b77edfe0c87817e697cbd1d4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497393Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#821036}
-
Zain Afzal authored
This is the first cl in a set of CLs centred around moving navigation order responsibility from launch.js to ReceivedFileList in receiver.js. This cl does 3 things to set up ReceivedFile list to take over owning open file functionality. * Loads a default file list into the media app on launch so we can have access to the openFile method regardless of if we were launched with files or not. * Moves the openFile function from clientAPIDelegate into receivedFileList. * Adds a currentFileIndex property. This is unused at the moment but needs to be on the api so observers can detect when the current file changes. Once Google3 updates to use this openFile function and updates the loaded file on a currentFile change, the old openFile code path can be removed. Then the ReceivedFileList can be updated to no longer rely on launch.js to do file navigation to the newly opened file but to do it internally. See go/bl-file-navigation-order for the full timeline for this effort. Change-Id: Idbbddf1338b66d37917413e67767b54b9709a7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494181Reviewed-by:Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#821035}
-
Leo Zhang authored
This will help IME service show logs better from loaded ime decoder. TEST=Betty with new built DSO. BUG=b/162375823 Change-Id: I9a3fa61078dfeae5a029b912c339cd80bc724a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497352 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#821034}
-
Josh Nohle authored
After a successful payload transfer, BluetoothSocket::Close() will be called multiple times (see crbug/1142071). In this CL, we check if the underlying socket has already been disconnected and reset before trying to disconnect and reset. Without this check, the Nearby process will crash after a successful share. Verified by manually testing Chromebook-->Android transfers. Fixed: 1142071 Change-Id: I1b2fd0a092f1025f95c2eed5253862805e46b034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500982 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#821033}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I88e7ce72d5b6d71327a0deda5f63dc1a171d9daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821032}
-
Dale Curtis authored
This reverts commit a2ecb05c. Reason for revert: This is causing quality reductions compared to the software encoder. We will need to figure out a way to limit usage of the hardware encoder to higher bit rate situations. See https://crbug.com/1142273 Original change's description: > Revert "Remove constrained baseline profile support for H264 in M86." > > This reverts commit 3234b57f. > > Reason for revert: AUD stripping patch from WebRTC has been rolled to Chromium: https://webrtc.googlesource.com/src/+/9345dcfeea73f9dd68dc83dee60255e86dac3f97 and https://source.chromium.org/chromium/chromium/src/+/76165ce5bf99790f8dbae685259723e867458337. CBP for H264 support can come back in. > > Original change's description: > > Remove constrained baseline profile support for H264 in M86. > > > > Bug: 982799 > > Change-Id: Ibe20d74bfe6182b8464855106ca2d09f5dca087c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363462 > > Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> > > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799783} > > TBR=dalecurtis@chromium.org,chunbo.hua@intel.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 982799 > Change-Id: Ib1c0212181d7efffe1cd4b82a0a1ddc9a603a0f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427573 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> > Cr-Commit-Position: refs/heads/master@{#811571} TBR=dalecurtis@chromium.org,guidou@chromium.org,chunbo.hua@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142273 Change-Id: I29c06fcba297967bdac8dd188acb24c84c1053bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500446Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#821031}
-
Patrick Noland authored
TBR=acolwell@chromium.org Bug: 1089994 Change-Id: I290d0294499f620e30157ebcae3a68374fa46f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500701Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#821030}
-
Yao Xiao authored
What: Remove blocklist service. The blocked status will be encoded in the 7th bit in the sorting-lsh entries. Update the component format version. Why: This would save the overhead to check whether the versions match, and would also save the component updater bandwidth. Bug: 1138743 Change-Id: Id590d675efc0c5c54905564ad50cd64b88e21bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473547Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#821029}
-
Evan Stade authored
The test is modeled after Chrome's MediaRouterIntegrationTest. Other test cases will be added soon. The cast emulator service is moved from //chrome to //components. This service (and an APK wrapping it) is necessary for the media route chooser dialog to have entries in it. The selection of these entries (creation of presentation, etc) is handled by MockMediaRouteProvider. RouterTestUtils is also moved to //components/media_router. This facilitates finding views in the chooser dialog. Bug: 1057099 Change-Id: I0e8b67f3286b21bec5bc0f4581975fc1cca95b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488088Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#821028}
-
Nate Chapin authored
Change-Id: I557b2aa89ec0a737e1d5b315b3d06fe12148b778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500271 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Ken Rockot authored
This is a reland of 0092862f Original change's description: > Reland "Mojo JS: Use BigInt consistently for 64-bit int fields" > > This is a reland of ea79bdd2 > > Fix is in the delta from PS1 -> PS3 > > Original change's description: > > Mojo JS: Use BigInt consistently for 64-bit int fields > > > > This changes 64-bit integer fields to be deserialized as > > BigInt values consistently, rather than sometimes being > > BigInts and sometimes being Numbers. > > > > Fixed: 1102217,1009262 > > Change-Id: I9cc8d767058938e9c39f62f139737e512f47cdb2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466398 > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > > Reviewed-by: Shik Chen <shik@chromium.org> > > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#818611} > > Change-Id: I393a33b44b1a3e1746f7b9ee021dbe06c3ff7b07 > Tbr: shik@chromium.org > Tbr: fdoray@chromium.org > Tbr: ryansturm@chromium.org > Tbr: mahmadi@chromium.org > Tbr: beccahughes@chromium.org > Tbr: oksamyt@chromium.org > Tbr: ortuno@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485749 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Auto-Submit: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#819004} NOPRESUBMIT=True Change-Id: I51f628aa5898f66d26ff1d8c7ef3ade3d0f91045 Tbr: shik@chromium.org Tbr: fdoray@chromium.org Tbr: ryansturm@chromium.org Tbr: mahmadi@chromium.org Tbr: beccahughes@chromium.org Tbr: oksamyt@chromium.org Tbr: ortuno@chromium.org Tbr: harringtond@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489666 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#821026}
-
Thomas Guilbert authored
This CL creates an exception to be reported by the error callback when decoders encounter a error. The error is also logged as a message in the DevTools media tab. Bug: 1139089 Change-Id: Ib8f71505303cb7ff535928055df05163bc57c267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499422 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#821025}
-
Toni Barzic authored
Introduces a concept of partially initialized HoldingSpaceItem - this state will be used when loading items from persistent storage in case the item file system URL cannot immediately be resolved (e.g. if the associated mount point hasn't been loaded yet). HoldingSpacePersistenceDelegate will deserialize persisted items into partial state when they are first loaded from the storage, and "finalize" them when their file system URL can be resolved. Compared to an alternative approach where items whose initialization has to be deferred, this approach keeps the order in which items are added to the model. Updates holding space UI not to show partially initialized items. BUG=1140150 Change-Id: Ie19997ec02f6323434f4053f6ba41a2998e72efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493323 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821024}
-
Mariia Shvedchenko authored
The MatchingPattern's negative pattern type from std::string to base::Optional<std::string> has been changed and the resulting changes have been made. This fixes that every pattern's negative pattern vacuously matched. Bug: 1142579 Change-Id: Ida580b33e9a4f0f42accdfcce082aa428ad12275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500221Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Commit-Queue: Mariia Shvedchenko <mariiash@google.com> Cr-Commit-Position: refs/heads/master@{#821023}
-
Shawn Gallea authored
This is not needed Merge-With: eureka-internal/472392 Bug: NONE Test: Locally on device Change-Id: Ia64527d24c0fc7062cd9da8aa51c00d304d0fd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485277Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#821022}
-
Morten Stenshorne authored
Bug: 800764 Change-Id: I3a7afb3095b5f686664d5061cfe11dd906116980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484699 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#821021}
-
Oleg Davydov authored
It's a fixup for https://crrev.com/c/2426583. We've decided to have burunduk@ at the main histogram owner, but forgot to upload a patch for that. Bug: None Change-Id: I4cb2777e931376a2f9dbc7a2c28dc64618e0c03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498566 Auto-Submit: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821020}
-
David Maunder authored
We want to be able to identify and display price updates in the Tab Grid Switcher. This change to the infrastructure will provide us with the capability to do that. Bug: 1139459 Change-Id: I7588b377bc1fd1532a67373835c4204201723fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481010Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821019}
-
Ken Rockot authored
These messages were identified as occasionally exceeding the soft message size limit. No functional changes here, only suppressions and TODOs. Bug: 1141980,1141985,1141987,1141990,1142000,1142008,1142011,1142013 Change-Id: Icd1a060b9bd082bfa204f44a3a12a43c8812c0fb Fixed: 1142019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495789 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821018}
-
Shakti Sahu authored
Bug: 1142645 Change-Id: I8c26e00a7239f2f37180ddbb37f52e92b9973bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497433 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#821017}
-
Glen Robertson authored
Blink impl: crrev.com/c/2497393 Explainer: https://github.com/WICG/digital-goods/blob/master/explainer.md Bug: 1140345 Change-Id: Idc6cfd23abcdf1ce696ed26d54804912304108bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486525 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
The blink-dev thread for deprecation is here: https://groups.google.com/a/chromium.org/g/blink-dev/c/7XWZ-J7HZHw Bug: webrtc:6625 Change-Id: I10b1f320a7b82fd75d184c487ef3afb18888533a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289831Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#821015}
-
cfredric authored
CookieStore. Change-Id: If6a77b1d8e71e9187f72735acaba6845b2de6b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498132 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#821014}
-
Michael Thiessen authored
Split off of https://chromium-review.googlesource.com/c/chromium/src/+/2442359 as these fixes will be useful even when that CL gets inevitably reverted :) Espresso wraps and re-throws Exceptions, so we catch Exceptions whose cause is a CriteriaNotSatisfiedException as well so that the polling actually works when using Espresso to check Criteria. Bug: 1134178 Change-Id: I7c9cdb7e637b306b0c6cb9ecb42a237d99091cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491117Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#821013}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c54539538ed6..77cd4b459b10 2020-10-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I85727b4f538d190fc3a8e35eb80f728121e3b371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500249Reviewed-by:
-
Clark DuVall authored
Bug: 1137468 Change-Id: I7380b5e1de6cd1af7b7c9577c1972003c4d99384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500443Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821011}
-
Lei Zhang authored
- Use nullptr - Use std::make_unique() - Use auto - Use = default; - Use modern copyright notice - Stop using DISALLOW_COPY_AND_ASSIGN() Bug: 1010217 Change-Id: Ib3e5ec1715b33325f11f391bb749e3e014c1ba4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495978Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#821010}
-
Tommy Li authored
This CL adds a base::Feature flag that disables the HistoryQuickProvider InMemoryURLIndex's cache file. Instead, the index will be rebuilt on every startup from the History DB. That's not as disastrous as it sounds. It takes ~2.5x as long compared to the on-disk persisted cache, and doesn't block the UI. It's on the History DB thread. Details of experiment: go/chrome-omnibox-hqp-ablate-cache-file Change-Id: Idddca4c5621010f3415e61d8731b3009892c281e Bug: 750845, 1032679, 1141539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441044 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821009}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3b334b2b8e1a..740ae9f60b00 2020-10-26 johnkslang@users.noreply.github.com Merge pull request #2435 from amdrexu/feature If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I82a9fd127a13a33ca0ac3c954c0f91b4ce664929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499901Reviewed-by:
-
Michael Checo authored
Bug: 1059779 Test: browser_tests --gtest_filter=ScanningUIBrowserTest.All Change-Id: Ia69f55232fc5e0065d646363798f545f6a1eeb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500421Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#821007}
-
Nate Chapin authored
Change-Id: I9647c6fa76a88a7d2c6f10a53436c203324d8dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500426 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b1635617. With Chromium commits locally applied on WPT: 6cca306f "webrtc wpt: add cleanup to insertable streams worker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Id099dd721f6136143279f5975e87b8426bd7bdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500322Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821005}
-
Kunihiko Sakamoto authored
This reverts commit 07c000ce. Reason for revert: use-of-uninitialized-value is detected in Linux MSan Tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25981 ==29008==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5580a100b292 in base::HangWatcher::GetTimeSinceLastCriticalMemoryPressureCrashKey() ./../../base/threading/hang_watcher.cc:268:7 Original change's description: > Fix thread checks in HangWatcher > > Remove the thread check that would never pass and make the variable > that is used by multiple threads thread safe. > > Bug: 1142155 > Change-Id: Iae33e15733eb78a47a664515e1abec671edbb64d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495579 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820817} TBR=fdoray@chromium.org,olivierli@chromium.org Change-Id: I463c2928c91878d396a0dd7ebb93b3c625e26a56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500385Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821004}
-
Yue Li authored
Bug: b/169453041 Test: Run TranslationResponseParserTest.* in chromeos_components_unittests Change-Id: I08315718f29b8785150fddc765552d73c88bab96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493434Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#821003}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8036d9953123..41c24933da1e 2020-10-26 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1bafdc3c45e7 to 57694c8dab3c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I733e16c9858e824a7de0ea8b133875473181001f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500143Reviewed-by:
-
Allen Bauer authored
Bug: 938501, 1130078 Change-Id: I50e6c35c97b1d25250bb45d2341e49602e86c29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498829 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#821001}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id146b05a48c87e45f7dac4a7640140a36fc9ad75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500043Reviewed-by:
-
Patrick Noland authored
Bug: 1139515 Change-Id: I0a34783a6a58581fcb64560c11ac5538db369553 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500427Reviewed-by:
-
Evan Stade authored
LargeIconServiceImpl depends on FaviconService, but WebLayer doesn't have that service. So the relevant part of FaviconService, i.e. GetLargestRawFaviconForPageURL, is moved to a new interface, LargeFaviconProvider. (The FaviconServiceImpl implementation is unchanged.) Also, the needed parts of LargeIconServiceImpl are refactored out into their own file, large_icon_worker.{h,cc}, which LargeIconBridge accesses directly. Some Profile references are updated to BrowserContext{,Handle} in LargeIconBridge. For LargeIconBridge to get a LargeFaviconProvider from a BrowserContext, a factory method/getter is used. Embedders must set this factory method if they are to use LargeIconBridge. The next step will be to actually LargeIconBridge in shared code (not just in Chrome), and to add a LargeIconProvider implementation in WebLayer (which is a simple pass through to FaviconBackend). Bug: 1137625 Change-Id: Ib06dc2325cac8c6c4439c43d30c4a8f7073b08fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473578 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
