- 25 Jun, 2019 40 commits
-
-
Kevin Strohbehn authored
This changes traversal to use a 'selection' similar to omnibox that is wholly managed by a single object. This change is currently behind a flag, and will be default-on in a follow up CL by June 25th Bug: 931909 Change-Id: I828605ca77a87829eded327ab8a6198097450ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607502 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#671890}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/e90aa11c4be3..dc0267693ad4 git log e90aa11c4be3..dc0267693ad4 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 codyleeweaver@gmail.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@dc0267693ad4 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: Iba5873a192896f050519af4008ab5c1ed0bff4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674784Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671889}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves RequestParameters to OAuth2AccessTokenManager and TokenCache type definition which uses RequestParameters also is moved. Bug: 967598 Change-Id: I62d268f634c91caf61d792110206f5a01751f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670132 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671888}
-
Yilkal Abe authored
This reverts commit b916e68c. Bug: 977019 Original change's description: > Enable feedback from power button menu in KioskNext sessions > > Bug: 967931 > > Change-Id: I302a4eb12ff69c117c0254fdc86d1a2323231180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647454 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667308} TBR=jamescook@chromium.org,michaelpg@chromium.org,yilkal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 967931 Change-Id: I279992966d55b8ba140f488bbac798efb515f11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674189Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671887}
-
Peter Kasting authored
Bug: 956419 Change-Id: I6f769800f1deb20461d4148b28d4b03d23310de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657355 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#671886}
-
Dana Fried authored
Because Linux/CrOS do not respect hit test transparency, the top shadow of bubbles fights for mouse events with the window underneath. This causes unacceptable flicker with tab hover cards on Linux and ChromeOS. As a temporary fix until the real culprit can be addressed (a much larger effort; see crbug/978134), on the affected platforms we move hover cards down slightly and slightly raise the bottom of the hit test area for tabs up slightly to compensate. This is not ideal from a UX standpoint but it is the only solution available at the current time for an issue that is otherwise a release blocker. Bug: 972582 Change-Id: I91f0583f8c6c4dfb912c4ea75e07a437fc770f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674290 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#671885}
-
Sangseok Jang authored
The function "AddItem" add invisible empty menu for extension overflow menu. It might be workaround to resolve appkit menus bug. But, it might be resolve. The empty menu added before extension overflow menu is invisible, but it has margins. So, the exetension overflow menu view in AppMenu looks different in Windows and Mac. Bug: NONE Change-Id: Iba0b944f688b42a42d2e83716209770acae689e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669136Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sangseok Jang <sangseok.jang@navercorp.com> Cr-Commit-Position: refs/heads/master@{#671884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3905cd79dbe..754e19056745 Created with: gclient setdep -r src-internal@754e19056745 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Ifc8580e7c4977b2052c79f6c94226d812d83ebee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674302Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671883}
-
Lukasz Anforowicz authored
Bug: 888079 Change-Id: Ic05a6d37c1457239330036149537f260a8c05bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669879 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#671882}
-
Charlie Reis authored
This reverts commit e2af10b0. Reason for revert: Seems to be causing crashes in https://crbug.com/977956. Original change's description: > Fix Android NTP kills by disallowing NTP process reuse before processing the NTP commit. > > SiteInstance supports a class of "siteless" URLs that represent blank > or placeholder documents, which normally do not "use up" their process > (by leaving their site URL unassigned) and allow subsequent > navigations to stay within the same process. Currently, these URLs > include "about:blank" as well as chrome-native://newtab on Android > (used as a placeholder when loading the native NTP to warm up the > process for a subsequent navigation). > > Unfortunately, with Android NTP, a race is possible where the NTP > placeholder process is told to commit chrome-native://newtab, but > before we hear back the DidCommitProvisionalLoad IPC for > chrome-native://newtab, a subsequent navigation to foo.com starts, > reaches the ReadyToCommit stage, and locks the NTP process to foo.com. > When the chrome-native://newtab commit is processed, we kill the > renderer, since the foo.com process lock is not compatible with > chrome-native://newtab. > > To fix this, this CL disallows reusing a process during the narrow > window of time when it has a pending commit to a siteless URL like > chrome-native://newtab (i.e., after CommitNavigation is sent, but > before DidCommitProvisionalLoad is received). It's still fine to > reuse the NTP process post-commit, which is expected to be the common > case that requires the process reuse optimization. > > Bug: 970046 > Change-Id: I82c4fa964e3b0cc5ed400b7da9981573f7873d86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661271 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Auto-Submit: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670618} TBR=creis@chromium.org,alexmos@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 970046 Change-Id: I957374edd66badbc0f1c4f33514e26d78713efbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674620Reviewed-by:
-
Dana Fried authored
Because border thickness changes the default result of calling contents of a view that has had its border changed must be re-laid-out. View: :GetInsets() and by extension View::GetContentsBounds(), the Change-Id: I42b9c95b72162d8bc4ca26d283062d6f154c021e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669655 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#671880}
-
Danton Vu authored
The overview selector is newer, so the window cycle selector should be updated to match it. Instead of using LayerFillBackgroundPainter, we'll opt to use setters for the layers more directly like with overview. R=afakhry@chromium.org, sammiequon@chromium.org Bug: 974050 Test: manual Change-Id: I86721cdb8a75daaabac2337a5b27ebc6b53102c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670288Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Danton Vu <dantonvu@google.com> Cr-Commit-Position: refs/heads/master@{#671879}
-
Doug Arnett authored
Adds Allowed/Committed PreviewsState -> PreviewType support in PreviewsContentUtil for DeferAllScript preview. It is prioritized at this level above ResourceLoadingHints and NoScript since they are supported on older clients and also assuming it is a better option if supported by the client. The optimization guide logic may affect priority separately as well. Bug: 965277 Change-Id: I27b24ad4076f9b424cc9c5041e2d7a36027b12f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669983 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#671878}
-
May Lippert authored
BUG=965657 Change-Id: Ie596ccf2b97c071b4039b643393c0391bf322c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673757 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
-
Lutz Justen authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ed5a30c1446a..33a144a0bdb9 $ git log ed5a30c14..33a144a0b --date=short --no-merges --format='%ad %ae %s' 2019-05-02 apotapchuk cryptohome: Adding calls for obtaining RSUDeviceID 2019-06-14 ljusten kerberos: Implement option to use login password 2019-06-06 ljusten Kerberos: Handle bad configuration 2019-05-20 khegde diagnostics: Add some telemetry battery metrics Created with: roll-dep src/third_party/cros_system_api BUG=chromium:952240 TEST=None Change-Id: I5a26fba9aea6096ff6e7794140d1b7a8104df12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674547Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#671876}
-
Shakti Sahu authored
Bug: 976402 Change-Id: Icef1bce64612e489c575d4ede2d892d76383b529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669990 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#671875}
-
Robert Kroeger authored
This reverts commit 9a315e8e. Reason for revert: https://crbug.com/978199: hook would appear to break the tab capture tests. Original change's description: > Hook up the delay load failure function in the renderer processes (Take 2) > > (reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1655909 with > the code living in a different compiland). > > The problem with the previous CL was that renderer_main_platform_delegate_win.cc > is linked into browser_tests.exe, which caused the hook to be used by the browser > code. > > I've verified this change by checking out the 3814, applying the fix to it and > navigating to https://opensource.salesforce.com/ to confirm that this was > generating a crash report. > > -------- Original CL description ------------- > > This allows getting a crash report when failing to delay load a DLL. > > Example of the stack trace that this will provide: > chrome_child!base::debug::BreakDebugger+0xc [C:\src\chrome\src\base\debug\debugger_win.cc @ 28] > chrome_child!logging::LogMessage::~LogMessage+0x3f5 [C:\src\chrome\src\base\logging.cc @ 939] > chrome_child!DllLoadHook+0x75 [C:\src\chrome\src\chrome\child\delay_load_failure_hook.cc @ 24] > chrome_child!__delayLoadHelper2+0x13f [d:\agent\_work\3\s\src\vctools\delayimp\delayhlp.cpp @ 305] > chrome_child!RtlUnwind+0x470 > chrome_child!SkFontMgr::legacyMakeTypeface+0x13 [C:\src\chrome\src\third_party\skia\src\core\SkFontMgr.cpp @ 164] > chrome_child!blink::DWriteVersionSupportsVariations+0x7f > chrome_child!blink::WebFontTypefaceFactory::FontManagerForVariations+0xc > > > Bug: 970893, 976241 > Change-Id: Ifeb5e79ee141c5eb121e379ff928a9c3d941e71c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665913 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670968} TBR=sky@chromium.org,wfh@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 970893, 976241 Change-Id: I08cf199c5ad21966530f0a325c2f5097786d5882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674610Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#671874}
-
Antoine Labour authored
They are unused after GpuVideoDecoder removal. Bug: 882542 Change-Id: Ic5e64f2b30b8a32be7a4f9209d5aebe007f439f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674474 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671873}
-
Nate Chapin authored
Bug: 977520 Test: http/tests/navigation/xmhtml-location-change-crash.xhtml Change-Id: Idbb8718db7de77ddf41dbc62bd102e884d0bfa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674364 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#671872}
-
Natalie Chouinard authored
Migrat the Site Settings preference fragment from the deprecated framework preferences to the support library preferences. Bug: 968592 Change-Id: I127b24977adf8f4091769131f6f554484b149317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668628 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671871}
-
Chris Blume authored
This CL adds another test which has flaked to the filter. Bug: 977669 Change-Id: I740871a457227a21a75834d02fe1da7afd527096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674632 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#671870}
-
Ayu Ishii authored
This change updates the SMS formatting to use "To:" instead of "From:"[1]. This seems more appropriate because there isn't any guarantee that it is actually going to be coming from what the address states. The intent is to direct a message "to" an origin, independently of "where/from" it is coming from. [1] https://github.com/samuelgoto/sms-receiver#formatting Bug: 976346 Change-Id: Iaf1358661b45a5a2066f4d8c3eac2bc294c10511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669985Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5dee3e826bed..99b76d1b8fdd git log 5dee3e826bed..99b76d1b8fdd --date=short --no-merges --format='%ad %ae %s' 2019-06-24 natlee@microsoft.com Clear D3D12 texture on first usage if not yet initialized Created with: gclient setdep -r src/third_party/dawn@99b76d1b8fdd The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I54e191a249a14d3e340626b8a0d67feca0e8a974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674626Reviewed-by:
-
Jan Wilken Dörrie authored
This change removes the dependency on Hash() in the implementation of StructPtr's and InlinedStructPtr's operator<, and replaces it with a deep comparison. Bug: 735302, 911929 Change-Id: I2d81d1990787e29a1588f3783eb91d0eaa98207b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665934Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#671867}
-
Lukasz Anforowicz authored
The NavigationRequest::base_url_ field used to be populated based on FrameHostMsg_DidCommitProvisionalLoad_Params::base_url, but was never read by production code. Bug: 962643 Change-Id: Ib9e46575f37efc56ca479294ba881919dd934f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670268 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd2737e2b572..73c4a7c3567a git log dd2737e2b572..73c4a7c3567a --date=short --no-merges --format='%ad %ae %s' 2019-06-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@73c4a7c3567a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib1c9f8b97e8d255d1521e5fc03d23f5a2d919b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674661Reviewed-by:
-
Kenichi Ishibashi authored
On-the-main-thread script fetch is disabled by default. Add virtual tests for on-the-main-thread script fetch to have better test coverage until we ship off-the-main-thread script fetch. Bug: 967272 Change-Id: If0b50ad557699d57bae70b2972418df5dc91ed72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673487Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671864}
-
Peter Kasting authored
* Initializer lists * Range-based for * stack::emplace() * Style fixes * Shorten code * Prefer ++ to +=1 * nullptr * Save result of PositionOf() call instead of recomputing * int -> size_t in TreeNodeIterator * Don't handle DCHECK failure Bug: 956419 Change-Id: I62c658a0b0476a37998aaaec89b91bca0c00ca2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660105 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ad6de6a08a66..50710e758168 git log ad6de6a08a66..50710e758168 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 asweintraub@google.com Fix non-standard assignment operator return types. 2019-06-24 asweintraub@google.com Fix 19 ClangTidy - Readability/Naming findings in core/fxge/ 2019-06-24 asweintraub@google.com Fix 31 ClangTidy-Readability/Naming findings in core/fxcrt/. Created with: gclient setdep -r src/third_party/pdfium@50710e758168 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ic3324923596f5accd23fcf8b40843c084f749c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674624Reviewed-by:
-
Karan Bhatia authored
DisplayInfoProvider::Create is declared at the extensions layer but not defined. The expectation is that the extensions embedder will define it. However this is not ideal since any target depending on just extensions gets an undefined function linking error. Correct this by introducing ExtensionsAPIClient::CreateDisplayInfoProvider and introducing appropriate embedder implementations. BUG=976556 Change-Id: I1a9d51ef90d2837ea4bc18cb6df7a629609d7d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666446 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671861}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79519d67783b..967947db0661 git log 79519d67783b..967947db0661 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 hjd@google.com Merge "traced_probes: Add atrace events explicitly" 2019-06-24 fmayer@google.com Merge "Share interning data between ProfilePackets." Created with: gclient setdep -r src/third_party/perfetto@967947db0661 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iacc8fee3de2276bf689ecd041eb8a2cead353354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674303Reviewed-by:
-
James Cook authored
OS settings doesn't control search engine, so don't use a magnifying glass icon. Use the assistant icon instead. See bug for screenshot. Bug: 960937 Change-Id: Icd2929a76572468df4d6615166c4b9d2782c4c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674641 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Eric Willigers authored
RTCRtpReceiver.getParameters() shipped in M73. https://chromestatus.com/feature/5641443221700608 The flag RTCRtpSenderParameter has been stable since https://chromium-review.googlesource.com/1070277 Bug: 803494 Change-Id: I162616cfb572487f9d29954da41e0b490c34a19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616831Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#671858}
-
David Benjamin authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/c8b248039ec1..f564874f4955 $ git log c8b248039..f564874f4 --date=short --no-merges --format='%ad %ae %s' 2019-06-19 davidben Don't opt out of sanitizers in third_party/nasm Created with: roll-dep src/third_party/nasm Bug: 928357 Change-Id: I2a796207721da649f24a84730bfdff3ef39eaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672127Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#671857}
-
Reilly Grant authored
Timeout and pending errors are generated by the chrome.serial API layer and not by the Mojo interface implementation in //services/device. Bug: 893334 Change-Id: Ibde54b35a54db5e7c7c27697eae21bce5b190537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674651Reviewed-by:
-
Istiaque Ahmed authored
Implement the ability to track and retrieve user gesture within an extension Service Worker. Introduce ExtensionInteraction class that provides unified way (for RenderFrames/SWs) to create or retrieve user gesture states. Limitations: * Note that this only works for extension API invocation (e.g. chrome.management.setEnabled), but not for web API invocation (clients.openWindow()). * This CL also does not support user interation retention in API callbacks. That will be tackled in a subsequent CL. RenderFrame based extensions: Make ExtensionInteraction class wrap WebScopedUserGesture and WebUserGestureIndicator to continue to provide RenderFrame/WebFrame based extension's user gesture support. In future this class will also wrap WebUserGestureToken, when necessary. SW based extensions: The interaction is implemented using a counter globally within a worker, in ServiceWorkerData. ExtensionInteraction consults worker local data (ServiceWorkerData) when a user gesture is created, destroyed (ServiceWorkerData::Increment/DecrementInteraction), or retrieved (ServiceWorkerData::interaction_count()). This CL also enables browserAction API for extension SWs. Add a test with browserAction API that ensures the gesture is present when browserAction.onClicked is fired. Bug: 977629 Change-Id: I9c3db7f2b7de67b50e92814b4d6b46060c8f9993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670317 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL informs the clients API about initialization result and list of guids of scheduled notifications. Also some minor polish for the client interface. Bug: 963288 Change-Id: I887f668b0f201583b208497ad4cd782a1679be4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670053 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Min Chen authored
Bug: None Change-Id: I1fe55628621fa05d4eaa3dead26bc19d38776be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674452Reviewed-by:
-
Eugene But authored
This histograms are useful beyond their originally set expiration date. Bug: 975332 Change-Id: Id913299c5de2f14bced1d81ff5424046c96958c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663054Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#671852}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I72c695ee6cf66dc02a5f9f9f6145b31ba3fae4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674456 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#671851}
-
