- 17 Nov, 2017 40 commits
-
-
Yuly Novikov authored
After https://chromium-review.googlesource.com/720019 changed scaling. BUG=785392 TBR=kbr@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If9b38cd6e915a547743ff21f6267847ef48adcbf Reviewed-on: https://chromium-review.googlesource.com/775156 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#517406}
-
Maks Orlovich authored
HttpCache.CantConditionalizeZeroFreshnessFromMemHint is logged along HttpCache.CantConditianlizeCause == ZERO_FRESHNESS to denote this working. Since this is implemented as dooming entries, it messes somewhat with the "open stale" feature on error page. It's my understanding that feature is not turned on, so this just relaxes tests for it to use things not eligible for the behavior change. Bug: 729679 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie9a489fb6fa53a76691615c789c7373650180de0 Reviewed-on: https://chromium-review.googlesource.com/732841 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#517405}
-
Gauthier Ambard authored
This CL adds a LocationBar to the ToolbarCoordinator. The ToolbarCoordinator is the delegate for the LocationBar so it needs to conforms to the LocationBarDelegate protocol. Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1b7d2aa2c7813f5d50622594a8922beacb62e6f6 Reviewed-on: https://chromium-review.googlesource.com/771693 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#517404}
-
Maxim Kolosovskiy authored
[Password Generation] Notify PasswordGenerationAgent about focus change when the user triggers the context menu The generation agent tracks last password field that had focus. The field is used for user-triggered password generation. Before this CL, the generation agent wasn't notified about focus change when the user triggers the context menu (only when the user makes left click on the field). This CL propagates right click events to autofill. Bug: 784840 Change-Id: I31e1d793350f3bd9a6b8a3d61d9fcff6e61acdd8 Reviewed-on: https://chromium-review.googlesource.com/768811Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#517403}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/bb27c3a1483c..2c7f34c833b4 $ git log bb27c3a14..2c7f34c83 --date=short --no-merges --format='%ad %ae %s' 2017-10-09 oetuaho Initialize uninitialized GLSL arrays in a for loop Created with: roll-dep src/third_party/angle BUG=735497 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I7a25c9f6a48140ab7ed97cb8fb2ef3680c62ed54 Reviewed-on: https://chromium-review.googlesource.com/776642Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517402}
-
Sandra Sun authored
virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html is flaky. This patch temporarily disables the test, and a following test will update the test and enable it back again. Bug: 778696 Change-Id: Id27ccb14e0deda20e46478a237ed07962ad7eb5d Reviewed-on: https://chromium-review.googlesource.com/770599Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#517401}
-
Eric Seckler authored
Moves virtual time offsets and durations from int to float to allow specifying virtual time budgets with higher precision. Also adds a return value to Emulation.setVirtualTimePolicy, to report the absolute time when virtual time was first enabled. Bug: 646774 Change-Id: I37fc197f2e9565bf5540fc3787a288a7ac11fa7e Reviewed-on: https://chromium-review.googlesource.com/749948 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517400}
-
kylechar authored
Try dropping two flags that shouldn't be needed. This only modifies the FYI trybot to confirm there are no tests that flake without the flags. TBR: sky@chromium.org Bug: 760181 Change-Id: I9918be273622e4acb016c56dbea3be32560e6040 Reviewed-on: https://chromium-review.googlesource.com/775753Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#517399}
-
Gauthier Ambard authored
- Creates a feature flag for Clean Toolbar. - Creates a ToolbarAdapter class that will be inited when the flag is enabled. - Adapter conforms to Toolbar protocol, but no-ops all implementation for now. - Adapter inits a CleanToolbarView controller and plumbs a dispatcher, WebstateList and ChromeBrowserState. - Adds a WebStateList parameter to BrowserViewControllerDependencyFactory. - Adds a convenience viewController getter to AbstractWebToolbar protocol. CL mainly done by sczs@. Bug: 784502 Change-Id: Ie0c1fce6062adc123e8226252b827281f96ff081 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771713Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ecd62a6cf65a..57e0828fade9 $ git log ecd62a6cf..57e0828fa --date=short --no-merges --format='%ad %ae %s' 2017-11-16 robertphillips Add backend GPU objects to fiddle app Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I11d1b0a39c14af81aa027ecf0f95c32a6cab6000 Reviewed-on: https://chromium-review.googlesource.com/776735Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517397}
-
Shivani Sharma authored
This is not a functionality change but a refactoring CL. In HttpCache::Transaction::WriterAboutToBeRemovedFromEntry we were setting entry_ to null only when result < 0. But there not need be any such condition and entry_ can be set to null for all cases since the transaction is being removed from the entry. This will help in all paths being consistent. It will also make sure that there is no path when a writer transaction is left with an entry pointer by mistake when the entry_ could have been destroyed. Bug: 784458 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4478964256ad3c7d12232cc4e5e793fc61f54cc3 Reviewed-on: https://chromium-review.googlesource.com/775138Reviewed-by:
-
Guido Urdaneta authored
These tests are flaky on Win7 dbg virtual/mojo-loading/http/tests/devtools/console/console-link-to-snippet.js virtual/mojo-loading/http/tests/permissions/test-api-surface.html TBR=chenwilliam@chromium.org, qyearsley@chromium.org Bug: 786345, 786348 Change-Id: Ib2b65c07bb97de4743c893a6b2740e5ed41981ea No-Try: true Reviewed-on: https://chromium-review.googlesource.com/776657 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#517395}
-
Bo Liu authored
This is needed to avoid dropping the strong binding when there were two racy signals to drop and add strong binding. Now the the "last foreground connection" has long been removed, it should be safe to just remove this delay. Bug: 689758 Change-Id: I874b7762f35c208f497189f142797200de307cd9 Reviewed-on: https://chromium-review.googlesource.com/767651Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517394}
-
James Cook authored
This is a start toward grouping them by cause. Also enable these tests, which pass now: AllForms* AllProcesses* BlockingLoginTestInstance/BlockingLoginTest.* BrailleDisplayPrivateAPIUserTest.* BrowserCloseManagerBrowserTest/BrowserCloseManagerBrowserTest.* BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.* BrowserLoginTest.* CertificateReportingServiceBrowserTest.* ChromeOriginTrialsDisabledTokensTest.* ContentScriptApiTests/ContentScriptApiTest.* CrControlledButtonTest.* CrControlledRadioButtonTest.* CrExtensionsManagerTestWithMultipleExtensionTypesInstalled.* Bug: 678687 Change-Id: I6eae99411a5ac0ce72d098da06ca7e42399181cd Reviewed-on: https://chromium-review.googlesource.com/776075Reviewed-by:
-
Hajime Hoshi authored
Bug: 780378 Change-Id: Iac3e165e9721dc9fbe4b1771f8a85e89b98e0056 Reviewed-on: https://chromium-review.googlesource.com/775611 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#517392}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7ac478bd..fb0a53b0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7dc0c9a3988bbbe1fc88bbc990a71cd6638ceeb2 Reviewed-on: https://chromium-review.googlesource.com/775983Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517391}
-
Robert Hogan authored
Bug: 702927 Change-Id: I9972f82a8d2b560042b0acbd8484eed5f76f6f2e Reviewed-on: https://chromium-review.googlesource.com/772412 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#517390}
-
Charles Harrison authored
Recent data shows that the time it takes to dispatch the IPC to Google Play Services is quite expensive. Android canary data (so probably trends higher end), for the subresource filter check (in navigation critical path): 50th percentile: 6ms 75th percentile: 10ms 95th percentile: 28ms 99th percentile: 100ms Average: 11ms Since this is directly in the critical path of navigation, it makes sense not to hog the thread / deschedule it before the network request goes out. It also looks like we hit some perf issues in other uses of the API too. See the linked bug for some chrome://tracing traces. Bug: 779914 Change-Id: Ibc44d9f199715c3fbf7a2d66604e82ee3ccfc5e4 Reviewed-on: https://chromium-review.googlesource.com/760550 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#517389}
-
Takashi Toyoshima authored
This patch plumbs CORSError and HTTP response headers from ResourceRequestCompletinoStatus to Blink's ResourceError. Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors Bug: 736308 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345 Reviewed-on: https://chromium-review.googlesource.com/749024 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#517388}
-
Ramin Halavati authored
A tfNative generated neural network is added to High Contrast classifier to make a better decision for images which are not decidable using the decision tree. Bug: 685242 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4c30f785d7ca65d129fb09902b748978dd6de4f6 Reviewed-on: https://chromium-review.googlesource.com/753588Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#517387}
-
zhuoyu.qian authored
As the comment in cache_storage.h by jkarlin@, rename DeleteCache to DoomCache. Also rename DeleteCacheImpl to DoomCacheImpl. BUG= R=jkarlin@chromium.org Signed-off-by:
zhuoyu.qian <zhuoyu.qian@samsung.com> Change-Id: I1cd75b0da724672ea0e746e749f47aa17e30e54d Reviewed-on: https://chromium-review.googlesource.com/753204Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#517386}
-
Benoit Lize authored
When enabled with the --log-native-library-residency command line switch, periodically collects native library residency, and dumps it to a file. process_residency.py then takes the output and creates a graph from it. This is used to assess the efficiency of the code ordering logic. Bug: 746665 Change-Id: I4a21ce4b9c01f8bb255f5997e665ff3dbdcf240a Reviewed-on: https://chromium-review.googlesource.com/756847 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517385}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/1eda27a65489..bb27c3a1483c $ git log 1eda27a65..bb27c3a14 --date=short --no-merges --format='%ad %ae %s' 2017-11-15 oetuaho Fix VectorizeVectorScalarArithmetic statement insertion Created with: roll-dep src/third_party/angle BUG=784078 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie7498bc51f6c405eaacbd683256699e1c946104e Reviewed-on: https://chromium-review.googlesource.com/776330Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium dce3b8ee. With Chromium commits locally applied on WPT: 23705631 "service worker: Upstream sandboxed iframe test to WPT." Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5375 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams mkwst@chromium.org: external/wpt/cookies TBR=qyearsley No-Export: true Change-Id: I06ee381f130c5fb50fcff030eabc2b2ed34c499f Reviewed-on: https://chromium-review.googlesource.com/776573 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517383}
-
Chris Cunningham authored
vp9 is ambiguous about important details like codec profile. vp09.... specifies the missing details. http://www.webmproject.org/vp9/mp4/#codecs-parameter-string Using the ambiguous vp9 string will cause the returned MediaCapabilitiesInfo to mark is_supported=false. The tests don't actually check this value, but we should use the right string to set a good example. Bug: 783153 Change-Id: I51a00c0ef3a3efedb70336894d3b17f786284156 Reviewed-on: https://chromium-review.googlesource.com/775903Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#517382}
-
Stefan Zager authored
The page zoom factor will propagate down to the LayoutView's style, and the scroll offset will be adjusted in LayoutBox::StyleDidChange. I'm not sure why the affected test isn't in FlagExpectations... BUG=711468 R=skobes@chromium.org,pdr@chromium.org TEST=cssom/elementfrompoint-scrolloffset.html Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I87c8fc3334244b17b41fd7e185822b0f35a763bd Reviewed-on: https://chromium-review.googlesource.com/775895Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#517381}
-
Mark Cogan authored
Deletes /ios/clean/ and references to it. Bug: 785925 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icbdd3a54657ebb3f54b3fb05b830bb803d46acb8 Reviewed-on: https://chromium-review.googlesource.com/774740Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#517380}
-
F#m authored
This patch uses stored historical data to associate touch devices and displays. Adds unittests for new functionality. Bug: 599985 Change-Id: I26e780d6a0c918d09e39600ad97f2e57d0601795 Component: ChromeOS, Touch, Display, Settings page, calibration Reviewed-on: https://chromium-review.googlesource.com/757023 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#517379}
-
Chandan Padhi authored
MediaStreamVideoCapturerSource unnecessarily inherits RenderFrameObserver and can be removed. This CL allows UserMediaProcessor to cache render_frame_id instead of RenderFrame. Bug: 742682 Change-Id: Ic27b9b8b5c8092a5b3031adbef5b9c0034171742 Reviewed-on: https://chromium-review.googlesource.com/776733Reviewed-by:
-
Sylvain Defresne authored
Convert RepostFormTabHelper to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Pass the WebState to the delegate instead of using the deprecated web_state() method. Bug: 775684 Change-Id: Ia8abfc6e8222adc47c7b90cb240bb1906683618e Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768723 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517377}
-
Vaclav Brozek authored
base::test::ios waiting helpers are deprecated and should be replaced with testing::WaitUntilConditionOrTimeout, which does not bring the whole test down with a DCHECK on failure. This CL migrates the tests in //ios/chrome/browser/{ui/settings|passwords} directories. It also adds a new waiting constant kWaitForActionTimeout (10 seconds), which is based on TestTimeouts::action_timeout() (currently 10 seconds). The latter was used as the default argument for the base::test::ios helpers which did not specify another timeout. Bug: 784735 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I84a528127eb061baefff799f6e467b72d6b1465a Reviewed-on: https://chromium-review.googlesource.com/774266 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: -
Sunny Sachanandani authored
This was disabled due to what looks like a telemetry issue at the time. In any case, disabling the entire benchmark is not compatible with the plan for merging all smoothness page sets. Local testing on Nexus 6 indicates that this benchmark is fine. R=nednguyen BUG=624032,760553 Change-Id: I6ab268ffbf0a8251844da0d7cdcf6841013356df Reviewed-on: https://chromium-review.googlesource.com/776215 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#517375}
-
zhuoyu.qian authored
As the comment in ReadableStreamController.h by tyoshino@, rename ReadableStreamController to ReadableStreamDefaultControllerWrapper, and related class. Rename the files also. BUG= R=tyoshino@chromium.org Signed-off-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#517374}
-
Ioana Pandele authored
PasswordStore::RemoveLogin passes the form through base::Bind which makes a copy, so this instance doesn't need to be kept around. Bug: 784788 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I47e02f82fa668b643d7d8c4a52907aa9b25aa404 Reviewed-on: https://chromium-review.googlesource.com/771550Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#517373}
-
Gauthier Ambard authored
ToolbarAssistiveKeyboardDelegate was implemented by the WebToolbarController. This CL moves the implementation to a separate object. It will allow the implementation to be moved to the omnibox folder once it is refactored. Bug: 784785 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I94c0fde654fe7b84332226f5d2d2827ade248651 Reviewed-on: https://chromium-review.googlesource.com/768735Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517372}
-
Peiyong Lin authored
Change-Id: Ib6ed31f5510bf577591e0277ca91f9d465274030 Reviewed-on: https://chromium-review.googlesource.com/776374Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#517371}
-
Christopher Cameron authored
This crashes the browser if the color profile that was specified at the command line does not match the color profile on the display. This is desirable for pixel tests because the pixel test output is subject to the operating system's color conversion, and will not be predictable or useful ness the operating system's color space is controlled for. Bug: 784456 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I15372cba6291bc764fe862ff6112a9f41d3ce929 Reviewed-on: https://chromium-review.googlesource.com/770131 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL enables the ContentSuggestions flag by default. The rollout is currently being done using finch and will reach 100% soon. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I52ace8c4240275abf75b1e8b16433cbccbc78d15 Reviewed-on: https://chromium-review.googlesource.com/754840Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
TBR=danakj@chromium.org Bug: 784563 Change-Id: I22a662b374b54a50f086fc2c7bcfce8a0c240e81 Reviewed-on: https://chromium-review.googlesource.com/776793 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
F#m authored
This patch allows external touch devices to be reassociated with different displays. To achieve this, the patch also updates the logic to record the calibration data points by applying the correct transform matrix to the event's locations. Bug: 599985 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic540cdb368d2d3bf26aa25fd6b0008e26e717211 Component: Touch, Calibration, Touch device manager, mash mus filters Reviewed-on: https://chromium-review.googlesource.com/749969 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517367}
-
