- 13 Feb, 2020 40 commits
-
-
Katie Dektar authored
This reverts commit 9a8afe6e. Reason for revert: Test is flaky, see crbug.com/1051546 Original change's description: > Enable SkiaCopyOutputScalingPixelTest > > The test should work with SkiaRenderer now. > > Bug: 1047217 > Change-Id: Ib467e836cf7abc3a8d00b606d81ed33470929db2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050616 > Reviewed-by: Jonathan Backer <backer@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740428} TBR=backer@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047217,1051546 Change-Id: I7184e18735d436edb404a0d9f342cef9830ce002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055283Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#741183}
-
Antonio Gomes authored
The message is not used. BUG=993189 R=kinuko@chromium.org Change-Id: Ib2d4e8842520381339ceadf0819a436459b17dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051190 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#741182}
-
Asanka Herath authored
The //cc:cc component was directly depending on //components/ukm. This is unnecessary since it really only needs to depend on //services/metrics/public/mojom which it was inheriting via public_deps. Having this unnecessary dependency causes the following dependency chain: - //third_party/blink/public:blink_headers --> - //cc:cc --> - //components/ukm:ukm --> - <<hypothetical component that wants to look at blink_headers>> --> - //third_party/blink/public:blink_headers. This relaxing the //cc to ///components/ukm dependency gives us more flexibility in adding a new dependency to //components/ukm where such a dependency itself is interested in blink_headers. Bug: None Change-Id: I71d19991b8068852cd06d31f79489012325980a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053148Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#741181}
-
Eric Orth authored
Original: crrev.com/c/2001144 Revert: crrev.com/c/2050749 Was reverted due to crashes where |ResolveContext::doh_server_availability_| size was not matching up with the number of DoH servers in the config in |current_session_|. Because the config is const in the session and |doh_server_availability_| is only and always set when setting |current_session_|, the most plausible theory I have is that the session pointer comparisons were invalid due to memory reuse (new session but incorrectly recognized as the old session because it has the same pointer). Protected the |current_session_| pointer from reuse via WeakPtr. Not ideal, but DnsSession ownership is already very loose with both ref counting and other WeakPtr instances. Also added a bunch of CHECK validations to help spot similar issues if this continues to or later crashes similarly. Bug: 1022059 Change-Id: Ibf030fa06882f02830bbaa13e45d9669815e9c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050758 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741180}
-
Matt Mueller authored
Bug: 1040681 Change-Id: Iefab63f598fecc3519065b0440815e2d65bb5070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036273Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#741179}
-
henrika authored
Adds support for: - Tracking stream creation sequence using unique ID. - Improves native logging related to usage of fake output streams. - "Stream is alive" marker. - Duration of stream. - Injects logger into PulseAudioOutputStream. - Improves native logs in AudioManagerBase. Example result: https://paste.googleplex.com/6677685310849024 Bug: 1017219 Change-Id: I9ae2d5a87a81e19de15faddfb1cd66250805eaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019243 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#741178}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e9ed65aa1904..9ee86e5a4697 git log e9ed65aa1904..9ee86e5a4697 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 ehmaldonado@google.com gerrit-util: Fix GCE check from behind proxy. Created with: gclient setdep -r src/third_party/depot_tools@9ee86e5a4697 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050380 Tbr: agable@chromium.org Change-Id: I38471ada322404d47d77a03a00e407c0c1d33ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741177}
-
Manu Cornet authored
The idea behind some of the recent refactorings is to split the logic for calculating target bounds and upating the layout to each shelf component instead of doing everything in the shelf layout manager. Previously, some (limited, soon more) work was delegated to the shelf widget's |UpdateLayout| method, but calling that method from the "central" place in the shelf layout manager was omitted. This change reinstates that call. Bug: 1051824, 1050383c Change-Id: Ibcf3bfd26210278ec464f186ae6a0a958f03d644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055392 Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741176}
-
David Bienvenu authored
The policy will allow enterprises who are concerned about the effect of native window occlusion in their environment to disable it easily. Bug: 813093 Change-Id: Ifef8af79652aba4e1433cc5d41585be866296ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032000 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#741175}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7db08fd9..0bee77f5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b67b6c1956a2ccbd35d4c796c22ffa13744c39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054565Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741174}
-
Natalie Chouinard authored
NfcSystemLevelSetting is not a shared class used by multiple Settings screens, so move it out of the org.chromium.chrome.browser.settings package to org.chromium.chrome.browser.nfc instead. Since the classes in org.chromium.chrome.browser.nfc are fairly trivial to modularize, organize and build to a separate target in //chrome/browser/nfc as part of go/chrome-hoa efforts. Bug: 1052056 Change-Id: Ia402340b05596ad880f16aef9521003658c1e2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032785 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741173}
-
Alex Cooper authored
Updates xr_browser_test infrastructure to appropriately grant (or deny) permissions, as well as providing tests with a way to override that. This ensures that tests will keep running when the permissions prompt is enabled by default and can be cleaned up as time permits. Additionally, refactors consent flow tests to a base class and two sub- classes. These sub classes can be used to explicitly test the custom consent flow or permissions prompt behavior. A (local) helper macro was created to indicate which of these tests should be run for both versions versus which tests were specific only to one or the other. To simplify this change (and because the permissions flow is runtime agnostic), consent flow tests are now run against only one runtime. Bug: 1043241 Change-Id: Ifb9040c46993f8b0375383426a4cafa7e342f6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055304 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741172}
-
Adrienne Walker authored
This is part of moving IndexedDB to live in the storage service. This API used by these unit tests needs to communicate over the IndexedDBControl interface instead of directly via IndexedDBContext. Bug: 1015214 Change-Id: Ida9d15282afe0946f14e1d4dc99573500b818769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048028 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741171}
-
Meilin Wang authored
This is a reland of 64cf44e2 Original change's description: > Add a new test case for |AssistantManagerServiceImpl|. > > This CL adds a new test case to ensure we update the supported action > list stored in |AssistantManagerServiceImpl| when ambient mode state has > changed. > > Bug: b/149237062 > Test: run the new unit test added in this change. > > Change-Id: Idc3c538e023cb59e76fb6c71219e4846da6d9c30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969777 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740817} Bug: b/149237062 Change-Id: I56f942df9293808a2411272022fe3cf3923096f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053287Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#741170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icdc972be1e6472b957592d49790108253c81a3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741169}
-
Evan Stade authored
This hooks up app-modal JS dialogs without adding any new APIs. Most functionality is "free" i.e. already componentized, including - alerts, prompts, and confirms (such as onbeforeunload) - anti-spam suppressions ("prevent this webpage..." checkbox) We will want to convert all except onBeforeUnload confirmations to tab-modal, but we'll still need app-modal for onBeforeUnload, so this is a reasonable stepping stone. TBR=twellington@chromium.org Bug: 1025256 Change-Id: I66575619dbfafcc0a575082c23f1e567568c29d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979154 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741168}
-
Shawn Gallea authored
This is no longer needed to reduce headless framerate. https://chromium-review.googlesource.com/c/chromium/src/+/1815049 is used instead. Test NONE Bug: NONE Change-Id: Iba114a91e6ca07a6383303b729cf5d5b415931db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055344 Commit-Queue: Shawn Gallea <sagallea@google.com> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741167}
-
Jose Lopes authored
The callback (init_cb_) is effectively called only once. This is guaranteed by the std::move(): https://cs.chromium.org/chromium/src/media/blink/multibuffer_data_source.cc?rcl=8d2d53d6df3c7347f9d4c32074540b990a8f1736&l=631 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I1ba81f8b281339cf514baa7f6739425bb9b9988c Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030962 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741166}
-
Alex Turner authored
Currently, the enabled flag is ignored for the AdTracker, which leads to some synchronous requests being erroneously reported as async. When the enabled flag is false, the task should not be reported to AdTracker. Bug: 1051519 Change-Id: Ia42ba7e6117ad2fc59cd95d41fcb8b1c5650a784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045176 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#741165}
-
Piotr Bialecki authored
The approach to performing hit test has changed, the new API that replaces the legacy one is already enabled by default in M81. https://immersive-web.github.io/hit-test/ Change-Id: Ia89921505ae4ed537c28b117808182efbc79396c Fixed: 1051626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050582Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741164}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a866d1f61a1..0715f3d5b5f1 Created with: gclient setdep -r src-internal@0715f3d5b5f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050954 Tbr: jbudorick@google.com Change-Id: I20e72ef4b6de9b6baebe76362957dd00ee3d54a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054984Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741163}
-
Marc Grimme authored
This reverts commit 8bc1fa58 because once again the PolicyDeviceDisplayResolution tests are flaky. The root cause needs to be investiated a tracking bug is filed #1051982. R=marcgrimme Bug: 1050303 Change-Id: Icd1cdb3f29dbb2fb78cea769c7fa36906405f7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054803Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Cr-Commit-Position: refs/heads/master@{#741162}
-
Etienne Bergeron authored
Plumb the code to get an experiment for studying the best ShapeRuns cache size. The entries of these cache are part of the top allocations in chrome browser process (based on memlog reports). Bug: 1050793 Change-Id: I51ca6aebfe6c8ae3881eb3c03a56b4d472216ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051976 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#741161}
-
Sebastien authored
Bug: 1029328 Change-Id: I4edcabad6ee26e34d9039c35f8ee4a38720b0210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942807 Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#741160}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e82ab75a4ca8..b79b57e047bb git log e82ab75a4ca8..b79b57e047bb --date=short --first-parent --format='%ad %ae %s' 2020-02-13 lexa.knyazev@gmail.com Vulkan: expose ANGLE_compressed_texture_etc Created with: gclient setdep -r src/third_party/angle@b79b57e047bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ibd939ff1eeb295f7cc793fec86d58084a05839dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741159}
-
Sonny Rao authored
The test assumes both Active and Inactive file and Anon fields will both be non-zero but this may not be the case. We see this especially when running kstaled on CrOS. Bug: 1048073 Change-Id: I7532d92f4cd69718aab01d263992b20054a621e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042544Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Sonny Rao <sonnyrao@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#741158}
-
John Chen authored
Currently run_py_tests.py shows test descriptions as part of its output. These descriptions are not useful while reviewing test results, and clutter the output. Modify settings to not show these descriptions. TBR=crouleau@chromium.org Change-Id: Ibb0c621aa33d18dd02e565281094a02a5d6914ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053112Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741157}
-
Dave Tapuska authored
Use gfx::RectF types natively and avoid using WebFloatRect. Change-Id: I750d75718465bcd44cfaee10cd5239cf38e9d0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051582 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741156}
-
Emircan Uysaler authored
This CL adds a new state to ScenicWindow that checks if the view is attached to a rendered scene graph. Bug: 1044802 Change-Id: Ieeb98a2bbe4d214fed302d60360dd77f0b702838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015675 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741155}
-
Victor Costan authored
This reverts commit 93682cb5. Reason for revert: The feature crashes on Windows -- https://crbug.com/1052041 Original change's description: > AppCache: Enable correct 304 handling by default. > > We'll monitor the fix as it goes through the Chrome release waterfall, > instead of doing a Finch-based trial. This frees us from having to > reason about enterprises that may disable Finch. > > Bug: 989611 > Change-Id: I50389c12d31f63fa6257d879f3d840ffde2cb27e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052245 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Commit-Queue: Chase Phillips <cmp@chromium.org> > Auto-Submit: Victor Costan <pwnall@chromium.org> > Reviewed-by: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740894} TBR=cmp@chromium.org,pwnall@chromium.org Change-Id: Ieeb9be42038ba56e176b0ba6a7ab0c84629fea1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055007Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741154}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0fd93555a59a..fbbf981a3401 git log 0fd93555a59a..fbbf981a3401 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tvanderlippe@chromium.org Migrate sources/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate main/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate css_overview/ to import cross-module 2020-02-13 khamu@microsoft.com Add high contrast styles for Memory tools panel. 2020-02-13 khamu@microsoft.com Add high contrast fix in Performance tools panel. Created with: gclient setdep -r src/third_party/devtools-frontend/src@fbbf981a3401 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6b38e27f8aded82a4509ab93a98054d866c2bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741153}
-
Maks Orlovich authored
This is basically Aaron Tagliaboschi's: https://chromium-review.googlesource.com/c/chromium/src/+/2012902 just with a bit of additional updated of tests. See https://github.com/WICG/ua-client-hints/issues/15 for rationale. Change-Id: I6562cf1a78ceb4eff18baf793cb89143782f9b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047410 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#741152}
-
Khushal authored
This reverts commit 16fc868a. Reason for revert: crbug.com/1051940 Original change's description: > canvas2d: Fix canvas resource thrashing with an intermediate canvas. > > If a canvas is used as an intermediate for drawing to the displayed > canvas multiple times in a frame, then a ref to its backing texture is > retained in the displayed canvas' paint recording. This triggers a > copy-on-write and a buffer allocation each time this intermediate canvas > is updated for a new draw. > > The above allocation can be avoided by ordering the GPU work > to write to and read from the intermediate canvas' buffer correctly and > reuse the buffer for each update to this intermediate canvas. > CanvasResourceProviderSharedImage did this optimization earlier by > flushing skia prior to triggering a copy-on-write. But after disabling > deferral for texture backed images, the draw for that texture is never > flushed to skia until the displayed canvas' paint recording is flushed. > > This change brings back the optimization by flushing a canvas' recording > each time a texture backed image is drawn to it. > > R=fserb@chromium.org, bsalomon@google.com > > Bug: 1030108 > Change-Id: Id46fa8399f64a4c724c9f51e5cb4927b7e97d747 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040028 > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Commit-Queue: Fernando Serboncini <fserb@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740005} TBR=bsalomon@google.com,fserb@chromium.org,khushalsagar@chromium.org,aaronhk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1030108 Change-Id: I7931a623c4c16dada7dc56f1c78f88aee8da4d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054271Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741151}
-
John Z Wu authored
Bug: 1048231 Change-Id: I34eaf7227400136fea1bfc70f7d5c48fa8498bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048287 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#741150}
-
Mohamed Amir Yosef authored
Bug: 1044038 Change-Id: I4857b10121e2c8dba95f1d5b58f57a0874294c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053884 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741149}
-
Jeffrey Kardatzke authored
This fixes a DCHECK that would occur if Initialize failed because then in CreateWithOutputMode it would let the unique_ptr for the image_processor fall out of scope and become deallocated; and we have a sequence checker to ensure deallocation only happens on the task runner. I would have used DeleteSoon, but that didn't seem possible because the destructor was not public. BUG=1050852 TEST=image_processor_test no longer DCHECKs on elm w/ 4.19 kernel Change-Id: Ifae96c3a4206d8e94b7fdd6dd3e2ec571cc3465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051162Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741148}
-
David Schinazi authored
The following users no longer work on Chrome Networking: rch@ jri@ ckrasic@ bnc@. Change-Id: If828d3be1200ca6bba367f6a71871b71b7998213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053143 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741147}
-
John Chen authored
While build for android, ChromeDriver can be built using host toolchain. Bug: 1050709 Change-Id: Ifc7b97f4474e73e3025ec33450bdfd29559ba087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050872Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741146}
-
Min Qin authored
Chrome cannot open zip files. As a result, directing users to the download Home won't help. This CL will check if Files app are present on the device, and then open the files app if no other apps register as the default handler for zip file. BUG=1050632 Change-Id: I052012113c2d38d52c37088839d75af5b206443d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052570Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741145}
-
Manu Cornet authored
Change-Id: Idae5f3fec0e8fbcbf1dbff9a3982e0a90b64d900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053249 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741144}
-