Commits · b66dce51fef1df008a0c608707e06900f367a490 · eriksson monteiro / tangled

24 Apr, 2018 40 commits

Update ownership semantics for TabStripModel::AppendWebContents · b66dce51

erikchen authored Apr 24, 2018

This CL is a refactor with no intended behavior change.

This CL updates TabStripModel::AppendWebContents to take a std::unique_ptr
rather than a raw pointer.

Change-Id: Ie04a8bc9299108d65449a765e5cffaebf9ca91ff
Bug: 832879
Reviewed-on: https://chromium-review.googlesource.com/1024296Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553245}

b66dce51

Add UMA histogram for power button events. · 625a4b72

Min Chen authored Apr 24, 2018

Power.PowerButtonPressInLaptopMode for press power button in laptop mode.
Power.PowerButtonPressInTabletMode for press power button in tablet mode.

Bug: 796315
Change-Id: Ibeaebbc39d3d5186552bd2a4f988d0e0144fc84c
Reviewed-on: https://chromium-review.googlesource.com/1022492Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553244}

625a4b72

NavigationMojoResponse: Remove the old code path [3/4] · 1645d4da

arthursonzogni authored Apr 24, 2018

Remove the IsNavigationMojoResponseEnabled() function and every mention
of "NavigationMojoResponse" in the code.

Other CLs:
  1) https://chromium-review.googlesource.com/c/chromium/src/+/1015005
  2) https://chromium-review.googlesource.com/c/chromium/src/+/1021631
* 3) https://chromium-review.googlesource.com/c/chromium/src/+/1022790
  4) https://chromium-review.googlesource.com/c/chromium/src/+/1024038

Bug: 705744
Change-Id: Ia755a96901d08819d0b10417965e292821415c44
Reviewed-on: https://chromium-review.googlesource.com/1022790
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553243}

1645d4da

Add new gsubmodd builders to luci-milo config. · 842c70b2

Alan Bram authored Apr 24, 2018

Change-Id: If02c85c71b0092eeb631dcbe9aefb765a67d5752
Reviewed-on: https://chromium-review.googlesource.com/1025327Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553242}

842c70b2

Revert "Disable NotificationImageReporterTest." · c2aa9081

Findit authored Apr 24, 2018

This reverts commit da17415d.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 553230 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RhMTc0MTVkMTg4ODRmYjQ3NDUxYmIyN2ZjOWYzMDg3ZmRiMzc5MTUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder/101940

Sample Failed Step: compile

Original change's description:
> Disable NotificationImageReporterTest.
> 
> Its use of feature flags causes data races.
> 
> BUG=836359
> TBR=xidachen@chromium.org
> NOTRY=true
> 
> Change-Id: I5bc92a6fc9b9010b9863b363dc3033b95f777762
> Reviewed-on: https://chromium-review.googlesource.com/1026462
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553230}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=836359

Change-Id: I748cc7ee9c5dd97a74d10dfdd77161966cff86b8
Reviewed-on: https://chromium-review.googlesource.com/1026433
Cr-Commit-Position: refs/heads/master@{#553241}

c2aa9081

Reland "Reland "Remove HttpStreamFactory interface."" · 9bfe0b6b

Xida Chen authored Apr 24, 2018

This reverts commit 7f7c86d8.

Reason for revert: <INSERT REASONING HERE>
Causing compile error:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/10534

Original change's description:
> Revert "Reland "Remove HttpStreamFactory interface.""
> 
> This reverts commit ea3e3f22.
> 
> Reason for revert: Failure at
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554
> 
> Original change's description:
> > Reland "Remove HttpStreamFactory interface."
> >
> > Reland https://crrev.com/c/1000487.
> >
> > Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> > to
> > HttpStreamFactory.
> >
> > Bug: 829429
> > Change-Id: I298879817785174d1d7290520f889f0252074e14
> > Reviewed-on: https://chromium-review.googlesource.com/1023321
> > Commit-Queue: Bence Béky <bnc@chromium.org>
> > Reviewed-by: Ryan Hamilton <rch@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553180}
> 
> TBR=rch@chromium.org,bnc@chromium.org
> 
> Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 829429
> Reviewed-on: https://chromium-review.googlesource.com/1026491
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Bence Béky <bnc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553233}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: I1a33380942c2fc0d3aed903a4a505f0615e24f8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829429
Reviewed-on: https://chromium-review.googlesource.com/1026492Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553240}

9bfe0b6b

Revert "Reland "Reland "Remove HttpStreamFactory interface.""" · f860bdc8

Xida Chen authored Apr 24, 2018

This reverts commit 4aa787aa.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Reland "Remove HttpStreamFactory interface.""
> 
> This reverts commit 7f7c86d8.
> 
> Reason for revert: <INSERT REASONING HERE>
> Causing compile error here:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/10534
> 
> Original change's description:
> > Revert "Reland "Remove HttpStreamFactory interface.""
> > 
> > This reverts commit ea3e3f22.
> > 
> > Reason for revert: Failure at
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554
> > 
> > Original change's description:
> > > Reland "Remove HttpStreamFactory interface."
> > >
> > > Reland https://crrev.com/c/1000487.
> > >
> > > Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> > > to
> > > HttpStreamFactory.
> > >
> > > Bug: 829429
> > > Change-Id: I298879817785174d1d7290520f889f0252074e14
> > > Reviewed-on: https://chromium-review.googlesource.com/1023321
> > > Commit-Queue: Bence Béky <bnc@chromium.org>
> > > Reviewed-by: Ryan Hamilton <rch@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#553180}
> > 
> > TBR=rch@chromium.org,bnc@chromium.org
> > 
> > Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 829429
> > Reviewed-on: https://chromium-review.googlesource.com/1026491
> > Commit-Queue: Bence Béky <bnc@chromium.org>
> > Reviewed-by: Bence Béky <bnc@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553233}
> 
> TBR=rch@chromium.org,bnc@chromium.org
> 
> Change-Id: I55ada6185c0a923d0c87b5986c15d1fc5f06d461
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 829429
> Reviewed-on: https://chromium-review.googlesource.com/1026530
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553238}

TBR=rch@chromium.org,bnc@chromium.org,xidachen@chromium.org

Change-Id: Ic8ecc1e9d34d964d4b825863ef1b725f4e48ad90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829429
Reviewed-on: https://chromium-review.googlesource.com/1026531Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553239}

f860bdc8

Reland "Reland "Remove HttpStreamFactory interface."" · 4aa787aa

Xida Chen authored Apr 24, 2018

This reverts commit 7f7c86d8.

Reason for revert: <INSERT REASONING HERE>
Causing compile error here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/10534

Original change's description:
> Revert "Reland "Remove HttpStreamFactory interface.""
> 
> This reverts commit ea3e3f22.
> 
> Reason for revert: Failure at
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554
> 
> Original change's description:
> > Reland "Remove HttpStreamFactory interface."
> >
> > Reland https://crrev.com/c/1000487.
> >
> > Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> > to
> > HttpStreamFactory.
> >
> > Bug: 829429
> > Change-Id: I298879817785174d1d7290520f889f0252074e14
> > Reviewed-on: https://chromium-review.googlesource.com/1023321
> > Commit-Queue: Bence Béky <bnc@chromium.org>
> > Reviewed-by: Ryan Hamilton <rch@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553180}
> 
> TBR=rch@chromium.org,bnc@chromium.org
> 
> Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 829429
> Reviewed-on: https://chromium-review.googlesource.com/1026491
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Bence Béky <bnc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553233}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: I55ada6185c0a923d0c87b5986c15d1fc5f06d461
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829429
Reviewed-on: https://chromium-review.googlesource.com/1026530Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553238}

4aa787aa

libvpx: force Chromium formatting · 334710bd

Johann authored Apr 24, 2018

Depending on who runs generate_gni.sh we get different
formatting from clang-format. Force it to -style=Chromium

Change-Id: Iee48618ee7e43ae956d3a65e5b08a6babc14c83e
Reviewed-on: https://chromium-review.googlesource.com/1024436Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#553237}

334710bd

Add UMA for DXVA PictureBufferMechanism. · ddaa30b6

liberato@chromium.org authored Apr 24, 2018

To help us figure out how to prioritize the various picture buffer
types in the new D3D11VideoDecoder, this UMA records how often
each is used in the DXVA VDA.

Bug: 835972
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I39b41000b54b932ce8cc592893bef1826f458308
Reviewed-on: https://chromium-review.googlesource.com/1024927Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553236}

ddaa30b6

cros: Fix login crash under mash due to multiple ash instances · bab49a45

James Cook authored Apr 24, 2018

The ash service was being started twice because it was not marked as
a "singleton" service. Service connections with different user ids
could result in the service starting twice in the same process.

This caused CHECK failures in bluez::BluezDBusManager::Initialize
and desktopui_MashLogin to fail in the autotest lab.

Fix by marking the ash and ui services as singlton services, which
they should have been in the first place.

Bug: 836311
Test: existing autotest desktopui_MashLogin
Change-Id: I066692b19bb5d89c75e46c79675024740f42f844
Reviewed-on: https://chromium-review.googlesource.com/1026202Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553235}

bab49a45

Initial work on MD Refresh new tab button position. · d42019b1

Peter Kasting authored Apr 24, 2018

Does not implement padding in spec.

BUG=822063
TEST=none

Change-Id: Ifcbcb1f7b6e4385a6c0318624d95e6201b5d5a4a
Reviewed-on: https://chromium-review.googlesource.com/1024666Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553234}

d42019b1

Revert "Reland "Remove HttpStreamFactory interface."" · 7f7c86d8

Bence Béky authored Apr 24, 2018

This reverts commit ea3e3f22.

Reason for revert: Failure at
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554

Original change's description:
> Reland "Remove HttpStreamFactory interface."
>
> Reland https://crrev.com/c/1000487.
>
> Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> to
> HttpStreamFactory.
>
> Bug: 829429
> Change-Id: I298879817785174d1d7290520f889f0252074e14
> Reviewed-on: https://chromium-review.googlesource.com/1023321
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553180}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829429
Reviewed-on: https://chromium-review.googlesource.com/1026491
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553233}

7f7c86d8

Roll src/third_party/angle/ 66410530a..33e05babb (1 commit) · cc257bd4

angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com authored Apr 24, 2018

https://chromium.googlesource.com/angle/angle.git/+log/66410530a78d..33e05babbc69

$ git log 66410530a..33e05babb --date=short --no-merges --format='%ad %ae %s'
2018-04-23 lucferron Vulkan: Bugfix in TextureVk::setSubImage and DynamicBuffer

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Iea27bf44c60456866d2e3d0e666c38f6db73af25
Reviewed-on: https://chromium-review.googlesource.com/1024598Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553232}

cc257bd4

Update V8 to version 6.8.64. · 4f845963

v8-autoroll authored Apr 24, 2018

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8fecf0ef..034c66d8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ib1166868b004c6767f8e8db66b692ce975691d4a
Reviewed-on: https://chromium-review.googlesource.com/1026056Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553231}

4f845963

Disable NotificationImageReporterTest. · da17415d

Lei Zhang authored Apr 24, 2018

Its use of feature flags causes data races.

BUG=836359
TBR=xidachen@chromium.org
NOTRY=true

Change-Id: I5bc92a6fc9b9010b9863b363dc3033b95f777762
Reviewed-on: https://chromium-review.googlesource.com/1026462Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553230}

da17415d

Reland "[cr-buildbucket] Clear 'cores' dimension for ios-* builders." · d4f651d0

Sergey Berezin authored Apr 24, 2018

This is a reland of be5a2a38

TBR=vadimsh@chromium.org, nodir@chromium.org, sergeyberezin@chromium.org

Original change's description:
> [cr-buildbucket] Clear 'cores' dimension for ios-* builders.
>
> ios-* builders may run on a mix of VMs with cores:8 and Mac Mini's with cores:4.
>
> Bug: 731546
> Change-Id: I056fbb5bd80ca50ef8005aa8bb99643853acd923
> Reviewed-on: https://chromium-review.googlesource.com/1024729
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553160}

Bug: 731546
Change-Id: I97848d9fccbc3c4d527d9a205150c7f6ffd920dd
Reviewed-on: https://chromium-review.googlesource.com/1025183Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553229}

d4f651d0

DevTools: add runtime experiment for prompt · cc91acb0

Erik Luo authored Apr 24, 2018

Bug: 810176
Change-Id: Ic78c5e6ef5557067679f3f4ed2dcf6b76f1ee8e2
Reviewed-on: https://chromium-review.googlesource.com/1014348
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553228}

cc91acb0

Remove cco3 from WATCHLISTS · d744e398

Conley Owens authored Apr 24, 2018

Change-Id: I77a57afaa10c8b5e8306c96f375c8f644e876d13
Reviewed-on: https://chromium-review.googlesource.com/1026095Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553227}

d744e398

[Extensions] Update SandboxedUnpackerTests to manifest v2 · 1de93897

Devlin Cronin authored Apr 24, 2018

Update SandboxedUnpackerTests to manifest v2 and remove the allowance
for manifest v1 extensions.

Repackage all the crx's used in the sandboxed unpacker tests.

Additionally, git doesn't allow empty directories to be added to the
repository, which appears to have caused problems with some of the
unpacked versions of these extensions (where the empty directory is
necessary for the test). Add the missing directories, and put in a
dummy readme file to appease git.

Bug: 816679
Change-Id: I7130bbe89079437b8ee9090ba120039e2dbe9672
Reviewed-on: https://chromium-review.googlesource.com/1024910Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553226}

1de93897

[FileAPI] Put a (pretty arbitrary) cap on the size of a blob mimetype. · 5be4d4f3

Marijn Kruisselbrink authored Apr 24, 2018

Unbounded mime-types result in the renderer getting killed because it is
trying to send a too large mojo message. Sensible mimetypes shouldn't be
very large anyway, so arbitrarily capping the mimetype at 64K is a
reasonable work around.

Bug: 835753
Change-Id: Idf91a27976f41b8cc07662a82f33d45a355c14f8
Reviewed-on: https://chromium-review.googlesource.com/1026201
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553225}

5be4d4f3

Fix DCHECK when setting transform-box style to 'border-box'. · 010c0cc3

Stephen McGruer authored Apr 24, 2018

This is an invalid value for the property, but had been incorrectly left
in the CSS parser fast-path code as allowed.

Bug: 816534
Change-Id: Ic787508d21b3f385a37e5c4d50989c69d8dd48ac
Reviewed-on: https://chromium-review.googlesource.com/1024775
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553224}

010c0cc3

Add tests for proxy fallback logic on ERR_MSG_TOO_BIG · bef17741

Helen Li authored Apr 24, 2018

The fallback logic is different for quic and non-quic proxies on
ERR_MSG_TOO_BIG. This CL adds test coverage for this error code.

Bug: 826570
Change-Id: Ied1470a878ddf3c6fabee1fe7170894a4de02f40
Reviewed-on: https://chromium-review.googlesource.com/1026050
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553223}

bef17741

[PE]: Update comments to reflect new blink directory structure. · bdf52086

Vladimir Levin authored Apr 24, 2018

R=chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia8a8ea56dadcdba09eef12ee7ee9a6ca6459cef8
Reviewed-on: https://chromium-review.googlesource.com/1025224Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553222}

bdf52086

Disable TabCaptureApiTest.GrantForChromePages · 493abc9c

Lei Zhang authored Apr 24, 2018

The test is flaky on all platforms.

BUG=294431
TBR=miu@chromium.org
NOTRY=true

Change-Id: Ifc4b0e8fef5b80bf02670f338987b322d388b666
Reviewed-on: https://chromium-review.googlesource.com/1026377Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553221}

493abc9c

[Extensions] Update ComponentLoaderTests to manifest v2 · dae58f92

Devlin Cronin authored Apr 24, 2018

ComponentLoaderTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679

Change-Id: Ic35a4f11840ea2194b16f93eb541aa62e8cd7361
Reviewed-on: https://chromium-review.googlesource.com/1025134Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553220}

dae58f92

[Eoc] Validate URLs before fetching suggestion · 22ec18cd

Patrick Noland authored Apr 24, 2018

Bug:835367

Change-Id: I21286271fb01e0737481a725d4d2d8a207a22ab7
Reviewed-on: https://chromium-review.googlesource.com/1017883
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553219}

22ec18cd

Add AudioParam.automationRate to WebAudio IDL · 63cd4dfa

Raymond Toy authored Apr 24, 2018

Update WebAudio interface to include the very recently added
automationRate attribute for an AudioParam.

Also remove idlharness time expectation (suggested by Robert Ma).

And this doesn't actually resolve any of failures in the bug, but
it's a convenient place to update the IDL that should have been
done earlier.

Bug: 836051
Test: webaudio/idlharness.https.html
Change-Id: Icd535ee63f0a5f8772cb3445c762c89154fbda88
Reviewed-on: https://chromium-review.googlesource.com/1026199Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553218}

63cd4dfa

Reland "Use user preferences for TTS speech rate, pitch and volume if not set." · 8236c3a3

Katie D authored Apr 24, 2018

This reverts commit 48d140d3.

Original reason for revert: New tests have memory leaks:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27171

Original change description:
Use user preferences for TTS speech rate, pitch and volume if not set.

TBR=thakis@chromium.org,dtseng@chromium.org,jochen@chromium.org,thestig@chromium.org

Bug: 823359
Change-Id: I2e8ac4995a1bd84533cc8f7be3bae4a1f5fcaad7
Reviewed-on: https://chromium-review.googlesource.com/1026087Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553217}

8236c3a3

Convert json_parser.mojom to use mojo/public/mojom/base/values.mojom · 23783373

Oksana Zhuravlova authored Apr 24, 2018

This change also converts the minimum necessary amount of C++ code to pass
objects of base::Value by value instead of std::unique_ptr.

This change also modifies the union condition of DataView template to add
a check for is_null and pass a nullptr to Deserialize so that optional
values are handled correctly.

Bug: 646113,799482
Change-Id: I09575f4e593741370b537ede8103a3c3b196dfc7
Reviewed-on: https://chromium-review.googlesource.com/1011206Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553216}

23783373

Detect application/octet-stream type for intent with MHTML file URL · 4e5405f4

Jian Li authored Apr 24, 2018

"application/octet-stream" type may be passed by some apps that do
not know about MHTML file types. So when we check if an intent is
to open MHTML file, we allow this type and let the following file
extension check to find out if the file URL is for MHTML file.

Bug: 831767
Change-Id: Ide23ebbfd4a4fd9d47e8a06003ea2cd66338a354
Reviewed-on: https://chromium-review.googlesource.com/1024506
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553215}

4e5405f4

[Omnibox] fix typo on kMDDarkControlBackround · 08514d6d

Dave Schuyler authored Apr 24, 2018

This is just an isolated typo. No logic changes.

TBR=ellyjones@chromium.org

Bug: None
Change-Id: Idac88730e63ed07cca46063045495702368945aa
Reviewed-on: https://chromium-review.googlesource.com/1025228Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553214}

08514d6d

[LUCI] Quick fix. · 69265c37

Zhiling Huang authored Apr 24, 2018

TBR=hzl@chromium.org

Bug: 790520
Change-Id: I92f8b2e00a9062e6a271cf3a94231ab82d78a6d4
Reviewed-on: https://chromium-review.googlesource.com/1026135Reviewed-by: Zhiling Huang <hzl@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553213}

69265c37

Add button mappings for Nintendo Switch Pro Controller. · e5d76c1d

Andrew Weintraub authored Apr 24, 2018

Bug: 836235
Change-Id: Ieef527eb62e8d1184e91c77cfd60bc7fcf01bc56
Reviewed-on: https://chromium-review.googlesource.com/1025639Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Andrew Weintraub <asweintraub@google.com>
Cr-Commit-Position: refs/heads/master@{#553212}

e5d76c1d

[Code Coverage] Add support for component build + update documentation. · d73e45fd

Max Moroz authored Apr 24, 2018

Bug: 831939
Change-Id: I2804796894045dc69aa8309aa3ab34e6c80b38d7
Reviewed-on: https://chromium-review.googlesource.com/1010464
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553211}

d73e45fd

fsamuel@ taking OWNERship of small bits of content/renderer for surface synchronization · 17f4edd8

Fady Samuel authored Apr 24, 2018

Surface synchronization code is plumbed through RenderWidget, RenderViewImpl (because it
currently is a RenderWidget) and RenderFrameProxy (and the ChildFrameCompositor interface).

I'd like to take OWNERship of those files in order to expedite work on child allocated
LocalSurfaceIds for navigation (should improve time to contentful paint metric) and
to add Android top-bar synchronization and text selection handle synchronization support.

Change-Id: Ida8816c495ca64e326ee09f4e5d648f8dcac15b1
Reviewed-on: https://chromium-review.googlesource.com/1026212Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553210}

17f4edd8

Disable DeleteActiveSession on Win · 463bf383

Xida Chen authored Apr 24, 2018

In my previous attemp to disable this here:
https://chromium-review.googlesource.com/c/chromium/src/+/1026155, there
was a typo and causes compile failure. I have a full build with this CL
and it works fine.

TBR=thestig@chromium.org
NOTRY=true

Bug: 836289
Change-Id: I92df34158b417b87adf48e9b8460d10171594a3e
Reviewed-on: https://chromium-review.googlesource.com/1024603
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553209}

463bf383

Chrome OS: Implement UI for first login Recommend Apps screen. · 46eca389

Yue Cen authored Apr 24, 2018

This only contains the UI skeleton.

Bug: 835029
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I98f22b71dd3ab0a51e2f13ab96c54a011897a15d
Reviewed-on: https://chromium-review.googlesource.com/1016083
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553208}

46eca389

Add name of histogram with mismatched params. · 8e2f297b

Brian White authored Apr 24, 2018

Bug: 836238
Change-Id: Ibec5500a6d9348a30009d3d6d97a51c38a8e64ef
Reviewed-on: https://chromium-review.googlesource.com/1026051Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553207}

8e2f297b

Migrate MessageLoop::current() to MessageLoopCurrent in /components/safe_browsing · d493f211

Gabriel Charette authored Apr 24, 2018

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=vakh@chromium.org

Bug: 825327
Change-Id: Ic8c07068f4f567da6191716241a39fb3a68e6647
Reviewed-on: https://chromium-review.googlesource.com/1024318
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553206}

d493f211