GitLab

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/555163004

Cr-Commit-Position: refs/heads/master@{#294632}

In preparation for moving webrequest_action, webrequest_rules_registry,
we need to move this dependency.

BUG=352293

Review URL: https://codereview.chromium.org/565273002

Cr-Commit-Position: refs/heads/master@{#294631}

Revert of Gardening: Revert "Use AudioStreamMonitor to control power save blocking." (patchset #1 id:1 of https://codereview.chromium.org/562863002/)

Reason for revert:
Bugs should be fixed now... will CQ this revert.

Original issue's description:
> Gardening: Revert "Use AudioStreamMonitor to control power save blocking."
>
> This reverts commit 484d29dc.
>
> This patch made media/media-controller-playbackrate.html test crash on DEBUG.
>
> it crashes at content/browser/web_contents/web_contents_impl.cc:4296 on DCHECK
> Looks like AddMediaPlayerEntry was called twice for the same player_cookie
>
> It is not clear how it happens due to async nature of the notification.
> The author is sleeping at the moment, so I decided to roll back the patch.
>
> BUG=
> TBR=dalecurtis@chromium.org
>
> Committed: https://crrev.com/0381a74131887eb13b5d457cce756fb7066411ea
> Cr-Commit-Position: refs/heads/master@{#294370}

TBR=loislo@chromium.org,jam@chromium.org,miu@chromium.org,scherkus@chromium.org
BUG=43667, 367785

Review URL: https://codereview.chromium.org/569713002

Cr-Commit-Position: refs/heads/master@{#294630}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/563553005

Cr-Commit-Position: refs/heads/master@{#294629}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/561903002

Cr-Commit-Position: refs/heads/master@{#294628}

They don't need to run in Chrome's unit_tests suite any more.

The tests that depend on Chrome's version channel information move to
ChromeChannelFeatureFilterTest.

BUG=413319,397165
TEST=unit_tests ChromeChannelFeatureFilterTest.* and extensions_unittests

Review URL: https://codereview.chromium.org/563923004

Cr-Commit-Position: refs/heads/master@{#294627}

BUG=412875
TEST=WindowEventDispatcherTest.GestureEventCoordinates

Review URL: https://codereview.chromium.org/564923003

Cr-Commit-Position: refs/heads/master@{#294626}

Fixes windows component error since we use SkMatrix in DrawViewTree.

BUG=413727

Review URL: https://codereview.chromium.org/566933003

Cr-Commit-Position: refs/heads/master@{#294625}

The change decouples input device hotplug event processing from output device
hotplug processing. In addition, for input device event processing, it takes
advantage of the X11 caches in ui/events and simplifies how hotplug events are
propagated to the system.

Depends on https://codereview.chromium.org/508303002/

BUG=381326

Review URL: https://codereview.chromium.org/336863002

Cr-Commit-Position: refs/heads/master@{#294624}

Extension actions that are dragged out of the overflow menu should not force
another inside; rather they should "pop out" and cause the container to grow.
Analogously, actions dragged in should reduce the size of the container.

BUG=411394

Review URL: https://codereview.chromium.org/550313002

Cr-Commit-Position: refs/heads/master@{#294623}

TBR=loislo
BUG=

Review URL: https://codereview.chromium.org/563273002

Cr-Commit-Position: refs/heads/master@{#294622}

BUG=403645

Review URL: https://codereview.chromium.org/467263006

Cr-Commit-Position: refs/heads/master@{#294621}

This CL removes most usages of the guava library.

TBR=thakis@chromium.org,brettw@chromium.org,yfriedman@chromium.org
BUG=412673

Review URL: https://codereview.chromium.org/565743002

Cr-Commit-Position: refs/heads/master@{#294620}

This reverts commit aefdf297.

There was a logic bug.

BUG=408911
TBR= bruening

Review URL: https://codereview.chromium.org/567793002

Cr-Commit-Position: refs/heads/master@{#294619}

Revert of Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*. (patchset #4 id:60001 of https://codereview.chromium.org/548323003/)

Reason for revert:
Breaks compile on multiple bots:

http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/3134
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/73424
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Win%20Builder%20%28dbg%29/builds/13365

Original issue's description:
> Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*.
>
> BUG=398856
> TEST=existing browser_tests and unit_tests
> R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c

TBR=jochen@chromium.org,erg@chromium.org,nkostylev@chromium.org,pastarmovj@chromium.org,ygorshenin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398856

Review URL: https://codereview.chromium.org/565293003

Cr-Commit-Position: refs/heads/master@{#294618}

BUG=

Review URL: https://codereview.chromium.org/557513002

Cr-Commit-Position: refs/heads/master@{#294617}

Make sure this flag can be used for out of sandbox plugin setup.

BUG=

Review URL: https://codereview.chromium.org/562073002

Cr-Commit-Position: refs/heads/master@{#294616}

https://skia.googlesource.com/skia/+log/1f777e8580a67f2f975151bc414a1695696aa635..83658305a1bda2d862f50145ecf5cb697b575e86

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/564133002

Cr-Commit-Position: refs/heads/master@{#294615}

Maintain the current hash associated each Page's state and use that rather than
querying location.hash directly. This fixes several long-standing issues with
the settings search page and the back/forward list:

- Opening an overlay from a search page no longer keeps the fragment in the
  URL.
- Closing an overlay no longer loses the search in the URL.
- Navigating back from one search page to another actually works.
- Navigating back from the search page doesn't clear the search box.

Add tests for this behavior.

BUG=410204

Review URL: https://codereview.chromium.org/555163007

Cr-Commit-Position: refs/heads/master@{#294614}

This binds mojo's html_viewer to a compositor implementation that uses surfaces
to present. It reuses the bindings for the WebLayer* types in cc/blink and adds
a new implementation of blink::WebLayerTreeView that shares some things with
content/renderer/gpu/render_widget_compositor.cc but is distinct enough to be
its own class. Whenever the compositor resizes (and thus needs a new surface id)
it passes the surface id to the view manager client lib.

This also adds mojo bindings for a few new quad types that are used on the web.
We don't yet have support for video quad types, but we don't have the media
system hooked up to html_viewer yet either so these will not be generated.

Committed: https://crrev.com/2abb46fdc18d2110b443a9e570ea393e3b0a42c5
Cr-Commit-Position: refs/heads/master@{#294546}

Review URL: https://codereview.chromium.org/558343004

Cr-Commit-Position: refs/heads/master@{#294613}

This CL includes the following changes:
1. Reduces the interval of media time update msg to 16 ms
2. Use interpolation to calculate the current playback time, and guarantee that time is always incrementing

BUG=327425

Review URL: https://codereview.chromium.org/545993002

Cr-Commit-Position: refs/heads/master@{#294612}

Revert of Generalize scroll parent work in CalculateDrawProperties (patchset #6 id:160001 of https://codereview.chromium.org/548963002/)

Reason for revert:
This patch seems to be exposing some bugs. They bugs appear not to be directly related to this patch, but I'm going to revert for now until I can investigate.

Original issue's description:
> Generalize scroll parent work in CalculateDrawProperties
>
> Previously, CDP would fail if the scroll child wasn't the immediate
> descendant of the lowest common ancestor of the scroll parent and child.
>
> With this patch I've fixed up two things so that CDP can handle these
> cases.
>
> 1. Dumber sorting.
>   I've made sorting simpler by removing assumptions about the tree
>   topology. Instead, I assigned "sort weights" to the layers in
>   PreCalculateMetaInformation. The approach is pretty naive. As I
>   walk the tree I assign a monotonically increasing weight. If I ever
>   hit a scroll child before its parent, I jump up to the lowest common
>   ancestor and make sure that the child of the LCA is assigned the
>   smallest weight in the tree so far (the negative of the next
>   monotonically increasing weight). This ensures that the scroll parent
>   will be visited first. Here's a picture of a layer tree and the
>   weights that would be assigned.
>
>   lca(0)
>   + filler(1)
>   | + scroll child(2)
>   + more-filler(-3)
>     + scroll parent(4)
>
>   It would be a huge bummer if we had to sort all the time, though, so
>   I've taken care to flag the LCA if I ever have to assign a negative
>   weight so that we only sort in that case.
>
>   Here's my argument for the correctness of the algorithm. Clearly,
>   we force correct ordering of a particular scroll child/parent pair,
>   but the worry is that by setting a negative weight, we'll force an
>   illegal ordering (i.e., we'll "undo" an ordering we've forced
>   earlier in the algorithm). Here's a diagram.
>
>   lca
>   + subtree with scroll parent #1
>   + subtree with scroll child #1 and scroll_parent #2
>   + subtree with scroll child #2.
>
>   Now, say we're processing scroll child #2. We want to be sure that
>   we don't go reordering subtrees and mess up the relative ordering of
>   scroll child #1 and scroll parent #1's subtrees.
>
>   But we know that this is impossible. Since we've already visited the
>   subtree with scroll child #1, scroll child #2 will necessarily get a
>   higher sort weight, so we'll never need to force any reordering in
>   this case; we won't assign any negative weights here.
>
>   Say the ordering were changed such that when processing scroll child
>   #2, we haven't seen scroll child #1's subtree. We're also fine in
>   this case because we will do any ordering fixups required when we do
>   eventually visit scroll child #1.
>
>   The only case where we get into trouble is when we have a cycle. For
>   example,
>
>   lca
>    + scroll parent 1
>    | + scroll child 2
>    + scroll parent 2
>      + scroll child 1
>
>   No ordering could satisfy a situation with a cycle, but this is
>   an impossible situation as CSS stacking defines a well defined, non
>   circular order.
>
> 2. Proper clip transformations.
>   We sometimes need to put the scroll parent's clip into the space of
>   the scroll child's immediate parent. This needs to go through the
>   LCA. Previously, we'd assumed that the LCA was going to be the scroll
>   child's immediate parent, but we no longer make that assumption.
>
> BUG=403866
>
> Committed: https://crrev.com/7faedca87705b714845842e595bca262c4090fa4
> Cr-Commit-Position: refs/heads/master@{#294521}

TBR=danakj@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403866

Review URL: https://codereview.chromium.org/563313002

Cr-Commit-Position: refs/heads/master@{#294611}

BUG=412954

Review URL: https://codereview.chromium.org/556403002

Cr-Commit-Position: refs/heads/master@{#294610}

BUG=398856
TEST=existing browser_tests and unit_tests
R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/548323003

Cr-Commit-Position: refs/heads/master@{#294609}

The shared memory support functions weren't getting exported properly, and the right targets didn't depend on it. This is the last component build failure in the GN build as of now.

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/549043005

Cr-Commit-Position: refs/heads/master@{#294608}

third_party/lss includes headers that are broken on Android.
Don't use LSS on Android and disable the corresponding test.

BUG=413635

Review URL: https://codereview.chromium.org/569633002

Cr-Commit-Position: refs/heads/master@{#294607}

GN handles adding platform-appropriate prefixes to library
entries. As such, doing it here leads to stuff like '-l-lpython'
winding up in generated build files.

BUG=388412
TEST=use GN to generate build files for something that depends on cython
R=qsr@chromium.org

Review URL: https://codereview.chromium.org/563903002

Cr-Commit-Position: refs/heads/master@{#294606}

Keep the wrench menu open for 300ms after dropping an extension action in it
to provide the user with visual feedback that the extension was properly moved.

BUG=412861

Review URL: https://codereview.chromium.org/561833003

Cr-Commit-Position: refs/heads/master@{#294605}

The linux builder is failing to checkout from github.

No trybots because this only affects the SDK waterfall builder (trybots don't
build the appengine demos).

BUG=412969
R=bradnelson@google.com, sbc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/566933002

Cr-Commit-Position: refs/heads/master@{#294604}

BUG=331299

Review URL: https://codereview.chromium.org/566833002

Cr-Commit-Position: refs/heads/master@{#294603}

This patch adds a flag indiciating whether we were OOM the last time
we did an assign.

R=reveman, nduca
BUG=408758, 410398

Review URL: https://codereview.chromium.org/533423003

Cr-Commit-Position: refs/heads/master@{#294602}

DeviceMotionAndOrientation.java has been renamed to DeviceSensors.java
(see https://codereview.chromium.org/236833003/) but the owners file has
not been updated.

BUG=

Review URL: https://codereview.chromium.org/562683002

Cr-Commit-Position: refs/heads/master@{#294601}

This reverts commit 2abb46fd.

The patch was causing flaky compile failures on the GN try servers.

TBR=jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/570623002

Cr-Commit-Position: refs/heads/master@{#294600}

The "conversion" from NativeEvent to ui::Event logically belongs in the
PlatformWindow, just prior to dispatch into aura. This is where the
analogous process happens for other platforms such as X11.

So do it there, using a helper function, and write a blurb about why we
need to do this (short answer: for compatibility with existing code,
while we working on fixing that code).

BUG=none
TEST=chrome --ozone-platform=caca, dri
NOTRY=true

Review URL: https://codereview.chromium.org/566673003

Cr-Commit-Position: refs/heads/master@{#294599}

R=miguelg@chromium.org, bauerb@chromium.org
BUG=413665

Review URL: https://codereview.chromium.org/548843003

Cr-Commit-Position: refs/heads/master@{#294598}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/566883003

Cr-Commit-Position: refs/heads/master@{#294597}

We should invalidate the input buffer index, or otherwise the new MediaCodec will call queueInputBuffer on an unitialized buffer

Review URL: https://codereview.chromium.org/558903003

Cr-Commit-Position: refs/heads/master@{#294596}

Review URL: https://codereview.chromium.org/560383002

Cr-Commit-Position: refs/heads/master@{#294595}

These classes do not need to be classes and expecially don't need to be
abstract classes as this leads to a complicated implementation and
complicated tests. All USB devices no matter the platform will have the
same descriptor data.

This change follows the model of device::HidDeviceInfo.

BUG=

Review URL: https://codereview.chromium.org/562763002

Cr-Commit-Position: refs/heads/master@{#294594}

When cretaing an InterfaceRequest for an interface that have a client,
there must be a way to provide the client implementation.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/562133002

Cr-Commit-Position: refs/heads/master@{#294593}