- 13 Nov, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 79aabb06. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" faa1edfe "update WPT tests to eliminate CSSPseudoElement from animations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic6db50c83c546242273ed94f8198066f6ebb6304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913112Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714851}
-
Shelley Vohr authored
Electron has exposed methods to allow setting the aspect ratio for a given window, and as a part of that needed to allow users to reset the aspect ratio. On macOS, we could do that using https://github.com/electron/electron/blob/3ae3233e65aa71b4815e156cd426834c30eb993b/shell/browser/native_window_mac.mm#L807-L816 , but on Linux this was not possible with currently exposed APIs without this patch. Change-Id: Ief3abea2322a734efe3e61b72df4d77daa88fb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895789Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714850}
-
Ramin Halavati authored
kCCTIncognito feature and flag are added to enable/disable incognito Chrome Custom Tabs. The default is set to disabled. Bug: 1023759 Change-Id: If32d256e3e9eaa94bcc09f7538c85e2dab53c589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911201Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#714849}
-
Ramin Halavati authored
Serving URL Request from persistent filesystems in incognito mode is enabled. Bug: 990592 Change-Id: Ieaaf59e60cc9d8de8ecbb3395ee209b0854555b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911202Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#714848}
-
rbpotter authored
Autogenerate a JS module version of cr/ui/store.js and add typechecking. This is a prerequesite for migrating pages that depend on cr.ui.Store to Polymer 3, e.g. Bookmarks. Bug: 1022213 Change-Id: I81634347188232468e851b63859b553c7e33c6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912693 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714847}
-
David Lei authored
This cl does the following: - change html encoding to utf-8 to support translation files. - add build-time grd file selection. - build real resources (if src-internal is available) or mock resources (for tests/if src-internal is unavailable). - iterate over chromeos_media_app_bundle_resources to add them as resources to serve at runtime. Submit after landing cl/277647372 & pushing to src-internal. Design doc: go/cr-g3-remote-resources#bookmark=id.b1xx7d4iasyv Bug: 996088, 1023739, b/141645032, b/142915800 Change-Id: Ib26a65b84f61b1f938e22c4242114448111c3469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895263Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#714846}
-
Shik Chen authored
Bug: b:111902891 Test: Pass capture_unittests. Change-Id: Ia9c207055613f0d2db98b22e435746a9818676dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911880 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#714845}
-
Jan Wilken Dörrie authored
This change adds UKMs for Touch To Fill User Actions. Launch Bug: https://crbug.com/1008937 Collection Review: go/touch-to-fill-ukm-collection-review Bug: 1020996 Change-Id: Ie2c4c731e2f53d879b9d5df73ab4e4465b21b228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897932 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#714844}
-
Kuo Jen Wei authored
Use photo-item/video-item for item showing selected photo/video resolution. Use title-item for title of external camera. Test: tast run <DUT> 'camera.CCAUI*' Bug: b/141518780 Change-Id: Ie4bb9eb89e5b6c1fc17b3b0bc2d9055227f52b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905295 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#714843}
-
Maggie Cai authored
This CL adds the functionality to delete all preferred apps settings for an particular app id. BUG=853604 Change-Id: I9d5306d6b1cac860306a2fb568d828b1bebff4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913280 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714842}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I466bd7d099511b4bbcbfcc2cbf58961f96f3b5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714841}
-
W. James MacLean authored
Disable /0 variant of ViewSourceWithSplitCacheEnabledTest.NetworkIsolationKeyReusedForBackNavigation. Dissable the test when the parameter is 'false'. TBR=yaoxia@chromium.org Bug: 1024033 Change-Id: Ia6f2b8e727437b2269f28c8c1353f41e83322510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913606Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714840}
-
W. James MacLean authored
Disabling a flaky test. TBR=xingliu@chromium.org Bug: 910870 Change-Id: I3ad5666f526f9a9a6268f9a5c6e4e97e13649c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913561 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29e7d3ba..09220549 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d7cb4ced5b6705e60e84a63a67ffb376c427c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913111Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714838}
-
Sinan Sahin authored
Bug: 1022185 Change-Id: Ib3344bd152874b92917b54b40a1f73003cfddd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913463Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#714837}
-
W. James MacLean authored
Update testExpectations to deal with this flaky test. TBR=dalecurtis@chromium.org Bug: 816914 Change-Id: I0838b12a303a3b36bb4a915b69f2b9a307bc87ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913612Reviewed-by:
-
Zhiheng Li authored
Bug: internal b/143071435 Test: tested on AndroidThings device Change-Id: I4b93f9ed7c39dbfa1e669c285515234f2acc241d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902075Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Auto-Submit: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#714835}
-
Liquan (Max) Gu authored
Added comments: * Comment why the ref over the weak-ref is chosen for WebContents. * Comment why using an abbreviation. Bug: 999196 Change-Id: I94eddbed050e131865869ac09521fa7275d48619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912912Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714834}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e46010f01da9..0865050e54e9 git log e46010f01da9..0865050e54e9 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 rharrison@google.com Split spvc shader generation into initialize and compile phases (#882) 2019-11-12 9856269+sarahM0@users.noreply.github.com opName - opStruct (#880) Created with: gclient setdep -r src/third_party/shaderc/src@0865050e54e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I62159dec827ab3d973b07f92d2f2230a5315c02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912928Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cea09e02b1a6..a4e6d1590f29 Created with: gclient setdep -r src-internal@a4e6d1590f29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I21bd3e5b70f712d0083a9712ad46599d5a74392e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714832}
-
Noel Gordon authored
Replace computer and shared SVG icons with viewBox="0 0 20 20" version from UX, and optimize them using SVGOMG. Bug: 992819, 1002393 Change-Id: I3f2d7625cb1d72e42a540e6da93a21bf186a819d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913779Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714831}
-
Wei Lee authored
The corresponding CL on ARC side is: http://ag/9684171 Bug: b/144062362 Test: Tested with an enterprise account and policy which blocks CCA and CCA will not show up as an option when forwarding camera intent. Change-Id: Ie27c899f044d7e72cd58439510adbb4af6b7775e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903238 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#714830}
-
Manu Cornet authored
When going to tablet mode ShelfWidget/ShelfConfig gets updated before the AppListController gets to notify observers that AppList will be visible. This means ShelfWidget will update thinking that the AppList is not visible, when it actually is. To fix this race, check whether the AppList *should* be visible at ShelfConfig::is_in_app(). Change-Id: I7d82b6ca5bd8933146dad75c0c1edb3257e41a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903595 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714829}
-
Paul Dyson authored
Bug: 991433 Change-Id: Ifdb323f64cb9dddc59e95ba673a5cadbf7869cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910822 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
-
Alexander Timin authored
Ensure that "extended experimental supported feature set" allows all pages regardless of features used by this page. This will break pages, so this should never be enabled for users, but it's useful for local testing and debugging without having to build Chrome or pass command-line flags, which is difficult on Android. TBR=arthursonzogni@chromium.org Change-Id: If0fd2c5f848211f60a33ee550c4fe27decc3acaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912701Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714827}
-
Julie Jeongeun Kim authored
It converts remote_cocoa::mojom::StubInterface from application.mojom to new Mojo types using PendingAssociatedReceiver, AssociatedReceiver, PendingAssociatedRemote, and AssociatedRemote. Bug: 955171 Change-Id: I8ab0dcc86445e14dc6ab966e1b2729fbe714931b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893609Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#714826}
-
Alexey Baskakov authored
Fix WebAppSyncBridge::ApplySyncChangesToRegistrar: Do not call SyncInstallDelegate methods if app sets are empty. Add WebAppSyncBridge unit tests for ApplySyncChanges method. These tests is a promised follow up for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. In next CL: Add WebAppSyncBridge::CommitUpdate unit tests (UpdateSync). Change-Id: If5b20b3ef8490397a4e024e3237b0456e06667ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910985 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#714825}
-
Justin Gallagher authored
Command line flags, field trials, and feature flags must be initialized before BrowserTaskEnvironment to avoid a potential race condition, where the browser is reading from the trial state at the same time that it is being written to. This isn't done in SearchProviderTest, which causes potential races in two tests: SearchProviderTest.CommandLineOverrides SearchProviderTest.SendsWarmUpRequestOnFocus To resolve, a new class SearchProviderFeatureTestComponent was created to handle field trial state. It's initialized before the BrowserTaskEnvironment member. BrowserTaskEnvironment is responsible for spinning up the thread pool, so everything before that point is synchronous. That's adding a thread which is reading the field trial state, causing the race. C++ initializes it's member variables in order of declaration, so adding the FeatureTestComponent before BrowserTaskEnvironment ensures that the command line and field tests are set before any other threads are added. This change is heavily based on mpearson's prior fix, which was reverted. http://crrev.com/c/1263562 Bug: 891959 Change-Id: I5590579ad9aef73d2d055dec5712dfd5dc567ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902786 Commit-Queue: Justin Gallagher <jugallag@microsoft.com> Reviewed-by:Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7980e5ea3e34..a1a26deab50b git log 7980e5ea3e34..a1a26deab50b --date=short --no-merges --format='%ad %ae %s' 2019-11-12 primiano@google.com trace_processor: don't use cxxabi for demangling on windows 2019-11-12 eseckler@google.com Merge "trace_processor: make stringpool not commit by default" 2019-11-12 skyostil@google.com TrackEvent: Check that category names are well formed 2019-11-12 treehugger-gerrit@google.com Merge "trace_processor: Implementing "demangle" SQL function" 2019-11-12 oysteine@google.com Update EXPORT_JSON to output stack samples in a matching format to the legacy viewer 2019-11-12 lalitm@google.com Merge "trace_processor: rework best index logic again" 2019-11-12 fmayer@google.com Merge "Disable AllGraphs test." 2019-11-12 lalitm@google.com Merge "trace_processor: remove kId flag" 2019-11-12 fmayer@google.com Merge "Only run HeapGraphWalker::AllGraphs on standalone builds." 2019-11-12 fmayer@google.com Merge "Mention UI for recording profiles." 2019-11-12 treehugger-gerrit@google.com Merge "Add new assertion to HeapGraphWalkerTest::AllGraphs" 2019-11-12 treehugger-gerrit@google.com Merge "ftrace probe: fix padding size calculation being off by 4 bytes" 2019-11-11 fmayer@google.com Merge "Do not count roots as unique_retained." 2019-11-11 rsavitski@google.com Merge "compact_sched: remove "unstable" notices" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: event decoding in trace_processor" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: writer (traced_probes)" Created with: gclient setdep -r src/third_party/perfetto@a1a26deab50b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:132678367 Change-Id: Ia42b7f5a4aefc6996ff8618ff553a5702f262c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913760Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0bbd6ee7bb63..2a11883d0071 git log 0bbd6ee7bb63..2a11883d0071 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 fancl@chromium.org Fix fetching config from luci-config 2019-11-13 fancl@chromium.org Fix handling invalid requests in /subscriptions/match Created with: gclient setdep -r src/third_party/catapult@2a11883d0071 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nuskos@google.com Bug: chromium:953181,chromium:953181 Change-Id: Ibb61ed9962cb8e7cf1d8a0d84127abb53279b3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913799Reviewed-by:
-
Bailey Berro authored
This change begins to address an issue where context was unclear for screen readers when a dialog opens. Previously, when a dialog had a field set as 'autofocus', ChromeVox would read the name and contents of the field followed by "dialog". With this change, all dialogs properly read title of dialog + "dialog" before reading the name and contents of the autofocused field. With this change, we end up with a slightly different issue where some information about the title/ first field of a dialog is read twice for example "Add Printer, Dialog, Name, dit text, Name, edit text, Add Printer, Dialog" Screen recordings: Before: https://www.loom.com/share/c3c71f84457d457b8bcf9a8cc973cc43 After: https://www.loom.com/share/24c4a8dd5ef54063a94bc94af48246ed Bug: 1015673 Change-Id: Ic79006ea3cf94c0695f140c1cdff9efdb65bc28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906254Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#714821}
-
Daniel Rubery authored
This CL adds a few variants on the MDB and CRT extension to download_file_types.asciipb, so that they have reasonable failure behavior in the event Safe Browsing is unavailable. Fixed: 1022257, 1022265, 1022732, 1022737, 1022316 Change-Id: I01cd8f79c6ac7b061acdcdf95533e80406074f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911283 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714820}
-
Joe DeBlasio authored
This CL adds two new safety tip statii: kBadReputationIgnored and kLookalikeIgnored. These states correspond to when the user has previously ignored a warning on that page, but the page would otherwise trigger a Safety Tip. This CL also updates every default case of SafetyTipStatus to be kUnknown instead of kNone. This means that kNone definitively means "safety tip status was checked, and found to be none" instead of a generic unknown state. These changes have no user-visible impact, but before this change, several distinct cases were conflated into kNone in metrics. TBR: cthomp@chromium.org Bug: 1022017 Change-Id: I51c81dab94b438abc13e62b837d4ec55be41e5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901631 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714819}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I2f5e0f4a3e6b3f530c8ff9a287656f0067ec6bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912892Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714818}
-
Dana Fried authored
Visibility change on animation start resulted in alpha overlay not painting until next animation frame, resulting in the underlying text (representing the new title and domain) showing through at 100% opacity. Now the overlay always draws but possibly at zero opacity, avoiding the issue. The text is still cleared when the card reaches its destination so we don't incur the overhead of laying out the text. Change-Id: Id1e0587874f7e91dad4efdf0fd31f2ac23860ceb Bug: 1023956 Fixes: 1023956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910681 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Pavel Yatsuk authored
The test verifies Identity Disc visibility based on navigation location (NTP vs. other locations), sign-in, and sync state. To enable testing I updated the logic to retrieve ProfileSyncService reference instead of using cached reference. I also updated FakeProfileSyncService to allow controlling sync state from test. R=twellington@chromium.org Change-Id: I8fcc672acd0b0a5e7c46e951e4222e7c9cbb8c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904080Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Ken Rockot authored
This is a stripped down incarnation of Service Manager's BinderMap type. Unlike that type, there is no intent here to support the complexity of variadic binder arguments since such use cases are generally now limited to the Content layer or above. This is a straightforward mapping of interface name to callback + task runner. At first this will at least be used by Blink and various Content child process types to expose interfaces to the browser through a common path in ChildThreadImpl. Bug: 977637 Change-Id: I7aa7cf40995b1898090202bd4e4377285c776421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905047 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f47c2ab889d9..d4002a733dc6 git log f47c2ab889d9..d4002a733dc6 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org RTC_EXPORT missing symbols for Chromium's component build. Created with: gclient setdep -r src/third_party/webrtc@d4002a733dc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I4d2c9014d7d0f19816c3ad6c3cfcfd20444e3000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913706Reviewed-by:
-
David Grogan authored
FlexibleBoxAlgorithm reads margins from LayoutBox. We weren't positioning items with margins correctly in FlexNG before this patch. Bug: 845235 Change-Id: I4d05fd6107f0140d69c6aee3f56d78dc430862c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913707Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714813}
-
Maggie Cai authored
Implement delete app from preferred apps for an |app_id| and |intent_filter|. BUG=853604 Change-Id: Ibc1060304765813bcde50f80d1a00a0d10fee880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910823Reviewed-by:
-
