GitLab

Bug: 729896, 729895
Change-Id: I4d5ba4d5c22fc2b85aa14dcde92e02ef3454b9da
Reviewed-on: https://chromium-review.googlesource.com/541020Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481255}

https://pdfium.googlesource.com/pdfium.git/+log/cddc8eddbd33..5e57faaa7fbc

$ git log cddc8eddb..5e57faaa7 --date=short --no-merges --format='%ad %ae %s'
2017-06-21 halcanary skia/BUILD.gn: s/ImageEncoder_none/ImageEncoder/

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Id77da9833f2196ee5465e8590bd2e9a935a3ee25
Reviewed-on: https://chromium-review.googlesource.com/543302
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481254}

Previously srcjars were not included as part of the java files that we
ran lint on. Now they are extracted to a temporary directory for each
target. Linting srcjars improves intdef and unused resources checks.

Type annotations will be available in Java 8. Removing it for now and
adding TODO to add it back when Java 8 becomes available.

Bug: 731159, 730711
Change-Id: Id2d7abe981c8ba8a23712748942d500056023587
Reviewed-on: https://chromium-review.googlesource.com/539897
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481253}

Bug: 316709,544085,373155,638557,730895
Change-Id: I424bfdd859f8a78996ea000dac9457e716976e87
Reviewed-on: https://chromium-review.googlesource.com/538827Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481252}

Now that we have modifiers, we need to make sure that not just the
format, but also the format modifer is compatible with the
HardwareDisplayController where we want to use the buffer.

Reland of 9947afe9.

BUG=b/38217940
TEST=Plug in external monitor that supports same resolution as internal
  panel with mirror mode enabled

Change-Id: I87c2590b556d5be7e99b7e43249c98e943324a03
Reviewed-on: https://chromium-review.googlesource.com/541778Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481251}

Add configuration check to throttle active downloads.

Bug: 
Change-Id: I0cf68481b0c9d7595a9713d1c311b63393ce640b
Reviewed-on: https://chromium-review.googlesource.com/538885
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481250}

/sys/devices/system/cpu/cpufreq/all_time_in_state reports cpu freq as
"N/A" for the cpu/freq combinations that are invalid. This CL makes
cpu_data_collector handle the case and adds unit test for it.

BUG=548510
TEST=unit_tests --gtest_filter=CpuDataCollectorTest.*

Review-Url: https://codereview.chromium.org/2950963002
Cr-Commit-Position: refs/heads/master@{#481249}

Though not used in production in any way that's affected by this,
r477744 broke clean shutdown. The bug is ultimately caused by the fact
that we don't check the shutdown-requested state after processing
incoming control event IPC, so if such an event is responsible for
making the system enter a clean-shutdownable state, it will go
undetected and the shutdown process will hang.

BUG=735338
TBR=jcivelli@chromium.org

Change-Id: If3ca2344a70024fbf6bc028ae177f23026612011
Reviewed-on: https://chromium-review.googlesource.com/543677Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481248}

R=thakis@chromium.org

Bug: 689520
Change-Id: I72b09f7daac13ffa90cc8925bc4abc142599d410
Reviewed-on: https://chromium-review.googlesource.com/542956
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481247}

card number: http://imgur.com/a/ffyCF, http://imgur.com/a/pMl33
phone number: http://imgur.com/a/H7i6b, http://imgur.com/a/HpHto

BUG=602666

Review-Url: https://codereview.chromium.org/2949813003
Cr-Commit-Position: refs/heads/master@{#481246}

Previously if the bottom sheet was opened while the keyboard was showing
BottomSheet#setSheetOffsetFromBottom() did not call onSheetOpened()
because its logic determined that the sheet was already open based on
the previous offsets (which are no longer valid since the keyboard is
hidden when the sheet is opened). #onSheetOpened and #onSheetClosed
include early returns so #setSheetOffsetFromBottom does not need to use
the previous offsets when determining whether to call these methods.

BUG=735378

Change-Id: I17bd59644a76886232e7cb1d3b9f40e4200afbe5
Reviewed-on: https://chromium-review.googlesource.com/543303Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481245}

Test added in https://chromium-review.googlesource.com/536383.

BUG=729849
NOTRY=true
TBR=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2950133002
Cr-Commit-Position: refs/heads/master@{#481244}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a64c010c74cc..06fd359d488b

$ git log a64c010c7..06fd359d4 --date=short --no-merges --format='%ad %ae %s'
2017-06-21 phsilva Add Ownership to Alerts

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I50a6dc2997471a0f7cf705e69403b6a4949e2dcc
Reviewed-on: https://chromium-review.googlesource.com/542958
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481243}

Added GetNavigationItemImplAtIndex() and GetPreviousItemIndex() as
private pass-through APIs on NavigationManagerImpl and removed direct
access to CRWSessionController in SessionStorageBuilder::BuildStorage().

BUG=734150

Review-Url: https://codereview.chromium.org/2944093002
Cr-Commit-Position: refs/heads/master@{#481242}

Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #2 id:20001 of https://codereview.chromium.org/2950933003/ )

Reason for revert:
Broke mac builders on chromium.perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/102244

Original issue's description:
> mac: Roll hermetic toolchain to Xcode 8.3.2.
>
> Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
> 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.
>
> To support machines running macOS versions < 10.12, but don't require building
> targets, this CL also:
>   * Does not download the hermetic toolchain if the macOS version does not
>     support the toolchain version.
>   * Does not allow building targets with the default hermetic toolchain if the
>     macOS version does not support the toolchain version.
>
> BUG=624049
>
> Review-Url: https://codereview.chromium.org/2950933003
> Cr-Commit-Position: refs/heads/master@{#481225}
> Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e

TBR=dpranke@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624049

Review-Url: https://codereview.chromium.org/2949043002
Cr-Commit-Position: refs/heads/master@{#481241}

These are only added in unit tests, in production they are always empty
so stop doing this. That way we also avoid crashing because the visual
rects array is empty.

R=vmpstr@chromium.org

Bug: 735217
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I01032ec5de7d3a5239fb193762cae6872b2d1af6
Reviewed-on: https://chromium-review.googlesource.com/541938Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481240}

BUG=734816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2945103002
Cr-Commit-Position: refs/heads/master@{#481239}

Implements two methods in the iOS AutocompleteProviderClientImpl that provide
the list of builtin URLs to the provider.

BUG=725120
TEST=The omnibox should suggest builtin URLs when typing "chrome://"
TEST=The omnibox should inline-autocomplete "chrome://version" and "chrome://chrome-urls"

Review-Url: https://codereview.chromium.org/2947643002
Cr-Commit-Position: refs/heads/master@{#481238}

The new code should be easier to test, easier to extend and easier to
re-use.

BUG=734776
TEST=added unittests for scheduler

Review-Url: https://codereview.chromium.org/2942373002
Cr-Commit-Position: refs/heads/master@{#481237}

Splitting ChildProcessServiceImpl with a delegate and moving the
content specific logic to a content implementation class.
ChildProcessServiceImpl takes care of initializing the command line and
registering file descriptors. This class will be next moved to base.
The content specific behavior (using the custom linker, providing the
GPU surfaces to the renderer) is moved to the content implementation
of the delegate, ContentChildProcessServiceDelegate.

Bug: 702316
Change-Id: I357e2a81836a97cf53888ca3d7ec3b46e12c91a1
Reviewed-on: https://chromium-review.googlesource.com/526262Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481236}

TBR=zmo@chromium.org
NOTRY=true

BUG=735464

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia9ef7c36274fe02b402db1a42ff6abdf7327878d
Reviewed-on: https://chromium-review.googlesource.com/542940
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481235}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ea49cd0a..165c183f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2949923003
Cr-Commit-Position: refs/heads/master@{#481234}

This is a partial manual revert of r459483, where the "service"
process type was renamed to "cloud-print-service" so that "service"
could later be co-opted for a generic service process environment.
That broke cloud printing.

The manual revert here simply changes the constant values of the
respective switches so that the previous cloud-print service behavior is
preserved and the new service process type doesn't collide with it.

Any additional hard-coded values or comments referring to
"cloud-print-service" have also been changed to "service" here.

BUG=735471

Change-Id: I1b63314a1047e53bb968c760432cacb6c19ea34d
Reviewed-on: https://chromium-review.googlesource.com/543558Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481233}

This CL deals with favicons that are added without the user visiting the corresponding
page. The CL introduces the notion of "on-demand" favicons for them:

1) The CL reuses (and renames) an existing function in FaviconService for storing
such on-demand favicons and pushes this concept further to ThumbnailDatabase.

2) The CL adds a new function to touch (i.e. update last_requested time-stamp) for
"on-deman" favicons.

The functionality to clear unused on-demand favicons is left for a further CL
(https://codereview.chromium.org/2903573002/). Similarly, calling
TouchOnDemandFavicon from LargeIconService is also left for a later CL.

BUG=709471

Review-Url: https://codereview.chromium.org/2856873002
Cr-Commit-Position: refs/heads/master@{#481232}

Introduce InProcessGpuMemoryBufferManager, which directly interacts
with a GpuMemoryBufferFactory to allocate memory used by the display
compositor.

Follow on steps: relocate ServerGpuMemoryBufferManager into viz/host.

BUG=733482

Review-Url: https://codereview.chromium.org/2942283002
Cr-Commit-Position: refs/heads/master@{#481231}

BUG=735457, 656015

Review-Url: https://codereview.chromium.org/2953573002
Cr-Commit-Position: refs/heads/master@{#481230}

BUG=656015

Review-Url: https://codereview.chromium.org/2948583002
Cr-Commit-Position: refs/heads/master@{#481229}

BrowserThread::FILE is deprecated in favor of the post_task API.

BUG=689520

Review-Url: https://codereview.chromium.org/2937253003
Cr-Commit-Position: refs/heads/master@{#481228}

This includes some refactoring of creation time defaulting, as well
as a histogram revision bump because the information about whether a
cookie is being set based on a null URL is no longer available at
the point of histogram creation.

BUG=721395, 723734
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2882063002
Cr-Commit-Position: refs/heads/master@{#481227}

One of the webkitpy unittests failed if you redirected the output
of test-webkitpy to a file. This CL fixes that, by implementing
a mock method that I had missed earlier.

R=qyearsley@chromium.org
BUG=726772

Change-Id: I49a8ed7c3453a1ff0ae03d43b64d1ea5af539c02
Reviewed-on: https://chromium-review.googlesource.com/541974Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481226}

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481225}

Bug: 728378
Change-Id: Ic3eb2ee97432d8261a75dd70b34fb064babb0966
Reviewed-on: https://chromium-review.googlesource.com/540776
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481224}

This CL also fixes the bug in this CL https://codereview.chromium.org/2952673002/
to add phone number suggestions.

BUG=723769

Review-Url: https://codereview.chromium.org/2945303002
Cr-Commit-Position: refs/heads/master@{#481223}

To reproduce the bug:
modify WebKit/public/platform/WebFeature.h
run: git cl presubmit --upload

Error:
[pretty_print_xml.py] Unrecognized attribute "type" in tag "enum"
Change-Id: If9f87116f691290533cfc84d65915474fdadc481


Root cause in: https://chromium.googlesource.com/chromium/src/+/8a09a116476b0c45134ac2391e4768611c738ab8%5E%21/

Change-Id: If9f87116f691290533cfc84d65915474fdadc481
Reviewed-on: https://chromium-review.googlesource.com/542135Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481222}

Implements current_directory by setting PWD in the new process's
environment.

Makes ProcessUtilTest.CurrentDirectory pass on Fuchsia.

Bug: 706592
Change-Id: Idcde248ccd82d26ea19d71b66b2688014858eb99
Reviewed-on: https://chromium-review.googlesource.com/541940Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481221}

If view is still attached, then check if 
frame.view == owner.embedded_content_view

Error if owner is attaching embedded_content_view during
Document::Shutdown

Bug: 729196
Change-Id: I46642663b635ceb9c1d29cfeb00361710f57bae8
Reviewed-on: https://chromium-review.googlesource.com/542055Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481220}

support importing dmabufs without an explicit roundtrip
to get the imported buffer handle into client as per
zwp_linux_dmabuf_v1_interface version 2, and make
clients use this by default.

TEST=`wayland_rects_client --use-drm`

Review-Url: https://codereview.chromium.org/2846203002
Cr-Commit-Position: refs/heads/master@{#481219}

BrowserThread::FILE is deprecated in favor of the post_task API.

BUG=689520

Change-Id: Ia3cee112af64b7e5e1208fb523f508c1444e2436
Reviewed-on: https://chromium-review.googlesource.com/541623
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481218}

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.

BUG=

Review-Url: https://codereview.chromium.org/2949873005
Cr-Commit-Position: refs/heads/master@{#481217}

Multipart images resources can be used for displaying mjpg videos which
should not be checkered. Plumb this state from blink to cc using
PaintImage to veto them from checkering.

BUG=733247
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2939243002
Cr-Commit-Position: refs/heads/master@{#481216}