- 11 May, 2017 40 commits
-
-
mad authored
BUG=721502 Review-Url: https://codereview.chromium.org/2875103003 Cr-Commit-Position: refs/heads/master@{#471091}
-
thakis authored
Autosizing can be triggered through devtools on desktop nowadays. BUG=675877 Review-Url: https://codereview.chromium.org/2874783003 Cr-Commit-Position: refs/heads/master@{#471090}
-
eae authored
Remove obsolete PaintImage trace from StyleFetchedImage::KnownToBeOpaque and StyleFetchedImageSet::KnownToBeOpaque. Trace was originally added in late 2014 (in r186030) to the ImageResource::currentFrameKnownToBeOpaque method as it, at the time, caused a forced decode for the image. That is no longer the case yet the trace call has stubbornly survived unchanged. R=pdr@chromium.org Review-Url: https://codereview.chromium.org/2880573003 Cr-Commit-Position: refs/heads/master@{#471089}
-
apacible authored
Revert of Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder (patchset #2 id:20001 of https://codereview.chromium.org/2854363002/ ) Reason for revert: Builder failing: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 Original issue's description: > Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder > > This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead > of an AudioFifo, to avoid copying data needlessly. > > BUG=None > > Review-Url: https://codereview.chromium.org/2854363002 > Cr-Commit-Position: refs/heads/master@{#471039} > Committed: https://chromium.googlesource.com/chromium/src/+/678c74cf3e17aaef9562ee13df8c803e1d014fc6 TBR=mcasas@chromium.org,miu@chromium.org,c.padhi@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2873123005 Cr-Commit-Position: refs/heads/master@{#471088}
-
chrishtr authored
Fragmented PaintLayers do not paint atomically (though each fragment does). PaintController, however does not support a fragment as a DisplayItemClient key for subsequences. BUG=717335 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2865403002 Cr-Commit-Position: refs/heads/master@{#471087}
-
rogerm authored
This CL is in response to perf regression (see referenced bugs). BUG=697947, 697665 Review-Url: https://codereview.chromium.org/2871843003 Cr-Commit-Position: refs/heads/master@{#471086}
-
rdevlin.cronin authored
The app custom bindings (and handler counterparts) had issues. Fix some of them. BUG=None Review-Url: https://codereview.chromium.org/2859233003 Cr-Commit-Position: refs/heads/master@{#471085}
-
chrome://ukmholte authored
BUG=718674 Review-Url: https://codereview.chromium.org/2858683006 Cr-Commit-Position: refs/heads/master@{#471084}
-
ynovikov authored
https://chromium.googlesource.com/angle/angle.git/+log/b4cf565..82830ed BUG= TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2878593004 Cr-Commit-Position: refs/heads/master@{#471083}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/external/swarming.client.git/+log/e6fc9383ad7c..a941a089ff10 $ git log e6fc9383a..a941a089f --date=short --no-merges --format='%ad %ae %s' 2017-05-11 maruel Revert "named caches: move instead of symlinking" 2017-05-10 nodir named caches: move instead of symlinking 2017-05-10 maruel swarming: fix support for raw command + isolated file 2017-05-09 qyearsley Rephrase a message in run_isolated to be more polite/formal. 2017-05-09 maruel swarming.py: remove old auto-isolate support Created with: roll-dep src/tools/swarming_client The last commit above may break users, if they specified the isolated hash as an unnamed argument, i.e. not using the -s/--isolated flag. At worst it is safe to revert. R=iannucci@chromium.org Bug: Change-Id: I21f53429a8e16dbd5754770bc1194fc018bf5615 Reviewed-on: https://chromium-review.googlesource.com/503507Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#471082}
-
rouslan authored
Before this patch, a PaymentRequest for USD $100.00 would show all available payment apps in Chrome UI, even if some of the apps do not carry enough balance. This patch adds a "total" parameter to IS_READY_TO_PAY service. This parameter is JSON-stringified PaymentCurencyAmount. For example: {"currency": "USD", "value": "10.00"} After this patch, payment apps can decide to return "false" to IS_READY_TO_PAY query if they do not carry enough balance. These apps would not be available in Chrome UI when a PaymentRequest for too high of an amount is created. Spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE BUG=620173 Review-Url: https://codereview.chromium.org/2873503006 Cr-Commit-Position: refs/heads/master@{#471081}
-
dougt authored
BUG=703369 Review-Url: https://codereview.chromium.org/2872983002 Cr-Commit-Position: refs/heads/master@{#471080}
-
nednguyen authored
https: //codereview.chromium.org/2877553003/) Review-Url: https://codereview.chromium.org/2881603002 Cr-Commit-Position: refs/heads/master@{#471079}
-
Tommy Nyquist authored
Before this CL, the ConditionValidator::MeetsConditions(...) method only returned a bool value whether all conditions were met. This made it harder to track what went wrong in a generic way across all validators, so this CL changes the return value to be a struct that contains information about all conditions, and whether they were met. In addition, to prepare for an upcoming CL that will need to use the current day to figure out whether conditions are met, that parameter is added in the current CL. BUG=706309 Change-Id: I73815d88facfc1fbee9e6a0058790cd4b73dc714 Reviewed-on: https://chromium-review.googlesource.com/502731Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#471078}
-
mef authored
BUG=666502 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2614423002 Cr-Commit-Position: refs/heads/master@{#471077}
-
nhiroki authored
After ES6 modules loading for PaintWorklet (issue 627945) is introduced, layout tests for PaintWorklet are no longer able to run on non-http environment because ES6 modules does not support "file://" url (See https://crbug.com/594639#c86). This CL moves the tests in inspector/console/ to http/tests/inspector/console/ to enable them to run with module loading. BUG=719857 Review-Url: https://codereview.chromium.org/2881443003 Cr-Commit-Position: refs/heads/master@{#471076}
-
sandersd authored
Since the dep is also conditional, not doing this fails gn check. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2876873002 Cr-Commit-Position: refs/heads/master@{#471075}
-
estade authored
BUG=522168 Review-Url: https://codereview.chromium.org/2878713002 Cr-Commit-Position: refs/heads/master@{#471074}
-
fdoray authored
ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Switching from MessageLoopForIO to ScopedTaskEnvironment in NetTestSuite allows Scoped(Async)TaskScheduler to be removed from individual net unittests. Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 Review-Url: https://codereview.chromium.org/2839663002 Cr-Commit-Position: refs/heads/master@{#471073}
-
estevenson authored
Broken in 40a227b7, we currently don't build for subrepo (and the script fails). BUG=695182 Review-Url: https://codereview.chromium.org/2876033002 Cr-Commit-Position: refs/heads/master@{#471072}
-
juliatuttle authored
BUG=704259 Review-Url: https://codereview.chromium.org/2851603002 Cr-Commit-Position: refs/heads/master@{#471071}
-
Chris Palmer authored
It was written assuming its only caller would be Blink, but that's no longer the case. Separate the Blink-specific stuff into a new Blink documentation file. BUG=NONE R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2870213002 . Cr-Commit-Position: refs/heads/master@{#471070}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/eb7a693e0f6d..ec8f8b064340 $ git log eb7a693e0..ec8f8b064 --date=short --no-merges --format='%ad %ae %s' 2017-05-11 brianosman Fix GPU text colors when color spaces are involved 2017-05-11 kjlubick Isolate CIPD assets for RPI tasks 2017-05-10 brianosman Remove SkCrossContextImageData and all support code 2017-05-11 mtklein hone down the SK_FORCE_RASTER_PIPELINE_BLITTER test bot Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I4329db0e7904a7a2691f3a769a34b925f01e70c2 Reviewed-on: https://chromium-review.googlesource.com/503488Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#471069}
-
minch authored
The context menu of the shelf will cover part of the icon in the shelf. And the coordinate adjustment from |MENU_ANCHOR_BOTTOMCENTER| is not suit for left and right shelf. changes in this cl, 1.Adjust the position of the context menu opened by shelf icon. Make it align to top edge of the shelf. Context menu of touch events should be put in the middle area. BUG=710601 Review-Url: https://codereview.chromium.org/2861873002 Cr-Commit-Position: refs/heads/master@{#471068}
-
eugenebut authored
BUG=721465 TBR=kkhorimoto@chromium.org Review-Url: https://codereview.chromium.org/2880443004 Cr-Commit-Position: refs/heads/master@{#471067}
-
eugenebut authored
BUG=None Review-Url: https://codereview.chromium.org/2845913003 Cr-Commit-Position: refs/heads/master@{#471066}
-
capn authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f34d1ac..9ed48ba Fixes LTO causing hard crash on Linux official builds. BUG=720933 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2877513004 Cr-Commit-Position: refs/heads/master@{#471065}
-
reed authored
BUG=skia:3191 Review-Url: https://codereview.chromium.org/2875043004 Cr-Commit-Position: refs/heads/master@{#471064}
-
vmiura authored
Test was disabled due to flakyness. Re-enabling to diagnose current situation. TBR=sullivan@chromium.org BUG=713260 Review-Url: https://codereview.chromium.org/2870233002 Cr-Commit-Position: refs/heads/master@{#471063}
-
pauljensen authored
BUG=719448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2872593002 Cr-Commit-Position: refs/heads/master@{#471062}
-
Jeff Carpenter authored
Bug: 700092 Change-Id: I7fd398d1e25b77493eef609cbf818747216cd140 Reviewed-on: https://chromium-review.googlesource.com/479931 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#471061}
-
thomasanderson authored
BUG=676220 R=peter@chromium.org Review-Url: https://codereview.chromium.org/2866363002 Cr-Commit-Position: refs/heads/master@{#471060}
-
chrishtr authored
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2874303002 Cr-Commit-Position: refs/heads/master@{#471059}
-
donnd authored
We were recording the first character of the selection to use as a hint for triggering. We don't currently have permission to send this to Ranker so it's being removed for now, and the histogram being marked obsolete. We don't yet have permission to send any content signals to Ranker so removing some promising ones like word-length from the send-to-ranker list but keeping the underlying data collection for now. Remove the entire blacklist and obsoleting the associated histogram. BUG=720193 Review-Url: https://codereview.chromium.org/2875553002 Cr-Commit-Position: refs/heads/master@{#471058}
-
wkorman authored
BUG=717538,715704 Review-Url: https://codereview.chromium.org/2874043003 Cr-Commit-Position: refs/heads/master@{#471057}
-
bcwhite authored
Memory-mapped files cause crashes if there are I/O problems. By ensuring that the file is fully realized on disk, we eliminate a disk-full condition from causing a crash down the road. BUG=715523, 717331 Review-Url: https://codereview.chromium.org/2860943005 Cr-Commit-Position: refs/heads/master@{#471056}
-
thakis authored
Revert of [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts (patchset #7 id:340001 of https://codereview.chromium.org/2861433005/ ) Reason for revert: Test is flaky, see https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452154 Original issue's description: > [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts > > It turns out that a frame can abort and continue to load resources even if it > has no previous navigation. This happens if a doc.write overwrites the frame > navigation while the navigation is still provisional. > > This CL now labels all finished frame navigations (regardless of success) and > removes an incorrect dcheck. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > BUG=708570 > > Review-Url: https://codereview.chromium.org/2861433005 > Cr-Commit-Position: refs/heads/master@{#470701} > Committed: https://chromium.googlesource.com/chromium/src/+/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71 TBR=bmcquade@chromium.org,csharrison@chromium.org,jkarlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708570 Review-Url: https://codereview.chromium.org/2876823003 Cr-Commit-Position: refs/heads/master@{#471055}
-
Mostyn Bramley-Moore authored
This assertion adds no value, and can trigger warnings (and errors if you build with -Werror). I think it should be removed. If it is really important, a comment where the variable is defined would suffice. Patch submitted upstream: https: //github.com/gperftools/gperftools/pull/885 Change-Id: Ife6de127928bfdd0c3861b65cdeb8e5ccbfee16d Reviewed-on: https://chromium-review.googlesource.com/503034Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#471054}
-
thomasanderson authored
BUG=676220 R=peter@chromium.org Review-Url: https://codereview.chromium.org/2875443002 Cr-Commit-Position: refs/heads/master@{#471053}
-
qyearsley authored
Revert of Change TBR on import CLs to jeffcarp. (patchset #1 id:1 of https://codereview.chromium.org/2827093004/ ) Reason for revert: Switching TBR back to qyearsley Original issue's description: > Change TBR on import CLs to jeffcarp. > > Review-Url: https://codereview.chromium.org/2827093004 > Cr-Commit-Position: refs/heads/master@{#466348} > Committed: https://chromium.googlesource.com/chromium/src/+/91d68416a8808790a8d721a5ebe0accdafbcc066 TBR=jeffcarp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2871603003 Cr-Commit-Position: refs/heads/master@{#471052}
-