- 01 Jun, 2020 40 commits
-
-
Marijn Kruisselbrink authored
Also replace remaining frame ids with GlobalFrameRoutingId rather than two separate ints to make it slightly harder to write buggy code. Bug: 1087205 Change-Id: Ie3d8c109f316cf157295eaf5524597cc3ad3a1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220271 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773895}
-
Yoshifumi Inoue authored
This patch changes |selection_test()| to be able to accept |AsyncFunction| as tester to use |chrome.gpuBenchmarking.pointerActionSequence()| for using mouse event in tester. Note: This patch is a preparation of http://crrev.com/c/2224485. Bug: 707656, 679977 Change-Id: I8e32f043ec64d5f0b32655018fbc171e69831581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224483 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773894}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iec8e0cdb0eaf912a9b1663bd42b3ff2b22267cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225483Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773893}
-
Kai Ninomiya authored
Bug: 1069302 Change-Id: Iaa4a7ed6f20d4e625dbf9127d325121b1d56fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223092 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#773892}
-
Chong Gu authored
Adds ~5 minutes of run time and bot time per builder Bug: 1090068 Change-Id: I6cc6fde064a4b0a459a937debbc0777adb67cf9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225507 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773891}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/da87b8d8b0a1..d8eca133b4b1 2020-06-01 rharrison@google.com Rolling 5 dependencies (#1078) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I174f03caab5077821d927677da0d97810533edef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225697Reviewed-by:
-
David Schinazi authored
I've noticed this log on the quic.rocks server and I think including the string in this log will facilitate debugging. R=zhongyi@chromium.org Change-Id: Iaf0744e3325310989ccac1dc216cf33162b1ed14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225481 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773889}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I17bb9621e7319df7eba6504ebc2fa11935abbe97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225346Reviewed-by:
-
Lei Zhang authored
Point it at pdf/OWNERS. Change-Id: I8c2dcc590b16c614170214566e72fa99e29d33c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223459Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773887}
-
Kurt Horimoto authored
This was previously handled by a WebStateDelegateTabHelper instance method that was bound with a weak pointer. If the WebState is destroyed before the completion callback is executed, this means that the WebKit-provided completion block will not be executed since the weak pointer makes the callback a no-op. This CL moves this logic into a standalone C function that will execute the WebKit callback regardless of whether the WebState has been destroyed. Bug: 1087858 Change-Id: Id1a8ccfbead397d04b923b04e069589ea8e83967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225461 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#773886}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67e50a6b5c59..43182bccce1d 2020-06-01 scroggo@google.com Remove SkBitmapRegionDecoder and SkBRDAllocator 2020-06-01 jvanverth@google.com Create ring buffer for managing D3D uniforms. 2020-06-01 csmartdalton@google.com Map the 's' key in CanvasKit viewer to force animation 2020-06-01 reed@google.com Revert "gms for SkParagraph" 2020-06-01 herb@google.com Move makeOp to SubRun 2020-06-01 fmalita@chromium.org [skottie] Pull SkottieProperty.h from Skotti.h 2020-06-01 herb@google.com Make flags private 2020-06-01 reed@google.com gms for SkParagraph 2020-06-01 johnstiles@google.com Revert "Allow printf-style formatting to be used in SK_ABORT." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I52023345b33118ba0330c26391339300cb7d4d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225696Reviewed-by:
-
Robert Liao authored
This helps prepare for removing set_owned_by_client(). Change-Id: I3ab63431717d6df8bd826c1ce404df9be751b127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222912 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773884}
-
Taylor Bergquist authored
Bug: 1082513 Change-Id: Ic7b628f2a81b461bd9b7649e47f9d81619e21eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220700Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#773883}
-
Tom Anderson authored
The previous rebuild only updated libraries in /lib/x86_64-linux-gnu, however, /usr/lib/x86_64-linux-gnu needs to be updated too. BUG=1086636 R=thestig CC=thakis Change-Id: I3ec3dac90ee7c145f361b5af7705953b7834d5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225743 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773882}
-
Xiaocheng Hu authored
We used to have LargestImage/TextPaint UMA, which were removed by crrev.com/c/2080815 in favor of the combined LargestContentfulPaint. This patch adds the two metrics back, but only reported when the page contains page preloading. This helps us understand how the feature FontPreloadingDelaysRendering affects text paint timings vs. image paint timings. Bug: 1040632 Change-Id: Icbddc33b85fc5a017a33435e4103a4532814d42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208256 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#773881}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c4c2415..b9f640ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff7c97d8c297e8db328c3a6434e3319fd8fca56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225636Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773880}
-
Sinan Sahin authored
Bug: 1084025 Change-Id: I7de1e9607c4a47c044aeb518b6b185f23f7896c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222890Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#773879}
-
Doug Arnett authored
Bug: 1063520 Change-Id: I8463fd5a1aad85a42e9700faba5bcef98af64502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224975Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#773878}
-
Ben Pastene authored
Will be used by clients that have a vendored copy of the lib: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:chromite/third_party/gn_helpers/ Bug: 937821 Change-Id: I6f2380fe60fe5bdc661bcbf7947bf3e221011e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225264 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#773877}
-
Tom Anderson authored
BUG=1066670 R=msisov CC=sky Change-Id: Iecd593c0c77878a80bf84e9e3c504fd90815db6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220686 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#773876}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6f5ff495681c..11dd7183c4d2 2020-06-01 capn@google.com Remove generation of OpenCLDebugInfo100.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iabd73801b331990f8d3043441fb609422734c498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225309Reviewed-by:
-
Zhongyi Shi authored
Bug: 1088100, 1090018 Change-Id: Ie25ffdecabb2bbaa242379b45f28debb0b10c1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223013 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#773874}
-
Thomas Guilbert authored
This is frequently failing on win7 bots. TBR=johnchen@chromium.org Bug: 1088447 Change-Id: Ia1b3778647f01afce6349cab31fedb8a2933713c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225367Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773873}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591026828-08649a6f2f91ff46c0ee4a8534af4c349ceca721.profdata to chrome-mac-master-1591041546-a410a758e06ddb76997f15201c691b94ce14829b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2c4103b81c342c333d9fc6f78942d036588b7247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225315Reviewed-by:
-
haozhe authored
The svg-baseline-shift-interpolation.html test occasionally flakes due to timeout. This patch marks this test as a slow test. The test require inline layout change, making the test slow. https://drafts.csswg.org/css-inline/#propdef-baseline-shift Bug: 1076034 Change-Id: Id1270b20479f3341e7051211bb0c891355bfe0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220349 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#773871}
-
Nathan Zabriskie authored
This is a reland of eeb9431b The change was reverted because it was causing breaks on android-pie-x86-rel. This relands the patch with a fix for those breaking tests. Original change's description: > Move CPU VideoFrame YUV Uploading code into yuv_util > > This patch unifies CPU VideoFrame uploading/conversion code for OOPR > and GPU rasterization. Now clients can call ConvertFromVideoFrameYUV > with CPU backed VideoFrames in addition to wrapped frames. > > Bug: 1058992 > Change-Id: I89c37179b12fe1375fa7a6f7d919f135f77b5857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200084 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770729} Bug: 1058992, 1085516 Change-Id: Ib465428bf72cbf98e69ae19db1e917ebcd32ebb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223325Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773870}
-
Will Harris authored
BUG=1005715 Change-Id: I7b15b4284725e3a8125b4d33dfa5da1dd0309b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225508 Auto-Submit: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#773869}
-
Karandeep Bhatia authored
The removeHeaders action has been removed from the API. BUG=1085326 Change-Id: I533c885d92373ce8fd888a059f8ded0a9acc6337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220831 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773868}
-
Tom Anderson authored
This CL just moves some things around and has no behavior changes. 1. Move response/event processing from X11EventSource to x11::Connection. This is done because X11EventSource can be null in some tests, but we always have an x11::Connection. Needed to fix tests for [1]. Also wanted for [2] which begins migrating events from Xlib to XProto. 2. Move some logic from x11::Future into x11::FutureBase. This is done to avoid including ui/gfx/x/connection.h from xproto_types.h which would otherwise add a circular include. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2220686 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2220635 BUG=1066670 R=msisov TBR=sky Change-Id: Ia0710595c6cb6337a8c9b52f31ceaafefaf00cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220524Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/13110bff05b8..0e3c27de6a33 2020-06-01 rharrison@chromium.org Rolling 5 dependencies 2020-06-01 bryan.bernhart@intel.com Roll third_party/shaderc/ 7d2f8c57e..da87b8d8b (3 commits) 2020-06-01 cwallez@chromium.org Fix missing space in an error string. 2020-06-01 enga@chromium.org Fix ValidateEntireSubresourceCopied If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3ae041252f8365a4631f1ea6d2a45c094efcbc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225314Reviewed-by:
-
Tibor Goldschwendt authored
Process-per-site makes all WebUI NTPs share a single renderer process. This is what the local NTP does and has the following performance advantages (measured on my linux machine): * Reduces mean of NewTabPage.LoadTime.WebUINTP (duration from starting the NTP navigation until the most visited items are added to the DOM) from 271ms to 141ms. * Reduces memory overhead of opening a new NTP from ~30MB to ~5MB. NOTE: The aforementioned performance improvements only hold true if another NTP is open to have the process pre-warmed. The WebUI NTP does not seem to use the pre-warmed spare renderer. + Move existing WebUI NTP browser test to //c/b/ui/webui/new_tab_page. Bug: 1075641 Change-Id: Id94294eac41e3ab083e8eece567941ef4d40d08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220634 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773865}
-
David Schinazi authored
This CL changes the test to pretty-print its parameters. R=zhongyi@chromium.org Change-Id: I0542a103b6ff69001bed54e3b6f152fe9a97b19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225473 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
This CL fixes a regression introduced by the refactor in https://chromium-review.googlesource.com/c/chromium/src/+/2181973. Apparently, it's possible that a subframe may have neither the old nor the new (target) FrameNavigationEntry during a history navigation. Prior to the refactor above, we returned early and avoided scheduling any loads for such a subframe. After the refactor, we incorrectly attempted to schedule a different-document load, which resulted in calling CreateNavigationRequestFromEntry() with a null frame_entry, which it didn't expect and crashed while deferencing it. Bug: 1088354, 1088175 Change-Id: Iaaa9743b0e897eecb1aa0317fa20d8d042c878f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225267 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773863}
-
Alex Turner authored
This adds the PageLoad.Clients.Ads.AllPages.NonAdNetworkBytes histogram. This will be useful for high-level comparisons of Cluster Telemetry runs, by allowing approximately tracking of AdTagging accuracy over time. While this histogram can be computed from the difference between total bytes and ad bytes (i.e. PageLoad.Experimental.Bytes. NetworkIncludingHeaders - PageLoad.Clients.Ads.Resources.Bytes.Ads2), cluster telemetry's performance dashboard does not support subtraction. Bug: 1084712 Change-Id: Id5853fa0008b854c576e63ef7498dfe42e491283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210666Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#773862}
-
Eric Lawrence authored
Several crash exit codes have duplicate definitions, and showing a textual constant for them in the sad tab page could be misleading to the end user. Remove the contested codes from the switch statement so that the default "Error code: ####" text is shown instead. Bug: 1090040,1076440 Change-Id: Ic1775f58f750b7cd942b2ccf3238314589d622d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225458Reviewed-by:
-
James Vecore authored
The NearbyConnectionsHost mojo interface allows the utility process to query for any browser owned mojo interfaces that it needs. The Bluetooth adapter is the first example of a mojo interface provided for the utility process. Change-Id: Ia8065586f60fad0728cd7bdbd95ead630f9aaac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220711 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#773860}
-
Bettina authored
For SafeBrowsing.Pref*, the enhanced protection just launched so we need the histograms to review. For all other histograms by this CL, there is still needed usage. Removed SafeBrowsing.Pref.Scout.Decision* due to it only referring to SBER1. Bug: 1089523,1089425,1089424,1089244,1089238,1089237,1089233 Change-Id: Ibc0e3e65ef32378d9463c34ffd2362de7e9821d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225380Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#773859}
-
David Bienvenu authored
Since this removes a RunUntilIdle, I had to replace an async close of a browser window with a synchronous close. Change-Id: I4428d218c4b4d5fbb218bdeefece4062f0394e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144421 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773858}
-
siashah authored
We update the status of the Done button based on whether the nickname is valid and then call PersonalDataManager.setCreditCard to save the card with the nickname. Video (Googlers only): https://drive.google.com/file/d/1rH_L7gPIiRSjmkoY5oxWEFoU5uUcCGVR/view?usp=sharing Bug: 1082013 Change-Id: Ifab123a53762da03f3c903962a70e431fc8fb78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218987Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#773857}
-
Adrienne Walker authored
This change turns back on (it's explicitly turned off in the test base class) the require appcache origin trial feature for several manifest 404/410 tests. It also adds a 410 gone test for an upgrade scenario. Bug: 1081907 Change-Id: I533f6ddfc6d45b4f73de5a82af159d77479dacbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225385Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#773856}
-
