GitLab

happens when domain name is not resolved through DNS.

BUG=https://code.google.com/p/webrtc/issues/detail?id=3384
R=jiayl@chromium.org
TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/439153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287553 0039d316-1c4b-4281-b951-d872f2087c98

This must be dcommit'd because CQ corrupts PNG files when landing them.
crbug.com/339068

BUG=none
TEST=none
R=rockot@chromium.org
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/424123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287552 0039d316-1c4b-4281-b951-d872f2087c98

LayerAnimationController::AccumulatePropertyUpdates

The animation value is computed from the animation curve. The general
format used is to get the specific animation curve into one variable 
and then use the getvalue to get the actual animation value. The same
is followed across the file except in AccumulatePropertyUpdates. 
This patch takes cares of the same.

Review URL: https://codereview.chromium.org/440873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287551 0039d316-1c4b-4281-b951-d872f2087c98

Previously, multiple simultaneous wss: connections to the same endpoint
did not work because the endpoint lock was not correctly released at the
end of the handshake.

This happened because the socket was wrapped for SSL and so the original socket
address that was passed to RememberSocket() was not the same one passed to
UnlockSocket().

Make releasing of the lock on successful handshake happen using the address
provided by GetPeerAddress() instead of the RememberSocket()
mechanism. This will not work if the socket has already been closed;
however, in that case the socket should be rapidly returned to the pool
anyway at which point UnlockSocket() will be called as normal.

Also add a browser test for multiple simultaneous wss: connections
(WebSocketBrowserTest.SSLConnectionLimit).

BUG=398737
TEST=net_unittests, browser_tests

Review URL: https://codereview.chromium.org/436493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287550 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to test_common.
5) Removed un-used test_common header.

BUG=331299

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287382

Review URL: https://codereview.chromium.org/436133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287549 0039d316-1c4b-4281-b951-d872f2087c98

Some versions of gtest print type- and value-parameterized tests with
their respective parameter as a comment after the test name when listing
tests. This patch should allow the android test runner scripts to
correctly ignore these comments.

BUG=

Review URL: https://codereview.chromium.org/441783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399744

Review URL: https://codereview.chromium.org/440663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287546 0039d316-1c4b-4281-b951-d872f2087c98

for Ozone. The Ozone flake hasn't been reported on non-ozone trybots.
Created a separate bug for Ozone flake: http://crbug.com/399676 and added some analysis.

BUG=357311

Review URL: https://codereview.chromium.org/428303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287545 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg

BUG=366899, 400747

Review URL: https://codereview.chromium.org/439943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400094

Review URL: https://codereview.chromium.org/422443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287543 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287542 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179497:179499&mode=html
TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org
BUG=

Review URL: https://codereview.chromium.org/445553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287541 0039d316-1c4b-4281-b951-d872f2087c98

gtest.h is included pref_store_observer_mock.cc and testing_pref_service.cc.
Found using 'gn check'.

Review URL: https://codereview.chromium.org/435983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287540 0039d316-1c4b-4281-b951-d872f2087c98

Note that this also involved copying neterror.css/js over to 
chrome/browser/resources/ssl so as to break the dependency between 
blocking.html in that directory and the css/js files in 
chrome/renderer/resources.  That copy means that, while I'm going 
through presubmit errors before uploading, I"m not fixing them all--
there are pre-existing errors in neterror.css that I don't have the 
expertise to fix.

BUG=None

Review URL: https://codereview.chromium.org/422933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287538 0039d316-1c4b-4281-b951-d872f2087c98

2 problems here:
1. Setting the frame time to 0 does nothing, because LTHI will read from
gfx::FrameTime::Now() instead. Need to start at 1 millisecond.

2. Need to tick the frame timer after SetupDrawPropertiesAndUpdateTiles.

BUG=399796

Review URL: https://codereview.chromium.org/444463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287536 0039d316-1c4b-4281-b951-d872f2087c98

. Add a shadow around the bottom-view of the home-card.
. Make the background slightly transparent.
. Make the bottom-view slightly narrower.
. Remove the borders around the apps.

BUG=none
R=mukai@chromium.org
TBR=sky@chromium.org for DEPS on ui/gfx/ from athena/home

Review URL: https://codereview.chromium.org/439673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287535 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/403343002/

This CL renames ChromeOS-specific resource IDs (strings/images)

Still missing:
- The global ENABLE_MANAGED_USERS define

TBRing a bunch of renames.
TBR=oshima@chromium.org (ash and c/b/ui/ash)
TBR=antrim@chromium.org (c/b/chromeos and ui/login)

BUG=385113

Review URL: https://codereview.chromium.org/425293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287534 0039d316-1c4b-4281-b951-d872f2087c98

Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.

Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.

Part 1: https://codereview.chromium.org/436843004/
Part 1 with conditional: https://codereview.chromium.org/440683004/
Part 3: https://codereview.chromium.org/438843004/

BUG=312586

Review URL: https://codereview.chromium.org/422023008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287532 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Resubmit: Remove deprecated extension notifications from ProcessManager (https://codereview.chromium.org/434593002/)

Reason for revert:
Speculative revert, see http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5773/steps/unit_tests/logs/GetHostZoomMap
The stack trace mentions extensions::ExtensionRegistry::RemoveObserver

Original issue's description:
> Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead.
> 
> ProcessManagerTest inherts ExtensionsTest for the test settings. So now unit test is passed.
> 
> R=rdevlin.cronin@chromium.org
> BUG=354046
> TEST=extensions_unittests
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287521

TBR=rdevlin.cronin@chromium.org,limasdf@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=354046

Review URL: https://codereview.chromium.org/443623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287530 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a typo.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/442743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398880
NOTRY=true

Review URL: https://codereview.chromium.org/440053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87553

Review URL: https://codereview.chromium.org/438193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287527 0039d316-1c4b-4281-b951-d872f2087c98

That should fix flakyness for the test on Windows with cl 134623005.

BUG=None

Review URL: https://codereview.chromium.org/441713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287526 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/427553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400469

Review URL: https://codereview.chromium.org/436323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388279

Review URL: https://codereview.chromium.org/420243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287522 0039d316-1c4b-4281-b951-d872f2087c98

ProcessManagerTest inherts ExtensionsTest for the test settings. So now unit test is passed.

R=rdevlin.cronin@chromium.org
BUG=354046
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/434593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397624

Review URL: https://codereview.chromium.org/431303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287520 0039d316-1c4b-4281-b951-d872f2087c98

Componentization of bookmarks is complete, so remove sdefresne and blundell
from OWNERS file as the access was only temporary.

BUG=383597

Review URL: https://codereview.chromium.org/439883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287519 0039d316-1c4b-4281-b951-d872f2087c98

This makes the memory model more robust for tests (which may not interact
with a notification), and means that the NotificationObjectProxy won't be
stuck with a bad pointer after the delegate deletes itself.

BUG=

Review URL: https://codereview.chromium.org/433273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287518 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384522

Review URL: https://codereview.chromium.org/433423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287517 0039d316-1c4b-4281-b951-d872f2087c98

The name of the gyp variable for disabling arm
components was mis-typed.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/435813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390520

Review URL: https://codereview.chromium.org/436903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287515 0039d316-1c4b-4281-b951-d872f2087c98

We already have a way to send message via ExecuteJavaScript,
no need for another mechanism.

BUG=398046
TBR=jam

Review URL: https://codereview.chromium.org/418243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287514 0039d316-1c4b-4281-b951-d872f2087c98

This qualification is not necessary now that we've moved way past M31.

BUG=399689

Review URL: https://codereview.chromium.org/439923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287513 0039d316-1c4b-4281-b951-d872f2087c98

vertexAttribPointer is a fairly common GL call, so substituting integer
division with bitwise and which has far less latency on common CPU
architectures is a worthwhile optimization.

IsPOT function is added for asserts that make sure this does not break.
Redundant comparison against zero is dropped from IsNPOT. In C++,
unsigned integers are specified to work with mod 2^n arithmetic.

TEST=gpu_unittests
BUG=400135

Review URL: https://codereview.chromium.org/439253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287512 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287511 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179489:179496&mode=html
TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org
BUG=

Review URL: https://codereview.chromium.org/440833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370850
TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/439993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287506 0039d316-1c4b-4281-b951-d872f2087c98

This abstraction was needed to correctly handle test data which was using the old format ID.
Now the test data is using the new ID format so it's OK to call CanonicalizeResourceId() directly.

BUG=None

Review URL: https://codereview.chromium.org/445473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287505 0039d316-1c4b-4281-b951-d872f2087c98