- 29 May, 2019 40 commits
-
-
Leon Han authored
This is a reland of a4545bae Based on the original CL, this CL changed to add the blob handle for network::mojom::DataElement --> blink::FormDataElement conversion in encoded_form_data_mojom_traits.cc for Network Service disabled cases. Original change's description: > [OnionSoup] Move binding of blink.mojom.ServiceWorker into Blink > > This CL moves blink.mojom.ServiceWorker interface implementation from > content::ServiceWorkerContextClient into > blink::ServiceWorkerGlobalScope, at the same time moves another two > tightly coupled classes into Blink as well: > content::{ServiceWorkerTimeoutTimer,ControllerServiceWorkerImpl}. > > Previously, > content::YYY -(Mojo call DispatchXXXEvent)-> > content::ServiceWorkerContextClient -(WebServiceWorkerContextProxy)-> > ServiceWorkerGlobalScopeProxy --> ServiceWorkerGlobalScope. > Now, > content::YYY -(Mojo call DispatchXXXEvent)-> ServiceWorkerGlobalScope. > > Previously, > blink::ZZZ -(DidHandleXXXEvent/ResponseToXXXEvent)-> > ServiceWorkerGlobalScopeClient -(WebServiceWorkerContextClient)-> > content::ServiceWorkerContextClient. > Now, > blink::ZZZ -(DidHandleXXXEvent/ResponseToXXXEvent)-> > ServiceWorkerGlobalScope. > > As a result of the above changes, we removed a bunch of member functions > from WebServiceWorkerContext{Client,Proxy}, together with a bunch of > public Web types which have been replaced with corresponding mojom > types, like WebServiceWorker{Request,Response} replaced by > blink.mojom.FetchAPI{Request,Response}, also removed those corresponding > type converters as well. > > BUG=922376 > > Change-Id: If9cc7f190f6056a2c4440f3e5e1eaa6823ed79e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1297740 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Leon Han <leon.han@intel.com> > Cr-Commit-Position: refs/heads/master@{#663648} TBR=falken,shimazu,peter,haraken,yhirano,tkent as they've already given OWNER approval on the original CL. Bug: 922376 Change-Id: Ie20bd86142aeb3d23561540246e22a87ed667697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631124Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#664105}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ib5e3666facd8d2eb4ccf4c74b3c8cbb68f4598b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633974Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#664104}
-
Jamie Walch authored
Change-Id: I25172eeb7f589d1dea3480d322d4ed73f2213fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633969Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664103}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8b5fc36191d7..26d3cf08c209 git log 8b5fc36191d7..26d3cf08c209 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 enga@chromium.org Fix dawn_end2end_tests with the wire 2019-05-29 jiawei.shao@intel.com Support force enabling multiple toggles in Dawn end2end tests Created with: gclient setdep -r src/third_party/dawn@26d3cf08c209 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Id5e3edfa6b1eaaa3c6068a01897876b48b3b4549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664102}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a730bef0e754..dc0353f46e1f git log a730bef0e754..dc0353f46e1f --date=short --no-merges --format='%ad %ae %s' 2019-05-29 gbiv@google.com chromeos_config: use llvm-next in the pgo_generate toolchain builder 2019-05-29 achuith@chromium.org lib/cros_test: Unittests Created with: gclient setdep -r src/third_party/chromite@dc0353f46e1f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I30a6524193ff010778f0457c4b0f855df89b2f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633733Reviewed-by:
-
Jordan Bayles authored
This patch rolls the third_party/openscreen dependency to include build fixes for compiling in Chromium. Change-Id: I451ef45155da341cf94fdf20e93f2e0dd31ddb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632910 Auto-Submit: Jordan Bayles <jophba@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#664100}
-
Austin Orion authored
This change adds the ability to take metadata provided by websites via the MediaSession API and give it to the System Media Transport Controls (SMTC), giving users more information about the active media session on Windows. Bug: 954009 Change-Id: I637fce4208a5a78138cbdc1bcb93a954b698b7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606900 Commit-Queue: Austin Orion <auorion@microsoft.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#664099}
-
Ehsan Karamad authored
The test PDFExtensionInternalLinkClickTest.ShiftLeft exposed a race where the embedder RenderFrameHost is nullptr by the time the IPC ReadyToCreateMimeHandlerView arrives. This CL checks |rfh| to ensure it is not nullptr. TBR=wjmaclean@chromium.org Bug: 967045 Change-Id: Ib80499c8d9e758c8ef07b7d06f69429062d8c6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633991Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#664098}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ce909c11c06..b97d193baafa git log 4ce909c11c06..b97d193baafa --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 maruel@chromium.org cipd: Update lucicfg to 1.7.7. Created with: gclient setdep -r src/third_party/depot_tools@b97d193baafa The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:808836 TBR=agable@chromium.org Change-Id: I3b4830379ab5adbbc95b0de154005d4959bfe61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633732Reviewed-by:
-
Vikas Soni authored
Move the files to from gpu/vulkan/ to gpu/ipc/common/. This is to avoid vulkan dependency and ifdefs at every place this struct is used. Bug: 948722 Change-Id: I065948a99b1ed0de92229173747711855e5ca63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601642Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#664096}
-
Nigel Tao authored
This allows cleanly breaking observer-observee reference cycles, regardless of which object is destroyed first. Prior to this commit, the implicit assumption was that the observer was always destroyed first. A follow-up commit will introduce some tests that create and destroy AppRegistryCache objects. BUG=826982 Change-Id: I94966439001ba310b5ee824ff62e72a533887c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629892 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#664095}
-
Yutaka Hirano authored
Split the interface part and the implementation part of blink::UseCounter, and rename the latter part as FrameUseCounter. - Define blink::UseCounter as a pure interface with some static helper functions. - Have ExecutionContext and DocumentLoader inherit UseCounter. - Move UseCounter static functions other than UseCounter::Count to each context-ish parameter class. - CountAnimatedCSS, CountCrossOriginIframe, IsCounted, ClearCountForTesting are moved to Document. - CountIfFeatureWouldBeBlockedByFeaturePolicy is moved to LocalFrame. - MapCSSPropertyIdToCSSSampleIdForHistogram is moved to the private section. Discussed on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/j7007MhubK4 Change-Id: I2e23381b9e3f63097e61600de5926fad405db776 Bug: 963306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614719Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664094}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76ce2f554e7a..83b12e46399c Created with: gclient setdep -r src-internal@83b12e46399c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I37916237885581a0bf439b4e9850172ca66e432e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633672Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664093}
-
Tsuyoshi Horo authored
This is the follow-up CL of kinuko@'s comment: https://crrev.com/c/1619527/5/services/network/public/cpp/resource_response.cc#67 Change-Id: If8dc0b534f39d2d6e097a35dfa552421b865b6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621988Reviewed-by:
-
Ian Kilpatrick authored
... rather than MutableResults. There should be no behaviour change. Change-Id: I3080aadc621a8ce3aafdf3be12b2c1ad111c6ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633329 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#664091}
-
Nigel Tao authored
Change-Id: I9b251a194ad5f82f6c6caea9e6b04c2aa363e98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626848Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664090}
-
Xing Liu authored
This CL adds the notification client interface, and a registrar class to register and maintain ownership of clients. The registrar is plumbed into the scheduler keyed service. The internal code will hook to the client in a following CL. Bug: 963288,930968 Change-Id: I48eb8cf460260304ab1ebd6de201a4ffc224ddc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616013 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#664089}
-
Xiaocheng Hu authored
When we encounter a preserved line break in relayout, we can't reuse its items if: - It was in a bidi context in a previous layout - It's in a bidi context in the current (re)layout In both cases, we need to go through the full pipeline, which is ensured by this patch. For this purpose, we need to pass the previous NGInlineNodeData to NGInlineItemsBuilder::AppendText(), which makes the patch slightly bigger due to changes in plumbing and test code. Bug: 966751 Change-Id: I0cc0a86fda004f130d294657cd9c41e11ca1bbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626498 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/66661df8e9f9..8f88b2da05d5 git log 66661df8e9f9..8f88b2da05d5 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8f88b2da05d5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I24975a152692b285979d07c6b9efdc6dc352ec10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633829Reviewed-by:
-
dpapad authored
This page is "parked" temporarily under chrome://print/polymer3/demo.html, and only included for optimize_webui=false, to avoid the overhead of adding a new top-level WebUI page, and should be removed once experimentation concludes. Bug: 965770 Change-Id: I9de73ccbdbd1150bc7ca73f09fe8b81d973ff0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613704 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#664086}
-
Yoichi Osato authored
As we decided to remove V0 APIs w/o this kind of exceptions, this patch removes those in perf stories. Bug: 937747, 937746 Change-Id: Ia6084b9c15e4b8d3e3c7cf61064fbfb75ecf895d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628632Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#664085}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ce33b6a4cfa0..686be20b4556 git log ce33b6a4cfa0..686be20b4556 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 sukhanov@webrtc.org Fix ICE connection in datagram_transport. 2019-05-28 mellem@webrtc.org Create a composite implementation of RtpTransportInternal. 2019-05-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 09fae7ef..9b60f86c (663849:663961) 2019-05-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9809faf8..09fae7ef (663719:663849) Created with: gclient setdep -r src/third_party/webrtc@686be20b4556 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I26b94a75f97d58c0ab92b37494a553af2300a732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633729Reviewed-by:
-
Lambros Lambrou authored
This gives the marker a more specific name, to reflect what is updated. This allows for any future config updates (for example, if we need to update the token to include more new scopes). Bug: 954427 Change-Id: I12554301096bd80a82f8eae0bc8567c2d11ae83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629702 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
In the previous CL https://crrev.com/c/1624385 I forwarded wrong axis indices to ARC. In order to forward correct evdev ABS_CNT axis indices, you have to also keep raw indices in ui::GamepadDevice::Axis. This is a part of the effort to improve ARC gamepad compatibility. Design doc: go/arc-improved-gamepad TEST=manual(--enable-features=ExoRawGamepadInfo to /etc/chrome_dev.conf) BUG=b:130597086 Change-Id: I997b262749b413cee38af40cc498ea2b399e2904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631150Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 5/28) <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#664082}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/05c766a1f461..5ba891aba76f git log 05c766a1f461..5ba891aba76f --date=short --no-merges --format='%ad %ae %s' 2019-05-28 zoddicus@users.noreply.github.com Convert spirv-cross tests to using a known failures list (#626) Created with: gclient setdep -r src/third_party/shaderc/src@5ba891aba76f The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: If6a4fcdf1236655e80350afbe49770f8cb34a9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633770Reviewed-by:
-
Matthew Webb authored
Bug: 838919 Change-Id: I588a33ffb20e9d38a6f8ba7f0bee83fa153265a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613781 Commit-Queue: Matthew Webb <noviv@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#664080}
-
Sergey Volk authored
Test: Played 5.1 opus encoded audio file through chromecast by pointing the chromecast to a local server and audio comes out of the AVR at the expected channel. Bug: b/133189747 Change-Id: Ia0e77ea9f6f8b3f9cd35803dffa5888fec0335d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627759Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#664079}
-
Charles Zhao authored
Currently, for two continuous discards queries, only the second label_id is logged in target, which makes it hard for pairing for the first label_id. Change: (1) We shift currently label_id * 8192 (<< 13), (2) If a tab already has label_id !=0, then that means we had second query before labeling. we only increase the label_id by 1. (3) If a tab has label==0, that means previous label_ids are all logged with labels. We assign a new label_id to the tab. Then with offline pipeline we use label_id_pre = label_id >> 13; label_id_suf = label_id %8192 And all tabs have same label_id_pres are the same tabs logged multiple times. We can pair them with the same labeling event. Bug: 966742 Change-Id: Ia741b16c2622eb158848e166e36ba1bf03655728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627845 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#664078}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ddde8daf5768..a730bef0e754 git log ddde8daf5768..a730bef0e754 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 richardfung@google.com Add qt-arc-dev to PFQ and betty-[nyc, pi, qt]-arc boards Created with: gclient setdep -r src/third_party/chromite@a730bef0e754 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I371e4fef76038e328eff6b0b676c614e1cff8ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633769Reviewed-by:
-
Eric Willigers authored
Rename WebAppUiDelegateImpl to WebAppUiService. TBR=msarda@chromium.org Bug: 966288 Change-Id: I4f92fc39f5c22a89e25093370e0d4753c23c7e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630376 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#664076}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d524d32f3c7c..4e2aa897a424 git log d524d32f3c7c..4e2aa897a424 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 tsepez@chromium.org Remove circular includes between cpdfdoc and core/fpdfapi/render Created with: gclient setdep -r src/third_party/pdfium@4e2aa897a424 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id6d7f4ba7ff1ba08400bd56cf0c3d19a9c870181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633440Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cee3dffa8f79..ca8e3d7c153e git log cee3dffa8f79..ca8e3d7c153e --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bclayton@google.com Reactor: Fix printing of small integer values. 2019-05-28 bclayton@google.com SpirvShader: Correctly handle phi values in the loop merge 2019-05-28 bclayton@google.com SpirvShader: Simplify the logic around the generation of the inner loop. Created with: gclient setdep -r src/third_party/swiftshader@ca8e3d7c153e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133440380,chromium:b/133481698,chromium:b/133440380,chromium:b/133481698 TBR=swiftshader-team+autoroll@google.com Change-Id: Iac6bde0fab5929670508c950d9b16e5cca4eaaa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633439Reviewed-by:
-
Kelvin Jiang authored
This CL allows users to navigate to the activity log page via URL even if the extension ID specified in the URL is invalid/uninstalled. This allows the user to see install-time activities in real-time via the following steps: 1) Navigate to the activity log via URL 2) Click on the real-time tab 3) Install the extension with the ID in the activity log's URL. Note that a listener for extension activities is already present for the extension ID. 4) In the real-time tab, the extension's install-time activities should appear. Screenshots: https://imgur.com/a/Niyc3S8 Bug: 832354 Change-Id: Ifaa0c3ea57d295f8657f067c610a093170e909a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620346 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#664073}
-
Alan Cutter authored
This CL creates a new "installable" state in AppBannerManager to distinguish whether Chrome provides the option to install (kByUserRequest) or whether Chrome promotes installation for the site (kPromotable). Before this CL we disabled PWA installation entirely if the site indicated it preferred a related app in its manifest. Now we just use it as a signal to avoid promoting install to the user but still provide them the option in the 3-dot menu. Bug: 964314, 966831 Change-Id: Ic68d21bbca021c4fad45f8225e097b1df3a46b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630128 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Justin Cohen authored
When quickly navigating back or forward, it's possible to trigger the following WebKit error: "[ProcessSwapping] WebPageProxy::suspendCurrentPageIfPossible: Not suspending current page for process pid XXXX because fromItem's URL does not match the page URL." When this happens, the WKBackForwardList gets out of sync with the webView, and currentItem.URL does not match webView.URL. This workaround takes the naive approach and looks to see if the next or previous WKBackForwardList item has the correct URL. Bug: 960326 Change-Id: I2b9d9355949fcc3978aef4f37584bb4aeade75a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627703 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664071}
-
Brian Sheedy authored
Rolls the goldctl version to pick up the change that adds goldctl-side triage links. TBR=kbr@chromium.org Bug: 850107 Change-Id: If20fdc3ba8579e15b9f8c22eb562f2b07f3192ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632709Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664070}
-
Nicholas Verne authored
Bug: 967499 Change-Id: Id216582068e5ed3484637611700edc8920fbd5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631260Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#664069}
-
John Abd-El-Malek authored
There are three fixes: 1) The main fix is that network::NetworkService needs to be torn down between tests. One reason is that so a test don't leave it misconfigured for other tests. The pressing reason is that if network::NetworkService is bound to a pipe in one test it'll also be bound to that test's BrowserThreadTestBundle's sequence; that means for other tests no mojo messages will be dispatched. Fix this by resetting the interface pointer at the end of each test. 2) We need to delete the network::NetworkService object to avoid leaks; depending on connection error dispatching again might not be delivered. This is fixed by storing the pointer in SequenceLocalStorageSlot. 3) We create network::NetworkService directly instead of trying to use the global ServiceManager. For most tests this happens because there's no global Connector. However some tests would instantiate a test service manager objects, so we need to force the direct instantiation through a test only method. Bug: 966633 Change-Id: I1c181733af692e7a6742a45c10a16c863e2642a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632494 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Taylor Bergquist authored
Bug: 958173 Change-Id: Iff81fa8dd3ff57cb7121d628cd5e78e8e58c157f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633350 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#664067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86837544cd02..76ce2f554e7a Created with: gclient setdep -r src-internal@76ce2f554e7a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I668311010db0a96804fc4e9ee10883386fd64b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633228Reviewed-by:
-
